ccmanager 2.8.0 → 2.9.0

package/dist/services/sessionManager.test.js

@@ -1,12 +1,16 @@
 import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest';
+import { Effect } from 'effect';
 import { spawn } from 'node-pty';
 import { EventEmitter } from 'events';
 import { exec } from 'child_process';
 // Mock node-pty
-vi.mock('node-pty');
+vi.mock('node-pty', () => ({
+    spawn: vi.fn(),
+}));
 // Mock child_process
 vi.mock('child_process', () => ({
     exec: vi.fn(),
+    execFile: vi.fn(),
 }));
 // Mock configuration manager
 vi.mock('./configurationManager.js', () => ({
@@ -93,7 +97,7 @@ describe('SessionManager', () => {
     afterEach(() => {
         sessionManager.destroy();
     });
-    describe('createSessionWithPreset', () => {
+    describe('createSessionWithPresetEffect', () => {
         it('should use default preset when no preset ID specified', async () => {
             // Setup mock preset
             vi.mocked(configurationManager.getDefaultPreset).mockReturnValue({
@@ -105,7 +109,7 @@ describe('SessionManager', () => {
             // Setup spawn mock
             vi.mocked(spawn).mockReturnValue(mockPty);
             // Create session with preset
-            await sessionManager.createSessionWithPreset('/test/worktree');
+            await Effect.runPromise(sessionManager.createSessionWithPresetEffect('/test/worktree'));
             // Verify spawn was called with preset config
             expect(spawn).toHaveBeenCalledWith('claude', ['--preset-arg'], {
                 name: 'xterm-256color',
@@ -127,7 +131,7 @@ describe('SessionManager', () => {
             // Setup spawn mock
             vi.mocked(spawn).mockReturnValue(mockPty);
             // Create session with specific preset
-            await sessionManager.createSessionWithPreset('/test/worktree', '2');
+            await Effect.runPromise(sessionManager.createSessionWithPresetEffect('/test/worktree', '2'));
             // Verify getPresetById was called with correct ID
             expect(configurationManager.getPresetById).toHaveBeenCalledWith('2');
             // Verify spawn was called with preset config
@@ -150,7 +154,7 @@ describe('SessionManager', () => {
             // Setup spawn mock
             vi.mocked(spawn).mockReturnValue(mockPty);
             // Create session with non-existent preset
-            await sessionManager.createSessionWithPreset('/test/worktree', 'invalid');
+            await Effect.runPromise(sessionManager.createSessionWithPresetEffect('/test/worktree', 'invalid'));
             // Verify fallback to default preset
             expect(configurationManager.getDefaultPreset).toHaveBeenCalled();
             expect(spawn).toHaveBeenCalledWith('claude', [], expect.any(Object));
@@ -168,8 +172,8 @@ describe('SessionManager', () => {
             vi.mocked(spawn).mockImplementation(() => {
                 throw new Error('Command failed');
             });
-            // Expect createSessionWithPreset to throw
-            await expect(sessionManager.createSessionWithPreset('/test/worktree')).rejects.toThrow('Command failed');
+            // Expect createSessionWithPresetEffect to throw
+            await expect(Effect.runPromise(sessionManager.createSessionWithPresetEffect('/test/worktree'))).rejects.toThrow('Command failed');
             // Verify only one spawn attempt was made
             expect(spawn).toHaveBeenCalledTimes(1);
             expect(spawn).toHaveBeenCalledWith('claude', ['--bad-flag'], expect.any(Object));
@@ -184,8 +188,8 @@ describe('SessionManager', () => {
             // Setup spawn mock
             vi.mocked(spawn).mockReturnValue(mockPty);
             // Create session twice
-            const session1 = await sessionManager.createSessionWithPreset('/test/worktree');
-            const session2 = await sessionManager.createSessionWithPreset('/test/worktree');
+            const session1 = await Effect.runPromise(sessionManager.createSessionWithPresetEffect('/test/worktree'));
+            const session2 = await Effect.runPromise(sessionManager.createSessionWithPresetEffect('/test/worktree'));
             // Should return the same session
             expect(session1).toBe(session2);
             // Spawn should only be called once
@@ -204,8 +208,8 @@ describe('SessionManager', () => {
             vi.mocked(spawn).mockImplementation(() => {
                 throw new Error('Command not found');
             });
-            // Expect createSessionWithPreset to throw the original error
-            await expect(sessionManager.createSessionWithPreset('/test/worktree')).rejects.toThrow('Command not found');
+            // Expect createSessionWithPresetEffect to throw the original error
+            await expect(Effect.runPromise(sessionManager.createSessionWithPresetEffect('/test/worktree'))).rejects.toThrow('Command not found');
         });
         it('should use fallback args when main command exits with code 1', async () => {
             // Setup mock preset with fallback
@@ -224,7 +228,7 @@ describe('SessionManager', () => {
                 .mockReturnValueOnce(firstMockPty)
                 .mockReturnValueOnce(secondMockPty);
             // Create session
-            const session = await sessionManager.createSessionWithPreset('/test/worktree');
+            const session = await Effect.runPromise(sessionManager.createSessionWithPresetEffect('/test/worktree'));
             // Verify initial spawn
             expect(spawn).toHaveBeenCalledTimes(1);
             expect(spawn).toHaveBeenCalledWith('claude', ['--invalid-flag'], expect.objectContaining({ cwd: '/test/worktree' }));
@@ -251,7 +255,7 @@ describe('SessionManager', () => {
             // Setup spawn mock - process doesn't exit early
             vi.mocked(spawn).mockReturnValue(mockPty);
             // Create session
-            await sessionManager.createSessionWithPreset('/test/worktree');
+            await Effect.runPromise(sessionManager.createSessionWithPresetEffect('/test/worktree'));
             // Wait a bit to ensure no early exit
             await new Promise(resolve => setTimeout(resolve, 600));
             // Verify only one spawn attempt
@@ -275,7 +279,7 @@ describe('SessionManager', () => {
                 .mockReturnValueOnce(firstMockPty)
                 .mockReturnValueOnce(secondMockPty);
             // Create session
-            const session = await sessionManager.createSessionWithPreset('/test/worktree');
+            const session = await Effect.runPromise(sessionManager.createSessionWithPresetEffect('/test/worktree'));
             // Verify initial spawn
             expect(spawn).toHaveBeenCalledTimes(1);
             expect(spawn).toHaveBeenCalledWith('claude', ['--invalid-flag'], expect.objectContaining({ cwd: '/test/worktree' }));
@@ -302,7 +306,7 @@ describe('SessionManager', () => {
             // Setup spawn mock
             vi.mocked(spawn).mockReturnValue(mockPty);
             // Create session
-            await sessionManager.createSessionWithPreset('/test/worktree');
+            await Effect.runPromise(sessionManager.createSessionWithPresetEffect('/test/worktree'));
             // Verify spawn was called with custom command
             expect(spawn).toHaveBeenCalledWith('my-custom-claude', ['--config', '/path/to/config'], expect.objectContaining({
                 cwd: '/test/worktree',
@@ -321,7 +325,7 @@ describe('SessionManager', () => {
                 throw new Error('spawn failed');
             });
             // Expect createSessionWithPreset to throw
-            await expect(sessionManager.createSessionWithPreset('/test/worktree')).rejects.toThrow('spawn failed');
+            await expect(Effect.runPromise(sessionManager.createSessionWithPresetEffect('/test/worktree'))).rejects.toThrow('spawn failed');
         });
     });
     describe('session lifecycle', () => {
@@ -334,7 +338,7 @@ describe('SessionManager', () => {
             });
             vi.mocked(spawn).mockReturnValue(mockPty);
             // Create and destroy session
-            await sessionManager.createSessionWithPreset('/test/worktree');
+            await Effect.runPromise(sessionManager.createSessionWithPresetEffect('/test/worktree'));
             sessionManager.destroySession('/test/worktree');
             // Verify cleanup
             expect(mockPty.kill).toHaveBeenCalled();
@@ -354,7 +358,7 @@ describe('SessionManager', () => {
                 exitedSession = session;
             });
             // Create session
-            const createdSession = await sessionManager.createSessionWithPreset('/test/worktree');
+            const createdSession = await Effect.runPromise(sessionManager.createSessionWithPresetEffect('/test/worktree'));
             // Simulate process exit after successful creation
             setTimeout(() => {
                 mockPty.emit('exit', { exitCode: 0 });
@@ -365,7 +369,7 @@ describe('SessionManager', () => {
             expect(sessionManager.getSession('/test/worktree')).toBeUndefined();
         });
     });
-    describe('createSessionWithDevcontainer', () => {
+    describe('createSessionWithDevcontainerEffect', () => {
         beforeEach(() => {
             // Reset shouldFail flag
             const mockExec = vi.mocked(exec);
@@ -401,7 +405,7 @@ describe('SessionManager', () => {
                 upCommand: 'devcontainer up --workspace-folder .',
                 execCommand: 'devcontainer exec --workspace-folder .',
             };
-            await sessionManager.createSessionWithDevcontainer('/test/worktree', devcontainerConfig);
+            await Effect.runPromise(sessionManager.createSessionWithDevcontainerEffect('/test/worktree', devcontainerConfig));
             // Verify spawn was called correctly which proves devcontainer up succeeded
             // Verify spawn was called with devcontainer exec
             expect(spawn).toHaveBeenCalledWith('devcontainer', ['exec', '--workspace-folder', '.', '--', 'claude', '--resume'], expect.objectContaining({ cwd: '/test/worktree' }));
@@ -421,7 +425,7 @@ describe('SessionManager', () => {
                 upCommand: 'devcontainer up',
                 execCommand: 'devcontainer exec',
             };
-            await sessionManager.createSessionWithDevcontainer('/test/worktree', devcontainerConfig, '2');
+            await Effect.runPromise(sessionManager.createSessionWithDevcontainerEffect('/test/worktree', devcontainerConfig, '2'));
             // Verify correct preset was used
             expect(configurationManager.getPresetById).toHaveBeenCalledWith('2');
             expect(spawn).toHaveBeenCalledWith('devcontainer', ['exec', '--', 'claude', '--resume', '--dev'], expect.any(Object));
@@ -435,7 +439,7 @@ describe('SessionManager', () => {
                 upCommand: 'devcontainer up',
                 execCommand: 'devcontainer exec',
             };
-            await expect(sessionManager.createSessionWithDevcontainer('/test/worktree', devcontainerConfig)).rejects.toThrow('Failed to start devcontainer: Container startup failed');
+            await expect(Effect.runPromise(sessionManager.createSessionWithDevcontainerEffect('/test/worktree', devcontainerConfig))).rejects.toThrow('Failed to start devcontainer: Container startup failed');
         });
         it('should return existing session if already created', async () => {
             // Setup mock preset
@@ -451,8 +455,8 @@ describe('SessionManager', () => {
                 execCommand: 'devcontainer exec',
             };
             // Create session twice
-            const session1 = await sessionManager.createSessionWithDevcontainer('/test/worktree', devcontainerConfig);
-            const session2 = await sessionManager.createSessionWithDevcontainer('/test/worktree', devcontainerConfig);
+            const session1 = await Effect.runPromise(sessionManager.createSessionWithDevcontainerEffect('/test/worktree', devcontainerConfig));
+            const session2 = await Effect.runPromise(sessionManager.createSessionWithDevcontainerEffect('/test/worktree', devcontainerConfig));
             // Should return the same session
             expect(session1).toBe(session2);
             // spawn should only be called once
@@ -473,7 +477,7 @@ describe('SessionManager', () => {
                 upCommand: 'devcontainer up --workspace-folder . --log-level debug',
                 execCommand: 'devcontainer exec --workspace-folder . --container-name mycontainer',
             };
-            await sessionManager.createSessionWithDevcontainer('/test/worktree', devcontainerConfig);
+            await Effect.runPromise(sessionManager.createSessionWithDevcontainerEffect('/test/worktree', devcontainerConfig));
             // Verify spawn was called with properly parsed exec command
             expect(spawn).toHaveBeenCalledWith('devcontainer', [
                 'exec',
@@ -510,10 +514,10 @@ describe('SessionManager', () => {
                 }
                 return {};
             });
-            await sessionManager.createSessionWithDevcontainer('/test/worktree2', {
+            await Effect.runPromise(sessionManager.createSessionWithDevcontainerEffect('/test/worktree2', {
                 upCommand: 'devcontainer up --workspace-folder .',
                 execCommand: 'devcontainer exec --workspace-folder .',
-            });
+            }));
             // Should spawn with devcontainer exec command
             expect(spawn).toHaveBeenCalledWith('devcontainer', ['exec', '--workspace-folder', '.', '--', 'claude'], expect.objectContaining({
                 cwd: '/test/worktree2',
@@ -531,10 +535,10 @@ describe('SessionManager', () => {
                 }
                 return {};
             });
-            await sessionManager.createSessionWithDevcontainer('/test/worktree', {
+            await Effect.runPromise(sessionManager.createSessionWithDevcontainerEffect('/test/worktree', {
                 upCommand: 'devcontainer up --workspace-folder .',
                 execCommand: 'devcontainer exec --workspace-folder .',
-            }, 'custom-preset');
+            }, 'custom-preset'));
             // Should call createSessionWithPreset internally
             const session = sessionManager.getSession('/test/worktree');
             expect(session).toBeDefined();
@@ -559,7 +563,7 @@ describe('SessionManager', () => {
                 upCommand: 'devcontainer up --workspace-folder /path/to/project',
                 execCommand: 'devcontainer exec --workspace-folder /path/to/project --user vscode',
             };
-            await sessionManager.createSessionWithDevcontainer('/test/worktree', config);
+            await Effect.runPromise(sessionManager.createSessionWithDevcontainerEffect('/test/worktree', config));
             expect(spawn).toHaveBeenCalledWith('devcontainer', [
                 'exec',
                 '--workspace-folder',
@@ -588,10 +592,10 @@ describe('SessionManager', () => {
                 command: 'claude',
                 args: ['-m', 'claude-3-opus'],
             });
-            await sessionManager.createSessionWithDevcontainer('/test/worktree', {
+            await Effect.runPromise(sessionManager.createSessionWithDevcontainerEffect('/test/worktree', {
                 upCommand: 'devcontainer up --workspace-folder .',
                 execCommand: 'devcontainer exec --workspace-folder .',
-            }, 'claude-with-args');
+            }, 'claude-with-args'));
             expect(spawn).toHaveBeenCalledWith('devcontainer', [
                 'exec',
                 '--workspace-folder',
@@ -629,10 +633,10 @@ describe('SessionManager', () => {
             vi.mocked(spawn)
                 .mockReturnValueOnce(firstMockPty)
                 .mockReturnValueOnce(secondMockPty);
-            const session = await sessionManager.createSessionWithDevcontainer('/test/worktree', {
+            const session = await Effect.runPromise(sessionManager.createSessionWithDevcontainerEffect('/test/worktree', {
                 upCommand: 'devcontainer up --workspace-folder .',
                 execCommand: 'devcontainer exec --workspace-folder .',
-            });
+            }));
             // Verify initial spawn
             expect(spawn).toHaveBeenCalledTimes(1);
             expect(spawn).toHaveBeenCalledWith('devcontainer', ['exec', '--workspace-folder', '.', '--', 'claude', '--invalid-flag'], expect.objectContaining({ cwd: '/test/worktree' }));
@@ -675,10 +679,10 @@ describe('SessionManager', () => {
             vi.mocked(spawn)
                 .mockReturnValueOnce(firstMockPty)
                 .mockReturnValueOnce(secondMockPty);
-            const session = await sessionManager.createSessionWithDevcontainer('/test/worktree', {
+            const session = await Effect.runPromise(sessionManager.createSessionWithDevcontainerEffect('/test/worktree', {
                 upCommand: 'devcontainer up --workspace-folder .',
                 execCommand: 'devcontainer exec --workspace-folder .',
-            });
+            }));
             // Verify initial spawn
             expect(spawn).toHaveBeenCalledTimes(1);
             expect(spawn).toHaveBeenCalledWith('devcontainer', ['exec', '--workspace-folder', '.', '--', 'claude', '--bad-flag'], expect.objectContaining({ cwd: '/test/worktree' }));