cc-safe-setup 29.7.0 → 30.0.4

package/tests/test-rg-replace-flag-detector.sh

@@ -0,0 +1,175 @@
+#!/bin/bash
+# Tests for rg-replace-flag-detector.sh
+#
+# Verifies the PreToolUse-Bash hook behavior from anthropics/claude-code#62016:
+#   - `rg -rn pattern path` → advisory fires (exit 0 + stderr)
+#   - `rg -r TEXT pattern` (intentional replace) → advisory fires (false-positive accepted)
+#   - `rg -n pattern path` → silent pass (no false-positive on correct usage)
+#   - `rg "pattern" path` → silent pass
+#   - `grep -rn pattern path` → silent pass (not rg)
+#   - Strict mode → exit 2 instead of exit 0
+#   - Disable flag → silent pass
+
+set -uo pipefail
+
+HOOK="$(dirname "$0")/../examples/rg-replace-flag-detector.sh"
+PASS=0
+FAIL=0
+
+assert_pass() { echo "  PASS: $1"; PASS=$((PASS + 1)); }
+assert_fail() { echo "  FAIL: $1"; FAIL=$((FAIL + 1)); }
+
+run_hook() {
+    local cmd="$1"
+    local extra_env="${2:-}"
+    local input
+    input=$(jq -nc --arg c "$cmd" '{tool_name: "Bash", tool_input: {command: $c}}')
+    if [ -n "$extra_env" ]; then
+        eval "$extra_env bash \"$HOOK\"" <<< "$input" 2>&1
+    else
+        printf '%s' "$input" | bash "$HOOK" 2>&1
+    fi
+}
+
+echo "=== rg-replace-flag-detector.sh tests ==="
+
+# --- Test 1: rg -rn pattern → advisory fires ---
+output=$(run_hook 'rg -rn "function generateTimeslotsForBranch" app/')
+rc=$?
+if [ "$rc" -eq 0 ] && echo "$output" | grep -q "rg-replace-flag-detector"; then
+    assert_pass "rg -rn fires advisory"
+else
+    assert_fail "expected exit 0 + advisory for rg -rn, got rc=$rc output=$output"
+fi
+
+# --- Test 2: rg -rln pattern → advisory fires ---
+output=$(run_hook 'rg -rln "preventStrayRequests" tests/')
+rc=$?
+if [ "$rc" -eq 0 ] && echo "$output" | grep -q "rg-replace-flag-detector"; then
+    assert_pass "rg -rln fires advisory"
+else
+    assert_fail "expected exit 0 + advisory for rg -rln, got rc=$rc output=$output"
+fi
+
+# --- Test 3: rg --replace=X explicit → advisory fires ---
+output=$(run_hook 'rg --replace=X "pattern" file.txt')
+rc=$?
+if [ "$rc" -eq 0 ] && echo "$output" | grep -q "rg-replace-flag-detector"; then
+    assert_pass "rg --replace= fires advisory"
+else
+    assert_fail "expected exit 0 + advisory for rg --replace=, got rc=$rc output=$output"
+fi
+
+# --- Test 4: rg -n pattern → silent pass (correct usage) ---
+output=$(run_hook 'rg -n "function foo" src/')
+rc=$?
+if [ "$rc" -eq 0 ] && [ -z "$output" ]; then
+    assert_pass "rg -n silent pass"
+else
+    assert_fail "expected silent exit 0 for rg -n, got rc=$rc output=$output"
+fi
+
+# --- Test 5: rg "pattern" path → silent pass ---
+output=$(run_hook 'rg "TODO" .')
+rc=$?
+if [ "$rc" -eq 0 ] && [ -z "$output" ]; then
+    assert_pass "bare rg silent pass"
+else
+    assert_fail "expected silent exit 0 for bare rg, got rc=$rc output=$output"
+fi
+
+# --- Test 6: grep -rn → silent pass (not rg) ---
+output=$(run_hook 'grep -rn "pattern" .')
+rc=$?
+if [ "$rc" -eq 0 ] && [ -z "$output" ]; then
+    assert_pass "grep -rn silent (not rg)"
+else
+    assert_fail "expected silent exit 0 for grep -rn, got rc=$rc output=$output"
+fi
+
+# --- Test 7: rg -i pattern → silent pass (case-insensitive, no -r) ---
+output=$(run_hook 'rg -i "pattern" src/')
+rc=$?
+if [ "$rc" -eq 0 ] && [ -z "$output" ]; then
+    assert_pass "rg -i silent pass"
+else
+    assert_fail "expected silent exit 0 for rg -i, got rc=$rc output=$output"
+fi
+
+# --- Test 8: rg -e pattern → silent pass (extended regex, no -r) ---
+output=$(run_hook 'rg -e "pattern" .')
+rc=$?
+if [ "$rc" -eq 0 ] && [ -z "$output" ]; then
+    assert_pass "rg -e silent pass"
+else
+    assert_fail "expected silent exit 0 for rg -e, got rc=$rc output=$output"
+fi
+
+# --- Test 9: strict mode → exit 2 ---
+output=$(run_hook 'rg -rn "pattern" .' 'CC_RG_REPLACE_DETECTOR_MODE=strict')
+rc=$?
+if [ "$rc" -eq 2 ] && echo "$output" | grep -q "rg-replace-flag-detector"; then
+    assert_pass "strict mode exits 2"
+else
+    assert_fail "expected exit 2 in strict mode, got rc=$rc output=$output"
+fi
+
+# --- Test 10: disable flag → silent ---
+output=$(run_hook 'rg -rn "pattern" .' 'CC_RG_REPLACE_DETECTOR_DISABLE=1')
+rc=$?
+if [ "$rc" -eq 0 ] && [ -z "$output" ]; then
+    assert_pass "disable flag silent pass"
+else
+    assert_fail "expected silent exit 0 when disabled, got rc=$rc output=$output"
+fi
+
+# --- Test 11: non-Bash tool → silent pass ---
+INPUT=$(jq -nc '{tool_name: "Edit", tool_input: {file_path: "/x", new_string: "rg -rn"}}')
+output=$(printf '%s' "$INPUT" | bash "$HOOK" 2>&1)
+rc=$?
+if [ "$rc" -eq 0 ] && [ -z "$output" ]; then
+    assert_pass "non-Bash tool silent"
+else
+    assert_fail "expected silent exit 0 for non-Bash, got rc=$rc output=$output"
+fi
+
+# --- Test 12: empty stdin → silent pass ---
+output=$(printf '' | bash "$HOOK" 2>&1)
+rc=$?
+if [ "$rc" -eq 0 ] && [ -z "$output" ]; then
+    assert_pass "empty stdin silent"
+else
+    assert_fail "expected silent exit 0 for empty stdin, got rc=$rc output=$output"
+fi
+
+# --- Test 13: rg -r (just -r, no other flags) → advisory ---
+output=$(run_hook 'rg -r REPLACEMENT "pattern" file.txt')
+rc=$?
+if [ "$rc" -eq 0 ] && echo "$output" | grep -q "rg-replace-flag-detector"; then
+    assert_pass "rg -r alone fires advisory"
+else
+    assert_fail "expected exit 0 + advisory for rg -r, got rc=$rc output=$output"
+fi
+
+# --- Test 14: rg with pipe → still detected ---
+output=$(run_hook 'find . -type f | xargs rg -rn pattern')
+rc=$?
+if [ "$rc" -eq 0 ] && echo "$output" | grep -q "rg-replace-flag-detector"; then
+    assert_pass "rg -rn after pipe still detected"
+else
+    assert_fail "expected exit 0 + advisory for piped rg -rn, got rc=$rc output=$output"
+fi
+
+# --- Test 15: rg -e then -r → still detected (mixed) ---
+output=$(run_hook 'rg -e "regex" -r REPLACEMENT file')
+rc=$?
+if [ "$rc" -eq 0 ] && echo "$output" | grep -q "rg-replace-flag-detector"; then
+    assert_pass "rg with -e and -r mixed still detected"
+else
+    assert_fail "expected exit 0 + advisory for rg -e -r, got rc=$rc output=$output"
+fi
+
+echo
+echo "=== Results: $PASS passed, $FAIL failed ==="
+[ "$FAIL" -eq 0 ] || exit 1
+exit 0

package/tests/test-rhetorical-verification-prompt-detector.sh

@@ -0,0 +1,237 @@
+#!/bin/bash
+# Tests for rhetorical-verification-prompt-detector.sh
+# Run: bash tests/test-rhetorical-verification-prompt-detector.sh
+set -uo pipefail
+
+PASS=0
+FAIL=0
+HOOK="$(cd "$(dirname "$0")/.." && pwd)/examples/rhetorical-verification-prompt-detector.sh"
+
+run_hook() {
+    local prompt="$1"
+    local extra_env="${2:-}"
+    if [ -n "$extra_env" ]; then
+        printf '{"prompt":%s}' "$(jq -Rs . <<< "$prompt")" | env -i PATH="$PATH" $extra_env bash "$HOOK" 2>&1
+    else
+        printf '{"prompt":%s}' "$(jq -Rs . <<< "$prompt")" | env -i PATH="$PATH" bash "$HOOK" 2>&1
+    fi
+}
+
+assert_silent() {
+    local label="$1"
+    local output="$2"
+    if [ -z "$output" ]; then
+        PASS=$((PASS + 1))
+        echo "  ✓ $label"
+    else
+        FAIL=$((FAIL + 1))
+        echo "  ✗ $label"
+        echo "    expected silent, got: ${output:0:200}"
+    fi
+}
+
+assert_emits_context() {
+    local label="$1"
+    local output="$2"
+    if echo "$output" | jq -e '.hookSpecificOutput.additionalContext' >/dev/null 2>&1; then
+        local ctx
+        ctx=$(echo "$output" | jq -r '.hookSpecificOutput.additionalContext')
+        if echo "$ctx" | grep -q "Verification-intent detected"; then
+            PASS=$((PASS + 1))
+            echo "  ✓ $label"
+        else
+            FAIL=$((FAIL + 1))
+            echo "  ✗ $label (context missing marker)"
+            echo "    got context: ${ctx:0:200}"
+        fi
+    else
+        FAIL=$((FAIL + 1))
+        echo "  ✗ $label (no hookSpecificOutput)"
+        echo "    got: ${output:0:200}"
+    fi
+}
+
+assert_emits_with_marker() {
+    local label="$1"
+    local output="$2"
+    local expected_marker_substring="$3"
+    if echo "$output" | jq -e '.hookSpecificOutput.additionalContext' >/dev/null 2>&1; then
+        local ctx
+        ctx=$(echo "$output" | jq -r '.hookSpecificOutput.additionalContext')
+        if echo "$ctx" | grep -qi "$expected_marker_substring"; then
+            PASS=$((PASS + 1))
+            echo "  ✓ $label"
+        else
+            FAIL=$((FAIL + 1))
+            echo "  ✗ $label (marker not found in context)"
+            echo "    expected marker: $expected_marker_substring"
+            echo "    got context: ${ctx:0:300}"
+        fi
+    else
+        FAIL=$((FAIL + 1))
+        echo "  ✗ $label (no output)"
+    fi
+}
+
+echo "=== Silent cases (no verification intent) ==="
+
+OUT=$(run_hook "Please write a Python script that calculates fibonacci numbers.")
+assert_silent "task prompt — no verification intent" "$OUT"
+
+OUT=$(run_hook "Add a new function to handle error cases.")
+assert_silent "task prompt — modification request" "$OUT"
+
+OUT=$(run_hook "What is the time complexity of quicksort?")
+assert_silent "knowledge question — not verification" "$OUT"
+
+OUT=$(run_hook "Show me the contents of README.md")
+assert_silent "read request — not verification" "$OUT"
+
+OUT=$(run_hook "Explain how OAuth2 works.")
+assert_silent "explanation request — not verification" "$OUT"
+
+OUT=$(run_hook "")
+assert_silent "empty prompt" "$OUT"
+
+# JSON without prompt key
+OUT=$(echo '{}' | env -i PATH="$PATH" bash "$HOOK" 2>&1)
+assert_silent "no prompt key in input" "$OUT"
+
+echo ""
+echo "=== English verification intent — should emit context ==="
+
+OUT=$(run_hook "Are you sure this is the right approach?")
+assert_emits_context "are you sure" "$OUT"
+
+OUT=$(run_hook "Did this actually work in production?")
+assert_emits_context "did this actually" "$OUT"
+
+OUT=$(run_hook "Can you confirm that the database is properly migrated?")
+assert_emits_context "can you confirm" "$OUT"
+
+OUT=$(run_hook "Is this really safe to deploy?")
+assert_emits_context "is this really safe" "$OUT"
+
+OUT=$(run_hook "Did you verify the changes are committed?")
+assert_emits_context "did you verify" "$OUT"
+
+OUT=$(run_hook "Please double-check the configuration before we proceed.")
+assert_emits_context "please double-check" "$OUT"
+
+OUT=$(run_hook "Just to be sure — did the deployment complete?")
+assert_emits_context "just to be sure" "$OUT"
+
+OUT=$(run_hook "Are you certain this is correct?")
+assert_emits_context "are you certain" "$OUT"
+
+OUT=$(run_hook "Is this actually working correctly?")
+assert_emits_context "is this actually working" "$OUT"
+
+OUT=$(run_hook "Sanity check: did all the tests pass?")
+assert_emits_context "sanity check" "$OUT"
+
+echo ""
+echo "=== Japanese verification intent — should emit context ==="
+
+OUT=$(run_hook "本当に動いてる?")
+assert_emits_context "本当に動いてる?" "$OUT"
+
+OUT=$(run_hook "確認したかどうかチェックして")
+assert_emits_context "確認した" "$OUT"
+
+OUT=$(run_hook "もう一度確認してください")
+assert_emits_context "もう一度確認" "$OUT"
+
+OUT=$(run_hook "本当に成功したのか?")
+assert_emits_context "本当に成功した" "$OUT"
+
+OUT=$(run_hook "間違いないですか?")
+assert_emits_context "間違いないですか" "$OUT"
+
+OUT=$(run_hook "大丈夫?")
+assert_emits_context "大丈夫?" "$OUT"
+
+echo ""
+echo "=== Marker propagation ==="
+
+OUT=$(run_hook "Are you sure the migration ran cleanly?")
+assert_emits_with_marker "marker 'are you sure' appears in context" "$OUT" "are you sure"
+
+OUT=$(run_hook "本当に保存されたか?")
+assert_emits_with_marker "marker '本当に' appears in context" "$OUT" "本当に"
+
+echo ""
+echo "=== Configuration ==="
+
+OUT=$(run_hook "Are you sure?" "CC_RHETORICAL_VERIFY_DISABLE=1")
+assert_silent "CC_RHETORICAL_VERIFY_DISABLE=1 silences output" "$OUT"
+
+# Logging
+LOG_FILE=$(mktemp)
+trap 'rm -f "$LOG_FILE"' EXIT
+OUT=$(run_hook "Did this really deploy?" "CC_RHETORICAL_VERIFY_LOG=$LOG_FILE")
+assert_emits_context "logging enabled still emits context" "$OUT"
+if grep -q "rhetorical-verify-detected" "$LOG_FILE" 2>/dev/null; then
+    PASS=$((PASS + 1))
+    echo "  ✓ log file contains detection event"
+else
+    FAIL=$((FAIL + 1))
+    echo "  ✗ log file missing detection event"
+fi
+
+echo ""
+echo "=== JSON structure ==="
+
+OUT=$(run_hook "Are you sure this is right?")
+# Check it's valid JSON
+if echo "$OUT" | jq -e '.' >/dev/null 2>&1; then
+    PASS=$((PASS + 1))
+    echo "  ✓ output is valid JSON"
+else
+    FAIL=$((FAIL + 1))
+    echo "  ✗ output is not valid JSON: ${OUT:0:200}"
+fi
+
+HOOK_NAME=$(echo "$OUT" | jq -r '.hookSpecificOutput.hookEventName // empty' 2>/dev/null)
+if [ "$HOOK_NAME" = "UserPromptSubmit" ]; then
+    PASS=$((PASS + 1))
+    echo "  ✓ hookEventName is UserPromptSubmit"
+else
+    FAIL=$((FAIL + 1))
+    echo "  ✗ hookEventName missing or wrong: $HOOK_NAME"
+fi
+
+# Check Issue reference appears in context
+CTX=$(echo "$OUT" | jq -r '.hookSpecificOutput.additionalContext // empty')
+if echo "$CTX" | grep -q "60107"; then
+    PASS=$((PASS + 1))
+    echo "  ✓ context references Issue #60107"
+else
+    FAIL=$((FAIL + 1))
+    echo "  ✗ context missing Issue #60107 reference"
+fi
+
+echo ""
+echo "=== Edge cases ==="
+
+# Verification intent inside a larger task should still trigger
+OUT=$(run_hook "Refactor the auth module. Are you sure the tests still pass after?")
+assert_emits_context "verification intent in mixed-purpose prompt" "$OUT"
+
+# Affirmative-sounding but not verification ("I'm sure")
+OUT=$(run_hook "I'm sure this is the right approach. Let's continue.")
+assert_silent "affirmative declaration (not verification)" "$OUT"
+
+# Long prompt with verification intent at the end
+OUT=$(run_hook "I implemented the migration script following our usual pattern, ran it against the staging database, and got the expected output. The script created the new columns, copied the data, and validated the row counts. Are you certain this is ready for production?")
+assert_emits_context "verification intent at end of long prompt" "$OUT"
+
+echo ""
+echo "==============================="
+echo "Total: $((PASS + FAIL))   PASS: $PASS   FAIL: $FAIL"
+echo "==============================="
+
+if [ "$FAIL" -gt 0 ]; then
+    exit 1
+fi
+exit 0

package/tests/test-rm-safety-net.sh

@@ -0,0 +1,115 @@
+#!/bin/bash
+# Tests for rm-safety-net.sh
+# Run: bash tests/test-rm-safety-net.sh
+set -uo pipefail
+
+HOOK="$(dirname "$0")/../examples/rm-safety-net.sh"
+PASS=0 FAIL=0
+
+run_test() {
+    local desc="$1" expected_exit="$2" cmd="$3"
+    local actual_exit
+    local input="{\"tool_name\":\"Bash\",\"tool_input\":{\"command\":${cmd}}}"
+    echo "$input" | bash "$HOOK" >/dev/null 2>/dev/null
+    actual_exit=$?
+    if [ "$actual_exit" -eq "$expected_exit" ]; then
+        echo "  PASS: $desc"
+        PASS=$((PASS + 1))
+    else
+        echo "  FAIL: $desc (expected exit $expected_exit, got $actual_exit)"
+        FAIL=$((FAIL + 1))
+    fi
+}
+
+echo "Testing rm-safety-net.sh"
+echo "========================"
+
+# --- BLOCK: rm on critical paths ---
+run_test "rm -rf / blocks"                  2 '"rm -rf /"'
+run_test "rm -rf ~ blocks"                  2 '"rm -rf ~"'
+run_test "rm -rf /etc blocks"               2 '"rm -rf /etc"'
+run_test "rm -rf /usr blocks"               2 '"rm -rf /usr"'
+run_test "rm -rf /var blocks"               2 '"rm -rf /var"'
+run_test "rm -rf /home blocks"              2 '"rm -rf /home"'
+run_test "rm -rf .git blocks"               2 '"rm -rf .git"'
+run_test "rm -rf .env blocks"               2 '"rm -rf .env"'
+run_test "rm .env (non-recursive) blocks"   2 '"rm .env"'
+run_test "rm .env.local blocks"             2 '"rm .env.local"'
+
+# --- BLOCK: nested .env paths (#65034 — Claude deleted a .env in a subdir) ---
+run_test "rm src/.env blocks"               2 '"rm src/.env"'
+run_test "rm backend/.env blocks"           2 '"rm backend/.env"'
+run_test "rm config/.env.local blocks"      2 '"rm config/.env.local"'
+run_test "rm ./app/.env blocks"             2 '"rm ./app/.env"'
+
+# --- ALLOW: lookalikes that are NOT .env files (no false positives) ---
+run_test "rm myenv allows"                  0 '"rm myenv"'
+run_test "rm environment.ts allows"         0 '"rm environment.ts"'
+run_test "rm dist/bundle.env.js allows"     0 '"rm dist/bundle.env.js"'
+
+# --- BLOCK: path traversal ---
+run_test "rm -rf ../ blocks (path traversal)"      2 '"rm -rf ../"'
+run_test "rm -rf ../foo blocks (path traversal)"   2 '"rm -rf ../foo"'
+
+# --- BLOCK: sudo prefix variant ---
+run_test "sudo rm -rf / blocks"             2 '"sudo rm -rf /"'
+
+# --- ALLOW: safe build artifacts ---
+run_test "rm -rf node_modules allows"       0 '"rm -rf node_modules"'
+run_test "rm -rf dist allows"               0 '"rm -rf dist"'
+run_test "rm -rf build allows"              0 '"rm -rf build"'
+run_test "rm -rf __pycache__ allows"        0 '"rm -rf __pycache__"'
+run_test "rm -rf .cache allows"             0 '"rm -rf .cache"'
+run_test "rm -rf .pytest_cache allows"      0 '"rm -rf .pytest_cache"'
+run_test "rm -rf coverage allows"           0 '"rm -rf coverage"'
+run_test "rm -rf .next allows"              0 '"rm -rf .next"'
+
+# --- ALLOW: relative paths under safe targets ---
+run_test "rm -rf ./node_modules allows"     0 '"rm -rf ./node_modules"'
+run_test "rm -rf ./dist allows"             0 '"rm -rf ./dist"'
+
+# --- ALLOW: non-rm commands ---
+run_test "ls -la passes through"            0 '"ls -la"'
+run_test "echo hello passes through"        0 '"echo hello"'
+run_test "git status passes through"        0 '"git status"'
+run_test "cat README.md passes through"     0 '"cat README.md"'
+
+# --- ALLOW: empty command ---
+run_test "empty command passes through"     0 '""'
+
+# --- find -delete handling (current dir allowed, sensitive paths blocked) ---
+run_test "find . -delete allows (current dir is safe)"    0 '"find . -delete"'
+run_test "find /home -delete blocks"                      2 '"find /home -delete"'
+run_test "find /etc -delete blocks"                       2 '"find /etc -delete"'
+run_test "find /tmp -delete allows (tmp is safe)"         0 '"find /tmp -delete"'
+run_test "find node_modules -delete allows (safe target)" 0 '"find node_modules -delete"'
+
+# --- BLOCK: shred (other destructive primitive) ---
+run_test "shred secret.key blocks"          2 '"shred secret.key"'
+
+# --- find | xargs rm without null delimiter (#69793) ---
+run_test "find | xargs rm -rf (no -0) blocks"        2 '"find . | xargs rm -rf"'
+run_test "find -type f | xargs rm blocks"            2 '"find . -type f | xargs rm"'
+run_test "find -print0 | xargs rm (no -0) blocks"    2 '"find . -print0 | xargs rm -rf"'
+run_test "find | xargs -0 rm (no -print0) blocks"    2 '"find . | xargs -0 rm"'
+run_test "find -print0 | xargs -0 rm -rf allows"     0 '"find . -print0 | xargs -0 rm -rf"'
+run_test "find -print0 | xargs -0 rm node_modules allows" 0 '"find . -print0 | xargs -0 rm -rf node_modules"'
+run_test "find -exec rm {} + allows (no xargs)"      0 '"find . -exec rm -rf {} +"'
+run_test "find | xargs grep allows (not destructive)" 0 '"find . | xargs grep foo"'
+
+# --- BLOCK: multi-target rm where a SAFE arg is last (last-arg-only bypass) ---
+# Before the fix, awk '{print $NF}' inspected only the last token, so a safe last
+# arg (node_modules, /tmp/...) made the whole command early-exit while the critical
+# FIRST arg was never checked.
+run_test "rm critical first, safe-dir last blocks"   2 '"rm -rf /home/user/data node_modules"'
+run_test "rm ssh key first, /tmp last blocks"        2 '"rm /home/user/.ssh/id_rsa /tmp/dummy"'
+run_test "rm /etc first, dist last blocks"           2 '"rm -rf /etc/cron.d dist"'
+run_test "rm safe-dir first, critical last blocks"   2 '"rm -rf node_modules /home/user/x"'
+# --- ALLOW: legit multi-target deletes still pass (no regression) ---
+run_test "rm two dist files allows"                  0 '"rm dist/a.js dist/b.js"'
+run_test "rm bare glob *.pyc allows"                 0 '"rm *.pyc"'
+
+echo
+echo "========================"
+echo "Results: $PASS passed, $FAIL failed"
+exit $FAIL