cc-reviewer 1.0.3 → 1.0.5

package/dist/cli/codex.js

@@ -8,7 +8,9 @@ import { spawn } from 'child_process';
 import { existsSync } from 'fs';
 import { build7SectionPrompt, buildDeveloperInstructions, buildRetryPrompt, isValidFeedbackOutput } from '../prompt.js';
 import { createTimeoutError, createCliNotFoundError, getSuggestion } from '../errors.js';
-const TIMEOUT_MS = 180000; // 3 minutes (Codex can be slow)
+// Activity-based timeout: reset on output, kill on silence
+const INACTIVITY_TIMEOUT_MS = 120000; // 2 min of no output = timeout
+const MAX_TIMEOUT_MS = 3600000; // 60 min absolute max (edge case safety)
 const MAX_RETRIES = 2;
 const MAX_BUFFER_SIZE = 1024 * 1024; // 1MB max buffer to prevent memory issues
 /**
@@ -45,7 +47,7 @@ async function runWithRetry(request, attempt, previousError, previousOutput) {
         // Codex exec doesn't have a separate system instruction flag
         const fullPrompt = `${developerInstructions}\n\n---\n\n${basePrompt}`;
         // Run the CLI
-        const result = await runCodexCli(fullPrompt, request.workingDir);
+        const result = await runCodexCli(fullPrompt, request.workingDir, request.reasoningEffort || 'high');
         // Check for CLI errors
         if (result.exitCode !== 0) {
             // Check for specific error patterns in stderr
@@ -136,11 +138,15 @@ async function runWithRetry(request, attempt, previousError, previousOutput) {
                 model: 'codex'
             };
         }
-        if (err.message === 'TIMEOUT') {
+        if (err.message === 'TIMEOUT' || err.message === 'MAX_TIMEOUT') {
+            const isMaxTimeout = err.message === 'MAX_TIMEOUT';
+            const timeoutMs = isMaxTimeout ? MAX_TIMEOUT_MS : INACTIVITY_TIMEOUT_MS;
             return {
                 success: false,
-                error: createTimeoutError('codex', TIMEOUT_MS),
-                suggestion: getSuggestion(createTimeoutError('codex', TIMEOUT_MS)),
+                error: createTimeoutError('codex', timeoutMs),
+                suggestion: isMaxTimeout
+                    ? 'Task exceeded 60 minute maximum. Try a smaller scope.'
+                    : 'No output for 2 minutes. Process may be hung. Try a smaller scope or use --focus.',
                 model: 'codex'
             };
         }
@@ -160,17 +166,17 @@ async function runWithRetry(request, attempt, previousError, previousOutput) {
 /**
  * Execute the Codex CLI in non-interactive mode
  *
- * Uses: codex exec -m gpt-5.2-codex -c model_reasoning_effort="xhigh" \
+ * Uses: codex exec -m gpt-5.2-codex -c model_reasoning_effort="high|xhigh" \
  *   -c model_reasoning_summary_format=experimental \
  *   --dangerously-bypass-approvals-and-sandbox "<prompt>"
  */
-function runCodexCli(prompt, workingDir) {
+function runCodexCli(prompt, workingDir, reasoningEffort = 'high') {
     return new Promise((resolve, reject) => {
         // Build CLI arguments for non-interactive execution
         const args = [
             'exec',
             '-m', 'gpt-5.2-codex',
-            '-c', 'model_reasoning_effort=xhigh',
+            '-c', `model_reasoning_effort=${reasoningEffort}`,
             '-c', 'model_reasoning_summary_format=experimental',
             '--dangerously-bypass-approvals-and-sandbox',
             '--skip-git-repo-check',
@@ -185,7 +191,24 @@ function runCodexCli(prompt, workingDir) {
         let stdout = '';
         let stderr = '';
         let truncated = false;
+        let inactivityTimer;
+        // Max timeout - absolute cap (60 min)
+        const maxTimer = setTimeout(() => {
+            proc.kill('SIGTERM');
+            reject(new Error('MAX_TIMEOUT'));
+        }, MAX_TIMEOUT_MS);
+        // Activity-based timeout - reset on any output
+        const resetInactivityTimer = () => {
+            clearTimeout(inactivityTimer);
+            inactivityTimer = setTimeout(() => {
+                proc.kill('SIGTERM');
+                reject(new Error('TIMEOUT'));
+            }, INACTIVITY_TIMEOUT_MS);
+        };
+        // Start inactivity timer
+        resetInactivityTimer();
         proc.stdout.on('data', (data) => {
+            resetInactivityTimer(); // Still streaming = reset timer
             if (stdout.length < MAX_BUFFER_SIZE) {
                 stdout += data.toString();
                 if (stdout.length > MAX_BUFFER_SIZE) {
@@ -195,6 +218,7 @@ function runCodexCli(prompt, workingDir) {
             }
         });
         proc.stderr.on('data', (data) => {
+            resetInactivityTimer(); // Still streaming = reset timer
             if (stderr.length < MAX_BUFFER_SIZE) {
                 stderr += data.toString();
                 if (stderr.length > MAX_BUFFER_SIZE) {
@@ -202,13 +226,9 @@ function runCodexCli(prompt, workingDir) {
                 }
             }
         });
-        // Timeout handling
-        const timeout = setTimeout(() => {
-            proc.kill('SIGTERM');
-            reject(new Error('TIMEOUT'));
-        }, TIMEOUT_MS);
         proc.on('close', (code) => {
-            clearTimeout(timeout);
+            clearTimeout(inactivityTimer);
+            clearTimeout(maxTimer);
             resolve({
                 stdout,
                 stderr,
@@ -217,7 +237,8 @@ function runCodexCli(prompt, workingDir) {
             });
         });
         proc.on('error', (err) => {
-            clearTimeout(timeout);
+            clearTimeout(inactivityTimer);
+            clearTimeout(maxTimer);
             reject(err);
         });
     });

package/dist/cli/gemini.js

@@ -9,7 +9,9 @@ import { spawn } from 'child_process';
 import { existsSync } from 'fs';
 import { build7SectionPrompt, buildDeveloperInstructions, buildRetryPrompt, isValidFeedbackOutput } from '../prompt.js';
 import { createTimeoutError, createCliNotFoundError, getSuggestion } from '../errors.js';
-const TIMEOUT_MS = 180000; // 3 minutes
+// Activity-based timeout: reset on output, kill on silence
+const INACTIVITY_TIMEOUT_MS = 120000; // 2 min of no output = timeout
+const MAX_TIMEOUT_MS = 3600000; // 60 min absolute max (edge case safety)
 const MAX_RETRIES = 2;
 const MAX_BUFFER_SIZE = 1024 * 1024; // 1MB max buffer to prevent memory issues
 /**
@@ -139,11 +141,15 @@ async function runWithRetry(request, attempt, previousError, previousOutput) {
                 model: 'gemini'
             };
         }
-        if (err.message === 'TIMEOUT') {
+        if (err.message === 'TIMEOUT' || err.message === 'MAX_TIMEOUT') {
+            const isMaxTimeout = err.message === 'MAX_TIMEOUT';
+            const timeoutMs = isMaxTimeout ? MAX_TIMEOUT_MS : INACTIVITY_TIMEOUT_MS;
             return {
                 success: false,
-                error: createTimeoutError('gemini', TIMEOUT_MS),
-                suggestion: getSuggestion(createTimeoutError('gemini', TIMEOUT_MS)),
+                error: createTimeoutError('gemini', timeoutMs),
+                suggestion: isMaxTimeout
+                    ? 'Task exceeded 60 minute maximum. Try a smaller scope.'
+                    : 'No output for 2 minutes. Process may be hung. Try a smaller scope or use --focus.',
                 model: 'gemini'
             };
         }
@@ -182,7 +188,24 @@ function runGeminiCli(prompt, workingDir) {
         let stdout = '';
         let stderr = '';
         let truncated = false;
+        let inactivityTimer;
+        // Max timeout - absolute cap (60 min)
+        const maxTimer = setTimeout(() => {
+            proc.kill('SIGTERM');
+            reject(new Error('MAX_TIMEOUT'));
+        }, MAX_TIMEOUT_MS);
+        // Activity-based timeout - reset on any output
+        const resetInactivityTimer = () => {
+            clearTimeout(inactivityTimer);
+            inactivityTimer = setTimeout(() => {
+                proc.kill('SIGTERM');
+                reject(new Error('TIMEOUT'));
+            }, INACTIVITY_TIMEOUT_MS);
+        };
+        // Start inactivity timer
+        resetInactivityTimer();
         proc.stdout.on('data', (data) => {
+            resetInactivityTimer(); // Still streaming = reset timer
             if (stdout.length < MAX_BUFFER_SIZE) {
                 stdout += data.toString();
                 if (stdout.length > MAX_BUFFER_SIZE) {
@@ -192,6 +215,7 @@ function runGeminiCli(prompt, workingDir) {
             }
         });
         proc.stderr.on('data', (data) => {
+            resetInactivityTimer(); // Still streaming = reset timer
             if (stderr.length < MAX_BUFFER_SIZE) {
                 stderr += data.toString();
                 if (stderr.length > MAX_BUFFER_SIZE) {
@@ -199,13 +223,9 @@ function runGeminiCli(prompt, workingDir) {
                 }
             }
         });
-        // Timeout handling
-        const timeout = setTimeout(() => {
-            proc.kill('SIGTERM');
-            reject(new Error('TIMEOUT'));
-        }, TIMEOUT_MS);
         proc.on('close', (code) => {
-            clearTimeout(timeout);
+            clearTimeout(inactivityTimer);
+            clearTimeout(maxTimer);
             resolve({
                 stdout,
                 stderr,
@@ -214,7 +234,8 @@ function runGeminiCli(prompt, workingDir) {
             });
         });
         proc.on('error', (err) => {
-            clearTimeout(timeout);
+            clearTimeout(inactivityTimer);
+            clearTimeout(maxTimer);
             reject(err);
         });
     });

package/dist/tools/feedback.d.ts

@@ -9,6 +9,7 @@ export declare const FeedbackInputSchema: z.ZodObject<{
     analyzedFiles: z.ZodOptional<z.ZodArray<z.ZodString, "many">>;
     focusAreas: z.ZodOptional<z.ZodArray<z.ZodEnum<["security", "performance", "architecture", "correctness", "maintainability", "scalability", "testing", "documentation"]>, "many">>;
     customPrompt: z.ZodOptional<z.ZodString>;
+    reasoningEffort: z.ZodOptional<z.ZodEnum<["high", "xhigh"]>>;
 }, "strip", z.ZodTypeAny, {
     workingDir: string;
     ccOutput: string;
@@ -16,6 +17,7 @@ export declare const FeedbackInputSchema: z.ZodObject<{
     analyzedFiles?: string[] | undefined;
     focusAreas?: ("security" | "performance" | "architecture" | "correctness" | "maintainability" | "scalability" | "testing" | "documentation")[] | undefined;
     customPrompt?: string | undefined;
+    reasoningEffort?: "high" | "xhigh" | undefined;
 }, {
     workingDir: string;
     ccOutput: string;
@@ -23,6 +25,7 @@ export declare const FeedbackInputSchema: z.ZodObject<{
     analyzedFiles?: string[] | undefined;
     focusAreas?: ("security" | "performance" | "architecture" | "correctness" | "maintainability" | "scalability" | "testing" | "documentation")[] | undefined;
     customPrompt?: string | undefined;
+    reasoningEffort?: "high" | "xhigh" | undefined;
 }>;
 export type FeedbackInput = z.infer<typeof FeedbackInputSchema>;
 /**

package/dist/tools/feedback.js

@@ -16,7 +16,8 @@ export const FeedbackInputSchema = z.object({
         'security', 'performance', 'architecture', 'correctness',
         'maintainability', 'scalability', 'testing', 'documentation'
     ])).optional().describe('Areas to focus the review on'),
-    customPrompt: z.string().optional().describe('Custom instructions for the reviewer')
+    customPrompt: z.string().optional().describe('Custom instructions for the reviewer'),
+    reasoningEffort: z.enum(['high', 'xhigh']).optional().describe('Codex reasoning effort level (default: high, use xhigh for deeper analysis)')
 });
 /**
  * Convert tool input to FeedbackRequest
@@ -28,7 +29,8 @@ function toFeedbackRequest(input) {
         outputType: input.outputType,
         analyzedFiles: input.analyzedFiles,
         focusAreas: input.focusAreas,
-        customPrompt: input.customPrompt
+        customPrompt: input.customPrompt,
+        reasoningEffort: input.reasoningEffort
     };
 }
 /**

package/dist/types.d.ts

@@ -4,6 +4,7 @@
 export type OutputType = 'plan' | 'findings' | 'analysis' | 'proposal';
 export type FocusArea = 'security' | 'performance' | 'architecture' | 'correctness' | 'maintainability' | 'scalability' | 'testing' | 'documentation';
 export type CliType = 'codex' | 'gemini';
+export type ReasoningEffort = 'high' | 'xhigh';
 export interface FeedbackRequest {
     workingDir: string;
     ccOutput: string;
@@ -11,6 +12,7 @@ export interface FeedbackRequest {
     analyzedFiles?: string[];
     focusAreas?: FocusArea[];
     customPrompt?: string;
+    reasoningEffort?: ReasoningEffort;
 }
 export interface FeedbackSuccess {
     success: true;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "cc-reviewer",
-  "version": "1.0.3",
+  "version": "1.0.5",
   "description": "MCP server for Claude Code - Get second-opinion feedback from Codex/Gemini CLIs",
   "type": "module",
   "main": "dist/index.js",