cc-devflow 4.5.8 → 4.5.10

package/lib/skill-runtime/schemas.js

@@ -1,6 +1,6 @@
 /**
- * [INPUT]: 依赖 zod 进行运行时 schema 校验，依赖调用方提供 manifest/report/checkpoint 原始对象。
- * [OUTPUT]: 对外提供 Manifest/Task/ReportCard/Checkpoint/Runtime approval schema 与 parse 校验函数。
+ * [INPUT]: 依赖 zod 进行运行时 schema 校验，依赖调用方提供 manifest/report/runtime 原始对象。
+ * [OUTPUT]: 对外提供 Manifest/Task/ReportCard/Runtime approval schema 与 parse 校验函数。
  * [POS]: skill runtime 的类型边界层，被 planner/dispatcher/verifier/release 复用。
  * [PROTOCOL]: 变更时更新此头部，然后检查 CLAUDE.md
  */
@@ -82,7 +82,7 @@ const TaskReviewStateSchema = z.object({
 const TaskSchema = z.object({
   id: z.string().regex(TASK_ID_PATTERN, 'Invalid task id'),
   title: z.string().min(1, 'Task title is required'),
-  type: z.enum(['TEST', 'IMPL', 'OTHER']).default('OTHER'),
+  type: z.enum(['TEST', 'IMPL', 'OTHER', 'REFACTOR', 'VERIFY']).default('OTHER'),
   phase: z.number().int().min(1).default(1),
   parallel: z.boolean().default(false),
   dependsOn: z.array(z.string().regex(TASK_ID_PATTERN)).default([]),
@@ -107,10 +107,10 @@ const ManifestSchema = z.object({
   createdAt: z.string().datetime(),
   updatedAt: z.string().datetime(),
   currentTaskId: z.string().regex(TASK_ID_PATTERN).nullable().default(null),
-  activePhase: z.number().int().min(1).nullable().default(null),
+  activePhase: z.number().int().min(1).nullable().optional(),
   tasks: z.array(TaskSchema),
   metadata: z.object({
-    source: z.enum(['tasks.md', 'default']).default('default'),
+    source: z.enum(['tasks.md', 'planning/tasks.md', 'default']).default('default'),
     generatedBy: z.string().min(1).default('skill:cc-plan'),
     planVersion: z.number().int().min(1).default(1)
   }).default({ source: 'default', generatedBy: 'skill:cc-plan', planVersion: 1 })
@@ -161,7 +161,7 @@ const ManifestSchema = z.object({
     ? Math.min(...unfinished.map((task) => task.phase || 1))
     : null;
 
-  if (manifest.activePhase !== null && manifest.activePhase !== derivedActivePhase) {
+  if (manifest.activePhase !== undefined && manifest.activePhase !== null && manifest.activePhase !== derivedActivePhase) {
     ctx.addIssue({
       code: z.ZodIssueCode.custom,
       path: ['activePhase'],
@@ -370,17 +370,31 @@ const ReviewSectionSchema = z.object({
   findings: z.array(ReviewFindingSchema).default([])
 });
 
+const ReviewFreshnessSchema = z.object({
+  status: z.enum(['fresh', 'stale', 'unknown', 'not-applicable']).default('unknown'),
+  reviewedCommit: z.string().default(''),
+  currentCommit: z.string().default(''),
+  commitsSinceReview: z.number().int().min(0).nullable().default(null),
+  staleReason: z.string().default('')
+});
+
+const RecordReviewSchema = ReviewSectionSchema.extend({
+  source: z.string().min(1).default('review-records'),
+  freshness: ReviewFreshnessSchema.default({
+    status: 'unknown',
+    reviewedCommit: '',
+    currentCommit: '',
+    commitsSinceReview: null,
+    staleReason: ''
+  }),
+  errors: z.array(z.string()).default([])
+});
+
 const ReportReviewSchema = z.object({
   status: ReviewDecisionStatusSchema.default('skipped'),
   summary: z.string().default(''),
   details: z.string().default(''),
-  freshness: z.object({
-    status: z.enum(['fresh', 'stale', 'unknown', 'not-applicable']).default('unknown'),
-    reviewedCommit: z.string().default(''),
-    currentCommit: z.string().default(''),
-    commitsSinceReview: z.number().int().min(0).nullable().default(null),
-    staleReason: z.string().default('')
-  }).default({
+  freshness: ReviewFreshnessSchema.default({
     status: 'unknown',
     reviewedCommit: '',
     currentCommit: '',
@@ -403,6 +417,22 @@ const ReportReviewSchema = z.object({
     reviewers: [],
     findings: []
   }),
+  recordReview: RecordReviewSchema.default({
+    source: 'review-records',
+    status: 'skipped',
+    required: false,
+    summary: '',
+    reviewers: [],
+    findings: [],
+    freshness: {
+      status: 'unknown',
+      reviewedCommit: '',
+      currentCommit: '',
+      commitsSinceReview: null,
+      staleReason: ''
+    },
+    errors: []
+  }),
   diffReview: ReviewSectionSchema.default({
     status: 'skipped',
     required: false,
@@ -529,6 +559,121 @@ const ReportCardSchema = z.object({
   timestamp: z.string().datetime()
 });
 
+/* ============================================================
+ *  Review-ledger event schemas (REQ-003 minimize-workflow-artifacts)
+ *  Source: devflow/changes/REQ-003-minimize-workflow-artifacts/
+ *  planning/design.md §Interface & Data Contract
+ * ============================================================ */
+
+const REVIEW_LEDGER_SCHEMA = z.literal('review-ledger.v2');
+const REVIEW_FINDINGS_SCHEMA = z.literal('review-findings.v2');
+const ReviewLedgerRouteSchema = z.enum(['cc-do', 'cc-check', 'cc-plan', 'cc-act', 'no-op']);
+const ReviewLedgerModeSchema = z.enum(['plan', 'implementation', 'mixed']);
+const ReviewLedgerSeveritySchema = z.enum(['critical', 'important', 'advisory']);
+const ReviewLedgerDisplayTierSchema = z.enum(['blocking', 'warning', 'info', 'suppressed']);
+const ReviewLedgerFreshnessStatusSchema = z.enum(['fresh', 'stale', 'unknown']);
+const ReviewLedgerSummaryStatusSchema = z.enum(['clean', 'findings', 'blocked']);
+
+const reviewLedgerEventCommon = {
+  schema: REVIEW_LEDGER_SCHEMA,
+  change: z.string().min(1),
+  reviewId: z.string().min(1),
+  createdAt: z.string().datetime(),
+  createdBy: z.string().min(1)
+};
+
+const ReviewLedgerStartedEventSchema = z.object({
+  ...reviewLedgerEventCommon,
+  event: z.literal('review-started'),
+  mode: ReviewLedgerModeSchema,
+  scope: z.string().min(1),
+  baseSha: z.string().min(1),
+  headSha: z.string().min(1),
+  selectedNodes: z.array(z.string().min(1)).default([]),
+  skippedNodes: z.array(z.object({
+    node: z.string().min(1),
+    reason: z.string().default('')
+  })).default([]),
+  riskLanes: z.array(z.string().min(1)).default([])
+});
+
+const ReviewLedgerNodeCheckedEventSchema = z.object({
+  ...reviewLedgerEventCommon,
+  event: z.literal('review-node-checked'),
+  nodeId: z.string().min(1),
+  mode: ReviewLedgerModeSchema,
+  target: z.string().min(1),
+  status: z.enum(['checked', 'skipped', 'blocked']),
+  coverage: z.array(z.string().min(1)).default([]),
+  evidenceRefs: z.array(z.string().min(1)).default([]),
+  findings: z.array(z.string().min(1)).default([]),
+  next: ReviewLedgerRouteSchema
+});
+
+const ReviewLedgerFindingAddedEventSchema = z.object({
+  ...reviewLedgerEventCommon,
+  event: z.literal('review-finding-added'),
+  findingId: z.string().min(1),
+  severity: ReviewLedgerSeveritySchema,
+  confidence: z.number().min(0).max(10),
+  displayTier: ReviewLedgerDisplayTierSchema,
+  fingerprint: z.string().min(1),
+  scope: z.string().min(1),
+  path: z.string().min(1),
+  evidence: z.string().min(1),
+  recommendation: z.string().min(1),
+  route: ReviewLedgerRouteSchema
+});
+
+const ReviewLedgerClosedEventSchema = z.object({
+  ...reviewLedgerEventCommon,
+  event: z.literal('review-closed'),
+  status: ReviewLedgerSummaryStatusSchema,
+  blockingCount: z.number().int().min(0),
+  warningCount: z.number().int().min(0),
+  next: ReviewLedgerRouteSchema
+});
+
+const ReviewLedgerEventSchema = z.discriminatedUnion('event', [
+  ReviewLedgerStartedEventSchema,
+  ReviewLedgerNodeCheckedEventSchema,
+  ReviewLedgerFindingAddedEventSchema,
+  ReviewLedgerClosedEventSchema
+]);
+
+const ReviewLedgerFindingEntrySchema = z.object({
+  id: z.string().min(1),
+  severity: ReviewLedgerSeveritySchema,
+  confidence: z.number().min(0).max(10),
+  displayTier: ReviewLedgerDisplayTierSchema,
+  fingerprint: z.string().min(1),
+  scope: z.string().min(1),
+  path: z.string().min(1),
+  evidence: z.string().min(1),
+  recommendation: z.string().min(1),
+  route: ReviewLedgerRouteSchema
+});
+
+const ReviewFindingsDocSchema = z.object({
+  schema: REVIEW_FINDINGS_SCHEMA,
+  change: z.string().min(1),
+  reviewId: z.string().min(1),
+  headSha: z.string().min(1),
+  freshness: z.object({
+    status: ReviewLedgerFreshnessStatusSchema,
+    reviewedCommit: z.string().min(1),
+    currentCommit: z.string().min(1),
+    commitsSinceReview: z.number().int().min(0)
+  }),
+  summary: z.object({
+    status: ReviewLedgerSummaryStatusSchema,
+    blockingCount: z.number().int().min(0),
+    warningCount: z.number().int().min(0),
+    next: ReviewLedgerRouteSchema
+  }),
+  findings: z.array(ReviewLedgerFindingEntrySchema).default([])
+});
+
 function parseWithSchema(schema, input, label) {
   const parsed = schema.safeParse(input);
   if (parsed.success) {
@@ -542,7 +687,9 @@ function parseWithSchema(schema, input, label) {
 }
 
 function parseManifest(input) {
-  return parseWithSchema(ManifestSchema, input, 'Manifest');
+  const manifest = parseWithSchema(ManifestSchema, input, 'Manifest');
+  delete manifest.activePhase;
+  return manifest;
 }
 
 function parseCheckpoint(input) {
@@ -557,6 +704,14 @@ function parseRuntimeState(input) {
   return parseWithSchema(RuntimeStateSchema, input, 'RuntimeState');
 }
 
+function parseReviewLedgerEvent(input) {
+  return parseWithSchema(ReviewLedgerEventSchema, input, 'ReviewLedgerEvent');
+}
+
+function parseReviewFindingsDoc(input) {
+  return parseWithSchema(ReviewFindingsDocSchema, input, 'ReviewFindingsDoc');
+}
+
 module.exports = {
   ChangeIdSchema,
   TaskSchema,
@@ -575,8 +730,17 @@ module.exports = {
   ReviewSectionSchema,
   ReportReviewSchema,
   ReportCardSchema,
+  ReviewLedgerEventSchema,
+  ReviewLedgerStartedEventSchema,
+  ReviewLedgerNodeCheckedEventSchema,
+  ReviewLedgerFindingAddedEventSchema,
+  ReviewLedgerClosedEventSchema,
+  ReviewLedgerFindingEntrySchema,
+  ReviewFindingsDocSchema,
   parseManifest,
   parseCheckpoint,
   parseReportCard,
-  parseRuntimeState
+  parseRuntimeState,
+  parseReviewLedgerEvent,
+  parseReviewFindingsDoc
 };

package/lib/skill-runtime/store.js

@@ -80,14 +80,6 @@ function getEventsPath(repoRoot, changeId, taskId, options = {}) {
   return getTaskPaths(repoRoot, changeId, taskId, options).eventsPath;
 }
 
-function getCheckpointPath(repoRoot, changeId, taskId, options = {}) {
-  return getTaskPaths(repoRoot, changeId, taskId, options).checkpointPath;
-}
-
-function getTaskReviewPath(repoRoot, changeId, taskId, kind, options = {}) {
-  return path.join(getTaskPaths(repoRoot, changeId, taskId, options).taskDir, `review-${kind}.md`);
-}
-
 async function exists(filePath) {
   try {
     await fsp.access(filePath);
@@ -239,8 +231,6 @@ module.exports = {
   getRuntimeChangeDir,
   getRuntimeTaskDir,
   getEventsPath,
-  getCheckpointPath,
-  getTaskReviewPath,
   exists,
   ensureDir,
   readText,

package/lib/skill-runtime/task-contract.js

@@ -0,0 +1,187 @@
+/**
+ * [INPUT]: 接收 tasks.md 原始 Markdown 字符串；无文件 IO、无全局状态。
+ * [OUTPUT]: 对外暴露 extractTasksContractSummary / extractTasksRootCauseContract → {found, content, fields}。
+ * [POS]: REQ-003 task-contract 纯函数层；后续 compile / validate / migrate 复用本文件的解析 engine。
+ * [PROTOCOL]: 变更时更新此头部，然后检查 CLAUDE.md
+ */
+
+// ============================================================================
+//  Section field schema
+// ============================================================================
+
+const CONTRACT_FIELD_MAP = {
+  'Change': 'change',
+  'Mode': 'mode',
+  'Profile': 'profile',
+  'Approval': 'approval',
+  'Goal': 'goal',
+  'Do Not Do': 'doNotDo',
+  'Approved Direction': 'approvedDirection',
+  'Acceptance': 'acceptance',
+  'Verification': 'verification',
+  'Risk / Escalate If': 'risk'
+};
+
+const CONTRACT_SINGLE_LINE = new Set(['change', 'mode', 'profile', 'approval']);
+const CONTRACT_LIST = new Set(['goal', 'doNotDo', 'approvedDirection', 'acceptance', 'risk']);
+const CONTRACT_VERIFICATION = new Set(['verification']);
+
+const ROOT_CAUSE_FIELD_MAP = {
+  'Change': 'change',
+  'Mode': 'mode',
+  'Profile': 'profile',
+  'Diagnosis': 'diagnosis',
+  'Symptom': 'symptom',
+  'Reproduction': 'reproduction',
+  'Expected': 'expected',
+  'Actual': 'actual',
+  'Root Cause': 'rootCause',
+  'Evidence Chain': 'evidenceChain',
+  'Repair Boundary': 'repairBoundary',
+  'Prevention': 'prevention',
+  'Risk / Escalate If': 'risk'
+};
+
+const ROOT_CAUSE_SINGLE_LINE = new Set(['change', 'mode', 'profile', 'diagnosis']);
+const ROOT_CAUSE_LIST = new Set([
+  'symptom',
+  'reproduction',
+  'expected',
+  'actual',
+  'rootCause',
+  'evidenceChain',
+  'repairBoundary',
+  'prevention',
+  'risk'
+]);
+const ROOT_CAUSE_VERIFICATION = new Set();
+
+// ============================================================================
+//  Heading block extraction (shared engine)
+// ============================================================================
+
+function extractHeadingBlock(text, heading) {
+  if (typeof text !== 'string') {
+    throw new TypeError('task-contract parser expects a string input');
+  }
+  const escaped = heading.replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
+  const pattern = new RegExp(`(^|\\n)(${escaped}\\r?\\n?)`);
+  const match = text.match(pattern);
+  if (!match) {
+    return { found: false, content: '', body: '' };
+  }
+  const headingStart = match.index + match[1].length;
+  const headingLineEnd = headingStart + match[2].length;
+  const rest = text.slice(headingLineEnd);
+  const nextIdx = rest.search(/\n## /);
+  const blockEnd = nextIdx === -1 ? text.length : headingLineEnd + nextIdx;
+  return {
+    found: true,
+    content: text.slice(headingStart, blockEnd),
+    body: text.slice(headingLineEnd, blockEnd)
+  };
+}
+
+// ============================================================================
+//  Generic section parser
+// ============================================================================
+
+function parseSectionFields(body, schema) {
+  const { fieldMap, singleLineKeys, listKeys, verificationKeys } = schema;
+  const lines = body.split('\n');
+  const fields = {};
+  let currentLabel = null;
+  let currentInline = null;
+  let currentLines = [];
+
+  const flush = () => {
+    if (!currentLabel) return;
+    const key = fieldMap[currentLabel];
+    if (key) {
+      const value = finalizeFieldValue(key, currentInline, currentLines, singleLineKeys, listKeys, verificationKeys);
+      if (value !== undefined) fields[key] = value;
+    }
+    currentLabel = null;
+    currentInline = null;
+    currentLines = [];
+  };
+
+  for (const line of lines) {
+    const kv = line.match(/^([A-Z][A-Za-z /]+?):\s*(.*)$/);
+    if (kv && Object.prototype.hasOwnProperty.call(fieldMap, kv[1])) {
+      flush();
+      currentLabel = kv[1];
+      currentInline = kv[2].length > 0 ? kv[2].trim() : null;
+    } else if (currentLabel) {
+      currentLines.push(line);
+    }
+  }
+  flush();
+  return fields;
+}
+
+function finalizeFieldValue(key, inline, lines, singleLineKeys, listKeys, verificationKeys) {
+  if (singleLineKeys.has(key)) {
+    return inline !== null ? inline : undefined;
+  }
+  if (listKeys.has(key)) {
+    const items = lines
+      .map(line => line.match(/^\s*-\s+(.*)$/))
+      .filter(Boolean)
+      .map(match => match[1].trim());
+    if (items.length > 0) return items;
+    return inline !== null ? inline : undefined;
+  }
+  if (verificationKeys.has(key)) {
+    const joined = lines.join('\n');
+    const fenceMatch = joined.match(/```[^\n]*\n([\s\S]*?)```/);
+    if (fenceMatch) return fenceMatch[1].replace(/^\n+|\n+$/g, '');
+    const trimmed = joined.replace(/^\n+|\n+$/g, '');
+    if (trimmed.length > 0) return trimmed;
+    return inline !== null ? inline : undefined;
+  }
+  return undefined;
+}
+
+// ============================================================================
+//  Public parsers
+// ============================================================================
+
+function extractTasksContractSummary(text) {
+  const block = extractHeadingBlock(text, '## Contract Summary');
+  if (!block.found) {
+    return { found: false, content: '', fields: {} };
+  }
+  return {
+    found: true,
+    content: block.content,
+    fields: parseSectionFields(block.body, {
+      fieldMap: CONTRACT_FIELD_MAP,
+      singleLineKeys: CONTRACT_SINGLE_LINE,
+      listKeys: CONTRACT_LIST,
+      verificationKeys: CONTRACT_VERIFICATION
+    })
+  };
+}
+
+function extractTasksRootCauseContract(text) {
+  const block = extractHeadingBlock(text, '## Root Cause Contract');
+  if (!block.found) {
+    return { found: false, content: '', fields: {} };
+  }
+  return {
+    found: true,
+    content: block.content,
+    fields: parseSectionFields(block.body, {
+      fieldMap: ROOT_CAUSE_FIELD_MAP,
+      singleLineKeys: ROOT_CAUSE_SINGLE_LINE,
+      listKeys: ROOT_CAUSE_LIST,
+      verificationKeys: ROOT_CAUSE_VERIFICATION
+    })
+  };
+}
+
+module.exports = {
+  extractTasksContractSummary,
+  extractTasksRootCauseContract
+};