cc-devflow 4.5.11 → 4.5.12

package/lib/skill-runtime/__tests__/readiness.test.js

@@ -1,53 +0,0 @@
-const {
-  assertShipReady,
-  deriveShipReadiness
-} = require('../readiness');
-
-describe('ship readiness', () => {
-  test('derives one shared readiness verdict from report-card truth', () => {
-    const report = {
-      verdict: 'pass',
-      overall: 'pass',
-      reroute: 'none',
-      specSyncReady: true,
-      blockingFindings: [],
-      gaps: [],
-      timestamp: '2026-03-25T01:11:00.000Z'
-    };
-
-    expect(deriveShipReadiness(report, { reportPath: '/tmp/report-card.json' })).toEqual({
-      ready: true,
-      verdict: 'pass',
-      reroute: 'none',
-      specSyncReady: true,
-      blockers: [],
-      reportPath: '/tmp/report-card.json',
-      timestamp: '2026-03-25T01:11:00.000Z'
-    });
-  });
-
-  test('throws named release errors from the same readiness blockers', () => {
-    const report = {
-      verdict: 'pass',
-      overall: 'pass',
-      reroute: 'cc-do',
-      specSyncReady: false,
-      blockingFindings: ['review: stale'],
-      gaps: ['spec gap'],
-      timestamp: '2026-03-25T01:11:00.000Z'
-    };
-
-    expect(() => assertShipReady(report, {
-      reportPath: '/tmp/report-card.json',
-      errorName: 'ReleaseReadinessError',
-      rescueAction: 'run cc-check until ship-readiness is ready before release'
-    })).toThrow(expect.objectContaining({
-      name: 'ReleaseReadinessError',
-      artifactRefs: ['/tmp/report-card.json'],
-      rescueAction: 'run cc-check until ship-readiness is ready before release',
-      details: {
-        blockers: ['reroute is cc-do', 'specSyncReady is not true', 'review: stale', 'spec gap']
-      }
-    }));
-  });
-});

package/lib/skill-runtime/__tests__/release.test.js

@@ -1,85 +0,0 @@
-const fs = require('fs');
-const os = require('os');
-const path = require('path');
-
-const { runRelease } = require('../operations/release');
-const {
-  getRuntimeStatePath,
-  getTaskManifestPath,
-  getReportCardPath,
-  getReleaseNotePath
-} = require('../store');
-
-function writeJson(filePath, value) {
-  fs.mkdirSync(path.dirname(filePath), { recursive: true });
-  fs.writeFileSync(filePath, `${JSON.stringify(value, null, 2)}\n`);
-}
-
-function writeReleaseFixture(repoRoot, reportOverrides = {}) {
-  writeJson(getRuntimeStatePath(repoRoot, 'REQ-123'), {
-    changeId: 'REQ-123',
-    goal: 'Release only when ship ready',
-    status: 'verified',
-    initializedAt: '2026-03-25T01:00:00.000Z',
-    plannedAt: '2026-03-25T01:01:00.000Z',
-    verifiedAt: '2026-03-25T01:02:00.000Z',
-    updatedAt: '2026-03-25T01:02:00.000Z'
-  });
-
-  writeJson(getTaskManifestPath(repoRoot, 'REQ-123'), {
-    changeId: 'REQ-123',
-    goal: 'Release only when ship ready',
-    createdAt: '2026-03-25T01:00:00.000Z',
-    updatedAt: '2026-03-25T01:02:00.000Z',
-    tasks: [
-      {
-        id: 'T001',
-        title: 'Finish change',
-        type: 'IMPL',
-        dependsOn: [],
-        touches: ['src/a.ts'],
-        run: ['echo ok'],
-        checks: [],
-        status: 'passed',
-        attempts: 1,
-        maxRetries: 1
-      }
-    ],
-    metadata: {
-      source: 'default',
-      generatedBy: 'test',
-      planVersion: 1
-    }
-  });
-
-  writeJson(getReportCardPath(repoRoot, 'REQ-123'), {
-    changeId: 'REQ-123',
-    verdict: 'pass',
-    overall: 'pass',
-    specSyncReady: false,
-    reroute: 'cc-do',
-    quickGates: [],
-    strictGates: [],
-    review: { status: 'pass', summary: 'review-ok', details: '' },
-    blockingFindings: [],
-    gaps: [],
-    timestamp: '2026-03-25T01:03:00.000Z',
-    ...reportOverrides
-  });
-}
-
-describe('runRelease', () => {
-  test('blocks reports that pass verification but are not ship ready', async () => {
-    const repoRoot = fs.mkdtempSync(path.join(os.tmpdir(), 'cc-devflow-release-readiness-'));
-    writeReleaseFixture(repoRoot);
-
-    await expect(runRelease({ repoRoot, changeId: 'REQ-123' })).rejects.toMatchObject({
-      name: 'ReleaseReadinessError',
-      rescueAction: 'run cc-check until ship-readiness is ready before release'
-    });
-
-    const runtimeState = JSON.parse(fs.readFileSync(getRuntimeStatePath(repoRoot, 'REQ-123'), 'utf8'));
-    expect(runtimeState.status).toBe('verified');
-    expect(fs.existsSync(getReleaseNotePath(repoRoot, 'REQ-123'))).toBe(false);
-  });
-});

package/lib/skill-runtime/__tests__/review-check-integration.test.js

@@ -1,148 +0,0 @@
-/**
- * [INPUT]: 依赖 runReviewSuite、临时 devflow review artifacts。
- * [OUTPUT]: 验证 cc-check review 读取 review-findings.json 优先并按 legacy 层级 fallback。
- * [POS]: REQ-003-minimize-workflow-artifacts T015 的 Red/Green 证据。
- * [PROTOCOL]: 变更时更新此头部，然后检查 CLAUDE.md
- */
-
-const fs = require('fs');
-const os = require('os');
-const path = require('path');
-
-const { runReviewSuite } = require('../review');
-
-function writeJson(filePath, value) {
-  fs.mkdirSync(path.dirname(filePath), { recursive: true });
-  fs.writeFileSync(filePath, `${JSON.stringify(value, null, 2)}\n`);
-}
-
-function writeText(filePath, value) {
-  fs.mkdirSync(path.dirname(filePath), { recursive: true });
-  fs.writeFileSync(filePath, value);
-}
-
-function makeReviewRoot(changeId, changeKey) {
-  const repoRoot = fs.mkdtempSync(path.join(os.tmpdir(), 'cc-devflow-review-check-'));
-  const reviewDir = path.join(repoRoot, 'devflow', 'changes', changeKey, 'review');
-  fs.mkdirSync(reviewDir, { recursive: true });
-  return { repoRoot, reviewDir, changeId, changeKey };
-}
-
-function findingsDoc(overrides = {}) {
-  return {
-    schema: 'review-findings.v2',
-    change: 'REQ-140-review-records',
-    reviewId: 'RVW-20260512-001',
-    headSha: 'def456',
-    freshness: {
-      status: 'fresh',
-      reviewedCommit: 'def456',
-      currentCommit: 'def456',
-      commitsSinceReview: 0
-    },
-    summary: {
-      status: 'findings',
-      blockingCount: 1,
-      warningCount: 0,
-      next: 'cc-do'
-    },
-    findings: [
-      {
-        id: 'F001',
-        severity: 'important',
-        confidence: 8,
-        displayTier: 'blocking',
-        fingerprint: 'sha256:f001',
-        scope: 'inside current requirement blast radius',
-        path: 'lib/skill-runtime/review.js',
-        evidence: 'review records should be consumed before legacy report text',
-        recommendation: 'read review-findings.json first',
-        route: 'cc-do'
-      }
-    ],
-    ...overrides
-  };
-}
-
-async function runReviewCase(files) {
-  const ctx = makeReviewRoot('REQ-140', 'REQ-140-review-records');
-  if (files.findings) {
-    writeJson(path.join(ctx.reviewDir, 'review-findings.json'), files.findings);
-  }
-  if (files.ledger) {
-    writeText(path.join(ctx.reviewDir, 'review-ledger.jsonl'), files.ledger);
-  }
-  if (files.legacyReport) {
-    writeText(path.join(ctx.reviewDir, 'cc-review-report.md'), files.legacyReport);
-  }
-
-  const review = await runReviewSuite({
-    repoRoot: ctx.repoRoot,
-    changeId: ctx.changeId,
-    manifest: { tasks: [] },
-    strict: false,
-    skipReview: true
-  });
-  fs.rmSync(ctx.repoRoot, { recursive: true, force: true });
-  return review;
-}
-
-describe('cc-check review record fallback', () => {
-  test('reads review-findings.json before ledger or legacy report', async () => {
-    const review = await runReviewCase({
-      findings: findingsDoc(),
-      ledger: '{"schema":"review-ledger.v2","change":"REQ-140-review-records","reviewId":"RVW-20260512-002","createdAt":"2026-05-12T00:00:00.000Z","createdBy":"cc-devflow-cli","event":"review-closed","status":"clean","blockingCount":0,"warningCount":0,"next":"cc-check"}\n',
-      legacyReport: '# Legacy Report\n'
-    });
-
-    expect(review.recordReview).toMatchObject({
-      source: 'review-findings.json',
-      status: 'fail',
-      freshness: { status: 'fresh' }
-    });
-    expect(review.findings[0]).toMatchObject({
-      id: 'F001',
-      source: 'review-records',
-      severity: 'important',
-      displayTier: 'blocking'
-    });
-  });
-
-  test('falls back to ledger tail when findings doc is missing', async () => {
-    const review = await runReviewCase({
-      ledger: [
-        '{"schema":"review-ledger.v2","change":"REQ-140-review-records","reviewId":"RVW-20260512-001","createdAt":"2026-05-12T00:00:00.000Z","createdBy":"cc-devflow-cli","event":"review-started","mode":"implementation","scope":"current-diff","baseSha":"abc123","headSha":"def456","selectedNodes":[],"skippedNodes":[],"riskLanes":[]}',
-        '{"schema":"review-ledger.v2","change":"REQ-140-review-records","reviewId":"RVW-20260512-001","createdAt":"2026-05-12T00:01:00.000Z","createdBy":"cc-devflow-cli","event":"review-closed","status":"clean","blockingCount":0,"warningCount":0,"next":"cc-check"}'
-      ].join('\n')
-    });
-
-    expect(review.recordReview).toMatchObject({
-      source: 'review-ledger.jsonl',
-      status: 'pass',
-      summary: expect.stringContaining('review ledger')
-    });
-  });
-
-  test('falls back to legacy cc-review-report.md with unknown freshness', async () => {
-    const review = await runReviewCase({
-      legacyReport: '# Legacy Review\n\nNo blocking findings.\n'
-    });
-
-    expect(review.recordReview).toMatchObject({
-      source: 'cc-review-report.md',
-      status: 'pass',
-      freshness: { status: 'unknown' }
-    });
-  });
-
-  test('blocks when all review records are missing', async () => {
-    const review = await runReviewCase({});
-
-    expect(review.status).toBe('blocked');
-    expect(review.recordReview).toMatchObject({
-      source: 'review-records',
-      status: 'blocked',
-      summary: expect.stringContaining('review-missing')
-    });
-  });
-});