cc-devflow 4.5.10 → 4.5.12

package/lib/skill-runtime/__tests__/runtime.integration.test.js

@@ -1,351 +0,0 @@
-/**
- * [INPUT]: 依赖 skill runtime operations 与临时仓库夹具。
- * [OUTPUT]: 验证 plan/do/check/act 共享运行时主链最小可运行性。
- * [POS]: lib/skill-runtime/__tests__ 的集成测试入口，保障 skill-first 内核回归。
- * [PROTOCOL]: 变更时更新此头部，然后检查 CLAUDE.md
- */
-
-const fs = require('fs');
-const os = require('os');
-const path = require('path');
-const { spawnSync } = require('child_process');
-
-const REPO_ROOT = path.resolve(__dirname, '../../..');
-
-const { runInit } = require('../operations/init');
-const { runPlanningSnapshot } = require('../operations/snapshot');
-const { runPlan } = require('../operations/plan');
-const { runApprove } = require('../operations/approve');
-const { runDispatch } = require('../operations/dispatch');
-const { runVerify } = require('../operations/verify');
-const { runRelease } = require('../operations/release');
-const {
-  getTaskManifestPath,
-  getReportCardPath,
-  getReleaseNotePath,
-  getTasksMarkdownPath,
-  readJson,
-  readText
-} = require('../store');
-const { getChangePaths } = require('../paths');
-
-const WRITE_TASK_CHECKPOINT = path.join(
-  REPO_ROOT,
-  '.claude/skills/cc-do/scripts/write-task-checkpoint.sh'
-);
-const RECORD_REVIEW_DECISION = path.join(
-  REPO_ROOT,
-  '.claude/skills/cc-do/scripts/record-review-decision.sh'
-);
-const VERIFY_TASK_GATES = path.join(
-  REPO_ROOT,
-  '.claude/skills/cc-do/scripts/verify-task-gates.sh'
-);
-const MARK_TASK_COMPLETE = path.join(
-  REPO_ROOT,
-  '.claude/skills/cc-do/scripts/mark-task-complete.sh'
-);
-
-jest.setTimeout(20000);
-
-describe('Skill runtime', () => {
-  let repoRoot;
-
-  beforeEach(() => {
-    repoRoot = fs.mkdtempSync(path.join(os.tmpdir(), 'skill-runtime-'));
-
-    fs.writeFileSync(
-      path.join(repoRoot, 'package.json'),
-      JSON.stringify(
-        {
-          name: 'tmp-repo',
-          version: '0.0.0',
-          scripts: {
-            lint: 'node -e "process.exit(0)"',
-            typecheck: 'node -e "process.exit(0)"',
-            test: 'node -e "process.exit(0)"'
-          }
-        },
-        null,
-        2
-      )
-    );
-
-    fs.mkdirSync(path.join(repoRoot, '.git'));
-  });
-
-  afterEach(() => {
-    fs.rmSync(repoRoot, { recursive: true, force: true });
-  });
-
-  async function markManifestReviews(changeId, verdict = 'pass') {
-    const manifestPath = getTaskManifestPath(repoRoot, changeId);
-    const manifest = await readJson(manifestPath);
-    manifest.tasks = manifest.tasks.map((task) => ({
-      ...task,
-      reviews: {
-        spec: verdict,
-        code: verdict
-      }
-    }));
-    fs.writeFileSync(manifestPath, `${JSON.stringify(manifest, null, 2)}\n`);
-  }
-
-  async function markManifestSpec(changeId) {
-    const manifestPath = getTaskManifestPath(repoRoot, changeId);
-    const manifest = await readJson(manifestPath);
-    manifest.spec = {
-      primaryCapability: 'skill-runtime-pipeline',
-      specFiles: ['devflow/specs/skill-runtime.md']
-    };
-    fs.writeFileSync(manifestPath, `${JSON.stringify(manifest, null, 2)}\n`);
-  }
-
-  function writeCleanReviewLedger(changeId) {
-    const change = getChangePaths(repoRoot, changeId);
-    const ledgerPath = path.join(change.reviewDir, 'review-ledger.jsonl');
-    fs.mkdirSync(path.dirname(ledgerPath), { recursive: true });
-    fs.writeFileSync(ledgerPath, [
-      JSON.stringify({
-        schema: 'review-ledger.v2',
-        change: change.changeKey,
-        reviewId: 'RVW-20260512-001',
-        createdAt: '2026-05-12T00:00:00.000Z',
-        createdBy: 'cc-devflow-cli',
-        event: 'review-started',
-        mode: 'implementation',
-        scope: 'current-diff',
-        baseSha: 'abc123',
-        headSha: 'def456',
-        selectedNodes: [],
-        skippedNodes: [],
-        riskLanes: []
-      }),
-      JSON.stringify({
-        schema: 'review-ledger.v2',
-        change: change.changeKey,
-        reviewId: 'RVW-20260512-001',
-        createdAt: '2026-05-12T00:01:00.000Z',
-        createdBy: 'cc-devflow-cli',
-        event: 'review-closed',
-        status: 'clean',
-        blockingCount: 0,
-        warningCount: 0,
-        next: 'cc-check'
-      })
-    ].join('\n'));
-  }
-
-  test('runs init -> snapshot -> plan -> dispatch -> verify -> release', async () => {
-    const changeId = 'REQ-999';
-    await runInit({ repoRoot, changeId, goal: 'Test skill runtime pipeline' });
-
-    fs.writeFileSync(
-      getTasksMarkdownPath(repoRoot, changeId),
-      [
-        '- [ ] T001 create scaffolding (src/a.ts)',
-        '- [ ] T002 [P] add docs (docs/readme.md)',
-        '- [ ] T003 finalize dependsOn:T001,T002 (src/b.ts)'
-      ].join('\n')
-    );
-
-    await runPlanningSnapshot({ repoRoot, changeId });
-
-    const planResult = await runPlan({ repoRoot, changeId, overwrite: true });
-    expect(planResult.taskCount).toBe(3);
-    await runApprove({ repoRoot, changeId, executionMode: 'direct' });
-
-    const dispatchResult = await runDispatch({
-      repoRoot,
-      changeId,
-      parallel: 2,
-      maxRetries: 0
-    });
-    expect(dispatchResult.success).toBe(true);
-
-    const manifest = await readJson(getTaskManifestPath(repoRoot, changeId));
-    expect(manifest.tasks.every((task) => task.status === 'passed')).toBe(true);
-
-    await markManifestSpec(changeId);
-    await markManifestReviews(changeId, 'pass');
-    writeCleanReviewLedger(changeId);
-
-    const verifyResult = await runVerify({
-      repoRoot,
-      changeId,
-      strict: false,
-      skipReview: true
-    });
-    expect(verifyResult.overall).toBe('pass');
-
-    const report = await readJson(getReportCardPath(repoRoot, changeId));
-    expect(report.overall).toBe('pass');
-    const requirementsMet = report.claimEvidence.find((claim) => claim.claim === 'requirements-met');
-    expect(requirementsMet).toMatchObject({
-      status: 'pass',
-      keyObservation: 'no open task gaps recorded'
-    });
-
-    const releaseResult = await runRelease({ repoRoot, changeId });
-    expect(releaseResult.status).toBe('released');
-
-    const releaseNote = await readText(getReleaseNotePath(repoRoot, changeId));
-    expect(releaseNote).toContain('Release Note - REQ-999');
-  });
-
-  test('blocks verify when passed tasks are missing native review proof', async () => {
-    const changeId = 'REQ-1000';
-    await runInit({ repoRoot, changeId, goal: 'Require task review proof' });
-
-    fs.writeFileSync(
-      getTasksMarkdownPath(repoRoot, changeId),
-      [
-        '- [ ] T001 [TEST] Counter behavior (src/a.test.ts)',
-        '- [ ] T002 [IMPL] Counter behavior dependsOn:T001 (src/a.ts)'
-      ].join('\n')
-    );
-
-    await runPlanningSnapshot({ repoRoot, changeId });
-    await runPlan({ repoRoot, changeId, overwrite: true });
-    await runApprove({ repoRoot, changeId, executionMode: 'direct' });
-    await runDispatch({ repoRoot, changeId, parallel: 1, maxRetries: 0 });
-
-    const verifyResult = await runVerify({
-      repoRoot,
-      changeId,
-      strict: false,
-      skipReview: true
-    });
-
-    expect(verifyResult.overall).toBe('fail');
-
-    const report = await readJson(getReportCardPath(repoRoot, changeId));
-    expect(report.review.status).toBe('blocked');
-    expect(report.blockingFindings.some((item) => item.includes('missing spec review proof'))).toBe(true);
-  });
-
-  test('cc-do shell helpers keep task truth in manifest and do not write process files by default', async () => {
-    const changeId = 'REQ-2001';
-    await runInit({ repoRoot, changeId, goal: 'Verify shell helper layout' });
-
-    const change = getChangePaths(repoRoot, changeId, { goal: 'Verify shell helper layout' });
-    const manifestPath = getTaskManifestPath(repoRoot, changeId, { goal: 'Verify shell helper layout' });
-    fs.writeFileSync(
-      manifestPath,
-      `${JSON.stringify(
-        {
-          changeId,
-          tasks: [
-            {
-              id: 'T001',
-              title: 'Verify helper layout',
-              reviews: { spec: 'pending', code: 'pending' }
-            }
-          ]
-        },
-        null,
-        2
-      )}\n`
-    );
-
-    const legacyCheckpoint = spawnSync(WRITE_TASK_CHECKPOINT, [
-      '--dir',
-      change.changeDir,
-      '--task',
-      'T001',
-      '--status',
-      'passed',
-      '--summary',
-      'task finished'
-    ], { encoding: 'utf8' });
-    expect(legacyCheckpoint.status).toBe(0);
-
-    const specReview = spawnSync(RECORD_REVIEW_DECISION, [
-      '--dir',
-      change.changeDir,
-      '--task',
-      'T001',
-      '--gate',
-      'spec',
-      '--verdict',
-      'pass',
-      '--summary',
-      'spec ok'
-    ], { encoding: 'utf8' });
-    expect(specReview.status).toBe(0);
-
-    const codeReview = spawnSync(RECORD_REVIEW_DECISION, [
-      '--dir',
-      change.changeDir,
-      '--task',
-      'T001',
-      '--gate',
-      'code',
-      '--verdict',
-      'pass',
-      '--summary',
-      'code ok'
-    ], { encoding: 'utf8' });
-    expect(codeReview.status).toBe(0);
-
-    const verify = spawnSync(VERIFY_TASK_GATES, [
-      '--dir',
-      change.changeDir,
-      '--task',
-      'T001'
-    ], { encoding: 'utf8' });
-    expect(verify.status).toBe(0);
-
-    const complete = spawnSync(MARK_TASK_COMPLETE, [
-      '--manifest',
-      manifestPath,
-      '--task',
-      'T001'
-    ], { encoding: 'utf8' });
-    expect(complete.status).toBe(0);
-
-    const manifest = JSON.parse(fs.readFileSync(manifestPath, 'utf8'));
-    expect(manifest.currentTaskId).toBeNull();
-    expect(manifest.tasks[0]).toMatchObject({
-      id: 'T001',
-      status: 'passed',
-      reviews: { spec: 'pass', code: 'pass' }
-    });
-
-    expect(fs.existsSync(path.join(change.tasksDir, 'T001', 'checkpoint.json'))).toBe(false);
-    expect(fs.existsSync(path.join(change.tasksDir, 'T001', 'context.md'))).toBe(false);
-    expect(fs.existsSync(path.join(change.tasksDir, 'T001', 'events.jsonl'))).toBe(false);
-    expect(fs.existsSync(path.join(repoRoot, '.harness', 'runtime', changeId))).toBe(false);
-    expect(fs.existsSync(path.join(change.tasksDir, 'T001', 'checkpoint.md'))).toBe(false);
-    expect(fs.existsSync(path.join(change.tasksDir, 'T001', 'review-spec.md'))).toBe(false);
-    expect(fs.existsSync(path.join(change.tasksDir, 'T001', 'review-code.md'))).toBe(false);
-  });
-
-  test('mark-task-complete updates only the first matching task line on Darwin-compatible userlands', () => {
-    const tasksPath = path.join(repoRoot, 'tasks.md');
-    fs.writeFileSync(
-      tasksPath,
-      [
-        '- [ ] **T001** first task',
-        '- [ ] T001 second task',
-        '- [ ] T002 untouched'
-      ].join('\n')
-    );
-
-    const result = spawnSync(MARK_TASK_COMPLETE, [
-      '--tasks',
-      tasksPath,
-      '--task',
-      'T001'
-    ], { encoding: 'utf8' });
-
-    expect(result.status).toBe(0);
-    expect(fs.readFileSync(tasksPath, 'utf8').trimEnd()).toBe(
-      [
-        '- [x] **T001** first task',
-        '- [ ] T001 second task',
-        '- [ ] T002 untouched'
-      ].join('\n')
-    );
-  });
-});

package/lib/skill-runtime/__tests__/schemas.test.js

@@ -1,337 +0,0 @@
-const { parseManifest } = require('../schemas');
-
-describe('Manifest schema hard constraints', () => {
-  test('accepts a tasks.md manifest with review and context metadata', () => {
-    const manifest = parseManifest({
-      changeId: 'REQ-555',
-      goal: 'Validate schema contract',
-      createdAt: '2026-04-10T01:00:00.000Z',
-      updatedAt: '2026-04-10T01:05:00.000Z',
-      currentTaskId: 'T001',
-      tasks: [
-        {
-          id: 'T001',
-          title: '[TEST] Counter behavior',
-          type: 'TEST',
-          phase: 1,
-          parallel: false,
-          dependsOn: [],
-          touches: ['src/counter.test.ts'],
-          files: ['src/counter.test.ts'],
-          run: ['echo "[TASK T001] Counter behavior"'],
-          checks: ['npm test -- src/counter.test.ts'],
-          acceptance: ['Prove counter behavior fails first'],
-          verification: ['npm test -- src/counter.test.ts'],
-          evidence: ['failing test output'],
-          context: {
-            readFiles: ['design.md', 'tasks.md'],
-            commands: ['npm test -- src/counter.test.ts'],
-            notes: ['Start from red']
-          },
-          reviews: {
-            spec: 'pending',
-            code: 'pending'
-          },
-          status: 'pending',
-          attempts: 0,
-          maxRetries: 1
-        },
-        {
-          id: 'T002',
-          title: '[IMPL] Counter behavior',
-          type: 'IMPL',
-          phase: 1,
-          parallel: false,
-          dependsOn: ['T001'],
-          touches: ['src/counter.ts'],
-          files: ['src/counter.ts'],
-          run: ['echo "[TASK T002] Counter behavior"'],
-          checks: ['npm test -- src/counter.test.ts'],
-          acceptance: ['Make counter behavior pass'],
-          verification: ['npm test -- src/counter.test.ts'],
-          evidence: ['passing test output'],
-          context: {
-            readFiles: ['design.md', 'src/counter.test.ts'],
-            commands: ['npm test -- src/counter.test.ts'],
-            notes: ['Smallest green implementation']
-          },
-          reviews: {
-            spec: 'pending',
-            code: 'pending'
-          },
-          status: 'pending',
-          attempts: 0,
-          maxRetries: 1
-        }
-      ],
-      metadata: {
-        source: 'tasks.md',
-        generatedBy: 'test',
-        planVersion: 1
-      }
-    });
-
-    expect(manifest.currentTaskId).toBe('T001');
-    expect(manifest.activePhase).toBeUndefined();
-  });
-
-  test('accepts legacy activePhase input without preserving the retired field', () => {
-    const manifest = parseManifest({
-      changeId: 'REQ-560',
-      goal: 'Validate legacy manifest compatibility',
-      createdAt: '2026-04-10T01:00:00.000Z',
-      updatedAt: '2026-04-10T01:05:00.000Z',
-      currentTaskId: 'T001',
-      activePhase: 1,
-      tasks: [
-        {
-          id: 'T001',
-          title: '[TEST] Counter behavior',
-          type: 'OTHER',
-          phase: 1,
-          dependsOn: [],
-          run: ['echo ok'],
-          status: 'pending',
-          attempts: 0,
-          maxRetries: 1
-        }
-      ],
-      metadata: {
-        source: 'default',
-        generatedBy: 'test',
-        planVersion: 1
-      }
-    });
-
-    expect(manifest.currentTaskId).toBe('T001');
-    expect(manifest.activePhase).toBeUndefined();
-  });
-
-  test('rejects invalid currentTaskId for tasks.md manifest', () => {
-    expect(() => parseManifest({
-      changeId: 'REQ-556',
-      goal: 'Reject invalid current task',
-      createdAt: '2026-04-10T01:00:00.000Z',
-      updatedAt: '2026-04-10T01:05:00.000Z',
-      currentTaskId: 'T999',
-      activePhase: 1,
-      tasks: [
-        {
-          id: 'T001',
-          title: '[TEST] Counter behavior',
-          type: 'TEST',
-          phase: 1,
-          dependsOn: [],
-          run: ['echo ok'],
-          checks: ['npm test -- src/counter.test.ts'],
-          acceptance: ['Prove failure'],
-          verification: ['npm test -- src/counter.test.ts'],
-          evidence: ['failing test output'],
-          context: {
-            readFiles: ['design.md'],
-            commands: ['npm test -- src/counter.test.ts'],
-            notes: []
-          },
-          reviews: {
-            spec: 'pending',
-            code: 'pending'
-          },
-          status: 'pending',
-          attempts: 0,
-          maxRetries: 1
-        }
-      ],
-      metadata: {
-        source: 'tasks.md',
-        generatedBy: 'test',
-        planVersion: 1
-      }
-    })).toThrow(/currentTaskId T999 is not present/);
-  });
-
-  test('accepts FIX ids and rejects legacy BUG ids', () => {
-    const baseManifest = {
-      goal: 'Validate fix id',
-      createdAt: '2026-04-10T01:00:00.000Z',
-      updatedAt: '2026-04-10T01:05:00.000Z',
-      currentTaskId: 'T001',
-      activePhase: 1,
-      tasks: [
-        {
-          id: 'T001',
-          title: 'Bootstrap fix',
-          type: 'OTHER',
-          phase: 1,
-          dependsOn: [],
-          run: ['echo ok'],
-          status: 'pending',
-          attempts: 0,
-          maxRetries: 1
-        }
-      ],
-      metadata: {
-        source: 'default',
-        generatedBy: 'test',
-        planVersion: 1
-      }
-    };
-
-    expect(parseManifest({ ...baseManifest, changeId: 'FIX-556' }).changeId).toBe('FIX-556');
-    expect(() => parseManifest({ ...baseManifest, changeId: 'BUG-556' })).toThrow(/Invalid changeId format/);
-  });
-
-  test('accepts current full change keys and review/verification task types', () => {
-    const manifest = parseManifest({
-      changeId: 'REQ-001-personal-output-config',
-      goal: 'Validate current manifest shape',
-      createdAt: '2026-04-10T01:00:00.000Z',
-      updatedAt: '2026-04-10T01:05:00.000Z',
-      currentTaskId: 'T007',
-      tasks: [
-        {
-          id: 'T007',
-          title: '[REFACTOR] Apply review fixes',
-          type: 'REFACTOR',
-          phase: 4,
-          dependsOn: [],
-          run: ['echo ok'],
-          status: 'pending',
-          attempts: 0,
-          maxRetries: 1
-        },
-        {
-          id: 'T008',
-          title: '[VERIFY] Run full gates',
-          type: 'VERIFY',
-          phase: 4,
-          dependsOn: ['T007'],
-          run: ['npm test'],
-          status: 'pending',
-          attempts: 0,
-          maxRetries: 1
-        }
-      ],
-      metadata: {
-        source: 'planning/tasks.md',
-        generatedBy: 'cc-plan',
-        planVersion: 1
-      }
-    });
-
-    expect(manifest.changeId).toBe('REQ-001-personal-output-config');
-    expect(manifest.tasks.map((task) => task.type)).toEqual(['REFACTOR', 'VERIFY']);
-    expect(manifest.metadata.source).toBe('planning/tasks.md');
-  });
-
-  test('rejects conflicting parallel tasks that share touches in same phase', () => {
-    expect(() => parseManifest({
-      changeId: 'REQ-557',
-      goal: 'Reject bad parallel plan',
-      createdAt: '2026-04-10T01:00:00.000Z',
-      updatedAt: '2026-04-10T01:05:00.000Z',
-      currentTaskId: 'T001',
-      activePhase: 1,
-      tasks: [
-        {
-          id: 'T001',
-          title: '[TEST] A',
-          type: 'TEST',
-          phase: 1,
-          parallel: true,
-          dependsOn: [],
-          touches: ['src/shared.ts'],
-          run: ['echo ok'],
-          checks: ['npm test -- a'],
-          acceptance: ['Prove A fails'],
-          verification: ['npm test -- a'],
-          evidence: ['failing output'],
-          context: { readFiles: ['design.md'], commands: ['npm test -- a'], notes: [] },
-          reviews: { spec: 'pending', code: 'pending' },
-          status: 'pending',
-          attempts: 0,
-          maxRetries: 1
-        },
-        {
-          id: 'T002',
-          title: '[TEST] B',
-          type: 'TEST',
-          phase: 1,
-          parallel: true,
-          dependsOn: [],
-          touches: ['src/shared.ts'],
-          run: ['echo ok'],
-          checks: ['npm test -- b'],
-          acceptance: ['Prove B fails'],
-          verification: ['npm test -- b'],
-          evidence: ['failing output'],
-          context: { readFiles: ['design.md'], commands: ['npm test -- b'], notes: [] },
-          reviews: { spec: 'pending', code: 'pending' },
-          status: 'pending',
-          attempts: 0,
-          maxRetries: 1
-        }
-      ],
-      metadata: {
-        source: 'tasks.md',
-        generatedBy: 'test',
-        planVersion: 1
-      }
-    })).toThrow(/share touches/);
-  });
-
-  test('rejects conflicting parallel tasks with nested touches in same phase', () => {
-    expect(() => parseManifest({
-      changeId: 'REQ-558',
-      goal: 'Reject nested parallel plan',
-      createdAt: '2026-04-10T01:00:00.000Z',
-      updatedAt: '2026-04-10T01:05:00.000Z',
-      currentTaskId: 'T001',
-      activePhase: 1,
-      tasks: [
-        {
-          id: 'T001',
-          title: '[TEST] A',
-          type: 'TEST',
-          phase: 1,
-          parallel: true,
-          dependsOn: [],
-          touches: ['packages/billing'],
-          run: ['echo ok'],
-          checks: ['npm test -- a'],
-          acceptance: ['Prove A fails'],
-          verification: ['npm test -- a'],
-          evidence: ['failing output'],
-          context: { readFiles: ['design.md'], commands: ['npm test -- a'], notes: [] },
-          reviews: { spec: 'pending', code: 'pending' },
-          status: 'pending',
-          attempts: 0,
-          maxRetries: 1
-        },
-        {
-          id: 'T002',
-          title: '[TEST] B',
-          type: 'TEST',
-          phase: 1,
-          parallel: true,
-          dependsOn: [],
-          touches: ['packages/billing/src/invoices.js'],
-          run: ['echo ok'],
-          checks: ['npm test -- b'],
-          acceptance: ['Prove B fails'],
-          verification: ['npm test -- b'],
-          evidence: ['failing output'],
-          context: { readFiles: ['design.md'], commands: ['npm test -- b'], notes: [] },
-          reviews: { spec: 'pending', code: 'pending' },
-          status: 'pending',
-          attempts: 0,
-          maxRetries: 1
-        }
-      ],
-      metadata: {
-        source: 'tasks.md',
-        generatedBy: 'test',
-        planVersion: 1
-      }
-    })).toThrow(/share touches: packages\/billing/);
-  });
-});