cc-dev-template 0.1.81 → 0.1.82

package/src/skills/task-review/references/checklist.md

@@ -1,153 +0,0 @@
-# Task Review Checklist
-
-Evaluate each area. Fix every issue you find by editing the task files directly. Note what you found and fixed:
-- **Critical**: Must fix — fix immediately
-- **Warning**: Should fix — fix now
-- **Note**: Minor suggestion — fix if straightforward
-
-## 1. Coverage
-
-Compare acceptance criteria in the spec to tasks generated.
-
-**Check:**
-- [ ] Every acceptance criterion has exactly one corresponding task
-- [ ] No criteria were skipped or forgotten
-- [ ] No phantom tasks that don't map to a criterion
-
-**How to verify:**
-List each criterion from the spec's Acceptance Criteria section. For each, find the matching task file. Flag any orphans in either direction.
-
-## 2. Dependency Order
-
-Tasks should be sequenced so each can be completed without waiting on later tasks.
-
-**Check:**
-- [ ] Task file names sort in valid execution order (T001, T002, etc.)
-- [ ] Each task's `depends_on` references only earlier tasks
-- [ ] No circular dependencies
-- [ ] Foundation work comes before features that use it
-
-**Common issues:**
-- API route task before the service it calls
-- UI component before the API it fetches from
-- Test file before the code it tests (tests should be in same task as code)
-
-## 3. File Plausibility
-
-Files listed in each task should make sense for the project.
-
-**Check:**
-- [ ] File paths follow project conventions (use Explorer if unsure)
-- [ ] Files to modify actually exist in the codebase
-- [ ] Files to create are in appropriate directories
-- [ ] No duplicate files across tasks (each file appears in exactly one task)
-
-**How to verify:**
-For files to modify, confirm they exist. For files to create, confirm the parent directory exists and the naming follows conventions.
-
-## 4. Verification Executability
-
-Each task's verification method must be concrete and runnable.
-
-**Check:**
-- [ ] Verification is a specific command or script, not vague prose
-- [ ] Test file paths exist or will be created by the task
-- [ ] agent-browser commands reference real routes/elements
-- [ ] No "manually verify" without clear steps
-
-**Red flags:**
-- "Verify it works correctly"
-- "Check that the feature functions"
-- Test commands for files not listed in the task
-
-## 5. Verification Completeness
-
-Each task's verification must test ALL behaviors mentioned in its criterion.
-
-**Check:**
-- [ ] Read the criterion text carefully - identify every distinct behavior or edge case mentioned
-- [ ] For each behavior, confirm there's a corresponding verification step
-- [ ] Flag any behaviors in the criterion that have no verification
-
-**How to verify:**
-For each task, extract bullet points from the criterion. For each bullet, find the matching verification step. If a behavior is mentioned but not tested, that's a Critical issue.
-
-**Common gaps:**
-- Criterion mentions "X persists across refresh" but verification doesn't test refresh
-- Criterion mentions "handles edge case Y" but verification only tests happy path
-- Criterion mentions animation/timing but verification can't test it (should note "Manual test required")
-
-## 6. Dependency Completeness
-
-Dependencies must be complete, not just valid.
-
-**Check:**
-- [ ] If task X modifies a file, check if another task creates it - that task must be in X's depends_on
-- [ ] If task X uses a component/function/route, check if another task creates it - that task must be in X's depends_on
-- [ ] If task X requires context from task Y (e.g., branding, layout, shared state), Y must be in X's depends_on
-
-**How to verify:**
-For each task, look at its Files section. For each "modify" entry, search other tasks for where that file is created. If found, verify the creating task is in depends_on. Also check the criterion for implicit dependencies (e.g., "shows branding" implies depending on the branding task).
-
-**Common gaps:**
-- Task uses a layout but doesn't depend on the task that configures the layout
-- Task modifies shared state but doesn't depend on the task that creates the context
-- Task assumes a feature exists but the feature is created by a later task
-
-## 7. Task Scope
-
-Each task should be appropriately sized for the coder→QA loop.
-
-**Check:**
-- [ ] No task touches more than ~10 files (consider splitting)
-- [ ] No trivially small tasks that could merge with related work
-- [ ] Each task produces a verifiable outcome, not just "creates a file"
-
-## 8. Consistency
-
-Cross-check task files against each other and the spec.
-
-**Check:**
-- [ ] Task titles match or closely reflect the acceptance criterion
-- [ ] Status is `pending` for all new tasks
-- [ ] Frontmatter format is consistent across all task files
-- [ ] Implementation Notes and Review Notes sections exist (empty is fine)
-
-## 9. Component Consolidation
-
-Scan for tasks that create structurally similar files.
-
-**Check:**
-- [ ] No two tasks create components with similar names, purposes, or overlapping structure
-- [ ] Shared patterns (cards, forms, list items, layout sections) use a single shared component with configuration, not separate implementations
-- [ ] Utility functions or services with similar logic are consolidated
-
-**How to verify:**
-Compare files-to-create across all tasks. Group by similarity (naming patterns, structural role, data shape). When two or more tasks create similar files, flag for consolidation.
-
-**Common issues:**
-- Three "card" components for different pages that differ only by displayed fields
-- Two form components with nearly identical validation and submission logic
-- Repeated layout patterns that could be a shared template with slots/children
-
----
-
-## Review and Fix Loop
-
-Run the checklist above against all task files. Fix every issue you find by editing the task files directly. Then re-run the full checklist from the top. Repeat until no issues remain.
-
-## Output Format
-
-After all issues are fixed, report what you found and fixed:
-
-```
-## Review Summary
-- [T002] Fixed: reordered dependency — was depending on T005 which came later
-- [T003] Fixed: added concrete verification command (was missing)
-- [T001] Fixed: split into T001a/T001b — was touching 12 files
-
-## Skill Observations (optional)
-If any checklist items or review patterns in this skill were wrong or misleading, note them here.
-```
-
-If no issues found, state: "Task breakdown looks good. All criteria covered, dependencies valid, verification methods concrete."