cc-context-stats 1.5.0 → 1.6.0

package/tests/python/test_state_rotation_validation.py

@@ -0,0 +1,232 @@
+"""Tests for state file rotation and session ID validation."""
+
+import re
+import subprocess
+import sys
+
+import pytest
+
+from claude_statusline.core.state import StateFile, _validate_session_id
+
+
+# ---------------------------------------------------------------------------
+# Helpers
+# ---------------------------------------------------------------------------
+
+
+def _make_csv_line(index: int) -> str:
+    """Generate a deterministic CSV state line for a given index."""
+    return (
+        f"{1710288000 + index},100,200,300,400,500,600,0.01,"
+        f"10,5,sess-{index},model,/tmp/proj,200000"
+    )
+
+
+# ---------------------------------------------------------------------------
+# State File Rotation
+# ---------------------------------------------------------------------------
+
+
+class TestStateFileRotation:
+    """Tests for _maybe_rotate() in StateFile."""
+
+    def test_below_threshold_no_rotation(self, tmp_path, monkeypatch):
+        """File with fewer than 10,000 lines is not rotated."""
+        monkeypatch.setattr(StateFile, "STATE_DIR", tmp_path)
+        monkeypatch.setattr(StateFile, "OLD_STATE_DIR", tmp_path / "old")
+        (tmp_path / "old").mkdir()
+
+        sf = StateFile("test-session")
+        # Write 9,999 lines
+        lines = [_make_csv_line(i) + "\n" for i in range(9_999)]
+        sf.file_path.write_text("".join(lines))
+
+        sf._maybe_rotate()
+
+        result_lines = sf.file_path.read_text().splitlines()
+        assert len(result_lines) == 9_999
+
+    def test_at_threshold_no_rotation(self, tmp_path, monkeypatch):
+        """File with exactly 10,000 lines is not rotated."""
+        monkeypatch.setattr(StateFile, "STATE_DIR", tmp_path)
+        monkeypatch.setattr(StateFile, "OLD_STATE_DIR", tmp_path / "old")
+        (tmp_path / "old").mkdir()
+
+        sf = StateFile("test-session")
+        lines = [_make_csv_line(i) + "\n" for i in range(10_000)]
+        sf.file_path.write_text("".join(lines))
+
+        sf._maybe_rotate()
+
+        result_lines = sf.file_path.read_text().splitlines()
+        assert len(result_lines) == 10_000
+
+    def test_exceeds_threshold_truncates_to_5000(self, tmp_path, monkeypatch):
+        """File with 10,001 lines is truncated to 5,000."""
+        monkeypatch.setattr(StateFile, "STATE_DIR", tmp_path)
+        monkeypatch.setattr(StateFile, "OLD_STATE_DIR", tmp_path / "old")
+        (tmp_path / "old").mkdir()
+
+        sf = StateFile("test-session")
+        lines = [_make_csv_line(i) + "\n" for i in range(10_001)]
+        sf.file_path.write_text("".join(lines))
+
+        sf._maybe_rotate()
+
+        result_lines = sf.file_path.read_text().splitlines()
+        assert len(result_lines) == 5_000
+
+    def test_retained_lines_are_most_recent(self, tmp_path, monkeypatch):
+        """After rotation, the retained lines are the last 5,000 of the original."""
+        monkeypatch.setattr(StateFile, "STATE_DIR", tmp_path)
+        monkeypatch.setattr(StateFile, "OLD_STATE_DIR", tmp_path / "old")
+        (tmp_path / "old").mkdir()
+
+        sf = StateFile("test-session")
+        total = 10_001
+        lines = [_make_csv_line(i) + "\n" for i in range(total)]
+        sf.file_path.write_text("".join(lines))
+
+        sf._maybe_rotate()
+
+        result_lines = sf.file_path.read_text().splitlines()
+        # First retained line should be the one at index (total - 5000) = 5001
+        assert f"sess-{total - 5000}" in result_lines[0]
+        # Last retained line should be the last original line
+        assert f"sess-{total - 1}" in result_lines[-1]
+
+    def test_rotation_via_append_entry(self, tmp_path, monkeypatch):
+        """append_entry triggers rotation when threshold is exceeded."""
+        monkeypatch.setattr(StateFile, "STATE_DIR", tmp_path)
+        monkeypatch.setattr(StateFile, "OLD_STATE_DIR", tmp_path / "old")
+        (tmp_path / "old").mkdir()
+
+        sf = StateFile("test-session")
+        # Write exactly 10,000 lines (at threshold, no rotation yet)
+        lines = [_make_csv_line(i) + "\n" for i in range(10_000)]
+        sf.file_path.write_text("".join(lines))
+
+        # Import StateEntry to create a valid entry
+        from claude_statusline.core.state import StateEntry
+
+        entry = StateEntry(
+            timestamp=1710298000,
+            total_input_tokens=100,
+            total_output_tokens=200,
+            current_input_tokens=300,
+            current_output_tokens=400,
+            cache_creation=500,
+            cache_read=600,
+            cost_usd=0.01,
+            lines_added=10,
+            lines_removed=5,
+            session_id="test-session",
+            model_id="model",
+            workspace_project_dir="/tmp/proj",
+            context_window_size=200000,
+        )
+        sf.append_entry(entry)
+
+        # Now file had 10,001 lines -> should have been rotated to 5,000
+        result_lines = sf.file_path.read_text().splitlines()
+        assert len(result_lines) == 5_000
+
+    def test_no_temp_files_left_after_rotation(self, tmp_path, monkeypatch):
+        """No .tmp files remain after successful rotation."""
+        monkeypatch.setattr(StateFile, "STATE_DIR", tmp_path)
+        monkeypatch.setattr(StateFile, "OLD_STATE_DIR", tmp_path / "old")
+        (tmp_path / "old").mkdir()
+
+        sf = StateFile("test-session")
+        lines = [_make_csv_line(i) + "\n" for i in range(10_001)]
+        sf.file_path.write_text("".join(lines))
+
+        sf._maybe_rotate()
+
+        tmp_files = list(tmp_path.glob("*.tmp"))
+        assert tmp_files == []
+
+
+# ---------------------------------------------------------------------------
+# Session ID Validation
+# ---------------------------------------------------------------------------
+
+
+class TestSessionIdValidation:
+    """Tests for _validate_session_id and StateFile constructor validation."""
+
+    def test_reject_forward_slash(self):
+        with pytest.raises(ValueError, match="/"):
+            _validate_session_id("../../etc/passwd")
+
+    def test_reject_backslash(self):
+        with pytest.raises(ValueError, match=re.escape("\\")):
+            _validate_session_id("..\\..\\etc\\passwd")
+
+    def test_reject_dot_dot(self):
+        with pytest.raises(ValueError, match=r"\.\."):
+            _validate_session_id("..hidden")
+
+    def test_reject_null_byte(self):
+        with pytest.raises(ValueError):
+            _validate_session_id("session\0id")
+
+    def test_accept_valid_uuid(self):
+        _validate_session_id("abc-123-def-456")  # Should not raise
+
+    def test_accept_hyphens_underscores(self):
+        _validate_session_id("my_session-id_123")  # Should not raise
+
+    def test_accept_alphanumeric(self):
+        _validate_session_id("abcdef1234567890")  # Should not raise
+
+    def test_statefile_rejects_invalid_session(self, tmp_path, monkeypatch):
+        monkeypatch.setattr(StateFile, "STATE_DIR", tmp_path)
+        monkeypatch.setattr(StateFile, "OLD_STATE_DIR", tmp_path / "old")
+        (tmp_path / "old").mkdir()
+
+        with pytest.raises(ValueError):
+            StateFile("../../etc/passwd")
+
+    def test_statefile_accepts_none_session(self, tmp_path, monkeypatch):
+        monkeypatch.setattr(StateFile, "STATE_DIR", tmp_path)
+        monkeypatch.setattr(StateFile, "OLD_STATE_DIR", tmp_path / "old")
+        (tmp_path / "old").mkdir()
+
+        sf = StateFile(None)  # Should not raise
+        assert sf.session_id is None
+
+    def test_statefile_accepts_valid_session(self, tmp_path, monkeypatch):
+        monkeypatch.setattr(StateFile, "STATE_DIR", tmp_path)
+        monkeypatch.setattr(StateFile, "OLD_STATE_DIR", tmp_path / "old")
+        (tmp_path / "old").mkdir()
+
+        sf = StateFile("valid-session-123")  # Should not raise
+        assert sf.session_id == "valid-session-123"
+
+
+# ---------------------------------------------------------------------------
+# CLI Session ID Rejection (subprocess test)
+# ---------------------------------------------------------------------------
+
+
+class TestCliSessionIdRejection:
+    """Test that context-stats CLI rejects invalid session IDs."""
+
+    def test_cli_rejects_path_traversal(self):
+        result = subprocess.run(
+            [sys.executable, "-m", "claude_statusline.cli.context_stats", "../../etc/passwd"],
+            capture_output=True,
+            text=True,
+        )
+        assert result.returncode != 0
+        assert "Invalid session_id" in result.stderr
+
+    def test_cli_rejects_backslash(self):
+        result = subprocess.run(
+            [sys.executable, "-m", "claude_statusline.cli.context_stats", "test\\bad"],
+            capture_output=True,
+            text=True,
+        )
+        assert result.returncode != 0
+        assert "Invalid session_id" in result.stderr

package/tests/python/test_statusline.py

@@ -1,5 +1,7 @@
 """Tests for statusline.py script."""
 
+from __future__ import annotations
+
 import json
 import os
 import re

package/.claude/commands/context-stats.md

@@ -1,17 +0,0 @@
----
-description: Display ASCII graph of token usage for current session
-argument-hint: [session_id] [--type cumulative|delta|both] [--no-color]
-allowed-tools: Bash(*)
----
-
-# Context Stats
-
-Display the token consumption history as ASCII graphs.
-
-**IMPORTANT**: This command executes a bash script and displays its output directly. Do NOT analyze or interpret the results - simply show them to the user.
-
-Execute the token graph script:
-
-!`bash /Users/montimage/buildspace/luongnv89/claude-statusline/scripts/context-stats.sh $ARGUMENTS`
-
-The output above shows the token usage visualization. No further analysis is needed.

package/.claude/settings.local.json

@@ -1,117 +0,0 @@
-{
-  "permissions": {
-    "allow": [
-      "Bash(/Users/montimage/buildspace/luongnv89/claude-statusline/scripts/statusline-full.sh:*)",
-      "Bash(find:*)",
-      "Bash(GIT_DIR=/Users/montimage/buildspace/luongnv89/claude-statusline/.git git add scripts/)",
-      "Bash(GIT_DIR=/Users/montimage/buildspace/luongnv89/claude-statusline/.git git -c core.hooksPath=/dev/null commit:*)",
-      "Bash(GIT_SSH_COMMAND=\"ssh -F /dev/null -o IdentityFile=~/.ssh/id_ed25519\" git push origin main)",
-      "Bash(/Users/montimage/buildspace/luongnv89/claude-statusline/scripts/statusline-original.sh)",
-      "Bash(/Users/montimage/buildspace/luongnv89/claude-statusline/scripts/statusline-git.sh)",
-      "Bash(/Users/montimage/buildspace/luongnv89/claude-statusline/scripts/statusline-minimal.sh:*)",
-      "Bash(ls:*)",
-      "Bash(wc:*)",
-      "Bash(pytest:*)",
-      "Bash(bats:*)",
-      "Bash(ruff check:*)",
-      "Bash(npx eslint:*)",
-      "Bash(shellcheck:*)",
-      "Bash(gh run list:*)",
-      "Bash(gh run view:*)",
-      "Bash(ruff format:*)",
-      "Bash(git rm:*)",
-      "Bash(scripts/statusline-full.sh:*)",
-      "Bash(./scripts/statusline-full.sh:*)",
-      "Bash(~/.claude/statusline.conf)",
-      "Bash(/Users/montimage/buildspace/luongnv89/claude-statusline/scripts/context-stats.sh:*)",
-      "Bash(bash -x:*)",
-      "Bash(timeout 5 bash:*)",
-      "Bash(perl -e 'alarm 10; exec @ARGV' -- /Users/montimage/buildspace/luongnv89/claude-statusline/scripts/context-stats.sh test-session --no-color)",
-      "Bash(bash -c '/Users/montimage/buildspace/luongnv89/claude-statusline/scripts/context-stats.sh test-session --no-color; echo \"\"Exit code: $?\"\"')",
-      "Bash(/bin/bash /Users/montimage/buildspace/luongnv89/claude-statusline/scripts/context-stats.sh:*)",
-      "Bash(/bin/bash:*)",
-      "Bash(/opt/homebrew/bin/bash:*)",
-      "Bash(COLUMNS=80 LINES=40 /bin/bash:*)",
-      "Bash(pre-commit:*)",
-      "Bash(./install.sh)",
-      "Bash(context-stats:*)",
-      "Bash(gh pr list:*)",
-      "Bash(apt-get update:*)",
-      "Bash(apt-get install:*)",
-      "Bash(pip install:*)",
-      "Bash(mypy:*)",
-      "Bash(npm ci:*)",
-      "Bash(npx prettier --check scripts/statusline.js)",
-      "Bash(cat:*)",
-      "Bash(node -c:*)",
-      "Bash(xxd:*)",
-      "Bash(node --version:*)",
-      "Bash(awk:*)",
-      "Bash(grep:*)",
-      "Bash(npm test:*)",
-      "Bash(SAMPLE_INPUT='{\"\"\"\"model\"\"\"\":{\"\"\"\"display_name\"\"\"\":\"\"\"\"Claude 3.5 Sonnet\"\"\"\"},\"\"\"\"workspace\"\"\"\":{\"\"\"\"current_dir\"\"\"\":\"\"\"\"/tmp/test\"\"\"\",\"\"\"\"project_dir\"\"\"\":\"\"\"\"/tmp/test\"\"\"\"},\"\"\"\"context_window\"\"\"\":{\"\"\"\"context_window_size\"\"\"\":200000,\"\"\"\"current_usage\"\"\"\":{\"\"\"\"input_tokens\"\"\"\":1000,\"\"\"\"cache_creation_input_tokens\"\"\"\":500,\"\"\"\"cache_read_input_tokens\"\"\"\":200}}}')",
-      "Bash(echo \"Testing bash scripts...\" echo \"$SAMPLE_INPUT\")",
-      "Bash(./scripts/statusline-git.sh echo \"$SAMPLE_INPUT\")",
-      "Bash(./scripts/statusline-minimal.sh:*)",
-      "Bash(echo \"Testing Python script...\" echo \"$SAMPLE_INPUT\")",
-      "Bash(python3:*)",
-      "Bash(echo \"Testing Node.js script...\" echo \"$SAMPLE_INPUT\")",
-      "Bash(node ./scripts/statusline.js:*)",
-      "Bash(./scripts/statusline-git.sh echo \"\" echo \"$SAMPLE_INPUT\")",
-      "Bash(export PATH=\"$HOME/.local/bin:$PATH\")",
-      "Bash(~/.local/bin/context-stats test-session:*)",
-      "Bash(~/.local/bin/context-stats)",
-      "Bash(~/.local/bin/context-stats:*)",
-      "Bash(gh run watch:*)",
-      "Bash(claude-statusline)",
-      "Bash(python -m build:*)",
-      "Bash(unzip:*)",
-      "Bash(twine:*)",
-      "WebFetch(domain:pypi.org)",
-      "Bash(python -m pytest:*)",
-      "Bash(python:*)",
-      "Bash(python -c:*)",
-      "Bash(timeout 5 context-stats:*)",
-      "Bash(gtimeout 5 context-stats:*)",
-      "Bash(./scripts/context-stats.sh:*)",
-      "Bash(echo:*)",
-      "Bash(CLAUDE_SESSION_ID=\"bf8a8370-18d6-473d-8f12-51e7f3c2a9d0\" node scripts/statusline.js:*)",
-      "Skill(pre-commit)",
-      "Bash(npm run format:check:*)",
-      "Bash(bash:*)",
-      "Bash(git tag:*)",
-      "Bash(git pull:*)",
-      "Bash(git rebase:*)",
-      "Bash(git stash:*)",
-      "Bash(npm whoami:*)",
-      "Bash(git filter-branch:*)",
-      "Bash(gh issue view:*)",
-      "Bash(head:*)",
-      "Bash(/Users/montimage/buildspace/luongnv89/cc-context-stats/.venv/bin/python -m pytest:*)",
-      "Bash(/Users/montimage/buildspace/luongnv89/cc-context-stats/.venv/bin/python3 -m pytest:*)",
-      "Bash(/Users/montimage/buildspace/luongnv89/cc-context-stats/.venv/bin/python3.14 -m pytest:*)",
-      "Bash(/Users/montimage/buildspace/luongnv89/cc-context-stats/venv/bin/python3 -m pytest:*)",
-      "Bash(/Users/montimage/buildspace/luongnv89/cc-context-stats/venv/bin/pip install:*)",
-      "Bash(.test_venv/bin/pip install:*)",
-      "Bash(.test_venv/bin/python3.14 -m pytest:*)",
-      "Bash(.venv/bin/pip install:*)",
-      "Bash(.venv/bin/python3.14 -m pytest:*)",
-      "Bash(.venv/bin/context-stats:*)",
-      "Bash(npx jest:*)",
-      "Bash(gh workflow:*)",
-      "Bash(git -C /Users/montimage/buildspace/luongnv89/cc-context-stats status)",
-      "Bash(git -C /Users/montimage/buildspace/luongnv89/cc-context-stats diff)",
-      "Bash(git -C /Users/montimage/buildspace/luongnv89/cc-context-stats log --oneline -5)",
-      "Bash(git -C /Users/montimage/buildspace/luongnv89/cc-context-stats add tests/python/test_statusline.py)",
-      "Bash(git -C /Users/montimage/buildspace/luongnv89/cc-context-stats commit -m \"$\\(cat <<''EOF''\nfix: resolve Windows CI failures caused by Unicode encoding in Python tests\n\nSet PYTHONUTF8=1 for subprocess calls and use explicit utf-8 encoding\nfor read_text\\(\\) to handle Unicode characters \\(emojis/icons\\) on Windows\nwhere the default cp1252 encoding cannot decode them.\nEOF\n\\)\")",
-      "Bash(git -C /Users/montimage/buildspace/luongnv89/cc-context-stats push)",
-      "Bash(COLUMNS=200 cat tests/fixtures/json/valid_full.json | scripts/statusline-full.sh 2>&1)",
-      "Bash(export COLUMNS=200 && cat tests/fixtures/json/valid_full.json | scripts/statusline-full.sh 2>&1)",
-      "Bash(gh release:*)",
-      "Read(//Users/montimage/.claude/**)",
-      "Bash(git checkout:*)",
-      "Bash(npm publish:*)",
-      "Bash(npm view:*)"
-    ]
-  }
-}