cbrowser 18.78.0 → 18.80.0

package/dist/cli.js

@@ -590,6 +590,10 @@ SCREEN CAPTURE (video/GIF — distinct from 'record', which captures actions)
     --quality <1-100>         JPEG quality of captured frames (default: 80)
     --max-frames <n>          Stop retaining frames after n (default: 3000)
     --contact-sheet           Also write one JPEG summarising the whole capture
+    --attention-overlay       Paint the predicted-attention map over every frame
+                              (adds ~0.5-1s per frame; uses the live DOM)
+    --overlay-persona <name>  Persona weighting the overlay (default: first-timer)
+    --overlay-goal <text>     Goal string weighting goal-relevance in the overlay
     --after <event>           Start on load|domcontentloaded|networkidle
     --after-element <sel>     Start when the element is present and visible
     --after-delay <500ms>     Extra delay after the start trigger
@@ -624,7 +628,7 @@ WEBHOOKS (v2.5.0)
 
 PERSONA QUESTIONNAIRE
   persona-questionnaire start        Build a persona from a behavioural questionnaire
-    --comprehensive                  All 25 traits (default: 8 core traits)
+    --comprehensive                  All 26 traits (default: 8 core traits)
     --name <name>                    Persona name (prompted if omitted)
     --output <file>                  Save answers to JSON
   persona-questionnaire list-traits  List available traits with descriptions
@@ -976,11 +980,12 @@ const COMMAND_FLAGS = {
     capture: [
         "fps", "duration", "format", "out", "name", "quality", "max-frames",
         "viewport", "region", "element", "element-padding", "contact-sheet",
+        "attention-overlay", "overlay-persona", "overlay-goal",
         "after", "after-element", "after-delay",
         "until-element", "until-element-gone", "until-idle", "timeout",
     ],
-    evaluate: ["file", "arg", "json", "raw", "wait-for", "expect-truthy"],
-    eval: ["file", "arg", "json", "raw", "wait-for", "expect-truthy"],
+    evaluate: ["file", "arg", "json", "raw", "wait-for", "timeout", "expect-truthy"],
+    eval: ["file", "arg", "json", "raw", "wait-for", "timeout", "expect-truthy"],
     keyboard: ["delay", "selector", "hold", "repeat", "text"],
     "test-suite": [
         "capture", "capture-fps", "capture-format", "capture-out",
@@ -1116,7 +1121,7 @@ const CAPTURE_FLAGS = new Set([
     // capture-specific
     "fps", "duration", "format", "out", "name", "quality", "max-frames",
     "viewport", "region", "element", "element-padding",
-    "contact-sheet",
+    "contact-sheet", "attention-overlay", "overlay-persona", "overlay-goal",
     "after", "after-element", "after-delay",
     "until-element", "until-element-gone", "until-idle", "timeout",
     // globals honoured by the shared CBrowser construction
@@ -1352,6 +1357,17 @@ async function runOneCapture(browser, page, options, slug, outDirOverride) {
     await session.start({
         fps, durationMs, outDir, format, slug, target, quality, maxFrames,
         contactSheet: options["contact-sheet"] === true || typeof options["contact-sheet"] === "string",
+        // Overlay the model's predicted-attention map on every frame. Opt-in: it
+        // costs one attention pass per frame. DOM is read from the live page at
+        // stop, so this is the full 35/65 model, not bottom-up contrast alone.
+        ...(options["attention-overlay"]
+            ? {
+                saliencyOverlay: {
+                    ...(typeof options["overlay-persona"] === "string" ? { persona: options["overlay-persona"] } : {}),
+                    ...(typeof options["overlay-goal"] === "string" ? { goal: options["overlay-goal"] } : {}),
+                },
+            }
+            : {}),
         ...triggers,
         // Element tracking resolves through the browser's existing nine-strategy
         // resolver rather than a second one living in the capture engine.
@@ -1713,7 +1729,7 @@ function reportAutoCapture(capture) {
 // =========================================================================
 /** Flags `evaluate` understands; anything else is rejected rather than ignored. */
 const EVALUATE_FLAGS = new Set([
-    "file", "arg", "json", "raw", "wait-for", "expect-truthy",
+    "file", "arg", "json", "raw", "wait-for", "timeout", "expect-truthy",
     "url", "browser", "device", "headless", "persistent", "restore",
     "locale", "timezone", "geo", "verbose",
 ]);
@@ -1852,11 +1868,35 @@ async function runEvaluate(browser, args, options) {
         await browser.navigate(options.url);
     const page = await browser.getPage();
     if (typeof options["wait-for"] === "string") {
+        // Bounded by the caller, not by a constant.
+        //
+        // This was a hardcoded 30s, which is two defects wearing one number. For a
+        // user it meant no way to fail fast on a page that renders in 200ms and no
+        // way to wait longer on one that does not. For the suite it meant the test
+        // asserting that a never-matching selector fails loudly spent 30 of its 60
+        // second budget deliberately waiting, so browser launch plus teardown had
+        // to fit in the rest -- which held when the test ran alone and did not when
+        // the full suite ran browsers in parallel. The test read as flaky and was
+        // not: it was structurally tight against a constant it could not reach.
+        // (2026-08-02)
+        // Falls back to the configured default rather than a fresh literal.
+        // `CBROWSER_TIMEOUT` is documented in --help as "Default timeout in ms" and
+        // config.ts already resolves it; a second hardcoded 30_000 here would mean
+        // the documented env var silently did not apply to this one wait.
+        const { getDefaultConfig } = await import("./config.js");
+        const configuredMs = getDefaultConfig().timeout ?? 30_000;
+        const waitMs = typeof options.timeout === "string" ? Number(options.timeout)
+            : typeof options.timeout === "number" ? options.timeout
+                : configuredMs;
+        if (!Number.isFinite(waitMs) || waitMs <= 0) {
+            console.error(`Error: --timeout must be a positive number of milliseconds, got: ${options.timeout}`);
+            process.exit(1);
+        }
         try {
-            await page.waitForSelector(options["wait-for"], { timeout: 30_000 });
+            await page.waitForSelector(options["wait-for"], { timeout: waitMs });
         }
         catch {
-            console.error(`✗ Timed out waiting for selector: ${options["wait-for"]}`);
+            console.error(`✗ Timed out waiting for selector: ${options["wait-for"]} (after ${waitMs}ms)`);
             process.exit(1);
         }
     }
@@ -6376,7 +6416,10 @@ Documentation: https://github.com/alexandriashai/cbrowser/wiki
                         fs.writeFileSync(options.output, JSON.stringify(result, null, 2));
                         console.log(`\n📄 Report saved: ${options.output}`);
                     }
-                    // Exit with appropriate code
+                    // Exit with appropriate code. This IS a cognitive journey, so
+                    // goalAchieved genuinely means the persona reached the goal — unlike
+                    // the empathy audit's field of the same old name, which measured
+                    // barriers and was renamed to noBlockingBarriers.
                     process.exit(result.goalAchieved ? 0 : 1);
                 }
                 catch (error) {
@@ -6807,7 +6850,7 @@ Commands:
   persona-questionnaire lookup       Look up behaviors for a specific trait value
 
 Options for 'start':
-  --comprehensive     Include all 25 traits (default: 8 core traits)
+  --comprehensive     Include all 26 traits (default: 8 core traits)
   --name <name>       Name for the persona (prompted if not provided)
   --output <file>     Save questionnaire answers to JSON file
 
@@ -6854,7 +6897,9 @@ Examples:
                             if (answer && answer.trim()) {
                                 const idx = parseInt(answer.trim()) - 1;
                                 if (idx >= 0 && idx < q.options.length) {
-                                    answers[q.trait] = q.options[idx].value;
+                                    // Keyed by id, not trait: a Big Five item has no trait, and for a trait
+                                    // question id and trait are the same string anyway.
+                                    answers[q.id] = q.options[idx].value;
                                     console.log(`  ✓ ${q.options[idx].label}`);
                                 }
                             }