catalyst-relay 0.6.1 → 0.6.3

package/dist/index.d.mts

@@ -599,17 +599,25 @@ interface SearchOptions {
 type ClassIncludeType = 'definitions' | 'implementations' | 'macros' | 'testclasses';
 
 /**
- * Create Transport — Create a new transport request for a package
+ * Create Transport — create a new transport request.
+ *
+ * Uses the transport-organizer endpoint, which allows choosing the request
+ * type (Workbench vs Customizing). The target is taken from the caller, or
+ * resolved from the target value-help when unambiguous.
  */
 
-/**
- * Configuration for creating a transport
- */
+declare const TRANSPORT_TYPE_CODES: {
+    readonly workbench: "K";
+    readonly customizing: "W";
+};
+type TransportType = keyof typeof TRANSPORT_TYPE_CODES;
 interface TransportConfig {
-    /** Package name (DEVCLASS) */
-    package: string;
     /** Transport description/text */
     description: string;
+    /** Request type — 'workbench' (default) or 'customizing' */
+    type?: TransportType;
+    /** Transport target. If omitted, resolved from the value-help (fails when ambiguous). */
+    target?: string;
 }
 
 /**
@@ -742,6 +750,7 @@ interface ADTClient {
     read(objects: ObjectRef[]): AsyncResult<ObjectWithContent[]>;
     create(object: ObjectContent, packageName: string, transport?: string): AsyncResult<void>;
     update(object: ObjectContent, transport?: string): AsyncResult<void>;
+    readClassInclude(className: string, includeType: ClassIncludeType): AsyncResult<string>;
     writeClassInclude(className: string, includeType: ClassIncludeType, source: string, transport?: string): AsyncResult<void>;
     upsert(objects: ObjectContent[], packageName: string, transport?: string): AsyncResult<UpsertResult[]>;
     activate(objects: ObjectRef[]): AsyncResult<ActivationResult[]>;
@@ -791,4 +800,4 @@ declare function activateLogging(): void;
  */
 declare function deactivateLogging(): void;
 
-export { type ADTClient, type ActivationMessage, type ActivationReference, type ActivationResult, type Aggregation, type ApiResponse, type AsyncResult, type AuthConfig, type AuthType, type BasicAuthConfig, type BasicFilter, BehaviorImplementationType, type BetweenFilter, type CheckResult, type ClassIncludeType, type ClientConfig, type ColumnInfo, type CreateServiceBindingOptions, type DataFrame, type DataPreviewQuery, type DeleteResult, type Dependency, type DiffHunk, type DiffResult, type DistinctResult, type ErrorCode, type ErrorResponse, type ExportableSessionState, type ExternalReference, ExternalReferencesError, type FolderNode, type GetPackagesOptions, type InactiveEntry, type InactiveObject, type InactiveRef, type InactiveTransport, type ListFilter, type ModifiedDiffHunk, type ObjectConfig, type ObjectContent, type ObjectMetadata, type ObjectNode, type ObjectRef, type ObjectWithContent, type Package, type PackageNode, type Parameter, type PreviewSQL, type QueryFilter, type Result, type SamlAuthConfig, type SearchOptions, type SearchResult, type ServiceBindingResult, type ServiceBindingType, type ServiceBindingVersion, type Session, type SimpleDiffHunk, type Sorting, type SsoAuthConfig, type SuccessResponse, type TaskContents, type Transport, type TransportConfig, type TransportObject, type TreeQuery, type TreeResponse, type UpsertResult, activateLogging, buildSQLQuery, createClient, deactivateLogging, err, ok };
+export { type ADTClient, type ActivationMessage, type ActivationReference, type ActivationResult, type Aggregation, type ApiResponse, type AsyncResult, type AuthConfig, type AuthType, type BasicAuthConfig, type BasicFilter, BehaviorImplementationType, type BetweenFilter, type CheckResult, type ClassIncludeType, type ClientConfig, type ColumnInfo, type CreateServiceBindingOptions, type DataFrame, type DataPreviewQuery, type DeleteResult, type Dependency, type DiffHunk, type DiffResult, type DistinctResult, type ErrorCode, type ErrorResponse, type ExportableSessionState, type ExternalReference, ExternalReferencesError, type FolderNode, type GetPackagesOptions, type InactiveEntry, type InactiveObject, type InactiveRef, type InactiveTransport, type ListFilter, type ModifiedDiffHunk, type ObjectConfig, type ObjectContent, type ObjectMetadata, type ObjectNode, type ObjectRef, type ObjectWithContent, type Package, type PackageNode, type Parameter, type PreviewSQL, type QueryFilter, type Result, type SamlAuthConfig, type SearchOptions, type SearchResult, type ServiceBindingResult, type ServiceBindingType, type ServiceBindingVersion, type Session, type SimpleDiffHunk, type Sorting, type SsoAuthConfig, type SuccessResponse, type TaskContents, type Transport, type TransportConfig, type TransportObject, type TransportType, type TreeQuery, type TreeResponse, type UpsertResult, activateLogging, buildSQLQuery, createClient, deactivateLogging, err, ok };

package/dist/index.d.ts

@@ -599,17 +599,25 @@ interface SearchOptions {
 type ClassIncludeType = 'definitions' | 'implementations' | 'macros' | 'testclasses';
 
 /**
- * Create Transport — Create a new transport request for a package
+ * Create Transport — create a new transport request.
+ *
+ * Uses the transport-organizer endpoint, which allows choosing the request
+ * type (Workbench vs Customizing). The target is taken from the caller, or
+ * resolved from the target value-help when unambiguous.
  */
 
-/**
- * Configuration for creating a transport
- */
+declare const TRANSPORT_TYPE_CODES: {
+    readonly workbench: "K";
+    readonly customizing: "W";
+};
+type TransportType = keyof typeof TRANSPORT_TYPE_CODES;
 interface TransportConfig {
-    /** Package name (DEVCLASS) */
-    package: string;
     /** Transport description/text */
     description: string;
+    /** Request type — 'workbench' (default) or 'customizing' */
+    type?: TransportType;
+    /** Transport target. If omitted, resolved from the value-help (fails when ambiguous). */
+    target?: string;
 }
 
 /**
@@ -742,6 +750,7 @@ interface ADTClient {
     read(objects: ObjectRef[]): AsyncResult<ObjectWithContent[]>;
     create(object: ObjectContent, packageName: string, transport?: string): AsyncResult<void>;
     update(object: ObjectContent, transport?: string): AsyncResult<void>;
+    readClassInclude(className: string, includeType: ClassIncludeType): AsyncResult<string>;
     writeClassInclude(className: string, includeType: ClassIncludeType, source: string, transport?: string): AsyncResult<void>;
     upsert(objects: ObjectContent[], packageName: string, transport?: string): AsyncResult<UpsertResult[]>;
     activate(objects: ObjectRef[]): AsyncResult<ActivationResult[]>;
@@ -791,4 +800,4 @@ declare function activateLogging(): void;
  */
 declare function deactivateLogging(): void;
 
-export { type ADTClient, type ActivationMessage, type ActivationReference, type ActivationResult, type Aggregation, type ApiResponse, type AsyncResult, type AuthConfig, type AuthType, type BasicAuthConfig, type BasicFilter, BehaviorImplementationType, type BetweenFilter, type CheckResult, type ClassIncludeType, type ClientConfig, type ColumnInfo, type CreateServiceBindingOptions, type DataFrame, type DataPreviewQuery, type DeleteResult, type Dependency, type DiffHunk, type DiffResult, type DistinctResult, type ErrorCode, type ErrorResponse, type ExportableSessionState, type ExternalReference, ExternalReferencesError, type FolderNode, type GetPackagesOptions, type InactiveEntry, type InactiveObject, type InactiveRef, type InactiveTransport, type ListFilter, type ModifiedDiffHunk, type ObjectConfig, type ObjectContent, type ObjectMetadata, type ObjectNode, type ObjectRef, type ObjectWithContent, type Package, type PackageNode, type Parameter, type PreviewSQL, type QueryFilter, type Result, type SamlAuthConfig, type SearchOptions, type SearchResult, type ServiceBindingResult, type ServiceBindingType, type ServiceBindingVersion, type Session, type SimpleDiffHunk, type Sorting, type SsoAuthConfig, type SuccessResponse, type TaskContents, type Transport, type TransportConfig, type TransportObject, type TreeQuery, type TreeResponse, type UpsertResult, activateLogging, buildSQLQuery, createClient, deactivateLogging, err, ok };
+export { type ADTClient, type ActivationMessage, type ActivationReference, type ActivationResult, type Aggregation, type ApiResponse, type AsyncResult, type AuthConfig, type AuthType, type BasicAuthConfig, type BasicFilter, BehaviorImplementationType, type BetweenFilter, type CheckResult, type ClassIncludeType, type ClientConfig, type ColumnInfo, type CreateServiceBindingOptions, type DataFrame, type DataPreviewQuery, type DeleteResult, type Dependency, type DiffHunk, type DiffResult, type DistinctResult, type ErrorCode, type ErrorResponse, type ExportableSessionState, type ExternalReference, ExternalReferencesError, type FolderNode, type GetPackagesOptions, type InactiveEntry, type InactiveObject, type InactiveRef, type InactiveTransport, type ListFilter, type ModifiedDiffHunk, type ObjectConfig, type ObjectContent, type ObjectMetadata, type ObjectNode, type ObjectRef, type ObjectWithContent, type Package, type PackageNode, type Parameter, type PreviewSQL, type QueryFilter, type Result, type SamlAuthConfig, type SearchOptions, type SearchResult, type ServiceBindingResult, type ServiceBindingType, type ServiceBindingVersion, type Session, type SimpleDiffHunk, type Sorting, type SsoAuthConfig, type SuccessResponse, type TaskContents, type Transport, type TransportConfig, type TransportObject, type TransportType, type TreeQuery, type TreeResponse, type UpsertResult, activateLogging, buildSQLQuery, createClient, deactivateLogging, err, ok };

package/dist/index.js

@@ -1061,22 +1061,6 @@ function escapeXml(str) {
   }
   return str.replace(/&/g, "&amp;").replace(/</g, "&lt;").replace(/>/g, "&gt;").replace(/"/g, "&quot;").replace(/'/g, "&apos;");
 }
-function dictToAbapXml(data, root = "DATA") {
-  const innerElements = Object.entries(data).map(([key, value]) => {
-    if (value) {
-      return `<${key}>${escapeXml(value)}</${key}>`;
-    }
-    return `<${key}/>`;
-  }).join("\n            ");
-  return `<?xml version="1.0" encoding="UTF-8"?>
-<asx:abap xmlns:asx="http://www.sap.com/abapxml" version="1.0">
-    <asx:values>
-        <${root}>
-            ${innerElements}
-        </${root}>
-    </asx:values>
-</asx:abap>`;
-}
 
 // src/core/utils/csrf.ts
 var FETCH_CSRF_TOKEN = "fetch";
@@ -1904,6 +1888,23 @@ async function updateObject(client, object, lockHandle, transport) {
 }
 
 // src/core/adt/craud/classInclude.ts
+async function readClassInclude(client, className, includeType) {
+  const [config, configErr] = requireConfig("aclass");
+  if (configErr) return err(configErr);
+  debug(`Read class include ${className}/${includeType}`);
+  const [response, requestErr] = await client.request({
+    method: "GET",
+    path: `/sap/bc/adt/${config.endpoint}/${className.toLowerCase()}/includes/${includeType}`,
+    headers: { "Accept": "text/plain" }
+  });
+  const [content, checkErr] = await checkResponse(
+    response,
+    requestErr,
+    `Failed to read ${includeType} include of class ${className}`
+  );
+  if (checkErr) return err(checkErr);
+  return ok(content);
+}
 async function updateClassInclude(client, className, includeType, source, lockHandle, transport) {
   const [config, configErr] = requireConfig("aclass");
   if (configErr) return err(configErr);
@@ -3081,35 +3082,102 @@ function parseSearchResults(xml) {
   return ok(results);
 }
 
-// src/core/adt/transports/createTransport.ts
-async function createTransport(client, config) {
-  const body = dictToAbapXml({
-    DEVCLASS: config.package,
-    REQUEST_TEXT: config.description,
-    REF: "",
-    OPERATION: "I"
+// src/core/adt/transports/getTransportTargets.ts
+var TARGET_VALUEHELP_PATH = "/sap/bc/adt/cts/transportrequests/valuehelp/target?name=*";
+var NAMEDITEM_CONTENT_TYPE = "application/vnd.sap.adt.nameditems.v1+xml";
+var NAMEDITEM_NS = "http://www.sap.com/adt/nameditem";
+async function getTransportTargets(client) {
+  const [response, requestErr] = await client.request({
+    method: "GET",
+    path: TARGET_VALUEHELP_PATH,
+    headers: { Accept: NAMEDITEM_CONTENT_TYPE }
   });
+  if (requestErr) return err(requestErr);
+  if (!response.ok) {
+    const text2 = await response.text();
+    return err(new Error(`Failed to fetch transport targets: ${extractError(text2)}`));
+  }
+  const text = await response.text();
+  const [targets, parseErr] = extractTargets(text);
+  if (parseErr) return err(parseErr);
+  return ok(targets);
+}
+function extractTargets(xml) {
+  const [doc, parseErr] = safeParseXml(xml);
+  if (parseErr) return err(parseErr);
+  const targets = [];
+  const items = doc.getElementsByTagNameNS(NAMEDITEM_NS, "namedItem");
+  for (let i = 0; i < items.length; i++) {
+    const item = items[i];
+    if (!item) continue;
+    const name = item.getElementsByTagNameNS(NAMEDITEM_NS, "name")[0]?.textContent;
+    if (!name || !name.trim()) continue;
+    const description = item.getElementsByTagNameNS(NAMEDITEM_NS, "description")[0]?.textContent;
+    targets.push({ name: name.trim(), description: (description ?? "").trim() });
+  }
+  return ok(targets);
+}
+
+// src/core/adt/transports/createTransport.ts
+var TRANSPORTREQUESTS_PATH = "/sap/bc/adt/cts/transportrequests";
+var TM_CONTENT_TYPE = "application/vnd.sap.adt.transportorganizer.v1+xml";
+var TM_NS = "http://www.sap.com/cts/adt/tm";
+var TRANSPORT_TYPE_CODES = {
+  workbench: "K",
+  customizing: "W"
+};
+async function createTransport(client, config, owner) {
+  const [target, targetErr] = await resolveTarget(client, config.target);
+  if (targetErr) return err(targetErr);
+  const typeCode = TRANSPORT_TYPE_CODES[config.type ?? "workbench"];
+  const body = `<?xml version="1.0" encoding="UTF-8"?>
+<tm:root xmlns:tm="${TM_NS}" tm:useraction="newrequest">
+  <tm:request tm:desc="${escapeXml(config.description)}" tm:type="${typeCode}" tm:target="${escapeXml(target)}" tm:cts_project="">
+    <tm:task tm:owner="${escapeXml(owner)}"/>
+  </tm:request>
+</tm:root>`;
   const [response, requestErr] = await client.request({
     method: "POST",
-    path: "/sap/bc/adt/cts/transports",
+    path: TRANSPORTREQUESTS_PATH,
     headers: {
-      "Content-Type": "application/vnd.sap.as+xml; charset=UTF-8; dataname=com.sap.adt.CreateCorrectionRequest",
-      "Accept": "text/plain"
+      "Content-Type": TM_CONTENT_TYPE,
+      "Accept": TM_CONTENT_TYPE
     },
     body
   });
   if (requestErr) return err(requestErr);
   if (!response.ok) {
     const text2 = await response.text();
-    const errorMsg = extractError(text2);
-    return err(new Error(`Failed to create transport for ${config.package}: ${errorMsg}`));
+    return err(new Error(`Failed to create transport: ${extractError(text2)}`));
   }
   const text = await response.text();
-  const transportId = text.trim().split("/").pop();
-  if (!transportId) {
-    return err(new Error("Failed to parse transport ID from response"));
+  return extractTransportNumber(text);
+}
+async function resolveTarget(client, explicit) {
+  if (explicit) return ok(explicit);
+  const [targets, targetsErr] = await getTransportTargets(client);
+  if (targetsErr) return err(targetsErr);
+  if (targets.length === 0) {
+    return err(new Error("No transport targets available; pass an explicit target."));
+  }
+  if (targets.length === 1) {
+    return ok(targets[0].name);
   }
-  return ok(transportId);
+  const options = targets.map((t) => `${t.name} (${t.description})`).join(", ");
+  return err(new Error(
+    `Multiple transport targets available; pass an explicit target. Options: ${options}`
+  ));
+}
+function extractTransportNumber(xml) {
+  const [doc, parseErr] = safeParseXml(xml);
+  if (parseErr) return err(parseErr);
+  const request4 = doc.getElementsByTagNameNS(TM_NS, "request")[0];
+  if (!request4) return err(new Error("Failed to parse transport number from response"));
+  const number = request4.getAttributeNS(TM_NS, "number") || request4.getAttribute("tm:number");
+  if (!number || !number.trim()) {
+    return err(new Error("Failed to parse transport number from response"));
+  }
+  return ok(number.trim());
 }
 
 // src/core/adt/transports/parseTransportTasks.ts
@@ -3620,6 +3688,12 @@ async function update(state, requestor, object, transport) {
   return ok(void 0);
 }
 
+// src/client/methods/craud/specialcases/classes/readClassInclude.ts
+async function readClassInclude2(state, requestor, className, includeType) {
+  if (!state.session) return err(new Error("Not logged in"));
+  return readClassInclude(requestor, className, includeType);
+}
+
 // src/client/methods/craud/specialcases/classes/writeClassInclude.ts
 async function writeClassInclude(state, requestor, className, includeType, source, transport) {
   if (!state.session) return err(new Error("Not logged in"));
@@ -3770,7 +3844,7 @@ async function whereUsed(state, requestor, object) {
 // src/client/methods/transport/createTransport.ts
 async function createTransport2(state, requestor, transportConfig) {
   if (!state.session) return err(new Error("Not logged in"));
-  return createTransport(requestor, transportConfig);
+  return createTransport(requestor, transportConfig, state.session.username);
 }
 
 // src/client/methods/transport/deleteTransport.ts
@@ -4156,6 +4230,9 @@ var ADTClientImpl = class {
   async update(object, transport) {
     return update(this.state, this.requestor, object, transport);
   }
+  async readClassInclude(className, includeType) {
+    return readClassInclude2(this.state, this.requestor, className, includeType);
+  }
   async writeClassInclude(className, includeType, source, transport) {
     return writeClassInclude(this.state, this.requestor, className, includeType, source, transport);
   }