catalyst-relay 0.4.1 → 0.4.3

package/dist/index.d.mts

@@ -496,6 +496,7 @@ interface ADTClient {
     getPackages(filter?: string): AsyncResult<Package[]>;
     getTree(query: TreeQuery): AsyncResult<TreeResponse>;
     getPackageStats(packageName: string): AsyncResult<PackageNode>;
+    getPackageStats(packageNames: string[]): AsyncResult<PackageNode[]>;
     getTransports(packageName: string): AsyncResult<Transport[]>;
     previewData(query: PreviewSQL): AsyncResult<DataFrame>;
     getDistinctValues(objectName: string, parameters: Parameter[], column: string, objectType?: 'table' | 'view'): AsyncResult<DistinctResult>;

package/dist/index.d.ts

@@ -496,6 +496,7 @@ interface ADTClient {
     getPackages(filter?: string): AsyncResult<Package[]>;
     getTree(query: TreeQuery): AsyncResult<TreeResponse>;
     getPackageStats(packageName: string): AsyncResult<PackageNode>;
+    getPackageStats(packageNames: string[]): AsyncResult<PackageNode[]>;
     getTransports(packageName: string): AsyncResult<Transport[]>;
     previewData(query: PreviewSQL): AsyncResult<DataFrame>;
     getDistinctValues(objectName: string, parameters: Parameter[], column: string, objectType?: 'table' | 'view'): AsyncResult<DistinctResult>;

package/dist/index.js

@@ -753,56 +753,6 @@ var API_FOLDERS = [
   "USE_IN_KEY_USER_APPS"
 ];
 
-// src/core/adt/discovery/tree/subpackages.ts
-async function getSubpackages(client, packageName) {
-  const params = new URLSearchParams([
-    ["parent_type", "DEVC/K"],
-    ["withShortDescriptions", "true"]
-  ]);
-  if (packageName) {
-    params.append("parent_name", packageName);
-  }
-  const [response, requestErr] = await client.request({
-    method: "POST",
-    path: `/sap/bc/adt/repository/nodestructure?${params.toString()}`,
-    headers: {
-      "Accept": "application/vnd.sap.as+xml"
-    }
-  });
-  if (requestErr) return err(requestErr);
-  if (!response.ok) {
-    const text2 = await response.text();
-    const errorMsg = extractError(text2);
-    return err(new Error(`Nodestructure failed: ${errorMsg}`));
-  }
-  const text = await response.text();
-  return parseNodestructureForPackages(text, packageName);
-}
-function parseNodestructureForPackages(xml, parentPackage) {
-  const [doc, parseErr] = safeParseXml(xml);
-  if (parseErr) return err(parseErr);
-  const packages = [];
-  const nodes = doc.getElementsByTagName("SEU_ADT_REPOSITORY_OBJ_NODE");
-  for (let i = 0; i < nodes.length; i++) {
-    const node = nodes[i];
-    if (!node) continue;
-    const objectType = node.getElementsByTagName("OBJECT_TYPE")[0]?.textContent?.trim();
-    if (objectType !== "DEVC/K") continue;
-    const objectName = node.getElementsByTagName("OBJECT_NAME")[0]?.textContent?.trim();
-    if (!objectName) continue;
-    if (parentPackage && objectName.toUpperCase() === parentPackage.toUpperCase()) continue;
-    const description = node.getElementsByTagName("DESCRIPTION")[0]?.textContent?.trim();
-    const pkg = {
-      name: objectName,
-      numContents: 0
-      // nodestructure doesn't provide counts
-    };
-    if (description) pkg.description = description;
-    packages.push(pkg);
-  }
-  return ok(packages);
-}
-
 // src/core/adt/discovery/tree/parsers.ts
 function buildQueryFromPath(packageName, path) {
   const query = {
@@ -928,6 +878,45 @@ function transformToTreeResponse(parsed, queryPackage) {
   return { packages, folders, objects };
 }
 
+// src/core/adt/discovery/tree/childPackages.ts
+async function fetchChildPackages(client, parentPackage) {
+  const query = {
+    PACKAGE: {
+      name: parentPackage,
+      hasChildrenOfSameFacet: true
+    }
+  };
+  const body = constructTreeBody(query, "*");
+  const [response, requestErr] = await client.request({
+    method: "POST",
+    path: "/sap/bc/adt/repository/informationsystem/virtualfolders/contents",
+    headers: {
+      "Content-Type": "application/vnd.sap.adt.repository.virtualfolders.request.v1+xml",
+      "Accept": "application/vnd.sap.adt.repository.virtualfolders.result.v1+xml"
+    },
+    body
+  });
+  if (requestErr) return err(requestErr);
+  if (!response.ok) {
+    const text2 = await response.text();
+    const errorMsg = extractError(text2);
+    return err(new Error(`Failed to fetch child packages: ${errorMsg}`));
+  }
+  const text = await response.text();
+  const [parsed, parseErr] = parseTreeXml(text);
+  if (parseErr) return err(parseErr);
+  const parentUpper = parentPackage.toUpperCase();
+  const packages = parsed.folders.filter((f) => f.facet === "PACKAGE" && f.name.toUpperCase() !== parentUpper).map((f) => {
+    const pkg = {
+      name: f.name,
+      numContents: f.count
+    };
+    if (f.description) pkg.description = f.description;
+    return pkg;
+  });
+  return ok(packages);
+}
+
 // src/core/adt/discovery/tree/virtualFolders.ts
 async function fetchVirtualFolders(client, query) {
   const body = constructTreeBody(query, "*");
@@ -1023,9 +1012,9 @@ async function getTree(client, query = {}) {
   }
   let packages = [];
   if (!query.path) {
-    const [subpkgs, subErr] = await getSubpackages(client, query.package);
-    if (subErr) return err(subErr);
-    packages = subpkgs;
+    const [childPkgs, childErr] = await fetchChildPackages(client, query.package);
+    if (childErr) return err(childErr);
+    packages = childPkgs;
   }
   const internalQuery = buildQueryFromPath(query.package, query.path);
   const [parsed, parseErr] = await fetchVirtualFolders(client, internalQuery);
@@ -1052,48 +1041,55 @@ async function getTree(client, query = {}) {
 }
 
 // src/core/adt/discovery/tree/packageStats.ts
-async function fetchPackageMetadata(client, packageName) {
-  const [response, requestErr] = await client.request({
-    method: "GET",
-    path: `/sap/bc/adt/packages/${packageName.toLowerCase()}`,
-    headers: {
-      "Accept": "application/vnd.sap.adt.packages.v1+xml"
-    }
-  });
-  if (requestErr) return err(requestErr);
-  if (!response.ok) {
-    const text = await response.text();
-    const errorMsg = extractError(text);
-    return err(new Error(`Package metadata fetch failed: ${errorMsg}`));
-  }
-  const xml = await response.text();
-  const [doc, parseErr] = safeParseXml(xml);
-  if (parseErr) return err(parseErr);
-  const packageElements = doc.getElementsByTagName("pak:package");
-  if (packageElements.length === 0) {
-    return err(new Error(`Package ${packageName} not found`));
-  }
-  const pkgEl = packageElements[0];
-  const name = pkgEl.getAttribute("adtcore:name") || pkgEl.getAttributeNS("http://www.sap.com/adt/core", "name") || packageName.toUpperCase();
-  const description = pkgEl.getAttribute("adtcore:description") || pkgEl.getAttributeNS("http://www.sap.com/adt/core", "description");
-  const result = { name };
-  if (description) result.description = description;
-  return ok(result);
-}
-function constructCountRequestBody(packageName) {
+function constructPackageStatsBody(packageNames) {
+  const names = packageNames.length === 1 ? [...packageNames, "SRIS_TEST_DATA_VFS_EMPTY"] : packageNames;
+  const values = names.map((name) => `    <vfs:value>${name}</vfs:value>`).join("\n");
   return `<?xml version="1.0" encoding="UTF-8"?>
 <vfs:virtualFoldersRequest xmlns:vfs="http://www.sap.com/adt/ris/virtualFolders" objectSearchPattern="*">
   <vfs:preselection facet="package">
-    <vfs:value>${packageName}</vfs:value>
+${values}
   </vfs:preselection>
-  <vfs:facetorder/>
+  <vfs:facetorder>
+    <vfs:facet>package</vfs:facet>
+    <vfs:facet>group</vfs:facet>
+    <vfs:facet>type</vfs:facet>
+  </vfs:facetorder>
 </vfs:virtualFoldersRequest>`;
 }
-async function fetchContentCount(client, packageName) {
-  const body = constructCountRequestBody(packageName);
+function parsePackageStats(xml) {
+  const [doc, parseErr] = safeParseXml(xml);
+  if (parseErr) return [];
+  const packages = [];
+  const virtualFolders = doc.getElementsByTagName("vfs:virtualFolder");
+  for (let i = 0; i < virtualFolders.length; i++) {
+    const vf = virtualFolders[i];
+    if (!vf) continue;
+    const facet = vf.getAttribute("facet")?.toUpperCase();
+    if (facet !== "PACKAGE") continue;
+    const name = vf.getAttribute("name");
+    if (!name) continue;
+    const countAttr = vf.getAttribute("counter");
+    const count = countAttr ? parseInt(countAttr, 10) : 0;
+    const description = vf.getAttribute("text");
+    const pkg = {
+      name,
+      numContents: count
+    };
+    if (description) pkg.description = description;
+    packages.push(pkg);
+  }
+  return packages;
+}
+async function getPackageStats(client, packageNames) {
+  const isSingle = typeof packageNames === "string";
+  const names = isSingle ? [packageNames] : packageNames;
+  if (names.length === 0) {
+    return ok([]);
+  }
+  const body = constructPackageStatsBody(names);
   const [response, requestErr] = await client.request({
     method: "POST",
-    path: "/sap/bc/adt/repository/informationsystem/virtualfolders",
+    path: "/sap/bc/adt/repository/informationsystem/virtualfolders/contents",
     headers: {
       "Content-Type": "application/vnd.sap.adt.repository.virtualfolders.request.v1+xml",
       "Accept": "application/vnd.sap.adt.repository.virtualfolders.result.v1+xml"
@@ -1104,41 +1100,17 @@ async function fetchContentCount(client, packageName) {
   if (!response.ok) {
     const text = await response.text();
     const errorMsg = extractError(text);
-    return err(new Error(`Package count fetch failed: ${errorMsg}`));
+    return err(new Error(`Package stats fetch failed: ${errorMsg}`));
   }
   const xml = await response.text();
-  const [doc, parseErr] = safeParseXml(xml);
-  if (parseErr) return err(parseErr);
-  const resultElements = doc.getElementsByTagName("vfs:virtualFoldersResult");
-  if (resultElements.length === 0) {
-    return err(new Error("Invalid virtualfolders response: missing result element"));
-  }
-  const resultEl = resultElements[0];
-  const objectCountAttr = resultEl.getAttribute("objectCount");
-  if (!objectCountAttr) {
-    return err(new Error("Invalid virtualfolders response: missing objectCount attribute"));
-  }
-  const count = parseInt(objectCountAttr, 10);
-  if (isNaN(count)) {
-    return err(new Error(`Invalid objectCount value: ${objectCountAttr}`));
+  const packages = parsePackageStats(xml).filter((pkg) => pkg.name !== "SRIS_TEST_DATA_VFS_EMPTY");
+  if (isSingle) {
+    if (packages.length === 0) {
+      return err(new Error(`Package ${packageNames} not found`));
+    }
+    return ok(packages[0]);
   }
-  return ok(count);
-}
-async function getPackageStats(client, packageName) {
-  const [metadataResult, countResult] = await Promise.all([
-    fetchPackageMetadata(client, packageName),
-    fetchContentCount(client, packageName)
-  ]);
-  const [metadata, metaErr] = metadataResult;
-  if (metaErr) return err(metaErr);
-  const [numContents, countErr] = countResult;
-  if (countErr) return err(countErr);
-  const result = {
-    name: metadata.name,
-    numContents
-  };
-  if (metadata.description) result.description = metadata.description;
-  return ok(result);
+  return ok(packages);
 }
 
 // src/core/adt/transports/transports.ts
@@ -2637,9 +2609,9 @@ var ADTClientImpl = class {
     if (!this.state.session) return err(new Error("Not logged in"));
     return getTree(this.requestor, query);
   }
-  async getPackageStats(packageName) {
+  async getPackageStats(packageNames) {
     if (!this.state.session) return err(new Error("Not logged in"));
-    return getPackageStats(this.requestor, packageName);
+    return getPackageStats(this.requestor, packageNames);
   }
   async getTransports(packageName) {
     if (!this.state.session) return err(new Error("Not logged in"));