catalyst-relay 0.2.4 → 0.3.0

package/dist/index.d.mts

@@ -35,8 +35,12 @@ interface SamlProviderConfig {
  */
 interface SamlAuthConfig {
     type: 'saml';
+    /** SAML username (often an email address) - used for browser login */
     username: string;
+    /** SAML password */
     password: string;
+    /** SAP system username - used for object creation (adtcore:responsible) */
+    sapUser: string;
     /** Optional custom provider configuration for non-standard login forms */
     providerConfig?: SamlProviderConfig;
 }
@@ -288,7 +292,6 @@ interface Transport {
     id: string;
     description: string;
     owner: string;
-    status: 'modifiable' | 'released';
 }
 
 /**
@@ -477,7 +480,7 @@ interface ADTClient {
     upsert(objects: ObjectContent[], packageName: string, transport?: string): AsyncResult<UpsertResult[]>;
     activate(objects: ObjectRef[]): AsyncResult<ActivationResult[]>;
     delete(objects: ObjectRef[], transport?: string): AsyncResult<void>;
-    getPackages(): AsyncResult<Package[]>;
+    getPackages(filter?: string): AsyncResult<Package[]>;
     getTree(query: TreeQuery): AsyncResult<TreeNode[]>;
     getTransports(packageName: string): AsyncResult<Transport[]>;
     previewData(query: PreviewSQL): AsyncResult<DataFrame>;

package/dist/index.d.ts

@@ -35,8 +35,12 @@ interface SamlProviderConfig {
  */
 interface SamlAuthConfig {
     type: 'saml';
+    /** SAML username (often an email address) - used for browser login */
     username: string;
+    /** SAML password */
     password: string;
+    /** SAP system username - used for object creation (adtcore:responsible) */
+    sapUser: string;
     /** Optional custom provider configuration for non-standard login forms */
     providerConfig?: SamlProviderConfig;
 }
@@ -288,7 +292,6 @@ interface Transport {
     id: string;
     description: string;
     owner: string;
-    status: 'modifiable' | 'released';
 }
 
 /**
@@ -477,7 +480,7 @@ interface ADTClient {
     upsert(objects: ObjectContent[], packageName: string, transport?: string): AsyncResult<UpsertResult[]>;
     activate(objects: ObjectRef[]): AsyncResult<ActivationResult[]>;
     delete(objects: ObjectRef[], transport?: string): AsyncResult<void>;
-    getPackages(): AsyncResult<Package[]>;
+    getPackages(filter?: string): AsyncResult<Package[]>;
     getTree(query: TreeQuery): AsyncResult<TreeNode[]>;
     getTransports(packageName: string): AsyncResult<Transport[]>;
     previewData(query: PreviewSQL): AsyncResult<DataFrame>;

package/dist/index.js

@@ -174,6 +174,11 @@ function debugError(message, cause) {
   }
 }
 
+// src/core/utils/content.ts
+function normalizeContent(content) {
+  return content.replace(/\s+/g, " ").trim();
+}
+
 // src/types/config.ts
 var import_zod = require("zod");
 var samlFormSelectorsSchema = import_zod.z.object({
@@ -198,6 +203,7 @@ var clientConfigSchema = import_zod.z.object({
       type: import_zod.z.literal("saml"),
       username: import_zod.z.string().min(1),
       password: import_zod.z.string().min(1),
+      sapUser: import_zod.z.string().min(1),
       providerConfig: samlProviderConfigSchema.optional()
     }),
     import_zod.z.object({
@@ -271,8 +277,9 @@ function getSessionTimeout(authType) {
 function extractUsername(auth) {
   switch (auth.type) {
     case "basic":
-    case "saml":
       return auth.username;
+    case "saml":
+      return auth.sapUser;
     case "sso":
       return process.env["USERNAME"] ?? process.env["USER"] ?? "SSO_USER";
     default: {
@@ -677,6 +684,46 @@ function extractActivationErrors(objects, xml, _extension) {
   return ok(results);
 }
 
+// src/core/adt/discovery/packages.ts
+async function getPackages(client, filter = "*") {
+  const params = new URLSearchParams([
+    ["operation", "quickSearch"],
+    ["query", filter],
+    ["maxResults", "10001"],
+    ["objectType", "DEVC/K"]
+  ]);
+  const [response, requestErr] = await client.request({
+    method: "GET",
+    path: `/sap/bc/adt/repository/informationsystem/search?${params.toString()}`
+  });
+  if (requestErr) {
+    return err(requestErr);
+  }
+  if (!response.ok) {
+    const text2 = await response.text();
+    const errorMsg = extractError(text2);
+    return err(new Error(`Package search failed: ${errorMsg}`));
+  }
+  const text = await response.text();
+  const [doc, parseErr] = safeParseXml(text);
+  if (parseErr) {
+    return err(parseErr);
+  }
+  const packages = [];
+  const objectRefs = doc.getElementsByTagNameNS("http://www.sap.com/adt/core", "objectReference");
+  for (let i = 0; i < objectRefs.length; i++) {
+    const obj = objectRefs[i];
+    if (!obj) return err(new Error("Invalid object reference in package search results"));
+    const name = obj.getAttributeNS("http://www.sap.com/adt/core", "name") || obj.getAttribute("adtcore:name");
+    const description = obj.getAttributeNS("http://www.sap.com/adt/core", "description") || obj.getAttribute("adtcore:description");
+    if (!name) return err(new Error("Package name missing in object reference"));
+    const pkg = { name };
+    if (description) pkg.description = description;
+    packages.push(pkg);
+  }
+  return ok(packages);
+}
+
 // src/core/adt/discovery/tree.ts
 async function getTree(client, query) {
   const internalQuery = {};
@@ -794,32 +841,23 @@ function parseTreeResponse(xml) {
   return ok({ nodes, packages });
 }
 
-// src/core/adt/discovery/packages.ts
-async function getPackages(client) {
-  const [treeResult, treeErr] = await getTreeInternal(client, {}, "*");
-  if (treeErr) {
-    return err(treeErr);
-  }
-  return ok(treeResult.packages);
-}
-
 // src/core/adt/transports/transports.ts
 async function getTransports(client, packageName) {
   const contentType = "application/vnd.sap.as+xml; charset=UTF-8; dataname=com.sap.adt.transport.service.checkData";
   const body = `<?xml version="1.0" encoding="UTF-8"?>
-                    <asx:abap version="1.0" xmlns:asx="http://www.sap.com/abapxml">
-                    <asx:values>
-                        <DATA>
-                        <PGMID></PGMID>
-                        <OBJECT></OBJECT>
-                        <OBJECTNAME></OBJECTNAME>
-                        <DEVCLASS>${packageName}</DEVCLASS>
-                        <SUPER_PACKAGE></SUPER_PACKAGE>
-                        <OPERATION>I</OPERATION>
-                        <URI>/sap/bc/adt/ddic/ddl/sources/transport_check</URI>
-                        </DATA>
-                    </asx:values>
-                    </asx:abap>`;
+<asx:abap version="1.0" xmlns:asx="http://www.sap.com/abapxml">
+  <asx:values>
+    <DATA>
+      <PGMID></PGMID>
+      <OBJECT></OBJECT>
+      <OBJECTNAME></OBJECTNAME>
+      <DEVCLASS>${packageName}</DEVCLASS>
+      <SUPER_PACKAGE></SUPER_PACKAGE>
+      <OPERATION>I</OPERATION>
+      <URI>/sap/bc/adt/ddic/ddl/sources/zsnap_test4transports</URI>
+    </DATA>
+  </asx:values>
+</asx:abap>`;
   const [response, requestErr] = await client.request({
     method: "POST",
     path: "/sap/bc/adt/cts/transportchecks",
@@ -829,44 +867,33 @@ async function getTransports(client, packageName) {
     },
     body
   });
-  if (requestErr) {
-    return err(requestErr);
-  }
+  if (requestErr) return err(requestErr);
   if (!response.ok) {
     const text2 = await response.text();
     const errorMsg = extractError(text2);
-    return err(new Error(`Failed to fetch transports for ${packageName}: ${errorMsg}`));
+    return err(new Error(`Failed to fetch transports for package ${packageName}: ${errorMsg}`));
   }
   const text = await response.text();
   const [transports, parseErr] = extractTransports(text);
-  if (parseErr) {
-    return err(parseErr);
-  }
+  if (parseErr) return err(parseErr);
   return ok(transports);
 }
 function extractTransports(xml) {
   const [doc, parseErr] = safeParseXml(xml);
-  if (parseErr) {
-    return err(parseErr);
-  }
+  if (parseErr) return err(parseErr);
   const transports = [];
   const reqHeaders = doc.getElementsByTagName("REQ_HEADER");
   for (let i = 0; i < reqHeaders.length; i++) {
     const header = reqHeaders[i];
     if (!header) continue;
-    const trkorrElement = header.getElementsByTagName("TRKORR")[0];
-    const userElement = header.getElementsByTagName("AS4USER")[0];
-    const textElement = header.getElementsByTagName("AS4TEXT")[0];
-    if (!trkorrElement || !userElement || !textElement) continue;
-    const id = trkorrElement.textContent;
-    const owner = userElement.textContent;
-    const description = textElement.textContent;
-    if (!id || !owner || !description) continue;
+    const id = header.getElementsByTagName("TRKORR")[0]?.textContent;
+    const owner = header.getElementsByTagName("AS4USER")[0]?.textContent;
+    const description = header.getElementsByTagName("AS4TEXT")[0]?.textContent;
+    if (!id) continue;
     transports.push({
       id,
-      owner,
-      description,
-      status: "modifiable"
+      description: description || "",
+      owner: owner || ""
     });
   }
   return ok(transports);
@@ -1827,11 +1854,22 @@ var SamlAuth = class {
     if (!config.username || !config.password) {
       throw new Error("SamlAuth requires both username and password");
     }
+    if (!config.sapUser) {
+      throw new Error("SamlAuth requires sapUser (SAP system username for object creation)");
+    }
     if (!config.baseUrl) {
       throw new Error("SamlAuth requires baseUrl");
     }
     this.config = config;
   }
+  /**
+   * Get SAP system username
+   *
+   * Used for object creation (adtcore:responsible) instead of the SAML email.
+   */
+  getSapUser() {
+    return this.config.sapUser;
+  }
   /**
    * Get auth headers for SAML
    *
@@ -1895,6 +1933,7 @@ function createAuthStrategy(options) {
       return new SamlAuth({
         username: config.username,
         password: config.password,
+        sapUser: config.sapUser,
         baseUrl,
         ...config.providerConfig && { providerConfig: config.providerConfig }
       });
@@ -2020,6 +2059,9 @@ var ADTClientImpl = class {
     if (this.agent) {
       fetchOptions.dispatcher = this.agent;
     }
+    if (config.insecure) {
+      fetchOptions.tls = { rejectUnauthorized: false };
+    }
     if (body) {
       fetchOptions.body = body;
     }
@@ -2084,6 +2126,13 @@ var ADTClientImpl = class {
         return err(loginErr);
       }
     }
+    if (authStrategy.type === "saml" && authStrategy.getCookies) {
+      const cookies = authStrategy.getCookies();
+      for (const cookie of cookies) {
+        this.state.cookies.set(cookie.name, cookie.value);
+      }
+      debug(`Transferred ${cookies.length} SAML cookies to client`);
+    }
     if (authStrategy.type === "sso" && authStrategy.getCertificates) {
       const certs = authStrategy.getCertificates();
       if (certs) {
@@ -2160,6 +2209,18 @@ var ADTClientImpl = class {
         results.push(result2);
         continue;
       }
+      const serverContent = normalizeContent(existing.content);
+      const localContent = normalizeContent(obj.content);
+      if (serverContent === localContent) {
+        const result2 = {
+          name: obj.name,
+          extension: obj.extension,
+          status: "unchanged"
+        };
+        if (transport) result2.transport = transport;
+        results.push(result2);
+        continue;
+      }
       const [, updateErr] = await this.update(obj, transport);
       if (updateErr) return err(updateErr);
       const result = {
@@ -2190,9 +2251,9 @@ var ADTClientImpl = class {
     return ok(void 0);
   }
   // --- Discovery ---
-  async getPackages() {
+  async getPackages(filter) {
     if (!this.state.session) return err(new Error("Not logged in"));
-    return getPackages(this.requestor);
+    return getPackages(this.requestor, filter);
   }
   async getTree(query) {
     if (!this.state.session) return err(new Error("Not logged in"));