cassproject 5.0.20 → 5.0.23

package/src/org/cass/importer/TabStructuredImport.js

@@ -68,9 +68,9 @@ module.exports = class TabStructuredImport {
 			}
 		}
 		let c = null;
-		for (let i = 0; i < competencies.length; i++) {
-			if (competencies[i].getName().trim() == lines[index].trim()) {
-				c = competencies[i];
+		for (let competency of competencies) {
+			if (competency.getName().trim() == lines[index].trim()) {
+				c = competency;
 				break;
 			}
 		}
@@ -86,9 +86,9 @@ module.exports = class TabStructuredImport {
 		}
 		if (parentI != -1) {
 			let parent = null;
-			for (let i = 0; i < competencies.length; i++) {
-				if (competencies[i].getName().trim() == lines[parentI].trim()) {
-					parent = competencies[i];
+			for (let competency of competencies) {
+				if (competency.getName().trim() == lines[parentI].trim()) {
+					parent = competency;
 					break;
 				}
 			}

package/src/org/cass/profile/EcAssertion.js

@@ -19,20 +19,15 @@ module.exports = class EcAssertion extends Assertion {
 	async decrypt(eim) {
 		eim = eim || EcIdentityManager.default;
 		let a = new Assertion().copyFrom(this);
-		let subject = this.getSubject(eim);
-		let agent = this.getAgent(eim);
-		let assertionDate = this.getAssertionDate(eim);
-		let expirationDate = this.getExpirationDate(eim);
-		let evidences = this.getEvidences(eim);
-		let negative = this.getNegative(eim);
-		let decayFunction = this.getDecayFunction(eim);
-		subject = await subject;
-		agent = await agent;
-		assertionDate = await assertionDate;
-		expirationDate = await expirationDate;
-		evidences = await evidences;
-		negative = await negative;
-		decayFunction = await decayFunction;
+		const [subject, agent, assertionDate, expirationDate, evidences, negative, decayFunction] = await Promise.all([
+			this.getSubject(eim),
+			this.getAgent(eim),
+			this.getAssertionDate(eim),
+			this.getExpirationDate(eim),
+			this.getEvidences(eim),
+			this.getNegative(eim),
+			this.getDecayFunction(eim)
+		]);
 		if (subject)
 			a.setSubject(subject);
 		if (agent)
@@ -95,13 +90,13 @@ module.exports = class EcAssertion extends Assertion {
 	 *
 	 *  @param pk
 	 */
-	async setSubject(pk) {
+	async setSubject(pk) { // NOSONAR - Encrypts asynchronously; making Assertion's setters async would turn their errors into rejections
 		let owners = [];
 		let readers = null;
 		if (this.reader == null) 
 			readers = [];
 		else 
-			readers = JSON.parse(JSON.stringify(this.reader));
+			readers = JSON.parse(JSON.stringify(this.reader)); // NOSONAR - structuredClone throws on Proxy-wrapped arrays (e.g. Vue reactive state); the JSON round trip does not.
 		if (this.subject != null) {
 			if (this.subject.owner != null) 
 				owners = owners.concat(this.subject.owner);
@@ -119,13 +114,12 @@ module.exports = class EcAssertion extends Assertion {
 	}
 	// @deprecated
 	setSubjectAsync(pk, success, failure) {
-		let me = this;
 		let owners = [];
 		let readers = null;
 		if (this.reader == null) 
 			readers = [];
 		else 
-			readers = JSON.parse(JSON.stringify(this.reader));
+			readers = JSON.parse(JSON.stringify(this.reader)); // NOSONAR - structuredClone throws on Proxy-wrapped arrays (e.g. Vue reactive state); the JSON round trip does not.
 		if (this.subject != null) {
 			if (this.subject.owner != null) 
 				owners = owners.concat(this.subject.owner);
@@ -139,8 +133,8 @@ module.exports = class EcAssertion extends Assertion {
 			this.id,
 			owners,
 			readers,
-			function (subject) {
-				me.subject = subject;
+			(subject) => {
+				this.subject = subject;
 				success();
 			},
 			failure
@@ -188,7 +182,7 @@ module.exports = class EcAssertion extends Assertion {
 		if (decryptedString == null) return null;
 		return EcPk.fromPem(decryptedString);
 	}
-	async setAgent(pk) {
+	async setAgent(pk) { // NOSONAR - Encrypts asynchronously; making Assertion's setters async would turn their errors into rejections
 		this.agent = await EcEncryptedValue.encryptValue(
 			pk.toPem(),
 			this.id,
@@ -198,14 +192,13 @@ module.exports = class EcAssertion extends Assertion {
 	}
 	// @deprecated
 	setAgentAsync(pk, success, failure) {
-		let me = this;
 		return EcEncryptedValue.encryptValueAsync(
 			pk.toPem(),
 			this.id,
 			this.subject.owner,
 			this.subject.reader,
-			function (agent) {
-				me.agent = agent;
+			(agent) => {
+				this.agent = agent;
 				success();
 			},
 			failure
@@ -295,9 +288,9 @@ module.exports = class EcAssertion extends Assertion {
 				.catch((error) => null);
 		}
 		if (decryptedString == null) return null;
-		return parseInt(decryptedString);
+		return Number.parseInt(decryptedString);
 	}
-	async setAssertionDate(assertionDateMs) {
+	async setAssertionDate(assertionDateMs) { // NOSONAR - Encrypts asynchronously; making Assertion's setters async would turn their errors into rejections
 		this.assertionDate = await EcEncryptedValue.encryptValue(
 			assertionDateMs.toString(),
 			this.id,
@@ -307,14 +300,13 @@ module.exports = class EcAssertion extends Assertion {
 	}
 	// @deprecated
 	setAssertionDateAsync(assertionDateMs, success, failure) {
-		let me = this;
 		return EcEncryptedValue.encryptValueAsync(
 			assertionDateMs.toString(),
 			this.id,
 			this.subject.owner,
 			this.subject.reader,
-			function (assertionDate) {
-				me.assertionDate = assertionDate;
+			(assertionDate) => {
+				this.assertionDate = assertionDate;
 				success();
 			},
 			failure
@@ -331,7 +323,7 @@ module.exports = class EcAssertion extends Assertion {
 		let decrypted = function (decryptedString) {
 			if (decryptedString == null)
 				failure("Could not decrypt assertion date.");
-			else success(parseInt(decryptedString));
+			else success(Number.parseInt(decryptedString));
 		};
 		let codebook = Assertion.getCodebook(this);
 		if (codebook != null)
@@ -358,9 +350,9 @@ module.exports = class EcAssertion extends Assertion {
 				.catch((error) => null);
 		}
 		if (decryptedString == null) return null;
-		return parseInt(decryptedString);
+		return Number.parseInt(decryptedString);
 	}
-	async setExpirationDate(expirationDateMs) {
+	async setExpirationDate(expirationDateMs) { // NOSONAR - Encrypts asynchronously; making Assertion's setters async would turn their errors into rejections
 		this.expirationDate = await EcEncryptedValue.encryptValue(
 			expirationDateMs.toString(),
 			this.id,
@@ -370,14 +362,13 @@ module.exports = class EcAssertion extends Assertion {
 	}
 	// @deprecated
 	setExpirationDateAsync(expirationDateMs, success, failure) {
-		let me = this;
 		return EcEncryptedValue.encryptValueAsync(
 			expirationDateMs.toString(),
 			this.id,
 			this.subject.owner,
 			this.subject.reader,
-			function (expirationDate) {
-				me.expirationDate = expirationDate;
+			(expirationDate) => {
+				this.expirationDate = expirationDate;
 				success();
 			},
 			failure
@@ -394,7 +385,7 @@ module.exports = class EcAssertion extends Assertion {
 		let decrypted = function (decryptedString) {
 			if (decryptedString == null)
 				failure("Could not decrypt expiration date.");
-			else success(parseInt(decryptedString));
+			else success(Number.parseInt(decryptedString));
 		};
 		let codebook = Assertion.getCodebook(this);
 		if (codebook != null)
@@ -498,7 +489,7 @@ module.exports = class EcAssertion extends Assertion {
 		if (decryptedString == null) return null;
 		return decryptedString;
 	}
-	async setDecayFunction(decayFunctionText) {
+	async setDecayFunction(decayFunctionText) { // NOSONAR - Encrypts asynchronously; making Assertion's setters async would turn their errors into rejections
 		this.decayFunction = await EcEncryptedValue.encryptValue(
 			decayFunctionText.toString(),
 			this.id,
@@ -508,14 +499,13 @@ module.exports = class EcAssertion extends Assertion {
 	}
 	// @deprecated
 	setDecayFunctionAsync(decayFunctionText, success, failure) {
-		let me = this;
 		return EcEncryptedValue.encryptValueAsync(
 			decayFunctionText,
 			this.id,
 			this.subject.owner,
 			this.subject.reader,
-			function (decayFunction) {
-				me.decayFunction = decayFunction;
+			(decayFunction) => {
+				this.decayFunction = decayFunction;
 				success();
 			},
 			failure
@@ -561,7 +551,7 @@ module.exports = class EcAssertion extends Assertion {
 		if (decryptedString != null) decryptedString.toLowerCase();
 		return "true" == decryptedString;
 	}
-	async setNegative(negativeB) {
+	async setNegative(negativeB) { // NOSONAR - Encrypts asynchronously; making Assertion's setters async would turn their errors into rejections
 		this.negative = await EcEncryptedValue.encryptValue(
 			negativeB.toString(),
 			this.id,
@@ -571,14 +561,13 @@ module.exports = class EcAssertion extends Assertion {
 	}
 	// @deprecated
 	setNegativeAsync(negativeB, success, failure) {
-		let me = this;
 		return EcEncryptedValue.encryptValueAsync(
 			negativeB.toString(),
 			this.id,
 			this.subject.owner,
 			this.subject.reader,
-			function (negative) {
-				me.negative = negative;
+			(negative) => {
+				this.negative = negative;
 				success();
 			},
 			failure
@@ -619,12 +608,12 @@ module.exports = class EcAssertion extends Assertion {
 	setConfidence(confidenceZeroToOne) {
 		this.confidence = confidenceZeroToOne;
 	}
-	async setEvidence(evidences) {
+	async setEvidence(evidences) { // NOSONAR - Encrypts asynchronously; making Assertion's setters async would turn their errors into rejections
 		let encryptedValues = [];
-		for (let i = 0; i < evidences.length; i++)
+		for (let evidence of evidences)
 			encryptedValues.push(
 				await EcEncryptedValue.encryptValue(
-					evidences[i],
+					evidence,
 					this.id,
 					this.subject.owner,
 					this.subject.reader
@@ -690,8 +679,8 @@ module.exports = class EcAssertion extends Assertion {
 			await this.decayFunction.addReader(newReader, eim);
 		}
 		if (this.evidence != null)
-			for (let i = 0; i < this.evidence.length; i++) {
-				await this.evidence[i].addReader(newReader, eim);
+			for (let evidence of this.evidence) {
+				await evidence.addReader(newReader, eim);
 			}
 		if (this.expirationDate != null) {
 			await this.expirationDate.addReader(newReader, eim);
@@ -715,8 +704,8 @@ module.exports = class EcAssertion extends Assertion {
 			await this.decayFunction.removeReader(newReader, eim);
 		}
 		if (this.evidence != null)
-			for (let i = 0; i < this.evidence.length; i++) {
-				await this.evidence[i].removeReader(newReader, eim);
+			for (let evidence of this.evidence) {
+				await evidence.removeReader(newReader, eim);
 			}
 		if (this.expirationDate != null) {
 			await this.expirationDate.removeReader(newReader, eim);

package/src/org/cassproject/ebac/identity/EcContactGrant.js

@@ -19,10 +19,10 @@ module.exports = class EcContactGrant extends EbacContactGrant {
 		if (!this.verify()) return false;
 		if (this.invalid()) return false;
 		let found = false;
-		for (let i = 0; i < eim.ids.length; i++) {
+		for (const id of eim.ids) {
 			if (
 				EcRsaOaep.verify(
-					eim.ids[i].ppk.toPk(),
+					id.ppk.toPk(),
 					this.responseToken,
 					this.responseSignature
 				)

package/src/org/cassproject/ebac/identity/EcIdentityManager.js

@@ -4,7 +4,7 @@ const EcPpkFacade = require("../../../../com/eduworks/ec/crypto/EcPpkFacade");
 const EcRsaOaepAsyncWorker = require("../../../../com/eduworks/ec/crypto/EcRsaOaepAsyncWorker");
 const {cassReturnAsPromise, cassPromisify} = require("../../../../com/eduworks/ec/promises/helpers");
 const EbacSignature = require("../../../../com/eduworks/schema/ebac/EbacSignature");
-let realCrypto = require('crypto');
+let realCrypto = require('crypto'); // NOSONAR - Bare specifier on purpose: browser bundlers polyfill "crypto", but webpack rejects "node:" URIs.
 
 /**
  *  Manages identities and contacts, provides hooks to respond to identity and
@@ -20,8 +20,6 @@ let realCrypto = require('crypto');
  */
 module.exports = class EcIdentityManager {
 	static default = new this();
-	constructor() {
-	}
 	eimId = EcCrypto.generateUUID();
 	/**
 	 *  The current user's owned identities (keys+displayName)
@@ -97,17 +95,16 @@ module.exports = class EcIdentityManager {
 			return;
 		}
 		let c = JSON.parse(localStore);
-		for (let i = 0; i < c.length; i++) {
+		for (const o of c) {
 			let contact = new EcContact();
-			let o = c[i];
 			let props = o;
 			contact.displayName = props["displayName"];
 			contact.pk = EcPk.fromPem(props["pk"]);
 			contact.source = props["source"];
 			let cont = false;
-			for (let j = 0; j < this.contacts.length; j++) {
+			for (const existing of this.contacts) {
 				if (
-					this.contacts[j].pk.toPem() ==
+					existing.pk.toPem() ==
 					contact.pk.toPem()
 				) {
 					cont = true;
@@ -128,10 +125,9 @@ module.exports = class EcIdentityManager {
 	 */
 	saveContacts() {
 		let c = [];
-		for (let i = 0; i < this.contacts.length; i++) {
+		for (const contact of this.contacts) {
 			let o = {};
 			let props = o;
-			let contact = this.contacts[i];
 			props["displayName"] = contact.displayName;
 			props["pk"] = contact.pk.toPem();
 			props["source"] = contact.source;
@@ -153,17 +149,16 @@ module.exports = class EcIdentityManager {
 			return;
 		}
 		let c = JSON.parse(localStore);
-		for (let i = 0; i < c.length; i++) {
+		for (const o of c) {
 			let identity = new EcIdentity();
-			let o = c[i];
 			let props = o;
 			identity.displayName = props["displayName"];
 			identity.ppk = EcPpk.fromPem(props["ppk"]);
 			identity.source = props["source"];
 			let cont = false;
-			for (let j = 0; j < this.ids.length; j++) {
+			for (const existing of this.ids) {
 				if (
-					this.ids[j].ppk.toPem() == identity.ppk.toPem()
+					existing.ppk.toPem() == identity.ppk.toPem()
 				) {
 					cont = true;
 				}
@@ -183,10 +178,9 @@ module.exports = class EcIdentityManager {
 	 */
 	saveIdentities() {
 		let c = [];
-		for (let i = 0; i < this.ids.length; i++) {
+		for (const identity of this.ids) {
 			let o = {};
 			let props = o;
-			let identity = this.ids[i];
 			props["displayName"] = identity.displayName;
 			props["ppk"] = identity.ppk.toPem();
 			props["source"] = identity.source;
@@ -229,8 +223,8 @@ module.exports = class EcIdentityManager {
 	 *  @static
 	 */
 	addIdentity(identity) {
-		for (let i = 0; i < this.ids.length; i++) {
-			if (this.ids[i].equals(identity)) {
+		for (const id of this.ids) {
+			if (id.equals(identity)) {
 				return;
 			}
 		}
@@ -247,8 +241,8 @@ module.exports = class EcIdentityManager {
 	 *  @static
 	 */
 	addIdentityQuietly(identity) {
-		for (let i = 0; i < this.ids.length; i++) {
-			if (this.ids[i].equals(identity)) {
+		for (const id of this.ids) {
+			if (id.equals(identity)) {
 				return;
 			}
 		}
@@ -264,29 +258,29 @@ module.exports = class EcIdentityManager {
 	 *  @static
 	 */
 	addContact(contact) {
-		for (let i = 0; i < this.ids.length; i++) {
+		for (const id of this.ids) {
 			if (
-				this.ids[i].ppk
+				id.ppk
 					.toPk()
 					.toPem()
 					.equals(contact.pk.toPem())
 			) {
-				this.ids[i].displayName = contact.displayName;
-				this.identityChanged(this.ids[i]);
+				id.displayName = contact.displayName;
+				this.identityChanged(id);
 			}
 		}
-		for (let i = 0; i < this.contacts.length; i++) {
+		for (const existing of this.contacts) {
 			if (
-				this.contacts[i].pk
+				existing.pk
 					.toPem()
 					.equals(contact.pk.toPem())
 			) {
-				this.contacts[i].displayName = contact.displayName;
-				this.contactChanged(this.contacts[i]);
+				existing.displayName = contact.displayName;
+				this.contactChanged(existing);
 			}
 		}
-		for (let i = 0; i < this.contacts.length; i++) {
-			if (this.contacts[i].equals(contact)) {
+		for (const existing of this.contacts) {
+			if (existing.equals(contact)) {
 				return;
 			}
 		}
@@ -303,27 +297,27 @@ module.exports = class EcIdentityManager {
 	 *  @static
 	 */
 	addContactQuietly(contact) {
-		for (let i = 0; i < this.ids.length; i++) {
+		for (const id of this.ids) {
 			if (
-				this.ids[i].ppk
+				id.ppk
 					.toPk()
 					.toPem()
 					.equals(contact.pk.toPem())
 			) {
-				this.ids[i].displayName = contact.displayName;
+				id.displayName = contact.displayName;
 			}
 		}
-		for (let i = 0; i < this.contacts.length; i++) {
+		for (const existing of this.contacts) {
 			if (
-				this.contacts[i].pk
+				existing.pk
 					.toPem()
 					.equals(contact.pk.toPem())
 			) {
-				this.contacts[i].displayName = contact.displayName;
+				existing.displayName = contact.displayName;
 			}
 		}
-		for (let i = 0; i < this.contacts.length; i++) {
-			if (this.contacts[i].equals(contact)) {
+		for (const existing of this.contacts) {
+			if (existing.equals(contact)) {
 				return;
 			}
 		}
@@ -356,7 +350,7 @@ module.exports = class EcIdentityManager {
 		if (this.signatureSheetCaching) {
 			cache = this.signatureSheetCache[server];
 			if (cache != null) {
-				if (cache[0] > new Date().getTime() + duration) {
+				if (cache[0] > Date.now() + duration) {
 					return cassReturnAsPromise(cache[1], success, failure);
 				}
 			}
@@ -371,12 +365,12 @@ module.exports = class EcIdentityManager {
 			);
 		let p = Promise.all(promises);
 		p = p.then((signatureCandidates) => {
-			let signatures = signatureCandidates.filter(x=>x);
+			let signatures = signatureCandidates.filter(Boolean);
 			let cache = null;
 			let stringified = JSON.stringify(signatures);
 			if (this.signatureSheetCaching) {
 				cache = [];
-				cache[0] = new Date().getTime() + finalDuration;
+				cache[0] = Date.now() + finalDuration;
 				cache[1] = stringified;
 				this.signatureSheetCache[server] = cache;
 			}
@@ -401,7 +395,7 @@ module.exports = class EcIdentityManager {
 		if (this.signatureSheetCaching) {
 			cache = this.signatureSheetCache[server];
 			if (cache != null) {
-				if (cache[0] > new Date().getTime() + duration) {
+				if (cache[0] > Date.now() + duration) {
 					return cassReturnAsPromise(cache[1], success, failure);
 				}
 			}
@@ -413,12 +407,12 @@ module.exports = class EcIdentityManager {
 		);
 		let p = Promise.all(promises);
 		p = p.then((signatureCandidates) => {
-			let signatures = signatureCandidates.filter(x=>x);
+			let signatures = signatureCandidates.filter(Boolean);
 			let stringified = JSON.stringify(signatures);
 			if (this.signatureSheetCaching) {
 				let cache = null;
 				cache = [];
-				cache[0] = new Date().getTime() + finalDuration;
+				cache[0] = Date.now() + finalDuration;
 				cache[1] = stringified;
 				this.signatureSheetCache[server] = cache;
 			}
@@ -440,7 +434,7 @@ module.exports = class EcIdentityManager {
 	 *  @static
 	 */
 	createSignature(duration, server, ppk, algorithm) {
-		if (typeof process !== 'undefined' && process && process.env && process.env.FIPS == null && realCrypto.getFips && realCrypto.getFips() == 1)
+		if (typeof process !== 'undefined' && process?.env && process.env.FIPS == null && realCrypto.getFips?.() == 1)
 		{
 			algorithm = "SHA-256";
 		}
@@ -448,7 +442,7 @@ module.exports = class EcIdentityManager {
 			return null;
 		}
 		let s = new EbacSignature();
-		s.expiry = new Date().getTime() + duration;
+		s.expiry = Date.now() + duration;
 		s.server = server;
 		delete s.owner;
 		delete s.signature;
@@ -475,9 +469,9 @@ module.exports = class EcIdentityManager {
 	 */
 	getPpk(fromPem) {
 		let pem = fromPem.toPem();
-		for (let i = 0; i < this.ids.length; i++) {
-			if (pem == this.ids[i].ppk.toPk().toPem()) {
-				return this.ids[i].ppk;
+		for (const id of this.ids) {
+			if (pem == id.ppk.toPk().toPem()) {
+				return id.ppk;
 			}
 		}
 		return null;
@@ -492,9 +486,9 @@ module.exports = class EcIdentityManager {
 	 *  @static
 	 */
 	getContact(pk) {
-		for (let i = 0; i < this.contacts.length; i++) {
-			if (pk.equals(this.contacts[i].pk)) {
-				return this.contacts[i];
+		for (const contact of this.contacts) {
+			if (pk.equals(contact.pk)) {
+				return contact;
 			}
 		}
 		return null;
@@ -509,9 +503,9 @@ module.exports = class EcIdentityManager {
 	 *  @static
 	 */
 	getIdentity(pk) {
-		for (let i = 0; i < this.ids.length; i++) {
-			if (pk.equals(this.ids[i].ppk.toPk())) {
-				return this.ids[i];
+		for (const id of this.ids) {
+			if (pk.equals(id.ppk.toPk())) {
+				return id;
 			}
 		}
 		return null;
@@ -527,9 +521,9 @@ module.exports = class EcIdentityManager {
 	async sign(d) {
 		let promises = [];
 		if (d.owner != null) {
-			for (let i = 0; i < d.owner.length; i++) {
+			for (const owner of d.owner) {
 				let attempt = this.getPpk(
-					EcPk.fromPem(d.owner[i])
+					EcPk.fromPem(owner)
 				);
 				if (attempt != null) {
 					promises.push(d.signWith(attempt));
@@ -537,8 +531,8 @@ module.exports = class EcIdentityManager {
 			}
 		}
 		return Promise.all(promises).then((signatures) => {
-			d.signatureSha256 = signatures.filter(x=>x);
-			if (d.signatureSha256 != null && d.signatureSha256.length == 0) {
+			d.signatureSha256 = signatures.filter(Boolean);
+			if (d.signatureSha256?.length == 0) {
 				delete d["signatureSha256"];
 				delete d["signature"];
 			}
@@ -552,12 +546,12 @@ module.exports = class EcIdentityManager {
 				searchString += " OR ";
 			}
 			searchString +=
-				'\\*reader:"' +
+				String.raw`\*reader:"` +
 				this.ids[i].ppk.toPk().toPem() +
 				'"';
 			searchString += " OR ";
 			searchString +=
-				'\\*owner:"' +
+				String.raw`\*owner:"` +
 				this.ids[i].ppk.toPk().toPem() +
 				'"';
 		}
@@ -566,8 +560,8 @@ module.exports = class EcIdentityManager {
 	getMyPks() {
 		let pks = [];
 		if (this.ids == null) return pks;
-		for (let i = 0; i < this.ids.length; i++)
-			pks.push(this.ids[i].ppk.toPk());
+		for (const id of this.ids)
+			pks.push(id.ppk.toPk());
 		return pks;
 	}
 };

package/src/org/cassproject/ebac/identity/EcRekeyRequest.js

@@ -91,15 +91,16 @@ module.exports = class EcRekeyRequest extends EcRemoteLinkedData {
 	 */
 	async verify() {
 		if (!await super.verify()) return false;
+		//Compare to true: the browser worker resolves to an {error} object, not false, when a signature is malformed.
 		return (await EcRsaOaepAsyncWorker.verifySha256(
 			EcPk.fromPem(this.rekeyPk),
 			this.toSignableRekeyJson(),
 			this.rekeySignature
-		) || (await EcRsaOaepAsyncWorker.verify(
+		)) === true || (await EcRsaOaepAsyncWorker.verify(
 			EcPk.fromPem(this.rekeyPk),
 			this.toSignableRekeyJson(),
 			this.rekeySignature
-		)));
+		)) === true;
 	}
 	async addRekeyRequestToForwardingTable() {
 		if (!(await this.verify())) return;