cartethyia 2.4.6 → 2.5.1

package/src/providers/integrations/buddy/buddy-conversation-headers.ts

@@ -89,10 +89,23 @@ export function buddyConversationHeaders(
     "x-b3-spanid": messageId.slice(0, 16),
     "x-b3-sampled": "1",
   };
-  // Only when the client actually gave one: inventing a conversation id makes
-  // the upstream build a session the caller never had.
-  if (ids.conversationId !== undefined && ids.conversationId.trim().length > 0) {
-    headers["x-conversation-id"] = ids.conversationId.trim();
-  }
+  // Always sent, invented when the caller gave none.
+  //
+  // This used to be omitted unless the client supplied one. That was wrong:
+  // `x-conversation-id` is mandatory, and a chat request without it is refused
+  // with `400 · 11-128 "request illegal"` — an error that names neither the
+  // header nor the channel, and which reads like a block rather than a missing
+  // field. Isolated against the live API by removing one header at a time:
+  // only `x-conversation-id`, `x-conversation-request-id` and
+  // `x-conversation-message-id` are required; the B3/W3C trace set, the
+  // stainless set, the agent block and the IDE block are all optional.
+  //
+  // Inventing one when the caller has none is still the right default: the id
+  // is per-dispatch here, so a caller with no session is not claiming a session
+  // it never had — and withholding the header only guarantees a refusal.
+  headers["x-conversation-id"] =
+    ids.conversationId !== undefined && ids.conversationId.trim().length > 0
+      ? ids.conversationId.trim()
+      : newMessageId();
   return headers;
 }

package/src/providers/integrations/buddy/codebuddy/cn-provider.ts

@@ -106,6 +106,10 @@ export const CODEBUDDY_CN_RAW: readonly BuddyRawEntry[] = [
   ["glm-5.3-flash", "GLM 5.3 Flash", true, true, 1_000_000, 131_072],
   ["glm-5v-turbo", "GLM 5v Turbo", true, true, 200_000, 131_072],
   ["minimax-m3", "MiniMax M3", true, true, 512_000, 512_000],
+  // 1M context, reasoning always on (upstream states both); vision inherited
+  // from the M3 row, which is the same family.
+  ["minimax-m3.1-flash", "MiniMax M3.1 Flash", true, true, 1_000_000, 512_000],
+  ["mimo-v2.6-pro", "MiMo V2.6 Pro", true, true, 1_000_000, 512_000],
   ["kimi-k2.8-preview", "Kimi K2.8 Preview", true, true, 1_048_576, 65_536],
   ["kimi-k2.7", "Kimi K2.7", true, true, 256_000, 65_536],
   ["kimi-k2.6", "Kimi K2.6", true, true, 256_000, 262_144],

package/src/providers/integrations/buddy/codebuddy/provider.ts

@@ -1,175 +1,180 @@
-// CodeBuddy International adapter — exact provider contract.
-// Canonical provider ID: cb
-// Base (manifest-owned CODEBUDDY_BASE_URL) → Chat: base + /chat/completions
-// Auth: Authorization Bearer for both api_key and oauth
-// Stream: force stream=true upstream, factory reaggregates for non-stream callers
-// Headers: per-provider CodeBuddy headers with fresh correlation IDs per dispatch
-// Payload: leading CodeBuddy system prompt + typed user content, reasoning_summary auto only when reasoning_effort
-
-import { BuddyMediaAdapter } from "../buddy-media";
-import type { ProviderDispatchContext, ProviderDispatchTarget, ProviderAdapter } from "../../../provider-contracts";
-import type { ModelDefinition } from "../../../provider-model-definition";
-import type { DiscoveryInput } from "../../../discovery/discovery-types";
-import { GatewayError } from "../../../../protocol/gateway-error";
-import type { CanonicalRequest } from "../../../../protocol/canonical-model";
-import { providerBaseUrl } from "../../../provider-metadata";
-import {
-  codebuddyAdapterConfig,
-} from "./shared";
-import {
-  BUDDY_SHARED_RAW,
-  BUDDY_IMAGE_MODEL_ID_SET,
-  BUDDY_VIDEO_MODEL_ID_SET,
-  makeBuddyModel,
-  makeBuddyImageModels,
-  makeBuddyVideoModels,
-  type BuddyRawEntry,
-} from "../buddy-catalog-shared";
-import { BUDDY_INTL_MODELS_PATH, fetchBuddyDirectoryModels } from "../buddy-discovery-shared";
-import {
-  applyBuddySystemPrompt,
-  buddyPrePayloadCommon,
-  normalizeBuddyToolNames,
-} from "../buddy-chat-shared";
-
-
-// Constants — public contract
-export const CODEBUDDY_PROVIDER_ID = "cb" as const;
-export const CODEBUDDY_BASE_URL = providerBaseUrl("cb");
-// Upstream model translation — preserve provider mapping
-
-// Payload hook — provider intl semantics
-// - force stream=true
-// - reasoning_summary auto only when reasoning_effort requested
-// - upstreamId translation
-// - leading CodeBuddy system prompt + typed user content normalization
-
-/**
- * Leading system turn for this variant.
- *
- * The upstream validates that the wire *opens* with a `system` turn (code
- * `11128`) but does not check its text — the CN variant installs a plain
- * engineering-assistant sentence in the same slot and the gateway accepts it.
- * So this text is a product choice rather than a wire contract, and the
- * previous vendor-branded line ("You are CodeBuddy Code.") made every request
- * claim an identity the caller never chose, while also discarding whatever
- * system prompt the caller actually sent.
- *
- * The prompt is therefore a neutral assistant identity with an explicit
- * persona: pragmatic, direct, and honest — no sycophancy, no hedging, no
- * invented certainty.
- */
-export const CODEBUDDY_SYSTEM_PROMPT =
-  "You are a pragmatic and direct software engineering assistant. " +
-  "Be honest and truthful: state what you know, say plainly when you are unsure " +
-  "or do not know, and never claim to have done something you have not done. " +
-  "Prefer concrete answers over filler, and say so when a request is ambiguous " +
-  "instead of guessing silently.";
-
-function codeBuddyIntlPrePayload(
-  payload: Record<string, unknown>,
-  request: CanonicalRequest,
-  candidate: ProviderDispatchTarget,
-  context?: ProviderDispatchContext,
-): void {
-  // International ladder: DeepSeek Flash and friends serve only `high`.
-  buddyPrePayloadCommon(payload, request, "intl", context);
-  const rawModel = payload["model"];
-  const source =
-    typeof rawModel === "string" && rawModel.length > 0
-      ? rawModel
-      : candidate.model_id;
-  if (!source) throw new GatewayError("invalid_request", 400, "CodeBuddy model is required");
-  const messages = payload["messages"];
-  if (Array.isArray(messages)) {
-    applyBuddySystemPrompt(messages as Array<Record<string, unknown>>, CODEBUDDY_SYSTEM_PROMPT);
-  }
-  normalizeBuddyToolNames(payload);
-  void request;
-}
-
-// Model catalog — shared CodeBuddy / WorkBuddy international roster
-
-const CODEBUDDY_INTL_RAW: readonly BuddyRawEntry[] = BUDDY_SHARED_RAW;
-
-/**
- * CodeBuddy's image generation rows.
- *
- * These ids also sit on the shared chat roster as ordinary `llm` rows, which is
- * why they were unreachable as image models: nothing downstream could tell a
- * chat model from one that returns an image, so `mediaGeneration` was false for
- * every catalog row. The roster and the declared capabilities come from
- * {@link makeBuddyImageModels} so cb and WorkBuddy cannot drift.
- */
-export const CODEBUDDY_IMAGE_MODELS: readonly ModelDefinition[] = makeBuddyImageModels(
-  "cb",
-  "/images/generations",
-);
-
-/**
- * CodeBuddy's video-generation rows (`seedance-2.5`).
- *
- * Reached through `/videos/generations` on the `/v2` base, so the endpoint is
- * the upstream video path rather than a chat-completions path.
- */
-export const CODEBUDDY_VIDEO_MODELS: readonly ModelDefinition[] = makeBuddyVideoModels(
-  "cb",
-  "/videos/generations",
-);
-
-/**
- * The full cb catalog the registry loads: chat roster plus image and video rows.
- *
- * The image and video ids are filtered out of the chat pass so one id never
- * appears under two service kinds. Exported as a single list so
- * `default-registry.ts` keeps one import for this provider.
- */
-export const CODEBUDDY_MODELS: readonly ModelDefinition[] = [
-  ...CODEBUDDY_INTL_RAW.filter(
-    (entry) => !BUDDY_IMAGE_MODEL_ID_SET.has(entry[0]) && !BUDDY_VIDEO_MODEL_ID_SET.has(entry[0]),
-  ).map((entry) => makeBuddyModel(entry, "cb")),
-  ...CODEBUDDY_IMAGE_MODELS,
-  ...CODEBUDDY_VIDEO_MODELS,
-];
-
-/**
- * Reads the CodeBuddy intl console directory.
- *
- * The static `CODEBUDDY_MODELS` above stays the fallback — this console is
- * documented to answer 500 intermittently — while discovery carries the
- * upstream's own limits and capability flags.
- */
-export async function discoverCodeBuddyModels(
-  input: DiscoveryInput,
-): Promise<readonly ModelDefinition[] | null> {
-  return fetchBuddyDirectoryModels({
-    siteUrl: CODEBUDDY_BASE_URL,
-    providerId: CODEBUDDY_PROVIDER_ID,
-    credential: input.credential,
-    modelsPath: BUDDY_INTL_MODELS_PATH,
-    endpoint: undefined,
-    ...(input.signal ? { signal: input.signal } : {}),
-    ...(input.fetcher ? { fetcher: input.fetcher } : {}),
-  });
-}
-
-// Public factory — uses OpenAI-compatible factory but forces provider semantics
-// Supports both api_key and oauth via Authorization Bearer (factory handles both)
-
-export function createCodeBuddyAdapter(fetchImpl?: typeof fetch): ProviderAdapter {
-  return new BuddyMediaAdapter(
-    codebuddyAdapterConfig({
-      providerId: CODEBUDDY_PROVIDER_ID,
-      baseUrl: CODEBUDDY_BASE_URL,
-      variant: "IDE",
-      prePayload: codeBuddyIntlPrePayload,
-      ...(fetchImpl ? { fetchImpl } : {}),
-    }),
-    {
-      variant: "IDE",
-      systemPrompt: CODEBUDDY_SYSTEM_PROMPT,
-      baseUrl: CODEBUDDY_BASE_URL,
-      imageGenerationPath: "/images/generations",
-    },
-  );
-}
+// CodeBuddy International adapter — exact provider contract.
+// Canonical provider ID: cb
+// Base (manifest-owned CODEBUDDY_BASE_URL) → Chat: base + /chat/completions
+// Auth: Authorization Bearer for both api_key and oauth
+// Stream: force stream=true upstream, factory reaggregates for non-stream callers
+// Headers: per-provider CodeBuddy headers with fresh correlation IDs per dispatch
+// Payload: leading CodeBuddy system prompt + typed user content, reasoning_summary auto only when reasoning_effort
+
+import { BuddyMediaAdapter } from "../buddy-media";
+import type { ProviderDispatchContext, ProviderDispatchTarget, ProviderAdapter } from "../../../provider-contracts";
+import type { ModelDefinition } from "../../../provider-model-definition";
+import type { DiscoveryInput } from "../../../discovery/discovery-types";
+import { GatewayError } from "../../../../protocol/gateway-error";
+import type { CanonicalRequest } from "../../../../protocol/canonical-model";
+import { providerBaseUrl } from "../../../provider-metadata";
+import {
+  codebuddyAdapterConfig,
+  codebuddyHeaders,
+} from "./shared";
+import {
+  BUDDY_SHARED_RAW,
+  BUDDY_IMAGE_MODEL_ID_SET,
+  BUDDY_VIDEO_MODEL_ID_SET,
+  makeBuddyModel,
+  makeBuddyImageModels,
+  makeBuddyVideoModels,
+  type BuddyRawEntry,
+} from "../buddy-catalog-shared";
+import { BUDDY_INTL_MODELS_PATH, fetchBuddyDirectoryModels } from "../buddy-discovery-shared";
+import {
+  applyBuddySystemPrompt,
+  buddyPrePayloadCommon,
+  normalizeBuddyToolNames,
+} from "../buddy-chat-shared";
+
+
+// Constants — public contract
+export const CODEBUDDY_PROVIDER_ID = "cb" as const;
+export const CODEBUDDY_BASE_URL = providerBaseUrl("cb");
+// Upstream model translation — preserve provider mapping
+
+// Payload hook — provider intl semantics
+// - force stream=true
+// - reasoning_summary auto only when reasoning_effort requested
+// - upstreamId translation
+// - leading CodeBuddy system prompt + typed user content normalization
+
+/**
+ * Leading system turn for this variant.
+ *
+ * The upstream validates that the wire *opens* with a `system` turn (code
+ * `11128`) but does not check its text — the CN variant installs a plain
+ * engineering-assistant sentence in the same slot and the gateway accepts it.
+ * So this text is a product choice rather than a wire contract, and the
+ * previous vendor-branded line ("You are CodeBuddy Code.") made every request
+ * claim an identity the caller never chose, while also discarding whatever
+ * system prompt the caller actually sent.
+ *
+ * The prompt is therefore a neutral assistant identity with an explicit
+ * persona: pragmatic, direct, and honest — no sycophancy, no hedging, no
+ * invented certainty.
+ */
+export const CODEBUDDY_SYSTEM_PROMPT =
+  "You are a pragmatic and direct software engineering assistant. " +
+  "Be honest and truthful: state what you know, say plainly when you are unsure " +
+  "or do not know, and never claim to have done something you have not done. " +
+  "Prefer concrete answers over filler, and say so when a request is ambiguous " +
+  "instead of guessing silently.";
+
+function codeBuddyIntlPrePayload(
+  payload: Record<string, unknown>,
+  request: CanonicalRequest,
+  candidate: ProviderDispatchTarget,
+  context?: ProviderDispatchContext,
+): void {
+  // International ladder: DeepSeek Flash and friends serve only `high`.
+  buddyPrePayloadCommon(payload, request, "intl", context);
+  const rawModel = payload["model"];
+  const source =
+    typeof rawModel === "string" && rawModel.length > 0
+      ? rawModel
+      : candidate.model_id;
+  if (!source) throw new GatewayError("invalid_request", 400, "CodeBuddy model is required");
+  const messages = payload["messages"];
+  if (Array.isArray(messages)) {
+    applyBuddySystemPrompt(messages as Array<Record<string, unknown>>, CODEBUDDY_SYSTEM_PROMPT);
+  }
+  normalizeBuddyToolNames(payload);
+  void request;
+}
+
+// Model catalog — shared CodeBuddy / WorkBuddy international roster
+
+const CODEBUDDY_INTL_RAW: readonly BuddyRawEntry[] = BUDDY_SHARED_RAW;
+
+/**
+ * CodeBuddy's image generation rows.
+ *
+ * These ids also sit on the shared chat roster as ordinary `llm` rows, which is
+ * why they were unreachable as image models: nothing downstream could tell a
+ * chat model from one that returns an image, so `mediaGeneration` was false for
+ * every catalog row. The roster and the declared capabilities come from
+ * {@link makeBuddyImageModels} so cb and WorkBuddy cannot drift.
+ */
+export const CODEBUDDY_IMAGE_MODELS: readonly ModelDefinition[] = makeBuddyImageModels(
+  "cb",
+  "/images/generations",
+);
+
+/**
+ * CodeBuddy's video-generation rows (`seedance-2.5`).
+ *
+ * Reached through `/videos/generations` on the `/v2` base, so the endpoint is
+ * the upstream video path rather than a chat-completions path.
+ */
+export const CODEBUDDY_VIDEO_MODELS: readonly ModelDefinition[] = makeBuddyVideoModels(
+  "cb",
+  "/videos/generations",
+);
+
+/**
+ * The full cb catalog the registry loads: chat roster plus image and video rows.
+ *
+ * The image and video ids are filtered out of the chat pass so one id never
+ * appears under two service kinds. Exported as a single list so
+ * `default-registry.ts` keeps one import for this provider.
+ */
+export const CODEBUDDY_MODELS: readonly ModelDefinition[] = [
+  ...CODEBUDDY_INTL_RAW.filter(
+    (entry) => !BUDDY_IMAGE_MODEL_ID_SET.has(entry[0]) && !BUDDY_VIDEO_MODEL_ID_SET.has(entry[0]),
+  ).map((entry) => makeBuddyModel(entry, "cb")),
+  ...CODEBUDDY_IMAGE_MODELS,
+  ...CODEBUDDY_VIDEO_MODELS,
+];
+
+/**
+ * Reads the CodeBuddy intl console directory.
+ *
+ * The static `CODEBUDDY_MODELS` above stays the fallback — this console is
+ * documented to answer 500 intermittently — while discovery carries the
+ * upstream's own limits and capability flags.
+ */
+export async function discoverCodeBuddyModels(
+  input: DiscoveryInput,
+): Promise<readonly ModelDefinition[] | null> {
+  return fetchBuddyDirectoryModels({
+    siteUrl: CODEBUDDY_BASE_URL,
+    providerId: CODEBUDDY_PROVIDER_ID,
+    credential: input.credential,
+    modelsPath: BUDDY_INTL_MODELS_PATH,
+    endpoint: undefined,
+    ...(input.signal ? { signal: input.signal } : {}),
+    ...(input.fetcher ? { fetcher: input.fetcher } : {}),
+  });
+}
+
+// Public factory — uses OpenAI-compatible factory but forces provider semantics
+// Supports both api_key and oauth via Authorization Bearer (factory handles both)
+
+export function createCodeBuddyAdapter(fetchImpl?: typeof fetch): ProviderAdapter {
+  return new BuddyMediaAdapter(
+    codebuddyAdapterConfig({
+      providerId: CODEBUDDY_PROVIDER_ID,
+      baseUrl: CODEBUDDY_BASE_URL,
+      variant: "IDE",
+      cliIdentity: true,
+      prePayload: codeBuddyIntlPrePayload,
+      ...(fetchImpl ? { fetchImpl } : {}),
+    }),
+    {
+      variant: "IDE",
+      // BuddyMediaConfig has no `cliIdentity`; the CLI identity is selected by
+      // supplying the builder that takes it.
+      buildHeaders: (context, request) => codebuddyHeaders("IDE", context, request, true),
+      systemPrompt: CODEBUDDY_SYSTEM_PROMPT,
+      baseUrl: CODEBUDDY_BASE_URL,
+      imageGenerationPath: "/images/generations",
+    },
+  );
+}

package/src/providers/integrations/buddy/codebuddy/shared.ts

@@ -41,10 +41,11 @@ export async function codebuddyHeaders(
   });
   if (resolveBuddyIdentity(context, cliIdentity) === "cli") {
     return {
-      // The reference is explicit: the official CLI sends `Accept:
-      // application/json` and no browser header at all — no
-      // `X-Requested-With`, no `x-codebuddy-request`, no device token. A
-      // request carrying both halves is a hybrid no real client produces.
+      // The CLI sends `Accept: application/json` and no device token. The
+      // browser-shaped pair (`X-Requested-With`, `x-codebuddy-request`) stays
+      // off this branch: a request carrying both halves is a hybrid no real
+      // client produces, and that is a fidelity choice, not a requirement —
+      // the live API answers either way.
       accept: "application/json",
       "User-Agent": `CLI/${getCodeBuddyVersion()} CodeBuddy/${getCodeBuddyVersion()}`,
       "X-Product": "SaaS",
@@ -52,6 +53,11 @@ export async function codebuddyHeaders(
       "X-IDE-Name": "CLI",
       "X-IDE-Version": getCodeBuddyVersion(),
       "X-Domain": codebuddyDomain(variant),
+      // The conversation purpose the reference client states. Not required —
+      // verified against the live API that a request succeeds without it — but
+      // it is part of the client's real request, and matching the client is the
+      // defence against a channel check tightening later.
+      "X-Agent-Purpose": "conversation",
       ...conversation,
       ...buddyCliTraceHeaders(conversation),
       ...buddyCliHeaders({ userId: buddyUserId(context) }),
@@ -70,9 +76,12 @@ export async function codebuddyHeaders(
     "X-Domain": codebuddyDomain(variant),
     "x-requested-with": "XMLHttpRequest",
     "x-codebuddy-request": "1",
+    // Same value the CLI branch sends, for the same reason: part of the
+    // client's real request, harmless when the channel check does not read it.
+    "X-Agent-Purpose": "conversation",
     // Same family WorkBuddy sends: the upstream's channel check reads the
-    // turn-level aggregation key, and a chat request without it is refused with
-    // `400 · 11-128 "conversation id missing"`.
+    // turn-level aggregation key, and a chat request without it is refused for a
+    // missing conversation id.
     ...conversation,
     ...(deviceToken === undefined ? {} : { "X-Device-Token": deviceToken }),
   };