carrick 0.3.83 → 0.3.84

package/sidecar/dist/src/capture/self-check.d.ts

@@ -22,7 +22,12 @@
  * Attribution is per-alias closure: failed specifiers are blamed on an alias
  * only if they occur in a file reachable from that alias's surface statement
  * (import-type seeds, then BFS over relative imports). The spike's
- * file-granularity shortcut is gone.
+ * file-granularity shortcut is gone -- including on the SURFACE file itself,
+ * which holds every alias, so a file-granular bucket there blamed the whole
+ * service for one alias's dangling specifier (cloud#1184). A surface
+ * diagnostic is attributed by `export type` statement span, exactly as
+ * check-poison.ts contains poison; one that no statement covers keeps the
+ * service-wide bucket.
  */
 import ts from 'typescript';
 import type { CaptureAliasRecord } from './api.js';

package/sidecar/dist/src/capture/self-check.js

@@ -22,7 +22,12 @@
  * Attribution is per-alias closure: failed specifiers are blamed on an alias
  * only if they occur in a file reachable from that alias's surface statement
  * (import-type seeds, then BFS over relative imports). The spike's
- * file-granularity shortcut is gone.
+ * file-granularity shortcut is gone -- including on the SURFACE file itself,
+ * which holds every alias, so a file-granular bucket there blamed the whole
+ * service for one alias's dangling specifier (cloud#1184). A surface
+ * diagnostic is attributed by `export type` statement span, exactly as
+ * check-poison.ts contains poison; one that no statement covers keeps the
+ * service-wide bucket.
  */
 import ts from 'typescript';
 import * as fs from 'node:fs';
@@ -73,13 +78,26 @@ function runSelfCheck(args, treeFiles) {
     const program = ts.createProgram(treeFiles, options, args.compilerHost?.(options));
     const checker = program.getTypeChecker();
     const diagnostics = ts.getPreEmitDiagnostics(program);
-    // Failed module specifiers, split external-pinned vs internal, per FILE.
+    const surfaceAbs = path.resolve(args.surfaceAbsPath);
+    const surfaceSource = program.getSourceFile(surfaceAbs);
+    // The surface holds EVERY alias, and every alias's closure starts there, so
+    // a file-granular failure bucket on it blames the whole service for one
+    // alias's dangling specifier (cloud#1184). Attribute by `export type`
+    // statement span, exactly as check-poison.ts contains poison.
+    const aliasAtSurfacePosition = buildSurfaceSpanIndex(surfaceSource);
+    // Failed module specifiers, split external-pinned vs internal, per FILE —
+    // except on the surface, where they are per ALIAS.
     const failuresByFile = new Map();
-    const failuresFor = (fileName) => {
-        let entry = failuresByFile.get(fileName);
+    const surfaceFailuresByAlias = new Map();
+    const emptyFailures = () => ({
+        externalPinned: new Set(),
+        internal: new Set(),
+    });
+    const bucketIn = (map, key) => {
+        let entry = map.get(key);
         if (!entry) {
-            entry = { externalPinned: new Set(), internal: new Set() };
-            failuresByFile.set(fileName, entry);
+            entry = emptyFailures();
+            map.set(key, entry);
         }
         return entry;
     };
@@ -91,7 +109,15 @@ function runSelfCheck(args, treeFiles) {
         if (!m)
             continue;
         const spec = m[1];
-        const bucket = failuresFor(path.resolve(d.file.fileName));
+        const abs = path.resolve(d.file.fileName);
+        // A surface diagnostic outside every alias statement (a file-level import,
+        // a reference directive) is attributable to no alias and keeps the
+        // service-wide file bucket: soundness over precision, the same fallback
+        // check-poison.ts makes.
+        const owner = abs === surfaceAbs ? aliasAtSurfacePosition(d.start) : undefined;
+        const bucket = owner
+            ? bucketIn(surfaceFailuresByAlias, owner)
+            : bucketIn(failuresByFile, abs);
         if (!isRelative(spec) && args.pinned[packageNameOf(spec)]) {
             bucket.externalPinned.add(spec);
         }
@@ -113,8 +139,6 @@ function runSelfCheck(args, treeFiles) {
         }
         adjacency.set(abs, neighbors);
     }
-    const surfaceAbs = path.resolve(args.surfaceAbsPath);
-    const surfaceSource = program.getSourceFile(surfaceAbs);
     const records = [];
     for (const anchor of args.resolved) {
         // Demotions (failureReason present) never reached the surface with a
@@ -131,10 +155,35 @@ function runSelfCheck(args, treeFiles) {
                 surfaceSource,
                 adjacency,
                 failuresByFile,
+                surfaceFailuresByAlias,
             }));
     }
     return records;
 }
+/**
+ * Position -> the alias whose `export type` statement span covers it, for
+ * diagnostics reported on the surface file. `undefined` when no alias
+ * statement covers the position, or when the surface is not in the program.
+ */
+function buildSurfaceSpanIndex(surfaceSource) {
+    if (!surfaceSource)
+        return () => undefined;
+    const spans = [];
+    for (const stmt of surfaceSource.statements) {
+        if (!ts.isTypeAliasDeclaration(stmt))
+            continue;
+        spans.push({
+            alias: stmt.name.text,
+            start: stmt.getStart(surfaceSource),
+            end: stmt.getEnd(),
+        });
+    }
+    return (position) => {
+        if (position === undefined)
+            return undefined;
+        return spans.find((span) => position >= span.start && position <= span.end)?.alias;
+    };
+}
 /** An alias that never reached a capture-native tier: the failure reason was
  * recorded at demotion time; the surface line is `unknown` by construction. */
 function demotedRecord(anchor) {
@@ -195,8 +244,13 @@ function checkedRecord(anchor, ctx) {
     let blamedExternal;
     let internalFailure;
     const danglingSpecifiers = new Set();
-    for (const file of closure) {
-        const failures = ctx.failuresByFile.get(file);
+    // This alias's own surface statement, then the closure's files. The surface
+    // file bucket now holds only the diagnostics no alias statement covers.
+    const closureFailures = [
+        ctx.surfaceFailuresByAlias.get(alias),
+        ...[...closure].map((file) => ctx.failuresByFile.get(file)),
+    ];
+    for (const failures of closureFailures) {
         if (!failures)
             continue;
         if (!blamedExternal)

package/sidecar/dist/src/validators.d.ts

@@ -346,45 +346,45 @@ export declare const CaptureV2RequestSchema: z.ZodObject<{
         alias: z.ZodString;
         symbol_name: z.ZodString;
         source_file: z.ZodString;
-        anchor_origin: z.ZodEnum<["llm-symbol", "deterministic-infer", "anchor-backfill"]>;
+        anchor_origin: z.ZodEnum<["llm-symbol", "deterministic-infer", "anchor-backfill", "manifest-placeholder"]>;
         array_depth: z.ZodOptional<z.ZodNumber>;
     }, "strip", z.ZodTypeAny, {
         kind: "symbol";
         alias: string;
         source_file: string;
         symbol_name: string;
-        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill";
+        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill" | "manifest-placeholder";
         array_depth?: number | undefined;
     }, {
         kind: "symbol";
         alias: string;
         source_file: string;
         symbol_name: string;
-        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill";
+        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill" | "manifest-placeholder";
         array_depth?: number | undefined;
     }>, z.ZodObject<{
         kind: z.ZodLiteral<"handler_return">;
         alias: z.ZodString;
         symbol_name: z.ZodString;
         source_file: z.ZodString;
-        anchor_origin: z.ZodEnum<["llm-symbol", "deterministic-infer", "anchor-backfill"]>;
+        anchor_origin: z.ZodEnum<["llm-symbol", "deterministic-infer", "anchor-backfill", "manifest-placeholder"]>;
     }, "strip", z.ZodTypeAny, {
         kind: "handler_return";
         alias: string;
         source_file: string;
         symbol_name: string;
-        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill";
+        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill" | "manifest-placeholder";
     }, {
         kind: "handler_return";
         alias: string;
         source_file: string;
         symbol_name: string;
-        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill";
+        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill" | "manifest-placeholder";
     }>, z.ZodObject<{
         kind: z.ZodLiteral<"infer">;
         alias: z.ZodString;
         source_file: z.ZodString;
-        anchor_origin: z.ZodEnum<["llm-symbol", "deterministic-infer", "anchor-backfill"]>;
+        anchor_origin: z.ZodEnum<["llm-symbol", "deterministic-infer", "anchor-backfill", "manifest-placeholder"]>;
         span_start: z.ZodOptional<z.ZodNumber>;
         span_end: z.ZodOptional<z.ZodNumber>;
         line_number: z.ZodOptional<z.ZodNumber>;
@@ -394,7 +394,7 @@ export declare const CaptureV2RequestSchema: z.ZodObject<{
         kind: "infer";
         alias: string;
         source_file: string;
-        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill";
+        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill" | "manifest-placeholder";
         line_number?: number | undefined;
         span_start?: number | undefined;
         span_end?: number | undefined;
@@ -404,7 +404,7 @@ export declare const CaptureV2RequestSchema: z.ZodObject<{
         kind: "infer";
         alias: string;
         source_file: string;
-        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill";
+        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill" | "manifest-placeholder";
         line_number?: number | undefined;
         span_start?: number | undefined;
         span_end?: number | undefined;
@@ -414,18 +414,18 @@ export declare const CaptureV2RequestSchema: z.ZodObject<{
         kind: z.ZodLiteral<"literal">;
         alias: z.ZodString;
         type_text: z.ZodString;
-        anchor_origin: z.ZodEnum<["llm-symbol", "deterministic-infer", "anchor-backfill"]>;
+        anchor_origin: z.ZodEnum<["llm-symbol", "deterministic-infer", "anchor-backfill", "manifest-placeholder"]>;
         source_file: z.ZodOptional<z.ZodString>;
     }, "strip", z.ZodTypeAny, {
         kind: "literal";
         alias: string;
-        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill";
+        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill" | "manifest-placeholder";
         type_text: string;
         source_file?: string | undefined;
     }, {
         kind: "literal";
         alias: string;
-        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill";
+        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill" | "manifest-placeholder";
         type_text: string;
         source_file?: string | undefined;
     }>]>, "many">;
@@ -441,19 +441,19 @@ export declare const CaptureV2RequestSchema: z.ZodObject<{
         alias: string;
         source_file: string;
         symbol_name: string;
-        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill";
+        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill" | "manifest-placeholder";
         array_depth?: number | undefined;
     } | {
         kind: "handler_return";
         alias: string;
         source_file: string;
         symbol_name: string;
-        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill";
+        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill" | "manifest-placeholder";
     } | {
         kind: "infer";
         alias: string;
         source_file: string;
-        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill";
+        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill" | "manifest-placeholder";
         line_number?: number | undefined;
         span_start?: number | undefined;
         span_end?: number | undefined;
@@ -462,7 +462,7 @@ export declare const CaptureV2RequestSchema: z.ZodObject<{
     } | {
         kind: "literal";
         alias: string;
-        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill";
+        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill" | "manifest-placeholder";
         type_text: string;
         source_file?: string | undefined;
     })[];
@@ -478,19 +478,19 @@ export declare const CaptureV2RequestSchema: z.ZodObject<{
         alias: string;
         source_file: string;
         symbol_name: string;
-        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill";
+        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill" | "manifest-placeholder";
         array_depth?: number | undefined;
     } | {
         kind: "handler_return";
         alias: string;
         source_file: string;
         symbol_name: string;
-        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill";
+        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill" | "manifest-placeholder";
     } | {
         kind: "infer";
         alias: string;
         source_file: string;
-        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill";
+        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill" | "manifest-placeholder";
         line_number?: number | undefined;
         span_start?: number | undefined;
         span_end?: number | undefined;
@@ -499,7 +499,7 @@ export declare const CaptureV2RequestSchema: z.ZodObject<{
     } | {
         kind: "literal";
         alias: string;
-        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill";
+        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill" | "manifest-placeholder";
         type_text: string;
         source_file?: string | undefined;
     })[];
@@ -1412,45 +1412,45 @@ export declare const SidecarRequestSchema: z.ZodDiscriminatedUnion<"action", [z.
         alias: z.ZodString;
         symbol_name: z.ZodString;
         source_file: z.ZodString;
-        anchor_origin: z.ZodEnum<["llm-symbol", "deterministic-infer", "anchor-backfill"]>;
+        anchor_origin: z.ZodEnum<["llm-symbol", "deterministic-infer", "anchor-backfill", "manifest-placeholder"]>;
         array_depth: z.ZodOptional<z.ZodNumber>;
     }, "strip", z.ZodTypeAny, {
         kind: "symbol";
         alias: string;
         source_file: string;
         symbol_name: string;
-        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill";
+        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill" | "manifest-placeholder";
         array_depth?: number | undefined;
     }, {
         kind: "symbol";
         alias: string;
         source_file: string;
         symbol_name: string;
-        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill";
+        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill" | "manifest-placeholder";
         array_depth?: number | undefined;
     }>, z.ZodObject<{
         kind: z.ZodLiteral<"handler_return">;
         alias: z.ZodString;
         symbol_name: z.ZodString;
         source_file: z.ZodString;
-        anchor_origin: z.ZodEnum<["llm-symbol", "deterministic-infer", "anchor-backfill"]>;
+        anchor_origin: z.ZodEnum<["llm-symbol", "deterministic-infer", "anchor-backfill", "manifest-placeholder"]>;
     }, "strip", z.ZodTypeAny, {
         kind: "handler_return";
         alias: string;
         source_file: string;
         symbol_name: string;
-        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill";
+        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill" | "manifest-placeholder";
     }, {
         kind: "handler_return";
         alias: string;
         source_file: string;
         symbol_name: string;
-        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill";
+        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill" | "manifest-placeholder";
     }>, z.ZodObject<{
         kind: z.ZodLiteral<"infer">;
         alias: z.ZodString;
         source_file: z.ZodString;
-        anchor_origin: z.ZodEnum<["llm-symbol", "deterministic-infer", "anchor-backfill"]>;
+        anchor_origin: z.ZodEnum<["llm-symbol", "deterministic-infer", "anchor-backfill", "manifest-placeholder"]>;
         span_start: z.ZodOptional<z.ZodNumber>;
         span_end: z.ZodOptional<z.ZodNumber>;
         line_number: z.ZodOptional<z.ZodNumber>;
@@ -1460,7 +1460,7 @@ export declare const SidecarRequestSchema: z.ZodDiscriminatedUnion<"action", [z.
         kind: "infer";
         alias: string;
         source_file: string;
-        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill";
+        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill" | "manifest-placeholder";
         line_number?: number | undefined;
         span_start?: number | undefined;
         span_end?: number | undefined;
@@ -1470,7 +1470,7 @@ export declare const SidecarRequestSchema: z.ZodDiscriminatedUnion<"action", [z.
         kind: "infer";
         alias: string;
         source_file: string;
-        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill";
+        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill" | "manifest-placeholder";
         line_number?: number | undefined;
         span_start?: number | undefined;
         span_end?: number | undefined;
@@ -1480,18 +1480,18 @@ export declare const SidecarRequestSchema: z.ZodDiscriminatedUnion<"action", [z.
         kind: z.ZodLiteral<"literal">;
         alias: z.ZodString;
         type_text: z.ZodString;
-        anchor_origin: z.ZodEnum<["llm-symbol", "deterministic-infer", "anchor-backfill"]>;
+        anchor_origin: z.ZodEnum<["llm-symbol", "deterministic-infer", "anchor-backfill", "manifest-placeholder"]>;
         source_file: z.ZodOptional<z.ZodString>;
     }, "strip", z.ZodTypeAny, {
         kind: "literal";
         alias: string;
-        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill";
+        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill" | "manifest-placeholder";
         type_text: string;
         source_file?: string | undefined;
     }, {
         kind: "literal";
         alias: string;
-        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill";
+        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill" | "manifest-placeholder";
         type_text: string;
         source_file?: string | undefined;
     }>]>, "many">;
@@ -1507,19 +1507,19 @@ export declare const SidecarRequestSchema: z.ZodDiscriminatedUnion<"action", [z.
         alias: string;
         source_file: string;
         symbol_name: string;
-        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill";
+        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill" | "manifest-placeholder";
         array_depth?: number | undefined;
     } | {
         kind: "handler_return";
         alias: string;
         source_file: string;
         symbol_name: string;
-        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill";
+        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill" | "manifest-placeholder";
     } | {
         kind: "infer";
         alias: string;
         source_file: string;
-        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill";
+        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill" | "manifest-placeholder";
         line_number?: number | undefined;
         span_start?: number | undefined;
         span_end?: number | undefined;
@@ -1528,7 +1528,7 @@ export declare const SidecarRequestSchema: z.ZodDiscriminatedUnion<"action", [z.
     } | {
         kind: "literal";
         alias: string;
-        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill";
+        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill" | "manifest-placeholder";
         type_text: string;
         source_file?: string | undefined;
     })[];
@@ -1544,19 +1544,19 @@ export declare const SidecarRequestSchema: z.ZodDiscriminatedUnion<"action", [z.
         alias: string;
         source_file: string;
         symbol_name: string;
-        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill";
+        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill" | "manifest-placeholder";
         array_depth?: number | undefined;
     } | {
         kind: "handler_return";
         alias: string;
         source_file: string;
         symbol_name: string;
-        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill";
+        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill" | "manifest-placeholder";
     } | {
         kind: "infer";
         alias: string;
         source_file: string;
-        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill";
+        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill" | "manifest-placeholder";
         line_number?: number | undefined;
         span_start?: number | undefined;
         span_end?: number | undefined;
@@ -1565,7 +1565,7 @@ export declare const SidecarRequestSchema: z.ZodDiscriminatedUnion<"action", [z.
     } | {
         kind: "literal";
         alias: string;
-        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill";
+        anchor_origin: "llm-symbol" | "deterministic-infer" | "anchor-backfill" | "manifest-placeholder";
         type_text: string;
         source_file?: string | undefined;
     })[];

package/sidecar/dist/src/validators.js

@@ -186,7 +186,12 @@ export const EmitSurfaceRequestSchema = BaseRequestSchema.extend({
     output_path: z.string().min(1, 'Output path cannot be empty'),
 });
 /** v2 "tsc as serializer" capture (contract in ./capture/api.ts). */
-const AnchorOriginSchema = z.enum(['llm-symbol', 'deterministic-infer', 'anchor-backfill']);
+const AnchorOriginSchema = z.enum([
+    'llm-symbol',
+    'deterministic-infer',
+    'anchor-backfill',
+    'manifest-placeholder',
+]);
 const CaptureAnchorRequestSchema = z.discriminatedUnion('kind', [
     z.object({
         kind: z.literal('symbol'),