carbon-components-angular 5.28.2 → 5.28.4

package/README.md

@@ -101,7 +101,7 @@ How to read this table:
 - **if you are contributing a fix**:
   - add your fix, update the documentation as needed
   - consider adding or modifying a test case to cover the fix
-- follow the [Angular style guide](https://angular.io/styleguide)
+- follow the [Angular style guide](https://angular.dev/style-guide)
 - be sure to run `npm test` and `npm run lint` to make sure the tests and linter pass
 - submit a PR
 

package/docs/documentation/components/ComboBox.html

@@ -1899,8 +1899,8 @@ Multi-select comboboxes also provide &quot;pills&quot; of selected items.</p>
 
                     <tr>
                         <td class="col-md-4">
-                            <div class="io-line">Defined in <a href="" data-line="821"
-                                    class="link-to-prism">src/combobox/combobox.component.ts:821</a></div>
+                            <div class="io-line">Defined in <a href="" data-line="825"
+                                    class="link-to-prism">src/combobox/combobox.component.ts:825</a></div>
                         </td>
                     </tr>
 
@@ -1938,8 +1938,8 @@ Multi-select comboboxes also provide &quot;pills&quot; of selected items.</p>
 
                     <tr>
                         <td class="col-md-4">
-                            <div class="io-line">Defined in <a href="" data-line="832"
-                                    class="link-to-prism">src/combobox/combobox.component.ts:832</a></div>
+                            <div class="io-line">Defined in <a href="" data-line="836"
+                                    class="link-to-prism">src/combobox/combobox.component.ts:836</a></div>
                         </td>
                     </tr>
 
@@ -1977,8 +1977,8 @@ Multi-select comboboxes also provide &quot;pills&quot; of selected items.</p>
 
                     <tr>
                         <td class="col-md-4">
-                            <div class="io-line">Defined in <a href="" data-line="801"
-                                    class="link-to-prism">src/combobox/combobox.component.ts:801</a></div>
+                            <div class="io-line">Defined in <a href="" data-line="805"
+                                    class="link-to-prism">src/combobox/combobox.component.ts:805</a></div>
                         </td>
                     </tr>
 
@@ -2083,8 +2083,8 @@ Multi-select comboboxes also provide &quot;pills&quot; of selected items.</p>
 
                     <tr>
                         <td class="col-md-4">
-                            <div class="io-line">Defined in <a href="" data-line="861"
-                                    class="link-to-prism">src/combobox/combobox.component.ts:861</a></div>
+                            <div class="io-line">Defined in <a href="" data-line="865"
+                                    class="link-to-prism">src/combobox/combobox.component.ts:865</a></div>
                         </td>
                     </tr>
 
@@ -2148,8 +2148,8 @@ Multi-select comboboxes also provide &quot;pills&quot; of selected items.</p>
 
                     <tr>
                         <td class="col-md-4">
-                            <div class="io-line">Defined in <a href="" data-line="841"
-                                    class="link-to-prism">src/combobox/combobox.component.ts:841</a></div>
+                            <div class="io-line">Defined in <a href="" data-line="845"
+                                    class="link-to-prism">src/combobox/combobox.component.ts:845</a></div>
                         </td>
                     </tr>
 
@@ -2190,8 +2190,8 @@ This can be overridden by passing in a value to the <code>dropUp</code> input.</
 
                     <tr>
                         <td class="col-md-4">
-                            <div class="io-line">Defined in <a href="" data-line="882"
-                                    class="link-to-prism">src/combobox/combobox.component.ts:882</a></div>
+                            <div class="io-line">Defined in <a href="" data-line="886"
+                                    class="link-to-prism">src/combobox/combobox.component.ts:886</a></div>
                         </td>
                     </tr>
 
@@ -2476,8 +2476,8 @@ This can be overridden by passing in a value to the <code>dropUp</code> input.</
 
                     <tr>
                         <td class="col-md-4">
-                            <div class="io-line">Defined in <a href="" data-line="794"
-                                    class="link-to-prism">src/combobox/combobox.component.ts:794</a></div>
+                            <div class="io-line">Defined in <a href="" data-line="798"
+                                    class="link-to-prism">src/combobox/combobox.component.ts:798</a></div>
                         </td>
                     </tr>
 
@@ -3242,8 +3242,8 @@ Updates pills if necessary.</p>
 
                     <tr>
                         <td class="col-md-4">
-                            <div class="io-line">Defined in <a href="" data-line="870"
-                                    class="link-to-prism">src/combobox/combobox.component.ts:870</a></div>
+                            <div class="io-line">Defined in <a href="" data-line="874"
+                                    class="link-to-prism">src/combobox/combobox.component.ts:874</a></div>
                         </td>
                     </tr>
 
@@ -5352,6 +5352,10 @@ export class ComboBox implements OnChanges, AfterViewInit, AfterContentInit, OnD
 	clearInput(event) {
 		event.stopPropagation();
 		event.preventDefault();
+		
+		if (this.disabled) {
+			return;
+		}
 
 		if (this.type &#x3D;&#x3D;&#x3D; &quot;single&quot;) { // don&#x27;t want to clear selected or close if multi
 			this.clearSelected(event);

package/docs/documentation/components/DropdownList.html

@@ -836,8 +836,8 @@ ArrowUp -&gt; emit event</p>
 
                     <tr>
                         <td class="col-md-4">
-                            <div class="io-line">Defined in <a href="" data-line="537"
-                                    class="link-to-prism">src/dropdown/list/dropdown-list.component.ts:537</a></div>
+                            <div class="io-line">Defined in <a href="" data-line="551"
+                                    class="link-to-prism">src/dropdown/list/dropdown-list.component.ts:551</a></div>
                         </td>
                     </tr>
 
@@ -977,8 +977,8 @@ ArrowUp -&gt; emit event</p>
 
                     <tr>
                         <td class="col-md-4">
-                            <div class="io-line">Defined in <a href="" data-line="572"
-                                    class="link-to-prism">src/dropdown/list/dropdown-list.component.ts:572</a></div>
+                            <div class="io-line">Defined in <a href="" data-line="586"
+                                    class="link-to-prism">src/dropdown/list/dropdown-list.component.ts:586</a></div>
                         </td>
                     </tr>
 
@@ -1572,8 +1572,8 @@ ArrowUp -&gt; emit event</p>
 
                     <tr>
                         <td class="col-md-4">
-                            <div class="io-line">Defined in <a href="" data-line="479"
-                                    class="link-to-prism">src/dropdown/list/dropdown-list.component.ts:479</a></div>
+                            <div class="io-line">Defined in <a href="" data-line="493"
+                                    class="link-to-prism">src/dropdown/list/dropdown-list.component.ts:493</a></div>
                         </td>
                     </tr>
 
@@ -1611,8 +1611,8 @@ ArrowUp -&gt; emit event</p>
 
                     <tr>
                         <td class="col-md-4">
-                            <div class="io-line">Defined in <a href="" data-line="505"
-                                    class="link-to-prism">src/dropdown/list/dropdown-list.component.ts:505</a></div>
+                            <div class="io-line">Defined in <a href="" data-line="519"
+                                    class="link-to-prism">src/dropdown/list/dropdown-list.component.ts:519</a></div>
                         </td>
                     </tr>
 
@@ -1759,8 +1759,8 @@ Additionally, any Observables for the <code>DropdownList</code> are initialized.
 
                     <tr>
                         <td class="col-md-4">
-                            <div class="io-line">Defined in <a href="" data-line="563"
-                                    class="link-to-prism">src/dropdown/list/dropdown-list.component.ts:563</a></div>
+                            <div class="io-line">Defined in <a href="" data-line="577"
+                                    class="link-to-prism">src/dropdown/list/dropdown-list.component.ts:577</a></div>
                         </td>
                     </tr>
 
@@ -1822,8 +1822,8 @@ Additionally, any Observables for the <code>DropdownList</code> are initialized.
 
                     <tr>
                         <td class="col-md-4">
-                            <div class="io-line">Defined in <a href="" data-line="557"
-                                    class="link-to-prism">src/dropdown/list/dropdown-list.component.ts:557</a></div>
+                            <div class="io-line">Defined in <a href="" data-line="571"
+                                    class="link-to-prism">src/dropdown/list/dropdown-list.component.ts:571</a></div>
                         </td>
                     </tr>
 
@@ -1885,8 +1885,8 @@ Additionally, any Observables for the <code>DropdownList</code> are initialized.
 
                     <tr>
                         <td class="col-md-4">
-                            <div class="io-line">Defined in <a href="" data-line="582"
-                                    class="link-to-prism">src/dropdown/list/dropdown-list.component.ts:582</a></div>
+                            <div class="io-line">Defined in <a href="" data-line="596"
+                                    class="link-to-prism">src/dropdown/list/dropdown-list.component.ts:596</a></div>
                         </td>
                     </tr>
 
@@ -2023,8 +2023,8 @@ Additionally, any Observables for the <code>DropdownList</code> are initialized.
 
                     <tr>
                         <td class="col-md-4">
-                            <div class="io-line">Defined in <a href="" data-line="587"
-                                    class="link-to-prism">src/dropdown/list/dropdown-list.component.ts:587</a></div>
+                            <div class="io-line">Defined in <a href="" data-line="601"
+                                    class="link-to-prism">src/dropdown/list/dropdown-list.component.ts:601</a></div>
                         </td>
                     </tr>
 
@@ -2130,8 +2130,8 @@ key input matching the first letter of the item in the list.</p>
 
                     <tr>
                         <td class="col-md-4">
-                            <div class="io-line">Defined in <a href="" data-line="490"
-                                    class="link-to-prism">src/dropdown/list/dropdown-list.component.ts:490</a></div>
+                            <div class="io-line">Defined in <a href="" data-line="504"
+                                    class="link-to-prism">src/dropdown/list/dropdown-list.component.ts:504</a></div>
                         </td>
                     </tr>
 
@@ -3223,24 +3223,38 @@ export class DropdownList implements AbstractDropdownView, AfterViewInit, OnDest
 			console.error(&#x60;${this.constructor.name}.propagateSelected expects an Array&lt;ListItem&gt;, got ${JSON.stringify(value)}&#x60;);
 		}
 		this.onItemsReady(() &#x3D;&gt; {
+			const selectedNewItems &#x3D; [];
+			for (let newItem of value) {
+				if (newItem &amp;&amp; newItem.selected) {
+					// copy the item
+					let tempNewItem: string | ListItem &#x3D; Object.assign({}, newItem);
+					// deleted selected because it&#x27;s what we _want_ to change
+					delete tempNewItem.selected;
+					// stringify for compare later
+					tempNewItem &#x3D; JSON.stringify(tempNewItem);
+					// add to the list of selected items
+					selectedNewItems.push(tempNewItem);
+				}
+			}
+
 			// loop through the list items and update the &#x60;selected&#x60; state for matching items in &#x60;value&#x60;
 			for (let oldItem of this.getListItems()) {
+				// fast path when no items are selected
+				if (selectedNewItems.length &#x3D;&#x3D;&#x3D; 0) {
+					oldItem.selected &#x3D; false;
+					continue;
+				}
+
 				// copy the item
 				let tempOldItem: string | ListItem &#x3D; Object.assign({}, oldItem);
 				// deleted selected because it&#x27;s what we _want_ to change
 				delete tempOldItem.selected;
 				// stringify for compare
 				tempOldItem &#x3D; JSON.stringify(tempOldItem);
-				for (let newItem of value) {
-					// copy the item
-					let tempNewItem: string | ListItem &#x3D; Object.assign({}, newItem);
-					// deleted selected because it&#x27;s what we _want_ to change
-					delete tempNewItem.selected;
-					// stringify for compare
-					tempNewItem &#x3D; JSON.stringify(tempNewItem);
+				for (let selectedNewItem of selectedNewItems) {
 					// do the compare
-					if (tempOldItem.includes(tempNewItem)) {
-						oldItem.selected &#x3D; newItem.selected;
+					if (tempOldItem.includes(selectedNewItem)) {
+						oldItem.selected &#x3D; true;
 						// if we&#x27;ve found a matching item, we can stop looping
 						break;
 					} else {

package/docs/documentation/index.html

@@ -280,7 +280,7 @@ $ npm i --save carbon-components-angular &#64;carbon/styles</code></pre></div><p
 <li>consider adding or modifying a test case to cover the fix</li>
 </ul>
 </li>
-<li>follow the <a href="https://angular.io/styleguide">Angular style guide</a></li>
+<li>follow the <a href="https://angular.dev/style-guide">Angular style guide</a></li>
 <li>be sure to run <code>npm test</code> and <code>npm run lint</code> to make sure the tests and linter pass</li>
 <li>submit a PR</li>
 </ul>