capacitor-camera-view 1.2.1 → 1.2.2

package/README.md

@@ -150,6 +150,9 @@ This plugin supports real-time barcode detection directly from the live camera f
 *   **Android:** Utilizes Google's [**ML Kit Barcode Scanning**](https://developers.google.com/ml-kit/vision/barcode-scanning).
 *   **Web:** Uses the [**Barcode Detection API**](https://developer.mozilla.org/en-US/docs/Web/API/Barcode_Detection_API) where available in the browser.
 
+> [!NOTE]
+> **Web Support:** The Barcode Detection API is not supported in all browsers (e.g., Windows browsers). For full browser compatibility, consider using a polyfill such as [`@undecaf/barcode-detector-polyfill`](https://www.npmjs.com/package/@undecaf/barcode-detector-polyfill) or [`barcode-detector`](https://www.npmjs.com/package/barcode-detector).
+
 **Enabling Barcode Detection:**
 To enable this feature, set the `enableBarcodeDetection` option to `true` when calling the `start()` method:
 

package/ios/Sources/CameraViewPlugin/CameraViewManager.swift

@@ -90,10 +90,20 @@ internal let SUPPORTED_CAMERA_DEVICE_TYPES: [AVCaptureDevice.DeviceType] = [
                 completion: { error in
                     if error != nil { completion(error) }
 
+                    // Handle barcode detection after session is running
+                    if configuration.enableBarcodeDetection {
+                        do {
+                            try self.enableBarcodeDetection()
+                        } catch {
+                            completion(error)
+                            return
+                        }
+                    }
+
                     // Complete already because the camera is ready to be used
-                    // We might asynchronously upgrade to a triple camera in the background if available and configured
                     completion(nil)
 
+                    // We might asynchronously upgrade to a triple camera in the background if available and configured
                     if configuration.useTripleCameraIfAvailable {
                         Task {
                             await self.upgradeToTripleCameraIfAvailable()
@@ -359,10 +369,7 @@ internal let SUPPORTED_CAMERA_DEVICE_TYPES: [AVCaptureDevice.DeviceType] = [
         // Set up the video data output for snapshots
         try setupVideoDataOutput()
 
-        // Setup metadata output for QR code scanning if enabled
-        if configuration.enableBarcodeDetection {
-            try setupMetadataOutput()
-        } else {
+        if !configuration.enableBarcodeDetection {
             // Remove the metadata output in case it already existed for the
             // capture session
             removeMetadataOutput()
@@ -405,6 +412,26 @@ internal let SUPPORTED_CAMERA_DEVICE_TYPES: [AVCaptureDevice.DeviceType] = [
         }
     }
 
+
+    /// Enables barcode detection by adding metadata output to the running session.
+    /// Somehow adding the metadata output with the session not being started yet
+    /// caused issues on some devices (iPad 7th Gen) where the session would just
+    /// not start at all without an error being thrown. I haven't been able to
+    /// figure out the root cause of this but it might generally be a good idea
+    /// to only add the metadata output when the session is already running.
+    ///
+    /// - Throws: An error if the metadata output cannot be added.
+    private func enableBarcodeDetection() throws {
+        guard captureSession.isRunning else {
+            throw CameraError.sessionNotRunning
+        }
+
+        captureSession.beginConfiguration()
+        defer { captureSession.commitConfiguration() }
+
+        try setupMetadataOutput()
+    }
+
     /// Retrieve a list of a available camera devices
     ///
     /// - Returns: a list of all  available camera devices.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "capacitor-camera-view",
-  "version": "1.2.1",
+  "version": "1.2.2",
   "description": "A Capacitor plugin for embedding a live camera feed directly into your app.",
   "main": "dist/plugin.cjs.js",
   "module": "dist/esm/index.js",