capacitor-camera-module 0.0.33 → 0.0.34

package/android/src/main/java/com/eddieagvictoria/cameramodule/CameraModulePlugin.java

@@ -15,7 +15,6 @@ import com.getcapacitor.annotation.PermissionCallback;
 
 import android.view.ViewGroup;
 import android.widget.FrameLayout;
-import androidx.appcompat.app.AppCompatActivity;
 import androidx.core.content.ContextCompat;
 import androidx.camera.core.CameraSelector;
 import androidx.camera.core.Preview;
@@ -67,7 +66,11 @@ import com.google.mlkit.vision.barcode.common.Barcode;
 import com.google.mlkit.vision.barcode.BarcodeScanner;
 import com.google.mlkit.vision.barcode.BarcodeScanning;
 
+import android.graphics.YuvImage;
+import android.graphics.Rect;
+import java.util.concurrent.Executors;
 
+import java.util.concurrent.ExecutorService;
 
 
 @CapacitorPlugin(
@@ -92,7 +95,6 @@ public class CameraModulePlugin extends Plugin {
 
     private PreviewView previewView;
     private ProcessCameraProvider cameraProvider;
-    private CameraSelector cameraSelector;
 
     private Camera camera;
 
@@ -101,12 +103,17 @@ public class CameraModulePlugin extends Plugin {
 
     private ImageCapture imageCapture;
 
-    private PluginCall pendingCaptureCall;
-
     private ImageAnalysis imageAnalysis;
     private boolean isScanning = false;
     private PluginCall scanCall;
 
+    private CameraSelector cameraSelector = CameraSelector.DEFAULT_BACK_CAMERA;
+
+    private BarcodeScanner barcodeScanner;
+
+    private final ExecutorService barcodeExecutor = Executors.newSingleThreadExecutor();
+
+
 
     @Override
     public void load() {
@@ -236,6 +243,12 @@ public class CameraModulePlugin extends Plugin {
     @PluginMethod
     public void startPreview(PluginCall call) {
         getActivity().runOnUiThread(() -> {
+
+            if (previewView != null) {
+                call.resolve();
+                return;
+            }
+
             previewView = new PreviewView(getContext());
             previewView.setLayoutParams(
                 new FrameLayout.LayoutParams(
@@ -269,7 +282,7 @@ public class CameraModulePlugin extends Plugin {
                         .setCaptureMode(ImageCapture.CAPTURE_MODE_MINIMIZE_LATENCY)
                         .build();
 
-                cameraSelector = CameraSelector.DEFAULT_BACK_CAMERA;
+
 
                 cameraProvider.unbindAll();
 
@@ -306,6 +319,11 @@ public class CameraModulePlugin extends Plugin {
                 previewView = null;
             }
 
+            if (barcodeScanner != null) {
+                barcodeScanner.close();
+                barcodeScanner = null;
+            }
+
             call.resolve();
         });
     }
@@ -355,6 +373,10 @@ public class CameraModulePlugin extends Plugin {
             return;
         }
 
+        if (savedCall != null) {
+            call.reject("Gallery already open");
+            return;
+        }
         savedCall = call;
 
         Intent intent = new Intent(
@@ -404,11 +426,19 @@ public class CameraModulePlugin extends Plugin {
         float ratio = (float) width / height;
 
         if (width > height) {
-            if (width <= maxSize) return bitmap;
+            if (width <= maxSize && height <= maxSize) {
+                Bitmap.Config config =
+                    bitmap.getConfig() != null ? bitmap.getConfig() : Bitmap.Config.ARGB_8888;
+                return bitmap.copy(config, false);
+            }
             width = maxSize;
             height = Math.round(width / ratio);
         } else {
-            if (height <= maxSize) return bitmap;
+            if (height <= maxSize && width <= maxSize) {
+                Bitmap.Config config =
+                    bitmap.getConfig() != null ? bitmap.getConfig() : Bitmap.Config.ARGB_8888;
+                return bitmap.copy(config, false);
+            }
             height = maxSize;
             width = Math.round(height * ratio);
         }
@@ -558,6 +588,11 @@ public class CameraModulePlugin extends Plugin {
                 ) {
                     try {
                         Bitmap bitmap = imageProxyToBitmap(image);
+                        if (bitmap == null) {
+                            image.close();
+                            call.reject("Failed to convert image");
+                            return;
+                        }
                         int rotation = image.getImageInfo().getRotationDegrees();
                         bitmap = rotateBitmap(bitmap, rotation);
                         image.close();
@@ -600,15 +635,45 @@ public class CameraModulePlugin extends Plugin {
     }
 
     private Bitmap imageProxyToBitmap(ImageProxy image) {
-        ImageProxy.PlaneProxy[] planes = image.getPlanes();
-        ByteBuffer buffer = planes[0].getBuffer();
-        byte[] bytes = new byte[buffer.remaining()];
-        buffer.get(bytes);
+        Image mediaImage = image.getImage();
+        if (mediaImage == null) return null;
+
+        ByteBuffer yBuffer = image.getPlanes()[0].getBuffer();
+        ByteBuffer uBuffer = image.getPlanes()[1].getBuffer();
+        ByteBuffer vBuffer = image.getPlanes()[2].getBuffer();
+
+        int ySize = yBuffer.remaining();
+        int uSize = uBuffer.remaining();
+        int vSize = vBuffer.remaining();
+
+        byte[] nv21 = new byte[ySize + uSize + vSize];
+
+        yBuffer.get(nv21, 0, ySize);
+        vBuffer.get(nv21, ySize, vSize);
+        uBuffer.get(nv21, ySize + vSize, uSize);
+
+        YuvImage yuvImage =
+            new YuvImage(
+                nv21,
+                ImageFormat.NV21,
+                image.getWidth(),
+                image.getHeight(),
+                null
+            );
 
-        return BitmapFactory.decodeByteArray(bytes, 0, bytes.length);
+        ByteArrayOutputStream out = new ByteArrayOutputStream();
+        yuvImage.compressToJpeg(
+            new Rect(0, 0, image.getWidth(), image.getHeight()),
+            100,
+            out
+        );
+
+        byte[] jpegBytes = out.toByteArray();
+        return BitmapFactory.decodeByteArray(jpegBytes, 0, jpegBytes.length);
     }
 
 
+
     private Bitmap rotateBitmap(Bitmap bitmap, int rotationDegrees) {
         if (rotationDegrees == 0) return bitmap;
 
@@ -627,29 +692,6 @@ public class CameraModulePlugin extends Plugin {
     }
 
 
-
-    private Bitmap mirrorBitmap(Bitmap bitmap) {
-        Matrix matrix = new Matrix();
-        matrix.preScale(-1, 1);
-
-        return Bitmap.createBitmap(
-            bitmap,
-            0,
-            0,
-            bitmap.getWidth(),
-            bitmap.getHeight(),
-            matrix,
-            true
-        );
-    }
-
-    private String bitmapToBase64(Bitmap bitmap) {
-        ByteArrayOutputStream outputStream = new ByteArrayOutputStream();
-        bitmap.compress(Bitmap.CompressFormat.JPEG, 80, outputStream);
-        byte[] bytes = outputStream.toByteArray();
-        return Base64.encodeToString(bytes, Base64.NO_WRAP);
-    }
-
     @PluginMethod
     public void startBarcodeScan(PluginCall call) {
 
@@ -673,6 +715,10 @@ public class CameraModulePlugin extends Plugin {
             return;
         }
 
+         barcodeScanner = BarcodeScanning.getClient();
+
+        call.setKeepAlive(true);
+
         scanCall = call;
         isScanning = true;
 
@@ -684,7 +730,7 @@ public class CameraModulePlugin extends Plugin {
                 .build();
 
         imageAnalysis.setAnalyzer(
-            ContextCompat.getMainExecutor(getContext()),
+            barcodeExecutor,
             this::processBarcode
         );
 
@@ -698,6 +744,10 @@ public class CameraModulePlugin extends Plugin {
                 .setCaptureMode(ImageCapture.CAPTURE_MODE_MINIMIZE_LATENCY)
                 .build();
 
+        if (cameraSelector == null) {
+            cameraSelector = CameraSelector.DEFAULT_BACK_CAMERA;
+        }
+
         camera = cameraProvider.bindToLifecycle(
             getActivity(),
             cameraSelector,
@@ -705,9 +755,13 @@ public class CameraModulePlugin extends Plugin {
             imageCapture,
             imageAnalysis
         );
+
+        call.resolve();
+
     }
 
     private void processBarcode(ImageProxy imageProxy) {
+
         if (!isScanning) {
             imageProxy.close();
             return;
@@ -719,19 +773,26 @@ public class CameraModulePlugin extends Plugin {
             return;
         }
 
-        InputImage image =
-            InputImage.fromMediaImage(
-                mediaImage,
-                imageProxy.getImageInfo().getRotationDegrees()
-            );
-
-        BarcodeScanner scanner =
-            BarcodeScanning.getClient();
+        InputImage image = InputImage.fromMediaImage(
+            mediaImage,
+            imageProxy.getImageInfo().getRotationDegrees()
+        );
 
-        scanner.process(image)
+        if (barcodeScanner == null) {
+            imageProxy.close();
+            return;
+        }
+        barcodeScanner.process(image)
             .addOnSuccessListener(barcodes -> {
-                if (!barcodes.isEmpty() && isScanning) {
 
+                if (!isScanning) {
+                    imageProxy.close();
+                    return;
+                }
+
+                if (!barcodes.isEmpty()) {
+
+                    isScanning = false;
                     vibrateOnce();
 
                     Barcode barcode = barcodes.get(0);
@@ -740,36 +801,63 @@ public class CameraModulePlugin extends Plugin {
                     ret.put("rawValue", barcode.getRawValue());
                     ret.put("format", barcode.getFormat());
 
-                    isScanning = false;
-                    imageProxy.close();
+                    if (scanCall != null) {
+                        scanCall.resolve(ret);
+                        scanCall.setKeepAlive(false);
+                        scanCall = null;
+
+                    }
+
+                    if (barcodeScanner != null) {
+                            barcodeScanner.close();
+                            barcodeScanner = null;
+                        }
 
-                    scanCall.resolve(ret);
-                    scanCall = null;
 
                     stopBarcodeScanInternal();
-                } else {
-                    imageProxy.close();
                 }
+
+                imageProxy.close();
             })
             .addOnFailureListener(e -> {
                 imageProxy.close();
             });
     }
 
+
     private void stopBarcodeScanInternal() {
-        if (imageAnalysis != null) {
-            cameraProvider.unbind(imageAnalysis);
-            imageAnalysis = null;
-        }
+        getActivity().runOnUiThread(() -> {
+            if (cameraProvider != null) {
+                cameraProvider.unbindAll();
+                startCamera();
+            }
+        });
     }
 
+
+
     @PluginMethod
     public void stopBarcodeScan(PluginCall call) {
         isScanning = false;
+        imageAnalysis = null;
+
+        if (scanCall != null) {
+            scanCall.setKeepAlive(false);
+            scanCall = null;
+        }
+
+        if (barcodeScanner != null) {
+            barcodeScanner.close();
+            barcodeScanner = null;
+        }
+
         stopBarcodeScanInternal();
+
         call.resolve();
     }
 
+
+
     private void vibrateOnce() {
         Vibrator vibrator =
             (Vibrator) getContext().getSystemService(Context.VIBRATOR_SERVICE);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "capacitor-camera-module",
-  "version": "0.0.33",
+  "version": "0.0.34",
   "description": "Plugin to request permissiones view camera take phots",
   "main": "dist/plugin.cjs.js",
   "module": "dist/esm/index.js",