canicode 0.12.1 → 0.12.2

package/dist/cli/index.js

@@ -3458,6 +3458,7 @@ defineRule({
 });
 var CODE_CONNECT_SETUP_KEY = "unmapped-component:setup-detected";
 var CODE_CONNECT_MAPPINGS_KEY = "unmapped-component:mappings";
+var SEEN_MAIN_IDS_KEY = "unmapped-component:seen-main-ids";
 function codeConnectIsSetUp(context) {
   return getAnalysisState(context, CODE_CONNECT_SETUP_KEY, () => {
     return existsSync(join(process.cwd(), "figma.config.json"));
@@ -3470,6 +3471,9 @@ function codeConnectMappings(context) {
     () => parseCodeConnectMappings(process.cwd())
   );
 }
+function seenMainIds(context) {
+  return getAnalysisState(context, SEEN_MAIN_IDS_KEY, () => /* @__PURE__ */ new Set());
+}
 var unmappedComponentDef = {
   id: "unmapped-component",
   name: "Unmapped Component",
@@ -3479,20 +3483,33 @@ var unmappedComponentDef = {
   fix: "Run /canicode-roundtrip on this component to register a mapping. Figma's get_code_connect_map will skip if a mapping already exists."
 };
 var unmappedComponentCheck = (node, context) => {
-  if (node.type !== "COMPONENT" && node.type !== "COMPONENT_SET") return null;
-  if (isInsideInstance(context)) return null;
   if (!codeConnectIsSetUp(context)) return null;
+  let mainId = null;
+  let mainName = node.name;
+  if (node.type === "COMPONENT" || node.type === "COMPONENT_SET") {
+    if (isInsideInstance(context)) return null;
+    mainId = node.id;
+  } else if (node.type === "INSTANCE" && node.componentId) {
+    mainId = node.componentId;
+    const meta = context.file.components[node.componentId];
+    if (meta?.name) mainName = meta.name;
+  } else {
+    return null;
+  }
+  const seen = seenMainIds(context);
+  if (seen.has(mainId)) return null;
+  seen.add(mainId);
   const mappings = codeConnectMappings(context);
-  if (mappings.mappedNodeIds.has(node.id)) return null;
-  const ack = context.findAcknowledgment(node.id, unmappedComponentDef.id);
+  if (mappings.mappedNodeIds.has(mainId)) return null;
+  const ack = context.findAcknowledgment(mainId, unmappedComponentDef.id);
   if (ack && isRuleOptOutIntent(ack.intent) && ack.intent.ruleId === unmappedComponentDef.id) {
     return null;
   }
   return {
     ruleId: unmappedComponentDef.id,
-    nodeId: node.id,
+    nodeId: mainId,
     nodePath: context.path.join(" > "),
-    ...unmappedComponentMsg(node.name)
+    ...unmappedComponentMsg(mainName)
   };
 };
 defineRule({
@@ -4509,7 +4526,7 @@ function computeApplyContext(violation, instanceContext) {
 }
 
 // package.json
-var version2 = "0.12.1";
+var version2 = "0.12.2";
 
 // src/core/engine/scoring.ts
 var GRADE_ORDER = ["S", "A+", "A", "B+", "B", "C+", "C", "D", "F"];
@@ -7945,7 +7962,7 @@ function runCodeConnectChecks(cwd) {
 }
 var PUBLISH_CHECK_NAME = "Figma component published in a library";
 async function runFigmaPublishCheck(input) {
-  const { figmaUrl, token, fetchPublishedComponents } = input;
+  const { figmaUrl, token, fetchPublishedComponents, fetchNodeType } = input;
   let parsed;
   try {
     parsed = parseFigmaUrl(figmaUrl);
@@ -8011,6 +8028,23 @@ async function runFigmaPublishCheck(input) {
       detail: `${match.name} (${match.node_id})`
     };
   }
+  if (fetchNodeType) {
+    let nodeType;
+    try {
+      nodeType = await fetchNodeType(parsed.fileKey, canonicalNodeId);
+    } catch {
+      nodeType = void 0;
+    }
+    if (nodeType && nodeType !== "COMPONENT" && nodeType !== "COMPONENT_SET") {
+      return {
+        name: PUBLISH_CHECK_NAME,
+        pass: false,
+        inconclusive: true,
+        detail: `node ${canonicalNodeId} is type ${nodeType} \u2014 Code Connect mapping is per-component`,
+        remediation: "Step 7 (Code Connect close-out) skips on screen-level scope anyway. To verify a specific component, re-invoke doctor with that component's URL."
+      };
+    }
+  }
   return {
     name: PUBLISH_CHECK_NAME,
     pass: false,
@@ -8058,7 +8092,11 @@ function registerDoctor(cli2) {
       const publishCheck = await runFigmaPublishCheck({
         figmaUrl: options.figmaUrl,
         token,
-        fetchPublishedComponents: client ? (fileKey) => client.getPublishedComponents(fileKey) : void 0
+        fetchPublishedComponents: client ? (fileKey) => client.getPublishedComponents(fileKey) : void 0,
+        fetchNodeType: client ? async (fileKey, nodeId) => {
+          const response = await client.getFileNodes(fileKey, [nodeId]);
+          return response.nodes[nodeId]?.document.type;
+        } : void 0
       });
       results.push(publishCheck);
     }