canary-test-cli 7.0.0 → 7.2.0

package/dist/engine/core/workflow-discovery.js

@@ -36,6 +36,7 @@
 import { spawnSync } from 'node:child_process';
 import { existsSync, mkdirSync, readFileSync, writeFileSync } from 'node:fs';
 import { join } from 'node:path';
+import { ensureAscii } from '../util/ensure-ascii.js';
 // ---------------------------------------------------------------------------
 // Python-compatibility helpers (copied locally per-module, matching reporter.ts)
 // ---------------------------------------------------------------------------
@@ -58,13 +59,6 @@ function pyTruthy(value) {
 function pyGet(obj, key, fallback) {
     return Object.prototype.hasOwnProperty.call(obj, key) ? obj[key] : fallback;
 }
-/**
- * Reproduce Python's `json.dumps(..., ensure_ascii=True)` (the library default)
- * on `JSON.stringify` output: escape every code point >= 0x80 as `\uXXXX`.
- */
-function ensureAscii(json) {
-    return json.replace(/[\u0080-\uffff]/g, (ch) => '\\u' + ch.charCodeAt(0).toString(16).padStart(4, '0'));
-}
 /** Python `str[:n]` by CODE POINT (never splits a surrogate pair). */
 function codePointSlice(s, n) {
     return [...s].slice(0, n).join('');
@@ -120,7 +114,7 @@ export const defaultSubprocess = (cmd, opts = {}) => {
 // ---------------------------------------------------------------------------
 // Schema
 // ---------------------------------------------------------------------------
-export const SCHEMA_VERSION = 'https://github.com/bop-clocktower/canary/schemas/workflow-mapping/v1';
+const SCHEMA_VERSION = 'https://github.com/bop-clocktower/canary/schemas/workflow-mapping/v1';
 // Word-list used for automatic semantic-role heuristics.
 const ROLE_TRIGGERS = {
     qa_passed: ['qa pass', 'qa passed', 'qa done', 'tested', 'verified'],

package/dist/engine/core/workspace-detect.js

@@ -8,7 +8,7 @@
  */
 import { existsSync, readdirSync } from 'node:fs';
 import { join, relative, sep } from 'node:path';
-import { _CONFIG_PROBES, inferPlaywrightShape, probe, } from './framework-probes.js';
+import { CONFIG_PROBES, inferPlaywrightTestType, probeFramework, } from './framework-probes.js';
 import { comparePathParts, globDirs, isFile, parseJsonOrNull, readTextOrNull, } from './fs-glob.js';
 /**
  * Workspace package globs declared at *root*, from pnpm-workspace.yaml or
@@ -146,13 +146,13 @@ function toPosixRel(root, dir) {
 function configFindings(dir, rel) {
     const out = [];
     const seen = new Set();
-    for (const [filename, framework, shape, confidence] of _CONFIG_PROBES) {
+    for (const [filename, framework, shape, confidence] of CONFIG_PROBES) {
         if (!isFile(join(dir, filename)))
             continue;
         // Mirrors the config tier's own refinement: a playwright config with no
         // UI-fixture spec is an API suite, and the shape decides which skills ship.
         const refined = framework === 'playwright' && shape === 'e2e_ui'
-            ? inferPlaywrightShape(dir)
+            ? inferPlaywrightTestType(dir)
             : shape;
         // NUL separates the parts because it cannot occur in a path, a framework
         // name, or a shape -- so `a\0b` can never collide with `a` + `\0b`. Written
@@ -177,14 +177,15 @@ function configFindings(dir, rel) {
  * Findings for one package: every config-tier match, or -- only when the config
  * tier found nothing at all -- a single content-tier answer.
  *
- * The language tier is deliberately withheld; see `probe` for why inheriting a
- * root `language:` per package would invent findings (#504 part 1, spec test 8).
+ * The language tier is deliberately withheld; see `probeFramework` for why
+ * inheriting a root `language:` per package would invent findings (#504 part 1,
+ * spec test 8).
  */
 function probePackage(dir, config, rel) {
     const fromConfig = configFindings(dir, rel);
     if (fromConfig.length > 0)
         return fromConfig;
-    const [framework, shape, source, confidence] = probe(dir, config, ['content']);
+    const [framework, shape, source, confidence] = probeFramework(dir, config, ['content']);
     return framework === null
         ? []
         : [{ dir: rel, framework, shape, source, confidence }];

package/dist/engine/data/personas/registry.json

@@ -0,0 +1,36 @@
+{
+  "version": 1,
+  "fallback": "junior",
+  "minDetectionConfidence": 0.5,
+  "minDetectionSignals": 2,
+  "detectionMap": {
+    "sdet": "sdet",
+    "manual": "manual"
+  },
+  "personas": [
+    {
+      "id": "sdet",
+      "label": "Senior SDET",
+      "audience": "Writes and owns automated tests daily; fluent in the framework and the codebase.",
+      "depth": "terse",
+      "formats": ["bullets", "code"],
+      "reasoning": false
+    },
+    {
+      "id": "junior",
+      "label": "Junior SDET",
+      "audience": "Writes automated tests but is still building judgement about which ones matter.",
+      "depth": "brief",
+      "formats": ["bullets", "code", "rationale"],
+      "reasoning": true
+    },
+    {
+      "id": "manual",
+      "label": "Manual tester",
+      "audience": "Tests by hand and reads test output; may not read or write the framework's code.",
+      "depth": "guided",
+      "formats": ["numbered-steps", "rationale"],
+      "reasoning": true
+    }
+  ]
+}

package/dist/engine/guardian/adjudication.js

@@ -162,9 +162,9 @@ export function tallyAdjudications(reactions) {
 const FINDING_ROW_RE = /^\|[^|]*\|\s*\[?`([^`]+)`/;
 /**
  * Extract the file paths of the ACTIVE findings shown in a sticky-comment body
- * (PURE). Reads the rendered table `render(fmt='comment')` emitted — this is
- * deliberately parsing the exact body reviewers reacted to, not the current
- * finding set, so a reaction is attributed to what the reviewer actually saw.
+ * (PURE). Reads the rendered table `renderFindings(fmt='comment')` emitted —
+ * this is deliberately parsing the exact body reviewers reacted to, not the
+ * current finding set, so a reaction is attributed to what the reviewer saw.
  * Returns `[]` for a no-gaps body (no table).
  */
 export function activeFindingPaths(commentBody) {
@@ -204,7 +204,7 @@ export function adjudicationFilename(prNumber) {
     return `${ADJUDICATION_SOURCE}-pr-${prNumber}.json`;
 }
 /** True iff the harness home (`dirname(analysesDir)`) exists. */
-function channelAvailable(analysesDir) {
+function isChannelAvailable(analysesDir) {
     try {
         return statSync(dirname(analysesDir)).isDirectory();
     }
@@ -241,7 +241,7 @@ export async function collectAdjudications(client, args) {
         tally,
         collectedAt: args.collectedAt,
     });
-    if (!channelAvailable(args.analysesDir)) {
+    if (!isChannelAvailable(args.analysesDir)) {
         return {
             action: 'unavailable',
             path: null,

package/dist/engine/guardian/analysis-emit.js

@@ -14,7 +14,7 @@
  *     canary's records -- they never clobber a harness record and always pass
  *     `AnalysisArchive.safePath` (no traversal).
  *   - {@link buildAnalysisRecord} -- the v1.0 envelope wrapping the verbatim
- *     `render(fmt="json")` findings array.
+ *     `renderFindings(fmt="json")` findings array.
  *
  * SC-11 boundary: this module is deterministic filesystem/JSON only. It imports
  * no `AgentTier`/LLM-SDK module (only intra-guardian, agent-free helpers).
@@ -34,36 +34,25 @@
 import { createHash, randomBytes } from 'node:crypto';
 import { mkdirSync, renameSync, statSync, unlinkSync, writeFileSync, } from 'node:fs';
 import { dirname, join } from 'node:path';
+import { ensureAscii } from '../util/ensure-ascii.js';
 import { coverageDegradedNotice, coverageStatus, } from './coverage.js';
-import { combineNotices, render } from './pr-check.js';
+import { combineNotices, renderFindings, } from './pr-check.js';
 // 1.1 adds the additive `coverage` block (#554); readers of 1.0 are unaffected.
 // 1.2 adds the additive `skipped` list (#582). Additive again, and bumped again
 // for the reason recorded in #572: a reader that pins a version must be able to
 // tell which fields it can rely on being present, and silence about a new field
 // is indistinguishable from the field being absent for a real reason.
-export const SCHEMA_VERSION = '1.2';
-export const SOURCE = 'canary-pr-guardian';
+// 1.3 adds the additive `provenance` block (#761). Same additive rule. This is
+// the field an archived record needs most: when a run is questioned WEEKS later
+// from its uploaded artifact, `checked: 43` is only interpretable next to the
+// diff endpoints that produced it.
+export const SCHEMA_VERSION = '1.3';
+const ANALYSIS_SOURCE = 'canary-pr-guardian';
 const REF_SAFE = /[^A-Za-z0-9._-]/g;
 const REF_MAX = 100; // cap the sanitized ref so a long branch never hits ENAMETOOLONG
 // The loud-fallback notices carry an em-dash (U+2014) as output data; written as
 // an escape to honor the ASCII-source rule.
 const EM_DASH = '\u{2014}';
-/**
- * Escape every non-ASCII (>= U+0080) code unit to a `\uXXXX` sequence, matching
- * Python's `json.dumps(..., ensure_ascii=True)` (the library default).
- */
-function ensureAscii(json) {
-    // Escape every UTF-16 code UNIT >= 0x80 to \uXXXX, matching Python
-    // json.dumps(ensure_ascii=True). Iterating by unit (not code point) means an
-    // astral char's surrogate pair emits \udXXX\udXXX, like Python; a code-point
-    // regex would stop at U+FFFF and leave astral chars raw.
-    let out = '';
-    for (let i = 0; i < json.length; i++) {
-        const c = json.charCodeAt(i);
-        out += c >= 0x80 ? '\\u' + c.toString(16).padStart(4, '0') : json[i];
-    }
-    return out;
-}
 /** Trim leading/trailing `-` characters (Python `str.strip("-")`). */
 function stripDashes(value) {
     return value.replace(/^-+/, '').replace(/-+$/, '');
@@ -76,7 +65,7 @@ function stripDashes(value) {
  * `REF_MAX` chars with a short hash suffix appended to preserve uniqueness --
  * only when truncation actually happens. Short refs are unchanged.
  */
-export function analysisFilename(ref, source = SOURCE) {
+export function analysisFilename(ref, source = ANALYSIS_SOURCE) {
     let safe = stripDashes(ref.replace(REF_SAFE, '-')) || 'local';
     if (safe.length > REF_MAX) {
         // sha1 is a filename disambiguator (not a security digest); it matches the
@@ -96,7 +85,8 @@ function isoUtcNow() {
     return new Date().toISOString().replace('Z', '+00:00');
 }
 /**
- * Build the v1.0 envelope. `findings` is exactly `render(fmt='json')`'s array.
+ * Build the v1.0 envelope. `findings` is exactly the array from
+ * `renderFindings(fmt='json')`.
  */
 export function buildAnalysisRecord(findings, args) {
     const { ref, gate, effective_tier, degraded_notice, exit_code } = args;
@@ -104,7 +94,7 @@ export function buildAnalysisRecord(findings, args) {
     // input's — so "no findings" can never be read as "coverage said so".
     const coverage = args.coverage ?? null;
     const notice = combineNotices(degraded_notice, coverage ? coverageDegradedNotice(coverage) : null);
-    const inner = JSON.parse(render(findings, 'json', effective_tier, notice));
+    const inner = JSON.parse(renderFindings(findings, 'json', effective_tier, notice));
     const active = findings.filter((f) => !f.suppressed);
     const suppressed = findings.filter((f) => f.suppressed);
     const byFidelity = {};
@@ -113,7 +103,7 @@ export function buildAnalysisRecord(findings, args) {
     }
     return {
         schemaVersion: SCHEMA_VERSION,
-        source: SOURCE,
+        source: ANALYSIS_SOURCE,
         ref,
         gate,
         exitCode: exit_code,
@@ -125,6 +115,7 @@ export function buildAnalysisRecord(findings, args) {
             ? null
             : { status: coverageStatus(coverage), ...coverage },
         skipped: args.skipped ?? [],
+        provenance: args.provenance ?? null,
         summary: {
             total: findings.length,
             unaddressed: active.length,
@@ -151,7 +142,7 @@ export const emitSeams = {
  * The analyses dir itself is created on demand by {@link emitAnalysis} (mirroring
  * harness `AnalysisArchive.save`'s recursive `mkdir`).
  */
-export function channelAvailable(analysesDir) {
+export function isChannelAvailable(analysesDir) {
     try {
         return statSync(dirname(analysesDir)).isDirectory();
     }
@@ -168,7 +159,7 @@ export function channelAvailable(analysesDir) {
  */
 export function emitAnalysis(findings, args) {
     const { analysesDir } = args;
-    if (!channelAvailable(analysesDir)) {
+    if (!isChannelAvailable(analysesDir)) {
         return {
             action: 'unavailable',
             path: null,
@@ -178,8 +169,8 @@ export function emitAnalysis(findings, args) {
     }
     const target = join(analysesDir, analysisFilename(args.ref));
     try {
-        // Build INSIDE the try: a non-I/O error (from JSON/render) would otherwise
-        // crash pr-check instead of degrading.
+        // Build INSIDE the try: a non-I/O error (from JSON/renderFindings) would
+        // otherwise crash pr-check instead of degrading.
         const record = emitSeams.buildAnalysisRecord(findings, args);
         mkdirSync(analysesDir, { recursive: true });
         // Atomic write: stage into a same-dir temp then rename (atomic on one