canary-test-cli 6.4.0 → 6.5.0

package/dist/gate-result.d.ts

@@ -0,0 +1,67 @@
+/**
+ * Shared gate-abstention helper (issue #508, no-silent-abstention spec).
+ *
+ * Doctrine: a check that verified zero items has ABSTAINED, not passed.
+ * Every gate reports its denominator (`checked`); zero is a distinct loud
+ * outcome. "Skipped" renders in every summary line and never aggregates
+ * into "passed" (D7).
+ *
+ * `gateOutcome` is the only path to a summary line for swept commands, so
+ * the refusal to print bare success on a zero denominator is structural.
+ * Surfaces append their own remediation text (why the denominator
+ * collapsed, first fix step) after the summary line.
+ *
+ * Output glyphs are written as `\u{...}` escapes so this source stays
+ * ASCII while the emitted bytes match the rest of the CLI (warning sign
+ * U+26A0, em dash U+2014).
+ */
+/** A check that was not run, and why. Always visible, never "passed". */
+export interface SkipEntry {
+    name: string;
+    reason: string;
+}
+/** What a gate actually verified: its denominator and what it found. */
+export interface GateResult<F> {
+    /** How many items were actually verified. Skipped items do NOT count. */
+    checked: number;
+    findings: F[];
+    skipped?: SkipEntry[];
+}
+/**
+ * Reserved CLI-wide (D4): exit 3 always means "abstained -- verified zero
+ * items", distinct from 0 (clean), 1 (findings), 2 (surface-specific).
+ */
+export declare const EXIT_ABSTAINED = 3;
+/**
+ * D3: a "gate" has an exit-code contract and fails loud (exit 3) on a zero
+ * denominator; an "advisory" command warns unmissably but exits 0 -- an
+ * empty answer honestly labeled is not an error.
+ */
+export type GateKind = 'gate' | 'advisory';
+export interface GateOutcome {
+    exitCode: number;
+    abstained: boolean;
+    summaryLine: string;
+}
+/** Copy hooks: surfaces adapt wording without re-owning the decision. */
+export interface GateOutcomeOptions {
+    /** Unit noun for the clean-pass line. Default: `'check(s)'`. */
+    noun?: string;
+}
+/**
+ * D7: skipped entries render in EVERY summary line.
+ *
+ * Exported so a surface with its own failure vocabulary (doctor says
+ * "check(s) failed", not "finding(s)") can render the identical skip suffix
+ * instead of re-deriving the format -- the decision still comes from
+ * {@link gateOutcome}, only the noun differs.
+ */
+export declare function skippedSuffix(skipped?: SkipEntry[]): string;
+/**
+ * The single summary-line/exit-code path for swept commands.
+ *
+ * Non-abstained exit codes are helper defaults (findings -> 1 for gates);
+ * surfaces with richer contracts (e.g. freshness 2 = local edits) apply
+ * their own mapping AFTER checking `abstained`.
+ */
+export declare function gateOutcome<F>(result: GateResult<F>, kind: GateKind, opts?: GateOutcomeOptions): GateOutcome;

package/dist/gate-result.js

@@ -0,0 +1,73 @@
+"use strict";
+// GENERATED FILE — DO NOT EDIT.
+// Verbatim copy of ts/src/core/gate-result.ts, mirrored into this CommonJS
+// package by scripts/sync-gate-result.mjs because the staged engine bundle is
+// ESM and unavailable at test time. Edit the engine source and re-run:
+//   node scripts/sync-gate-result.mjs
+// `npm test` verifies this copy has not drifted (--check runs as pretest).
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.EXIT_ABSTAINED = void 0;
+exports.skippedSuffix = skippedSuffix;
+exports.gateOutcome = gateOutcome;
+/**
+ * Reserved CLI-wide (D4): exit 3 always means "abstained -- verified zero
+ * items", distinct from 0 (clean), 1 (findings), 2 (surface-specific).
+ */
+exports.EXIT_ABSTAINED = 3;
+const WARN = '\u{26A0}'; // warning sign
+const EMDASH = '\u{2014}'; // em dash
+// C0 controls (incl. \n, ESC) and DEL: a skip name must never be able to
+// forge output lines or smuggle ANSI sequences into the summary.
+const CONTROL_CHARS = /[\u0000-\u001F\u007F]/g;
+/**
+ * D7: skipped entries render in EVERY summary line.
+ *
+ * Exported so a surface with its own failure vocabulary (doctor says
+ * "check(s) failed", not "finding(s)") can render the identical skip suffix
+ * instead of re-deriving the format -- the decision still comes from
+ * {@link gateOutcome}, only the noun differs.
+ */
+function skippedSuffix(skipped) {
+    if (!skipped || skipped.length === 0)
+        return '';
+    const names = skipped
+        .map((s) => s.name.replace(CONTROL_CHARS, ''))
+        .join(', ');
+    return ` (${skipped.length} skipped: ${names})`;
+}
+/**
+ * The single summary-line/exit-code path for swept commands.
+ *
+ * Non-abstained exit codes are helper defaults (findings -> 1 for gates);
+ * surfaces with richer contracts (e.g. freshness 2 = local edits) apply
+ * their own mapping AFTER checking `abstained`.
+ */
+function gateOutcome(result, kind, opts = {}) {
+    const noun = opts.noun ?? 'check(s)';
+    const suffix = skippedSuffix(result.skipped);
+    // Findings outrank abstention: a finding proves something was checked,
+    // so it must never be masked by a collapsed/invalid denominator.
+    if (result.findings.length > 0) {
+        return {
+            exitCode: kind === 'gate' ? 1 : 0,
+            abstained: false,
+            summaryLine: `${result.findings.length} finding(s) across ` +
+                `${result.checked} checked${suffix}`,
+        };
+    }
+    // Negated comparison so 0, negatives, and NaN all abstain: an invalid
+    // denominator must never render as success.
+    if (!(result.checked > 0)) {
+        return {
+            exitCode: kind === 'gate' ? exports.EXIT_ABSTAINED : 0,
+            abstained: true,
+            summaryLine: `${WARN} Abstained ${EMDASH} verified zero items; ` +
+                `this is not a pass.${suffix}`,
+        };
+    }
+    return {
+        exitCode: 0,
+        abstained: false,
+        summaryLine: `All ${result.checked} run ${noun} passed${suffix}`,
+    };
+}

package/dist/overlay-commands.js

@@ -51,6 +51,7 @@ const registry = __importStar(require("./overlays-registry.js"));
 const doctor_manifest_js_1 = require("./doctor-manifest.js");
 const overlay_conflicts_js_1 = require("./overlay-conflicts.js");
 const overlay_lint_js_1 = require("./overlay-lint.js");
+const gate_result_js_1 = require("./gate-result.js");
 const defaultGit = (args, opts = {}) => {
     const r = (0, node_child_process_1.spawnSync)('git', args, { cwd: opts.cwd, encoding: 'utf8' });
     if (r.error) {
@@ -373,12 +374,27 @@ function lint(nameOrPath, deps = {}, opts = {}) {
     }
     const result = (0, overlay_lint_js_1.lintOverlay)(dir);
     const errors = result.findings.filter((f) => f.level === 'error');
+    // #508: linting zero skills is an ABSENT verdict, not a clean bill of health.
+    // Advisory (D3) -- a workflows-only overlay is legitimate, so the exit stays
+    // 0 -- but the line is unmissable and `--json` says so. Findings outrank
+    // abstention inside `gateOutcome`, so a missing skills dir still exits 1.
+    const outcome = (0, gate_result_js_1.gateOutcome)({ checked: result.skillsChecked, findings: result.findings }, 'advisory');
     if (opts.json) {
-        out.write(`${JSON.stringify(result, null, 2)}\n`);
+        out.write(`${JSON.stringify({
+            ...result,
+            checked: result.skillsChecked,
+            abstained: outcome.abstained,
+        }, null, 2)}\n`);
         return errors.length === 0 ? 0 : 1;
     }
     const symbol = (f) => (f.level === 'error' ? '✗' : '⚠');
     out.write(`canary overlay lint: ${nameOrPath}\n`);
+    if (outcome.abstained) {
+        out.write(`\n${outcome.summaryLine}\n`);
+        out.write(`  No skill directories under ${dir}/.canary/skills, so nothing was ` +
+            `linted. Add a skill, or lint the overlay that actually ships them.\n`);
+        return 0;
+    }
     if (result.findings.length === 0) {
         out.write(`\n✓ ${result.skillsChecked} skill(s) — no issues.\n`);
         return 0;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "canary-test-cli",
-  "version": "6.4.0",
+  "version": "6.5.0",
   "description": "Canary — AI-powered test automation agent",
   "license": "MIT",
   "repository": {
@@ -30,6 +30,7 @@
   "scripts": {
     "build": "tsc && node scripts/build-engine.mjs",
     "prepare": "npm run build",
+    "pretest": "node scripts/sync-gate-result.mjs --check",
     "test": "tsc && node --test \"scripts/__tests__/*.test.js\""
   },
   "engines": {