camunda-bpmn-js 0.12.1 → 0.12.2

package/CHANGELOG.md

@@ -6,6 +6,11 @@ All notable changes to [camunda-bpmn-js](https://github.com/camunda/camunda-bpmn
 
 ___Note:__ Yet to be released changes appear here._
 
+## 0.12.2
+
+* `FEAT`: behavior for Cloud to ensure that no empty `zeebe:AssignmentDefinitions`
+  remain in the model after modeling or propertyPanel operations ([e26c486](https://github.com/camunda/camunda-bpmn-js/commit/e26c486bac3b54202fdf6c2b09d64483b52a2298))
+
 ## 0.12.1
 
 * `DEPS`: update to `zeebe-bpmn-moddle@0.10.0`

package/dist/camunda-cloud-modeler.development.js

@@ -72072,13 +72072,82 @@
 	const HIGH_PRIORITY$l = 5000;
 
 
+	/**
+	 * Zeebe BPMN behavior for ensuring that there are not empty (ie. without properties)
+	 * zeebe:assignmentDefinitions after modeling operations. Will also remove related
+	 * extensionElements, if they remain empty afterwards (could be a seperate
+	 * behavior in the future, if needed)
+	 */
+	class CleanUpBusinessRuleTaskBehavior extends CommandInterceptor {
+	  constructor(eventBus, modeling) {
+	    super(eventBus);
+
+	    /**
+	     * Remove zeebe:assignmentDefinition when it has no defined properties left after the operation
+	     */
+	    this.postExecuted([
+	      'properties-panel.update-businessobject',
+	      'element.updateModdleProperties'
+	    ] , HIGH_PRIORITY$l, function(context) {
+	      const {
+	        element,
+	        businessObject,
+	        moddleElement
+	      } = context;
+
+	      // (1) harmonize property names from commands
+	      const assignmentDefintion = businessObject || moddleElement;
+
+	      if (
+	        is$1(element, 'bpmn:UserTask')
+	        && assignmentDefintion
+	        && is$1(assignmentDefintion, 'zeebe:AssignmentDefinition')
+	        && assignmentDefintion.assignee === undefined
+	        && assignmentDefintion.candidateGroups === undefined
+	      ) {
+	        const extensionElements = getBusinessObject(element).extensionElements;
+
+	        // (2) remove zeebe:assignmentDefintion
+	        removeFromExtensionElements(element, extensionElements, modeling,
+	          (ele) => !is$1(ele, 'zeebe:AssignmentDefinition'));
+
+	        // (3) if extensionElements are empty afterwards, remove them as well
+	        if (extensionElements.values.length === 0) {
+	          modeling.updateModdleProperties(element, getBusinessObject(element),
+	            { extensionElements: undefined });
+	        }
+	      }
+	    }, true);
+
+	  }
+	}
+
+	CleanUpBusinessRuleTaskBehavior.$inject = [
+	  'eventBus',
+	  'modeling'
+	];
+
+
+	// helper ////////////////////
+
+	function removeFromExtensionElements(element, extensionElements, modeling, filterFun) {
+	  const values = extensionElements.get('values').filter(filterFun);
+
+	  modeling.updateModdleProperties(element, extensionElements, {
+	    values
+	  });
+	}
+
+	const HIGH_PRIORITY$m = 5000;
+
+
 	/**
 	 * Zeebe BPMN behavior for ensuring that a BusinessRuleTask:
 	 * 1) Either has a taskDefinition ExtensionElement OR
 	 * 2) Or has a calledDecision ExtensionElement
 	 * 2.1) If it has a calledDecision ExtensionElement, it shall not have taskHeaders
 	 */
-	class CleanUpBusinessRuleTaskBehavior extends CommandInterceptor {
+	class CleanUpBusinessRuleTaskBehavior$1 extends CommandInterceptor {
 	  constructor(eventBus, modeling) {
 	    super(eventBus);
 
@@ -72088,7 +72157,7 @@
 	    this.postExecute([
 	      'properties-panel.update-businessobject-list',
 	      'element.updateModdleProperties'
-	    ] , HIGH_PRIORITY$l, function(context) {
+	    ] , HIGH_PRIORITY$m, function(context) {
 	      const {
 	        element,
 	        currentObject,
@@ -72120,7 +72189,7 @@
 	    this.postExecute([
 	      'properties-panel.update-businessobject-list',
 	      'element.updateModdleProperties'
-	    ] , HIGH_PRIORITY$l, function(context) {
+	    ] , HIGH_PRIORITY$m, function(context) {
 	      const {
 	        element,
 	        currentObject,
@@ -72150,7 +72219,7 @@
 	  }
 	}
 
-	CleanUpBusinessRuleTaskBehavior.$inject = [
+	CleanUpBusinessRuleTaskBehavior$1.$inject = [
 	  'eventBus',
 	  'modeling'
 	];
@@ -72158,7 +72227,7 @@
 
 	// helper ////////////////////
 
-	function removeFromExtensionElements(element, extensionElements, modeling, filterFun) {
+	function removeFromExtensionElements$1(element, extensionElements, modeling, filterFun) {
 	  const values = extensionElements.get('values').filter(filterFun);
 
 	  modeling.updateModdleProperties(element, extensionElements, {
@@ -72167,16 +72236,16 @@
 	}
 
 	function removeCalledDecision(element, extensionElements, modeling) {
-	  removeFromExtensionElements(element, extensionElements, modeling,
+	  removeFromExtensionElements$1(element, extensionElements, modeling,
 	    (ele) => !is$1(ele, 'zeebe:CalledDecision'));
 	}
 
 	function removeTaskDefintionAndHeaders(element, extensionElements, modeling) {
-	  removeFromExtensionElements(element, extensionElements, modeling,
+	  removeFromExtensionElements$1(element, extensionElements, modeling,
 	    (ele) => !is$1(ele, 'zeebe:TaskDefinition') && !is$1(ele, 'zeebe:TaskHeaders'));
 	}
 
-	const HIGH_PRIORITY$m = 5000;
+	const HIGH_PRIORITY$n = 5000;
 
 
 	/**
@@ -72189,7 +72258,7 @@
 	    /**
 	     * Replace intermediate catch event with boundary event when attaching it to a shape.
 	     */
-	    this.preExecute('shape.create', HIGH_PRIORITY$m, function(context) {
+	    this.preExecute('shape.create', HIGH_PRIORITY$n, function(context) {
 	      const {
 	        shape,
 	        host
@@ -72474,7 +72543,7 @@
 	  }
 	}
 
-	const HIGH_PRIORITY$n = 5000;
+	const HIGH_PRIORITY$o = 5000;
 
 
 	/**
@@ -72488,7 +72557,7 @@
 	     * Add zeebe:CalledElement extension element with zeebe:propagateAllChildVariables attribute = false
 	     * when creating bpmn:CallActivity.
 	     */
-	    this.postExecuted('shape.create', HIGH_PRIORITY$n, function(context) {
+	    this.postExecuted('shape.create', HIGH_PRIORITY$o, function(context) {
 	      const { shape } = context;
 
 	      if (!is$1(shape, 'bpmn:CallActivity')) {
@@ -72536,7 +72605,7 @@
 	  'modeling'
 	];
 
-	const HIGH_PRIORITY$o = 5000;
+	const HIGH_PRIORITY$p = 5000;
 
 
 	/**
@@ -72549,7 +72618,7 @@
 	    /**
 	     * Remove zeebe:OutputParameters when zeebe:propagateAllChildVariables is set to true.
 	     */
-	    this.postExecute('properties-panel.update-businessobject' , HIGH_PRIORITY$o, function(context) {
+	    this.postExecute('properties-panel.update-businessobject' , HIGH_PRIORITY$p, function(context) {
 	      const {
 	        element,
 	        properties
@@ -72594,7 +72663,7 @@
 	    /**
 	     * Set zeebe:propagateAllChildVariables to false on zeebe:Output added.
 	     */
-	    this.postExecute('properties-panel.update-businessobject-list' , HIGH_PRIORITY$o, function(context) {
+	    this.postExecute('properties-panel.update-businessobject-list' , HIGH_PRIORITY$p, function(context) {
 	      const {
 	        currentObject,
 	        element,
@@ -72821,13 +72890,15 @@
 
 	var zeebeModelingBehaviors = {
 	  __init__: [
+	    'cleanUpAssignmentDefinitionBehavior',
 	    'cleanUpBusinessRuleTaskBehavior',
 	    'createZeebeBoundaryEventBehavior',
 	    'createZeebeCallActivityBehavior',
 	    'updatePropagateAllChildVariablesBehavior',
 	    'formDefinitionBehavior'
 	  ],
-	  cleanUpBusinessRuleTaskBehavior: [ 'type', CleanUpBusinessRuleTaskBehavior ],
+	  cleanUpAssignmentDefinitionBehavior: [ 'type', CleanUpBusinessRuleTaskBehavior ],
+	  cleanUpBusinessRuleTaskBehavior: [ 'type', CleanUpBusinessRuleTaskBehavior$1 ],
 	  createZeebeBoundaryEventBehavior: [ 'type', CreateZeebeBoundaryEventBehavior ],
 	  createZeebeCallActivityBehavior: [ 'type', CreateZeebeCallActivityBehavior ],
 	  updatePropagateAllChildVariablesBehavior: [ 'type', UpdatePropagateAllChildVariablesBehavior ],
@@ -73056,7 +73127,7 @@
 	  zeebeReplaceMenuProvider: [ 'type', ReplaceMenuProvider$1 ]
 	};
 
-	const HIGH_PRIORITY$p = 5000;
+	const HIGH_PRIORITY$q = 5000;
 
 	/**
 	 * Zeebe rule provider that allows to create boundary events with catch events
@@ -73074,7 +73145,7 @@
 
 	  init() {
 	    super.init();
-	    this.addRule('shape.attach', HIGH_PRIORITY$p,(context) => {
+	    this.addRule('shape.attach', HIGH_PRIORITY$q,(context) => {
 	      return this.canAttach(
 	        context.shape,
 	        context.target,