camunda-bpmn-js 0.11.4 → 0.12.2

package/lib/camunda-cloud/helper/CalledElementHelper.js

@@ -1,70 +1,72 @@
-import {
-  has
-} from 'min-dash';
+import { has } from 'min-dash';
 
-import {
-  getOutputParameters
-} from './InputOutputHelper';
+import { getOutputParameters } from './InputOutputHelper';
 
-import {
-  getExtensionElements
-} from 'bpmn-js-properties-panel/lib/helper/ExtensionElementsHelper';
-
-import {
-  getBusinessObject
-} from 'bpmn-js/lib/util/ModelUtil';
+import { getExtensionElements } from 'bpmn-js-properties-panel/lib/helper/ExtensionElementsHelper';
 
 import {
+  getBusinessObject,
   is
 } from 'bpmn-js/lib/util/ModelUtil';
 
+
 /**
-  * Determine default value for propagateAllChildVariables attribute
-  * @param {Object} element representing a bpmn:CallActivity
-  *
-  * @returns {boolean}
-  */
-function determinePropAllChildVariablesDefault(element) {
+ * Get default value for zeebe:propagateAllChildVariables.
+ *
+ * @param {djs.model.Base|ModdleElement} element
+ *
+ * @returns {boolean}
+ */
+function getPropagateAllChildVariablesDefault(element) {
+  if (!is(element, 'bpmn:CallActivity')) {
+    return;
+  }
+
   const outputParameters = getOutputParameters(element);
 
   if (outputParameters) {
-    return (outputParameters.length > 0) ? false : true;
+    return !outputParameters.length;
   }
 }
 
 /**
-  * Get the 'zeebe:CalledElement' extension element for a given business Object
-  * @param {Object} bo businessObject
-  *
-  * @returns {Object} the calledElement Moddle Object or undefined if zeebe:CalledElement does not exist
-  */
+ * Get zeebe:CalledElement of an element.
+ *
+ * @param {djs.model.Base|ModdleElement} element
+ *
+ * @returns {ModdleElement}
+ */
 export function getCalledElement(element) {
   const calledElements = getCalledElements(element);
-  return calledElements[0];
+
+  return calledElements[ 0 ];
 }
 
 export function getCalledElements(element) {
-  const bo = getBusinessObject(element);
-  const extElements = getExtensionElements(bo, 'zeebe:CalledElement');
-  return extElements;
+  const businessObject = getBusinessObject(element);
+
+  return getExtensionElements(businessObject, 'zeebe:CalledElement');
 }
 
 /**
-  * Check whether the propagateAllChildVariables attribute is set on an element.
-  * Note that a default logic will be determine if it is not explicitly set.
-  * @param {Object} element
-  *
-  * @returns {boolean}
-  */
+ * Check whether zeebe:propagateAllChildVariables is set on an element.
+ * Fall back to default if zeebe:propagateAllChildVariables not set.
+ *
+ * @param {djs.model.Base|ModdleElement} element
+ *
+ * @returns {boolean}
+ */
 export function isPropagateAllChildVariables(element) {
   if (!is(element, 'bpmn:CallActivity')) {
-    return undefined;
+    return;
   }
 
-  const bo = getBusinessObject(element),
-        calledElement = getCalledElement(bo);
+  const businessObject = getBusinessObject(element),
+        calledElement = getCalledElement(businessObject);
 
-  return calledElement && has(calledElement, 'propagateAllChildVariables') ?
-    calledElement.get('propagateAllChildVariables') :
-    determinePropAllChildVariablesDefault(element);
+  if (calledElement && has(calledElement, 'propagateAllChildVariables')) {
+    return calledElement.get('propagateAllChildVariables');
+  } else {
+    return getPropagateAllChildVariablesDefault(element);
+  }
 }

package/lib/camunda-cloud/helper/FormsHelper.js

@@ -1,6 +1,4 @@
-import {
-  getExtensionElements
-} from 'bpmn-js-properties-panel/lib/helper/ExtensionElementsHelper';
+import { getExtensionElements } from 'bpmn-js-properties-panel/lib/helper/ExtensionElementsHelper';
 
 import elementHelper from 'bpmn-js-properties-panel/lib/helper/ElementHelper';
 
@@ -9,47 +7,12 @@ import {
   is
 } from 'bpmn-js/lib/util/ModelUtil';
 
-import {
-  nextId
-} from 'bpmn-js-properties-panel/lib/Utils';
-
-import {
-  find
-} from 'min-dash';
-
-const USER_TASK_FORM_PREFIX = 'userTaskForm_';
-
-
-export function getUserTaskForm(element, parent) {
+import { nextId } from 'bpmn-js-properties-panel/lib/Utils';
 
-  const rootElement = parent || getRootElement(element);
-
-  // (1) get form definition from user task
-  const formDefinition = getFormDefinition(element);
-
-  if (!formDefinition) {
-    return;
-  }
+import { find } from 'min-dash';
 
-  const formKey = formDefinition.get('formKey');
+const USER_TASK_FORM_PREFIX = 'UserTaskForm_';
 
-  // (2) retrieve user task form via form key
-  const userTaskForm = findUserTaskForm(formKey, rootElement);
-
-  return userTaskForm;
-}
-
-export function getFormDefinition(element) {
-  const businessObject = getBusinessObject(element);
-
-  const formDefinitions = getExtensionElements(businessObject, 'zeebe:FormDefinition');
-
-  return formDefinitions[0];
-}
-
-export function createFormKey(formId) {
-  return 'camunda-forms:bpmn:' + formId;
-}
 
 export function createFormDefinition(properties, extensionElements, bpmnFactory) {
   return elementHelper.createElement(
@@ -60,6 +23,14 @@ export function createFormDefinition(properties, extensionElements, bpmnFactory)
   );
 }
 
+export function createFormId() {
+  return nextId(USER_TASK_FORM_PREFIX);
+}
+
+export function createFormKey(formId) {
+  return `camunda-forms:bpmn:${ formId }`;
+}
+
 export function createUserTaskForm(properties, extensionElements, bpmnFactory) {
   return elementHelper.createElement(
     'zeebe:UserTaskForm',
@@ -69,19 +40,22 @@ export function createUserTaskForm(properties, extensionElements, bpmnFactory) {
   );
 }
 
-export function createFormId() {
-  return nextId(USER_TASK_FORM_PREFIX);
-}
+function findUserTaskForm(formKey, rootElement) {
+  const userTaskForms = getExtensionElements(rootElement, 'zeebe:UserTaskForm');
 
+  return find(userTaskForms, function(userTaskForm) {
+    const id = userTaskForm.get('zeebe:id');
 
-// helpers /////////////////////
+    return createFormKey(id) === formKey;
+  });
+}
 
-function findUserTaskForm(formKey, rootElement) {
-  const forms = getExtensionElements(rootElement, 'zeebe:UserTaskForm');
+export function getFormDefinition(element) {
+  const businessObject = getBusinessObject(element);
 
-  return find(forms, function(userTaskForm) {
-    return createFormKey(userTaskForm.id) === formKey;
-  });
+  const formDefinitions = getExtensionElements(businessObject, 'zeebe:FormDefinition');
+
+  return formDefinitions[ 0 ];
 }
 
 function getRootElement(element) {
@@ -93,4 +67,18 @@ function getRootElement(element) {
   }
 
   return parent;
+}
+
+export function getUserTaskForm(element, parent) {
+  const rootElement = parent || getRootElement(element);
+
+  const formDefinition = getFormDefinition(element);
+
+  if (!formDefinition) {
+    return;
+  }
+
+  const formKey = formDefinition.get('zeebe:formKey');
+
+  return findUserTaskForm(formKey, rootElement);
 }

package/lib/camunda-cloud/helper/InputOutputHelper.js

@@ -1,132 +1,135 @@
 import {
-  getBusinessObject
+  getBusinessObject,
+  is
 } from 'bpmn-js/lib/util/ModelUtil';
 
-import {
-  isAny
-} from 'bpmn-js/lib/features/modeling/util/ModelingUtil';
+import { isAny } from 'bpmn-js/lib/features/modeling/util/ModelingUtil';
 
-import {
-  isZeebeServiceTask
-} from './ZeebeServiceTaskHelper';
+import elementHelper from 'bpmn-js-properties-panel/lib/helper/ElementHelper';
 
-import extensionElementsHelper from 'bpmn-js-properties-panel/lib/helper/ExtensionElementsHelper';
+import { isZeebeServiceTask } from './ZeebeServiceTaskHelper';
 
-import elementHelper from 'bpmn-js-properties-panel/lib/helper/ElementHelper';
 
+/**
+ * Get zeebe:IoMapping from an element.
+ *
+ * @param {djs.model.Base|ModdleElement} element
+ *
+ * @return {ModdleElement}
+ */
+export function getIoMapping(element) {
+  const businessObject = getBusinessObject(element);
 
-function getElements(bo, type, prop) {
-  const elems = extensionElementsHelper.getExtensionElements(bo, type);
-  return !prop ? elems : (elems[0] || {})[prop] || [];
-}
+  const extensionElements = businessObject.get('extensionElements');
 
-function getParameters(element, prop) {
-  const inputOutput = getInputOutput(element);
-  return (inputOutput && inputOutput.get(prop)) || [];
-}
+  if (!extensionElements) {
+    return;
+  }
 
-/**
-   * Get a inputOutput from the business object
-   *
-   * @param {djs.model.Base} element
-   *
-   * @return {ModdleElement} the inputOutput object
-   */
-export function getInputOutput(element) {
-  const bo = getBusinessObject(element);
-  return (getElements(bo, 'zeebe:IoMapping') || [])[0];
+  return extensionElements.get('values').find((value) => {
+    return is(value, 'zeebe:IoMapping');
+  });
 }
 
-
 /**
-   * Return all input parameters existing in the business object, and
-   * an empty array if none exist.
-   *
-   * @param  {djs.model.Base} element
-   *
-   * @return {Array} a list of input parameter objects
-   */
+ * Get zeebe:InputParameters from an element.
+ *
+ * @param  {djs.model.Base|ModdleElement} element
+ *
+ * @return {Array<ModdleElement>}
+ */
 export function getInputParameters(element) {
-  return getParameters.apply(this, [ element, 'inputParameters' ]);
+  const ioMapping = getIoMapping(element);
+
+  if (ioMapping) {
+    return ioMapping.get('zeebe:inputParameters');
+  }
+
+  return [];
 }
 
 /**
-   * Return all output parameters existing in the business object, and
-   * an empty array if none exist.
-   *
-   * @param  {djs.model.Base} element
-   *
-   * @return {Array} a list of output parameter objects
-   */
+ * Get zeebe:OutputParameters from an element.
+ *
+ * @param  {djs.model.Base|ModdleElement} element
+ *
+ * @return {Array<ModdleElement>}
+ */
 export function getOutputParameters(element) {
-  return getParameters.apply(this, [ element, 'outputParameters' ]);
+  const ioMapping = getIoMapping(element);
+
+  if (ioMapping) {
+    return ioMapping.get('zeebe:outputParameters');
+  }
+
+  return [];
 }
 
 /**
-   * Get a input parameter from the business object at given index
-   *
-   * @param {djs.model.Base} element
-   * @param {number} idx
-   *
-   * @return {ModdleElement} input parameter
-   */
-export function getInputParameter(element, idx) {
-  return getInputParameters(element)[idx];
+ * Get zeebe:Input at index.
+ *
+ * @param {djs.model.Base|ModdleElement} element
+ * @param {number} index
+ *
+ * @return {ModdleElement}
+ */
+export function getInputParameter(element, index) {
+  return getInputParameters(element)[ index ];
 }
 
 /**
-   * Get a output parameter from the business object at given index
-   *
-   * @param {djs.model.Base} element
-   * @param {number} idx
-   *
-   * @return {ModdleElement} output parameter
-   */
-export function getOutputParameter(element, idx) {
-  return getOutputParameters(element)[idx];
+ * Get zeebe:Output at index.
+ *
+ * @param {djs.model.Base|ModdleElement} element
+ * @param {number} index
+ *
+ * @return {ModdleElement}
+ */
+export function getOutputParameter(element, index) {
+  return getOutputParameters(element)[ index ];
 }
 
 /**
-   * Returns 'true' if the given element supports inputOutput
-   *
-   * @param {djs.model.Base} element
-   *
-   * @return {boolean} a boolean value
-   */
+ * Check whether element supports zeebe:Input or zeebe:Output.
+ *
+ * @param {djs.model.Base|ModdleElement} element
+ *
+ * @return {boolean}
+ */
 export function isInputOutputSupported(element) {
-  return areOutputParametersSupported(element) || areInputParametersSupported(element);
+  return areInputParametersSupported(element) || areOutputParametersSupported(element);
 }
 
 /**
-   * Returns 'true' if the given element supports input parameters
-   *
-   * @param {djs.model.Base} element
-   *
-   * @return {boolean} a boolean value
-   */
+ * Check whether element supports zeebe:Input.
+ *
+ * @param {djs.model.Base|ModdleElement} element
+ *
+ * @return {boolean}
+ */
 export function areInputParametersSupported(element) {
   return isAny(element, [
-    'bpmn:UserTask',
+    'bpmn:CallActivity',
     'bpmn:SubProcess',
-    'bpmn:CallActivity'
+    'bpmn:UserTask'
   ]) || isZeebeServiceTask(element);
 }
 
 /**
-   * Returns 'true' if the given element supports output parameters
-   *
-   * @param {djs.model.Base} element
-   *
-   * @return {boolean} a boolean value
-   */
+ * Check whether element supports zeebe:Output.
+ *
+ * @param {djs.model.Base|ModdleElement} element
+ *
+ * @return {boolean}
+ */
 export function areOutputParametersSupported(element) {
   return isAny(element, [
-    'zeebe:ZeebeServiceTask',
-    'bpmn:UserTask',
-    'bpmn:SubProcess',
-    'bpmn:ReceiveTask',
     'bpmn:CallActivity',
-    'bpmn:Event'
+    'bpmn:Event',
+    'bpmn:ReceiveTask',
+    'bpmn:SubProcess',
+    'bpmn:UserTask',
+    'zeebe:ZeebeServiceTask'
   ]);
 }
 
@@ -134,23 +137,6 @@ export function createElement(type, parent, factory, properties) {
   return elementHelper.createElement(type, properties, parent, factory);
 }
 
-export function createIOMapping(parent, bpmnFactory, properties) {
+export function createIoMapping(parent, bpmnFactory, properties) {
   return createElement('zeebe:IoMapping', parent, bpmnFactory, properties);
 }
-
-/**
- * Get getter function for IOMapping parameters according to provided property name
- *
- * @param {string} property
- *
- * @returns {Function} Getter function for the IOMapping parameters according to provided property name
- */
-export function determineParamGetFunc(property) {
-  if (property == 'inputParameters') {
-    return getInputParameters;
-  }
-
-  if (property == 'outputParameters') {
-    return getOutputParameters;
-  }
-}

package/lib/camunda-platform/features/modeling/behavior/DeleteErrorEventDefinitionBehavior.js

@@ -1,5 +1,3 @@
-import inherits from 'inherits';
-
 import {
   getBusinessObject,
   is
@@ -11,18 +9,19 @@ const HIGH_PRIORITY = 5000;
 
 
 /**
- * Camunda BPMN specific `camunda:errorEventDefinition` behavior.
- *
- * When `camunda:type` is set to something different than `external`
- * on an element, then `camunda:errorEventDefinition` extension elements
- * shall be removed.
+ * Camunda BPMN specific camunda:ErrorEventDefinition behavior.
  */
-export default function DeleteErrorEventDefinitionBehavior(eventBus) {
-
-  CommandInterceptor.call(this, eventBus);
-
-  this.executed([ 'properties-panel.update-businessobject', 'element.updateProperties' ],
-    HIGH_PRIORITY, function(context) {
+export default class DeleteErrorEventDefinitionBehavior extends CommandInterceptor {
+  constructor(eventBus, modeling) {
+    super(eventBus);
+
+    /**
+     * Remove camunda:ErrorEventDefinitions on camunda:type set to external.
+     */
+    this.postExecute([
+      'element.updateProperties',
+      'properties-panel.update-businessobject'
+    ], HIGH_PRIORITY, function(context) {
       const {
         element,
         oldProperties,
@@ -30,52 +29,30 @@ export default function DeleteErrorEventDefinitionBehavior(eventBus) {
       } = context;
 
       const businessObject = getBusinessObject(element),
-            extensionElements = businessObject.extensionElements;
+            extensionElements = businessObject.get('extensionElements');
 
-      // (1) Check whether behavior is suitable
-      if (
-        is(element, 'camunda:ExternalCapable') &&
-        extensionElements &&
-        externalTypeChanged(oldProperties, properties)
-      ) {
+      if (is(element, 'camunda:ExternalCapable')
+        && extensionElements
+        && externalTypeChanged(oldProperties, properties)) {
 
-        // (2) Delete camunda:ErrorEventDefinition elements and save them for revert
-        context.deletedErrorEventDefinitions = extensionElements.values;
+        const values = extensionElements.get('values').filter((element) => {
+          return !is(element, 'camunda:ErrorEventDefinition');
+        });
 
-        extensionElements.values = extensionElements.values.filter(
-          element => !is(element, 'camunda:ErrorEventDefinition')
-        );
+        modeling.updateModdleProperties(element, extensionElements, { values });
       }
-
     }, true);
 
-  this.reverted([ 'properties-panel.update-businessobject', 'element.updateProperties' ],
-    HIGH_PRIORITY, function({ context }) {
-      const {
-        element,
-        deletedErrorEventDefinitions: oldExtensionElements
-      } = context;
-
-      const businessObject = getBusinessObject(element);
-
-      // Only intercept the revert, if the behavior became active
-      if (oldExtensionElements) {
-        const extensionElements = businessObject.extensionElements;
-
-        extensionElements.values = oldExtensionElements;
-      }
-    });
+  }
 }
 
-
 DeleteErrorEventDefinitionBehavior.$inject = [
-  'eventBus'
+  'eventBus',
+  'modeling'
 ];
 
-inherits(DeleteErrorEventDefinitionBehavior, CommandInterceptor);
-
 
-// helper //////////////////
+// helpers //////////
 
 function externalTypeChanged(oldProperties, updatesProperties) {
   const {