camox 0.77.0 → 0.78.0

package/dist/features/preview/EditablePageExperience.js

@@ -3,6 +3,7 @@ import { CamoxContent } from "../content/CamoxContent.js";
 import { AuthenticatedCamoxProvider } from "../provider/AuthenticatedCamoxProvider.js";
 import { CamoxStudio } from "../studio/CamoxStudio.js";
 import { CompleteBlockEditingRuntimeProvider } from "../../core/editing/CompleteBlockEditingRuntime.js";
+import { CamoxMemory } from "../memory/CamoxMemory.js";
 import { CamoxSettings } from "../settings/CamoxSettings.js";
 import { c } from "react/compiler-runtime";
 import { jsx } from "react/jsx-runtime";
@@ -11,6 +12,7 @@ import { jsx } from "react/jsx-runtime";
 /** The studio section each studio route shows. */
 const STUDIO_SECTIONS = {
 	"studio-content": CamoxContent,
+	"studio-memory": CamoxMemory,
 	"studio-settings": CamoxSettings
 };
 function EditablePageExperience(t0) {

package/dist/features/runtime/publicCache.d.ts

@@ -16,6 +16,8 @@ export declare function readLiveCacheKey(apiUrl: string, projectUuid: string): P
 /**
  * Answers a public request from the cache, or renders it and keeps the render when it may be
  * shared. Without a Live cache key, it renders without the cache: nothing tells when Live changed.
+ * A key slower than `RENDER_HEAD_START_MS` starts the render before it arrives; should the cache
+ * have the page after all, that render is dropped.
  */
 export declare function respondThroughPublicCache(request: Request, publicCache: PublicCache, render: () => Promise<Response | null>): Promise<Response | null>;
 //#endregion

package/dist/features/runtime/publicCache.js

@@ -9,6 +9,13 @@ const EDGE_MAX_AGE = 86400;
 const VISITOR_CACHE_CONTROL = "public, max-age=0, must-revalidate";
 /** The search parameter the cache key adds to a request's URL. */
 const CACHE_KEY_PARAM = "__camox_cache";
+/**
+* How long a render waits for the Live cache key before it starts anyway. The edge answers a key
+* it keeps within a few milliseconds. One it doesn't keep, the API mints, which often takes a
+* second while an API isolate starts, and no render is kept under a key just minted, so the page
+* renders either way: it starts while the key is on its way.
+*/
+const RENDER_HEAD_START_MS = 50;
 /** The project's Live cache key, as the API serves it from its edge cache. */
 async function readLiveCacheKey(apiUrl, projectUuid) {
 	try {
@@ -21,10 +28,26 @@ async function readLiveCacheKey(apiUrl, projectUuid) {
 /**
 * Answers a public request from the cache, or renders it and keeps the render when it may be
 * shared. Without a Live cache key, it renders without the cache: nothing tells when Live changed.
+* A key slower than `RENDER_HEAD_START_MS` starts the render before it arrives; should the cache
+* have the page after all, that render is dropped.
 */
 async function respondThroughPublicCache(request, publicCache, render) {
-	const liveCacheKey = await publicCache.liveCacheKey();
-	if (!liveCacheKey) return render();
+	let rendering;
+	const renderOnce = () => {
+		if (!rendering) {
+			rendering = render();
+			rendering.catch(() => void 0);
+		}
+		return rendering;
+	};
+	const headStart = setTimeout(renderOnce, 50);
+	let liveCacheKey;
+	try {
+		liveCacheKey = await publicCache.liveCacheKey();
+	} finally {
+		clearTimeout(headStart);
+	}
+	if (!liveCacheKey) return renderOnce();
 	const key = cacheKeyOf(request, `${liveCacheKey}.${publicCache.build}`);
 	let cache;
 	let cached;
@@ -33,10 +56,10 @@ async function respondThroughPublicCache(request, publicCache, render) {
 		cached = await cache.match(withValidators(key, request));
 	} catch (error) {
 		console.error("The edge cache couldn't be read: the page renders without it", error);
-		return render();
+		return renderOnce();
 	}
 	if (cached) return forVisitors(cached, request);
-	const response = await render();
+	const response = await renderOnce();
 	if (!response || !mayBeShared(response)) return response;
 	publicCache.waitUntil((async () => cache.put(key, forEdge(response.clone())))().catch((error) => {
 		console.error("The edge cache couldn't keep a render", error);

package/dist/features/runtime/runtime.d.ts

@@ -11,7 +11,7 @@ import { LookPlaceholderHeight } from "@camox/api-contract/drafts";
 import { UseHeadInput } from "unhead/types";
 //#region src/features/runtime/runtime.d.ts
 /** The studio's own routes, rather than a page or the Canvas. */
-declare const STUDIO_ROUTE_KINDS: readonly ["studio", "studio-content", "studio-settings", "studio-nested"];
+declare const STUDIO_ROUTE_KINDS: readonly ["studio", "studio-content", "studio-memory", "studio-settings", "studio-nested"];
 export type StudioRouteKind = (typeof STUDIO_ROUTE_KINDS)[number];
 export type RuntimeRouteKind = RuntimeOwnedRouteKind | "canvas" | "page" | StudioRouteKind;
 export interface RuntimeRouteMatch {

package/dist/features/runtime/runtime.js

@@ -8,7 +8,7 @@ import { ARTIFACTS_PATH_PREFIX, RUNTIME_ROUTE_PATHS, matchRuntimeOwnedRoute } fr
 import { reads } from "../../lib/studio-reads.js";
 import { recordMarkdownTemplate } from "../../core/recordItem.js";
 import { PLATFORM_SCRIPT } from "../../lib/platform.js";
-import { STUDIO_ASSETS_PATH, STUDIO_CANVAS_PATH, STUDIO_CONTENT_PATH, STUDIO_SETTINGS_PATH, matchCollectionContentPath } from "../studio/routes.js";
+import { STUDIO_ASSETS_PATH, STUDIO_CANVAS_PATH, STUDIO_CONTENT_PATH, STUDIO_MEMORY_PATH, STUDIO_SETTINGS_PATH, matchCollectionContentPath } from "../studio/routes.js";
 import { STUDIO_THEME_SCRIPT } from "../studio/studioTheme.js";
 import { DefaultPageImage, renderPageImage } from "../og/pageImage.js";
 import { discoverLayoutPages } from "../../core/derivedRoutes.js";
@@ -39,6 +39,7 @@ const DEFAULT_RUNTIME_BASE_PATH = "";
 const STUDIO_ROUTE_KINDS = [
 	"studio",
 	"studio-content",
+	"studio-memory",
 	"studio-settings",
 	"studio-nested"
 ];
@@ -122,6 +123,10 @@ function matchRuntimeRoute(pathname) {
 		kind: "studio-content",
 		pathname
 	};
+	if (pathname === "/camox/memory" || pathname === `${"/camox/memory"}/`) return {
+		kind: "studio-memory",
+		pathname
+	};
 	if (pathname === "/camox/settings" || pathname === `${"/camox/settings"}/`) return {
 		kind: "studio-settings",
 		pathname
@@ -1687,21 +1692,35 @@ async function handleCamoxRequest(request, options = {}) {
 		if (signedIn) return signedIn;
 	}
 	const { apiUrl, projectUuid } = options;
+	if (!apiUrl || !projectUuid) return respondInLocale(options, request, pathname);
 	const markdownPathname = parseMarkdownPath(pathname);
-	if (apiUrl && projectUuid && (markdownPathname || prefersMarkdown(request.headers.get("Accept") ?? ""))) {
-		const markdownResponse = await createPageMarkdownResponse({
-			...options,
-			apiUrl,
-			projectUuid
-		}, {
-			pathname: markdownPathname ?? pathname,
-			request,
-			pagesOnly: !markdownPathname
-		});
-		if (markdownResponse) return markdownResponse;
-		if (markdownPathname) return new Response("Page not found", { status: 404 });
-	}
-	return respondInLocale(options, request, pathname);
+	if (markdownPathname) return await createPageMarkdownResponse({
+		...options,
+		apiUrl,
+		projectUuid
+	}, {
+		pathname: markdownPathname,
+		request,
+		pagesOnly: false
+	}) ?? new Response("Page not found", { status: 404 });
+	return varyingByAccept((prefersMarkdown(request.headers.get("Accept") ?? "") ? await createPageMarkdownResponse({
+		...options,
+		apiUrl,
+		projectUuid
+	}, {
+		pathname,
+		request,
+		pagesOnly: true
+	}) : null) ?? await respondInLocale(options, request, pathname));
+}
+/**
+* A response its URL answers in HTML or Markdown, by what the request accepts: it says so, so no
+* cache answers one with the other.
+*/
+function varyingByAccept(response) {
+	const varying = new Response(response.body, response);
+	varying.headers.append("Vary", "Accept");
+	return varying;
 }
 /**
 * Answers a path under its locale's prefix: the Canvas, a studio route or a page, in that locale.

package/dist/features/studio/FollowAgentProvider.js

@@ -4,9 +4,9 @@ import { useLocation, useNavigate } from "../navigation/navigation.js";
 import { useProjectUuid } from "../../lib/auth.js";
 import { reads, useReadQueries, useReadQuery } from "../../lib/studio-reads.js";
 import { useRoutableLayouts } from "../../lib/studio-definitions.js";
+import { canvasPageId, getCanvasPages } from "../canvas/canvasPages.js";
 import { STUDIO_CANVAS_PATH } from "./routes.js";
 import { FollowAgentContext } from "./followAgentContext.js";
-import { canvasPageId, getCanvasPages } from "../canvas/canvasPages.js";
 import { selectedCanvasPage } from "../canvas/canvasSelection.js";
 import { useDiscoveredPreviewPaths } from "../canvas/useDiscoveredPreviewPaths.js";
 import { EditorWhereContext } from "./editorWhereContext.js";

package/dist/features/studio/components/AgentSidebar.js

@@ -1,5 +1,6 @@
 import { cn } from "../../../lib/utils.js";
 import { SIDEBAR_GUTTER } from "../../preview/components/SidebarStack.js";
+import { useCanvasLayout } from "../../canvas/useCanvasLayout.js";
 import { ChatWidget } from "./ChatWidget.js";
 import { Specialists } from "./Specialists.js";
 import { c } from "react/compiler-runtime";
@@ -14,30 +15,34 @@ import { jsx, jsxs } from "react/jsx-runtime";
 * and the Preview and Studio pages follow the editor's runs too.
 */
 function AgentSidebar(t0) {
-	const $ = c(6);
+	const $ = c(8);
 	const { hidden: t1 } = t0;
 	const hidden = t1 === void 0 ? false : t1;
+	const { sidebarWidth } = useCanvasLayout();
 	let t2;
+	if ($[0] === Symbol.for("react.memo_cache_sentinel")) {
+		t2 = cn("absolute inset-y-0 right-0 z-10 flex flex-col gap-2 py-2 max-md:hidden", SIDEBAR_GUTTER);
+		$[0] = t2;
+	} else t2 = $[0];
 	let t3;
+	if ($[1] !== sidebarWidth) {
+		t3 = { width: sidebarWidth };
+		$[1] = sidebarWidth;
+		$[2] = t3;
+	} else t3 = $[2];
 	let t4;
 	let t5;
-	if ($[0] === Symbol.for("react.memo_cache_sentinel")) {
-		t2 = cn("absolute inset-y-0 right-0 z-10 flex flex-col gap-2 py-2 max-md:hidden", SIDEBAR_GUTTER);
-		t3 = { width: 265 };
+	if ($[3] === Symbol.for("react.memo_cache_sentinel")) {
 		t4 = /* @__PURE__ */ jsx(Specialists, { className: "min-h-0 flex-[0_1_auto]" });
 		t5 = /* @__PURE__ */ jsx(ChatWidget, { className: "min-h-0 flex-[7_1_0]" });
-		$[0] = t2;
-		$[1] = t3;
-		$[2] = t4;
-		$[3] = t5;
+		$[3] = t4;
+		$[4] = t5;
 	} else {
-		t2 = $[0];
-		t3 = $[1];
-		t4 = $[2];
-		t5 = $[3];
+		t4 = $[3];
+		t5 = $[4];
 	}
 	let t6;
-	if ($[4] !== hidden) {
+	if ($[5] !== hidden || $[6] !== t3) {
 		t6 = /* @__PURE__ */ jsxs("aside", {
 			"aria-label": "Agent",
 			"data-agent-sidebar": true,
@@ -46,9 +51,10 @@ function AgentSidebar(t0) {
 			style: t3,
 			children: [t4, t5]
 		});
-		$[4] = hidden;
-		$[5] = t6;
-	} else t6 = $[5];
+		$[5] = hidden;
+		$[6] = t3;
+		$[7] = t6;
+	} else t6 = $[7];
 	return t6;
 }
 

package/dist/features/studio/components/DraftBar.js

@@ -3,6 +3,8 @@ import { studioStore } from "../studioStore.js";
 import { plural } from "../draftLabel.js";
 import { useArchiveDraft } from "../useArchiveDraft.js";
 import { useDrafts } from "./DraftsControl.js";
+import { usePublishDraft } from "../usePublishDraft.js";
+import { DraftReview } from "./DraftReview.js";
 import { c } from "react/compiler-runtime";
 import * as React from "react";
 import { jsx, jsxs } from "react/jsx-runtime";
@@ -18,143 +20,205 @@ import { FloatingToolbar } from "@camox/ui/floating-toolbar";
 const SETTLE_MS = 1500;
 /**
 * Asks what to do with the draft being viewed, once its edits settle: archive it, unless it's
-* Camox's Catch-up Draft, or publish it.
-* Publishing waits while Camox's agent is mid-turn in the draft, so half a change never goes live;
+* Camox's Catch-up Draft, or publish it right away, which a toast follows. Its count of pending
+* changes opens the draft's review, as does a publish that blockers held or stopped. Publishing
+* waits while Camox's agent is mid-turn in the draft, so half a change never goes live;
 * nothing else Camox does holds it here. `stacked` places it in the Preview toolbar's column, just above the toolbar;
 * otherwise it floats at the bottom of the screen on its own.
 */
 function DraftBar(t0) {
-	const $ = c(32);
+	const $ = c(10);
 	const { stacked: t1 } = t0;
 	const stacked = t1 === void 0 ? false : t1;
 	const { projectId, current } = useDrafts();
 	const { archive, archiving } = useArchiveDraft(projectId);
 	const settled = useSettled(current?.id ?? null, current?.lastChangedAt ?? null);
+	const reviewing = useSelector(studioStore, _temp);
 	let t2;
 	if ($[0] !== current) {
-		t2 = (state) => !!current && state.context.agentWorkingIn === current.id;
+		t2 = (state_0) => !!current && state_0.context.agentWorkingIn === current.id;
 		$[0] = current;
 		$[1] = t2;
 	} else t2 = $[1];
 	const working = useSelector(studioStore, t2);
-	if (!projectId || !current || !settled) return null;
-	const empty = current.changeCount === 0;
-	const t3 = stacked ? "pointer-events-auto relative left-auto translate-x-0" : "fixed bottom-2";
+	if (!projectId || !current || !(settled || reviewing)) return null;
+	let t3;
+	if ($[2] !== archive || $[3] !== archiving || $[4] !== current || $[5] !== projectId || $[6] !== reviewing || $[7] !== stacked || $[8] !== working) {
+		t3 = /* @__PURE__ */ jsx(Bar, {
+			projectId,
+			draft: current,
+			archive,
+			archiving,
+			working,
+			reviewing,
+			stacked
+		}, current.id);
+		$[2] = archive;
+		$[3] = archiving;
+		$[4] = current;
+		$[5] = projectId;
+		$[6] = reviewing;
+		$[7] = stacked;
+		$[8] = working;
+		$[9] = t3;
+	} else t3 = $[9];
+	return t3;
+}
+function _temp(state) {
+	return state.context.isDraftReviewOpen;
+}
+function Bar(t0) {
+	const $ = c(37);
+	const { projectId, draft, archive, archiving, working, reviewing, stacked } = t0;
+	const review = _temp2;
+	let t1;
+	if ($[0] !== draft.id || $[1] !== projectId) {
+		t1 = {
+			projectId,
+			draftId: draft.id,
+			onBlocked: review
+		};
+		$[0] = draft.id;
+		$[1] = projectId;
+		$[2] = t1;
+	} else t1 = $[2];
+	const { publish, publishing } = usePublishDraft(t1);
+	const empty = draft.changeCount === 0;
+	const toolbar = React.useRef(null);
+	const t2 = stacked ? "pointer-events-auto relative left-auto translate-x-0" : "fixed bottom-2";
+	let t3;
+	if ($[3] !== t2) {
+		t3 = cn("w-max gap-4", t2);
+		$[3] = t2;
+		$[4] = t3;
+	} else t3 = $[4];
 	let t4;
-	if ($[2] !== t3) {
-		t4 = cn("w-max gap-4", t3);
-		$[2] = t3;
-		$[3] = t4;
-	} else t4 = $[3];
-	let t5;
-	if ($[4] === Symbol.for("react.memo_cache_sentinel")) {
-		t5 = /* @__PURE__ */ jsx("span", {
-			"aria-hidden": true,
-			className: "size-2 shrink-0 rounded-full bg-blue-500"
-		});
-		$[4] = t5;
-	} else t5 = $[4];
-	let t6;
-	if ($[5] !== current.changeCount || $[6] !== empty) {
-		t6 = empty ? "No changes yet" : plural(current.changeCount, "pending change");
-		$[5] = current.changeCount;
-		$[6] = empty;
-		$[7] = t6;
-	} else t6 = $[7];
-	let t7;
-	if ($[8] !== t6) {
-		t7 = /* @__PURE__ */ jsxs("span", {
+	if ($[5] !== draft.changeCount || $[6] !== draft.id || $[7] !== empty || $[8] !== projectId || $[9] !== reviewing) {
+		t4 = empty ? /* @__PURE__ */ jsxs("span", {
 			className: "flex items-center gap-2 px-2 text-sm",
-			children: [t5, t6]
+			children: [/* @__PURE__ */ jsx("span", {
+				"aria-hidden": true,
+				className: "size-2 shrink-0 rounded-full bg-blue-500"
+			}), "No changes yet"]
+		}) : /* @__PURE__ */ jsx(DraftReview, {
+			projectId,
+			draftId: draft.id,
+			open: reviewing,
+			anchor: toolbar,
+			onOpenChange: _temp3,
+			trigger: /* @__PURE__ */ jsxs(Button, {
+				type: "button",
+				variant: "ghost",
+				children: [/* @__PURE__ */ jsx("span", {
+					"aria-hidden": true,
+					className: "size-2 shrink-0 rounded-full bg-blue-500"
+				}), plural(draft.changeCount, "pending change")]
+			})
 		});
-		$[8] = t6;
-		$[9] = t7;
-	} else t7 = $[9];
-	let t8;
-	if ($[10] !== archive || $[11] !== archiving || $[12] !== current.catchUp) {
-		t8 = !current.catchUp && /* @__PURE__ */ jsx(Button, {
+		$[5] = draft.changeCount;
+		$[6] = draft.id;
+		$[7] = empty;
+		$[8] = projectId;
+		$[9] = reviewing;
+		$[10] = t4;
+	} else t4 = $[10];
+	let t5;
+	if ($[11] !== archive || $[12] !== archiving || $[13] !== draft.catchUp || $[14] !== publishing) {
+		t5 = !draft.catchUp && /* @__PURE__ */ jsx(Button, {
 			type: "button",
 			variant: "outline",
-			disabled: archiving,
+			disabled: archiving || publishing,
 			onClick: archive,
 			children: "Archive"
 		});
-		$[10] = archive;
-		$[11] = archiving;
-		$[12] = current.catchUp;
-		$[13] = t8;
-	} else t8 = $[13];
-	const t9 = !working;
-	const t10 = working ? 0 : void 0;
+		$[11] = archive;
+		$[12] = archiving;
+		$[13] = draft.catchUp;
+		$[14] = publishing;
+		$[15] = t5;
+	} else t5 = $[15];
+	const t6 = !working;
+	const t7 = working ? 0 : void 0;
+	let t8;
+	if ($[16] !== t7) {
+		t8 = /* @__PURE__ */ jsx("span", { tabIndex: t7 });
+		$[16] = t7;
+		$[17] = t8;
+	} else t8 = $[17];
+	const t9 = empty || working || publishing;
+	let t10;
+	if ($[18] !== publish) {
+		t10 = () => void publish();
+		$[18] = publish;
+		$[19] = t10;
+	} else t10 = $[19];
 	let t11;
-	if ($[14] !== t10) {
-		t11 = /* @__PURE__ */ jsx("span", { tabIndex: t10 });
-		$[14] = t10;
-		$[15] = t11;
-	} else t11 = $[15];
-	const t12 = empty || working;
-	let t13;
-	if ($[16] !== t12) {
-		t13 = /* @__PURE__ */ jsx(Button, {
+	if ($[20] !== t10 || $[21] !== t9) {
+		t11 = /* @__PURE__ */ jsx(Button, {
 			type: "button",
-			disabled: t12,
-			onClick: _temp,
-			children: "Publish…"
+			disabled: t9,
+			onClick: t10,
+			children: "Publish"
+		});
+		$[20] = t10;
+		$[21] = t9;
+		$[22] = t11;
+	} else t11 = $[22];
+	let t12;
+	if ($[23] !== t11 || $[24] !== t8) {
+		t12 = /* @__PURE__ */ jsx(TooltipTrigger, {
+			render: t8,
+			children: t11
 		});
-		$[16] = t12;
-		$[17] = t13;
-	} else t13 = $[17];
+		$[23] = t11;
+		$[24] = t8;
+		$[25] = t12;
+	} else t12 = $[25];
+	let t13;
+	if ($[26] === Symbol.for("react.memo_cache_sentinel")) {
+		t13 = /* @__PURE__ */ jsx(TooltipContent, { children: "Camox's agent is working" });
+		$[26] = t13;
+	} else t13 = $[26];
 	let t14;
-	if ($[18] !== t11 || $[19] !== t13) {
-		t14 = /* @__PURE__ */ jsx(TooltipTrigger, {
-			render: t11,
-			children: t13
+	if ($[27] !== t12 || $[28] !== t6) {
+		t14 = /* @__PURE__ */ jsxs(Tooltip, {
+			disabled: t6,
+			children: [t12, t13]
 		});
-		$[18] = t11;
-		$[19] = t13;
-		$[20] = t14;
-	} else t14 = $[20];
+		$[27] = t12;
+		$[28] = t6;
+		$[29] = t14;
+	} else t14 = $[29];
 	let t15;
-	if ($[21] === Symbol.for("react.memo_cache_sentinel")) {
-		t15 = /* @__PURE__ */ jsx(TooltipContent, { children: "Camox's agent is working" });
-		$[21] = t15;
-	} else t15 = $[21];
-	let t16;
-	if ($[22] !== t14 || $[23] !== t9) {
-		t16 = /* @__PURE__ */ jsxs(Tooltip, {
-			disabled: t9,
-			children: [t14, t15]
-		});
-		$[22] = t14;
-		$[23] = t9;
-		$[24] = t16;
-	} else t16 = $[24];
-	let t17;
-	if ($[25] !== t16 || $[26] !== t8) {
-		t17 = /* @__PURE__ */ jsxs("div", {
+	if ($[30] !== t14 || $[31] !== t5) {
+		t15 = /* @__PURE__ */ jsxs("div", {
 			className: "flex items-center gap-2",
-			children: [t8, t16]
+			children: [t5, t14]
 		});
-		$[25] = t16;
-		$[26] = t8;
-		$[27] = t17;
-	} else t17 = $[27];
-	let t18;
-	if ($[28] !== t17 || $[29] !== t4 || $[30] !== t7) {
-		t18 = /* @__PURE__ */ jsxs(FloatingToolbar, {
+		$[30] = t14;
+		$[31] = t5;
+		$[32] = t15;
+	} else t15 = $[32];
+	let t16;
+	if ($[33] !== t15 || $[34] !== t3 || $[35] !== t4) {
+		t16 = /* @__PURE__ */ jsxs(FloatingToolbar, {
+			ref: toolbar,
 			"aria-label": "Draft",
-			className: t4,
-			children: [t7, t17]
+			className: t3,
+			children: [t4, t15]
 		});
-		$[28] = t17;
-		$[29] = t4;
-		$[30] = t7;
-		$[31] = t18;
-	} else t18 = $[31];
-	return t18;
+		$[33] = t15;
+		$[34] = t3;
+		$[35] = t4;
+		$[36] = t16;
+	} else t16 = $[36];
+	return t16;
+}
+function _temp3(open) {
+	return studioStore.send({ type: open ? "openDraftReview" : "closeDraftReview" });
 }
-function _temp() {
-	return studioStore.send({ type: "openReviewDraftDialog" });
+function _temp2() {
+	return studioStore.send({ type: "openDraftReview" });
 }
 /**
 * Whether the draft went without a change for `SETTLE_MS`. Once settled it stays so for that