c64bridge 1.0.5 → 1.0.6

package/mcp/schemas/c64_input.schema.json

@@ -178,7 +178,7 @@
   "required": [
     "op"
   ],
-  "description": "Input operations: write_text, key, keyboard, joystick, release_all, state.\n\nOperations:\n- write_text: Send a text string to the keyboard buffer, with PETSCII token expansion. Required inputs: text. Optional inputs: delayMs.\n- key: Tap a single key or hold it for a duration. Required inputs: key. Optional inputs: durationMs, count.\n- joystick: Simulate joystick input. On C64U/U64 this uses machine:input; VICE uses Binary Monitor Joyport Set. Required inputs: port, controls, action. Optional inputs: durationMs.\n- keyboard: Send physical C64 keyboard matrix events through machine:input (a C64U firmware version that provides it, or U64 3.15+). Required inputs: inputs, transition.\n- release_all: Release every key and joystick control injected through machine:input (a C64U firmware version that provides it, or U64 3.15+). Required inputs: none.\n- state: Read the keys and joystick controls held through machine:input (a C64U firmware version that provides it, or U64 3.15+). Required inputs: none.",
+  "description": "Input operations: write_text, key, keyboard, joystick, release_all, state.\n\nOperations:\n- write_text: Send a text string to the keyboard buffer, with PETSCII token expansion. Required inputs: text. Optional inputs: delayMs.\n- key: Tap a single key or hold it for a duration. Required inputs: key. Optional inputs: durationMs, count.\n- joystick: Simulate joystick input. On C64U/U64 this uses machine:input. On VICE it attaches VICE's I/O simulation joyport device while pressed; that device also pulls CIA lines 5-7 low, so port 1 produces phantom keys (e.g. SHIFT+C=) and port 2 reads $1E for up instead of $7E. Prefer port 2 on VICE and test bits 0-4. Required inputs: port, controls, action. Optional inputs: durationMs.\n- keyboard: Send physical C64 keyboard matrix events through machine:input (a C64U firmware version that provides it, or U64 3.15+). Required inputs: inputs, transition.\n- release_all: Release every key and joystick control injected through machine:input (a C64U firmware version that provides it, or U64 3.15+). Required inputs: none.\n- state: Read the keys and joystick controls held through machine:input (a C64U firmware version that provides it, or U64 3.15+). Required inputs: none.",
   "additionalProperties": false,
   "x-c64bridge-operations": [
     {
@@ -274,7 +274,7 @@
     },
     {
       "op": "joystick",
-      "description": "Simulate joystick input. On C64U/U64 this uses machine:input; VICE uses Binary Monitor Joyport Set.",
+      "description": "Simulate joystick input. On C64U/U64 this uses machine:input. On VICE it attaches VICE's I/O simulation joyport device while pressed; that device also pulls CIA lines 5-7 low, so port 1 produces phantom keys (e.g. SHIFT+C=) and port 2 reads $1E for up instead of $7E. Prefer port 2 on VICE and test bits 0-4.",
       "required": [
         "port",
         "controls",
@@ -285,7 +285,7 @@
       ],
       "inputSchema": {
         "type": "object",
-        "description": "Simulate joystick input. On C64U/U64 this uses machine:input; VICE uses Binary Monitor Joyport Set.",
+        "description": "Simulate joystick input. On C64U/U64 this uses machine:input. On VICE it attaches VICE's I/O simulation joyport device while pressed; that device also pulls CIA lines 5-7 low, so port 1 produces phantom keys (e.g. SHIFT+C=) and port 2 reads $1E for up instead of $7E. Prefer port 2 on VICE and test bits 0-4.",
         "properties": {
           "op": {
             "const": "joystick"

package/mcp/schemas/c64_program.schema.json

@@ -60,7 +60,7 @@
               "properties": {
                 "type": {
                   "type": "string",
-                  "description": "Assertion type",
+                  "description": "Assertion type; sid_silent needs the C64 Ultimate audio stream (c64u backend).",
                   "enum": [
                     "screen_contains",
                     "memory_equals",
@@ -462,7 +462,7 @@
                     "properties": {
                       "type": {
                         "type": "string",
-                        "description": "Assertion type",
+                        "description": "Assertion type; sid_silent needs the C64 Ultimate audio stream (c64u backend).",
                         "enum": [
                           "screen_contains",
                           "memory_equals",

package/mcp/schemas/c64_vice.schema.json

@@ -11,7 +11,7 @@
     },
     "name": {
       "type": "string",
-      "description": "VICE resource name (example: SidEngine, C64Model).",
+      "description": "VICE resource name (example: SidEngine, SidModel).",
       "minLength": 1,
       "maxLength": 64,
       "pattern": "^[A-Z][A-Za-z0-9_.-]{0,63}$"
@@ -46,7 +46,7 @@
           },
           "name": {
             "type": "string",
-            "description": "VICE resource name (example: SidEngine, C64Model).",
+            "description": "VICE resource name (example: SidEngine, SidModel).",
             "minLength": 1,
             "maxLength": 64,
             "pattern": "^[A-Z][A-Za-z0-9_.-]{0,63}$"
@@ -76,7 +76,7 @@
           },
           "name": {
             "type": "string",
-            "description": "VICE resource name (example: SidEngine, C64Model).",
+            "description": "VICE resource name (example: SidEngine, SidModel).",
             "minLength": 1,
             "maxLength": 64,
             "pattern": "^[A-Z][A-Za-z0-9_.-]{0,63}$"

package/mcp/server.json

@@ -1,6 +1,6 @@
 {
   "name": "c64bridge",
-  "version": "1.0.5",
+  "version": "1.0.6",
   "description": "Stdio-based Model Context Protocol (MCP) server that bridges Commodore 64 Ultimate hardware with AI agents.",
   "transports": [
     "stdio"

package/mcp/tools.json

@@ -66,7 +66,7 @@
                     "properties": {
                       "type": {
                         "type": "string",
-                        "description": "Assertion type",
+                        "description": "Assertion type; sid_silent needs the C64 Ultimate audio stream (c64u backend).",
                         "enum": [
                           "screen_contains",
                           "memory_equals",
@@ -468,7 +468,7 @@
                           "properties": {
                             "type": {
                               "type": "string",
-                              "description": "Assertion type",
+                              "description": "Assertion type; sid_silent needs the C64 Ultimate audio stream (c64u backend).",
                               "enum": [
                                 "screen_contains",
                                 "memory_equals",
@@ -4483,7 +4483,7 @@
               "integer",
               "null"
             ],
-            "description": "Track count (D64 supports 35 or 40; DNP requires explicit tracks).",
+            "description": "Track count (D64 supports 35 to 41; DNP requires explicit tracks).",
             "minimum": 1,
             "maximum": 255
           },
@@ -4785,7 +4785,7 @@
                     "integer",
                     "null"
                   ],
-                  "description": "Track count (D64 supports 35 or 40; DNP requires explicit tracks).",
+                  "description": "Track count (D64 supports 35 to 41; DNP requires explicit tracks).",
                   "minimum": 1,
                   "maximum": 255
                 },
@@ -4949,6 +4949,10 @@
           "vice"
         ],
         "operationPlatforms": {
+          "unmount": [
+            "c64u",
+            "u2"
+          ],
           "file_info": [
             "c64u",
             "u2"
@@ -8075,7 +8079,7 @@
           },
           "name": {
             "type": "string",
-            "description": "VICE resource name (example: SidEngine, C64Model).",
+            "description": "VICE resource name (example: SidEngine, SidModel).",
             "minLength": 1,
             "maxLength": 64,
             "pattern": "^[A-Z][A-Za-z0-9_.-]{0,63}$"
@@ -8110,7 +8114,7 @@
                 },
                 "name": {
                   "type": "string",
-                  "description": "VICE resource name (example: SidEngine, C64Model).",
+                  "description": "VICE resource name (example: SidEngine, SidModel).",
                   "minLength": 1,
                   "maxLength": 64,
                   "pattern": "^[A-Z][A-Za-z0-9_.-]{0,63}$"
@@ -8140,7 +8144,7 @@
                 },
                 "name": {
                   "type": "string",
-                  "description": "VICE resource name (example: SidEngine, C64Model).",
+                  "description": "VICE resource name (example: SidEngine, SidModel).",
                   "minLength": 1,
                   "maxLength": 64,
                   "pattern": "^[A-Z][A-Za-z0-9_.-]{0,63}$"
@@ -8392,7 +8396,7 @@
         "required": [
           "op"
         ],
-        "description": "Input operations: write_text, key, keyboard, joystick, release_all, state.\n\nOperations:\n- write_text: Send a text string to the keyboard buffer, with PETSCII token expansion. Required inputs: text. Optional inputs: delayMs.\n- key: Tap a single key or hold it for a duration. Required inputs: key. Optional inputs: durationMs, count.\n- joystick: Simulate joystick input. On C64U/U64 this uses machine:input; VICE uses Binary Monitor Joyport Set. Required inputs: port, controls, action. Optional inputs: durationMs.\n- keyboard: Send physical C64 keyboard matrix events through machine:input (a C64U firmware version that provides it, or U64 3.15+). Required inputs: inputs, transition.\n- release_all: Release every key and joystick control injected through machine:input (a C64U firmware version that provides it, or U64 3.15+). Required inputs: none.\n- state: Read the keys and joystick controls held through machine:input (a C64U firmware version that provides it, or U64 3.15+). Required inputs: none.",
+        "description": "Input operations: write_text, key, keyboard, joystick, release_all, state.\n\nOperations:\n- write_text: Send a text string to the keyboard buffer, with PETSCII token expansion. Required inputs: text. Optional inputs: delayMs.\n- key: Tap a single key or hold it for a duration. Required inputs: key. Optional inputs: durationMs, count.\n- joystick: Simulate joystick input. On C64U/U64 this uses machine:input. On VICE it attaches VICE's I/O simulation joyport device while pressed; that device also pulls CIA lines 5-7 low, so port 1 produces phantom keys (e.g. SHIFT+C=) and port 2 reads $1E for up instead of $7E. Prefer port 2 on VICE and test bits 0-4. Required inputs: port, controls, action. Optional inputs: durationMs.\n- keyboard: Send physical C64 keyboard matrix events through machine:input (a C64U firmware version that provides it, or U64 3.15+). Required inputs: inputs, transition.\n- release_all: Release every key and joystick control injected through machine:input (a C64U firmware version that provides it, or U64 3.15+). Required inputs: none.\n- state: Read the keys and joystick controls held through machine:input (a C64U firmware version that provides it, or U64 3.15+). Required inputs: none.",
         "additionalProperties": false,
         "x-c64bridge-operations": [
           {
@@ -8488,7 +8492,7 @@
           },
           {
             "op": "joystick",
-            "description": "Simulate joystick input. On C64U/U64 this uses machine:input; VICE uses Binary Monitor Joyport Set.",
+            "description": "Simulate joystick input. On C64U/U64 this uses machine:input. On VICE it attaches VICE's I/O simulation joyport device while pressed; that device also pulls CIA lines 5-7 low, so port 1 produces phantom keys (e.g. SHIFT+C=) and port 2 reads $1E for up instead of $7E. Prefer port 2 on VICE and test bits 0-4.",
             "required": [
               "port",
               "controls",
@@ -8499,7 +8503,7 @@
             ],
             "inputSchema": {
               "type": "object",
-              "description": "Simulate joystick input. On C64U/U64 this uses machine:input; VICE uses Binary Monitor Joyport Set.",
+              "description": "Simulate joystick input. On C64U/U64 this uses machine:input. On VICE it attaches VICE's I/O simulation joyport device while pressed; that device also pulls CIA lines 5-7 low, so port 1 produces phantom keys (e.g. SHIFT+C=) and port 2 reads $1E for up instead of $7E. Prefer port 2 on VICE and test bits 0-4.",
               "properties": {
                 "op": {
                   "const": "joystick"

package/mcp.json

@@ -1,6 +1,6 @@
 {
   "name": "c64bridge",
-  "version": "1.0.5",
+  "version": "1.0.6",
   "description": "Stdio-based Model Context Protocol (MCP) server that bridges Commodore 64 Ultimate hardware with AI agents.",
   "entry": "dist/index.js",
   "type": "stdio",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "c64bridge",
-  "version": "1.0.5",
+  "version": "1.0.6",
   "mcpName": "io.github.chrisgleissner/c64bridge",
   "description": "C64 Bridge MCP server for Commodore 64 Ultimate hardware and VICE emulator control",
   "repository": {

package/scripts/mockC64Server.mjs

@@ -685,7 +685,21 @@ export async function startMockC64Server(options = {}) {
       const lengthValue = routeUrl.searchParams.get("length") ?? "256";
       const address = parseNumeric(addressValue);
       const length = Math.max(0, parseNumeric(lengthValue, 10));
-      const bytes = readMemoryWithHeartbeat(state, address, length);
+      // Same checks as the firmware (route_machine.cc readmem).
+      if (length < 1 || length > 65536) {
+        sendJson(res, { errors: ["Invalid length"] }, 400);
+        return;
+      }
+      if (address + length > 65536) {
+        sendJson(res, { errors: ["Memory read exceeds location $FFFF"] }, 400);
+        return;
+      }
+      const bytes = Uint8Array.from(readMemoryWithHeartbeat(state, address, length));
+      // SID registers $D400-$D418 are write-only; the Ultimate 64 reads them as $00.
+      for (let i = 0; i < bytes.length; i += 1) {
+        const target = address + i;
+        if (target >= 0xd400 && target <= 0xd418) bytes[i] = 0;
+      }
 
       const accept = String(req.headers["accept"] || "");
       if (accept.includes("application/octet-stream")) {

package/scripts/run-coverage.mjs

@@ -98,7 +98,10 @@ export async function main() {
     legOutputs.push(legPath);
   }
 
-  const finalReport = mergeReports(await Promise.all(legOutputs.map(readReport)));
+  const finalReport = await dropNonCodeLines(
+    mergeReports(await Promise.all(legOutputs.map(readReport))),
+    (relativePath) => fs.readFile(path.join(repoRoot, relativePath), "utf8"),
+  );
   const finalPath = path.join(coverageDir, "lcov.info");
   await fs.writeFile(finalPath, serializeReport(finalReport), "utf8");
 
@@ -265,6 +268,33 @@ function parseReport(text) {
   return report;
 }
 
+/**
+ * Bun's LCOV output lists blank and comment-only lines inside executed
+ * functions as executable lines that were never hit. Drop them, using each
+ * file's source, so coverage counts only code.
+ */
+export async function dropNonCodeLines(report, readSource) {
+  const result = new Map();
+  for (const [filePath, record] of report.entries()) {
+    let sourceLines;
+    try {
+      sourceLines = (await readSource(filePath)).split(/\r?\n/);
+    } catch {
+      result.set(filePath, record);
+      continue;
+    }
+    const lines = new Map();
+    for (const [lineNo, hits] of record.lines.entries()) {
+      const text = (sourceLines[lineNo - 1] ?? "").trim();
+      const isComment = text.startsWith("//") || text.startsWith("/*") || text.startsWith("*");
+      if (text === "" || isComment) continue;
+      lines.set(lineNo, hits);
+    }
+    result.set(filePath, { ...record, lines });
+  }
+  return result;
+}
+
 function mergeReports(reports) {
   const merged = new Map();
   for (const report of reports) {

package/scripts/update-readme.ts

@@ -485,8 +485,9 @@ export async function updateReadme(): Promise<boolean> {
   const generatedDocs = `\n\n${buildDocumentation()}\n\n`;
   const generatedEnv = `\n\n${buildEnvironmentDocumentation()}\n\n`;
   const nextReadme = readme
-    .replace(docsPattern, `${START_MARKER}${generatedDocs}${END_MARKER}`)
-    .replace(envPattern, `${ENV_START_MARKER}${generatedEnv}${ENV_END_MARKER}`);
+    // Replacement functions, not strings: generated text such as "$1E" must not be read as "$1".
+    .replace(docsPattern, () => `${START_MARKER}${generatedDocs}${END_MARKER}`)
+    .replace(envPattern, () => `${ENV_START_MARKER}${generatedEnv}${ENV_END_MARKER}`);
 
   if (nextReadme === readme) {
     return false;

package/server.json

@@ -8,12 +8,12 @@
     "source": "github"
   },
   "websiteUrl": "https://github.com/chrisgleissner/c64bridge",
-  "version": "1.0.5",
+  "version": "1.0.6",
   "packages": [
     {
       "registryType": "npm",
       "identifier": "c64bridge",
-      "version": "1.0.5",
+      "version": "1.0.6",
       "transport": {
         "type": "stdio"
       },