byterover-cli 2.4.1 → 2.5.1

package/dist/oclif/commands/providers/connect.js

@@ -89,9 +89,12 @@ export default class ProviderConnect extends Command {
             }
             // 4. Connect or switch active provider
             const hasNewConfig = apiKey || baseUrl;
-            await (provider.isConnected && !hasNewConfig
+            const response = await (provider.isConnected && !hasNewConfig
                 ? client.requestWithAck(ProviderEvents.SET_ACTIVE, { providerId })
                 : client.requestWithAck(ProviderEvents.CONNECT, { apiKey, baseUrl, providerId }));
+            if (!response.success) {
+                throw new Error(response.error ?? 'Failed to connect provider. Please try again.');
+            }
             // 5. Set model if specified
             if (model) {
                 await client.requestWithAck(ModelEvents.SET_ACTIVE, { modelId: model, providerId });

package/dist/oclif/commands/providers/index.d.ts

@@ -8,6 +8,7 @@ export default class Provider extends Command {
     };
     protected fetchActiveProvider(options?: DaemonClientOptions): Promise<{
         activeModel: string | undefined;
+        loginRequired: boolean | undefined;
         providerId: string;
         providerName: string;
     }>;

package/dist/oclif/commands/providers/index.js

@@ -22,6 +22,7 @@ export default class Provider extends Command {
             const provider = providers.find((p) => p.id === active.activeProviderId);
             return {
                 activeModel: active.activeModel,
+                loginRequired: active.loginRequired,
                 providerId: active.activeProviderId,
                 providerName: provider?.name ?? active.activeProviderId,
             };
@@ -33,7 +34,11 @@ export default class Provider extends Command {
         try {
             const info = await this.fetchActiveProvider();
             if (format === 'json') {
-                writeJsonResponse({ command: 'providers', data: info, success: true });
+                const { loginRequired, ...rest } = info;
+                const data = loginRequired
+                    ? { ...rest, warning: "Not logged in. Run 'brv login' to authenticate." }
+                    : rest;
+                writeJsonResponse({ command: 'providers', data, success: true });
             }
             else {
                 this.log(`Provider: ${info.providerName} (${info.providerId})`);
@@ -45,6 +50,9 @@ export default class Provider extends Command {
                         this.log('Model: Not set. Run "brv model list" to see available models, or "brv model switch <model>" to set one.');
                     }
                 }
+                if (info.loginRequired) {
+                    this.log("Warning: Not logged in. Run 'brv login' to authenticate.");
+                }
             }
         }
         catch (error) {

package/dist/oclif/commands/providers/switch.js

@@ -54,7 +54,10 @@ export default class ProviderSwitch extends Command {
             if (!provider.isConnected) {
                 throw new Error(`Provider "${providerId}" is not connected. Use "brv providers connect ${providerId}" instead.`);
             }
-            await client.requestWithAck(ProviderEvents.SET_ACTIVE, { providerId });
+            const response = await client.requestWithAck(ProviderEvents.SET_ACTIVE, { providerId });
+            if (!response.success) {
+                throw new Error(response.error ?? 'Failed to switch provider. Please try again.');
+            }
             return { providerId, providerName: provider.name };
         }, options);
     }

package/dist/server/core/domain/entities/provider-config.js

@@ -184,7 +184,7 @@ export class ProviderConfig {
     withProviderDisconnected(providerId) {
         // eslint-disable-next-line @typescript-eslint/no-unused-vars
         const { [providerId]: _removed, ...remainingProviders } = this.providers;
-        const newActiveProvider = this.activeProvider === providerId ? 'byterover' : this.activeProvider;
+        const newActiveProvider = this.activeProvider === providerId ? '' : this.activeProvider;
         return new ProviderConfig({
             activeProvider: newActiveProvider,
             providers: remainingProviders,

package/dist/server/core/domain/entities/provider-registry.js

@@ -26,7 +26,7 @@ export const PROVIDER_REGISTRY = {
     byterover: {
         baseUrl: '',
         category: 'popular',
-        description: 'Built-in LLM, no API key required. Free tier available.',
+        description: 'Built-in LLM, logged-in ByteRover account required. Limited free usage.',
         headers: {},
         id: 'byterover',
         modelsEndpoint: '',

package/dist/server/core/domain/transport/schemas.d.ts

@@ -465,6 +465,8 @@ export interface ProviderConfigResponse {
     activeProvider: string;
     /** How the provider was authenticated ('api-key' | 'oauth'). Undefined for internal providers. */
     authMethod?: 'api-key' | 'oauth';
+    /** True when the active provider requires login but the user is not logged in. */
+    loginRequired?: boolean;
     maxInputTokens?: number;
     openRouterApiKey?: string;
     provider?: string;

package/dist/server/infra/auth/oauth-service.js

@@ -52,6 +52,7 @@ export class OAuthService {
                 },
                 httpAgent: ProxyConfig.getProxyAgent(),
                 httpsAgent: ProxyConfig.getProxyAgent(),
+                proxy: false,
             });
             return this.parseTokenResponse(response.data);
         }
@@ -97,6 +98,7 @@ export class OAuthService {
             }, {
                 httpAgent: ProxyConfig.getProxyAgent(),
                 httpsAgent: ProxyConfig.getProxyAgent(),
+                proxy: false,
             });
             return this.parseTokenResponse(response.data);
         }

package/dist/server/infra/auth/oidc-discovery-service.js

@@ -79,6 +79,7 @@ export class OidcDiscoveryService {
             const response = await axios.get(wellKnownUrl, {
                 httpAgent: ProxyConfig.getProxyAgent(),
                 httpsAgent: ProxyConfig.getProxyAgent(),
+                proxy: false,
                 timeout: this.timeoutMs,
             });
             // Validate required fields

package/dist/server/infra/cogit/http-cogit-push-service.js

@@ -99,6 +99,7 @@ export class HttpCogitPushService {
             },
             httpAgent: ProxyConfig.getProxyAgent(),
             httpsAgent: ProxyConfig.getProxyAgent(),
+            proxy: false,
             timeout: this.config.timeout,
         });
         return CogitPushResponse.fromJson(response.data);

package/dist/server/infra/daemon/agent-process.js

@@ -38,6 +38,7 @@ import { QueryExecutor } from '../executor/query-executor.js';
 import { AgentInstanceDiscovery } from '../transport/agent-instance-discovery.js';
 import { createAgentLogger } from './agent-logger.js';
 import { resolveSessionId } from './session-resolver.js';
+import { validateProviderForTask } from './task-validation.js';
 // ============================================================================
 // Environment
 // ============================================================================
@@ -308,17 +309,9 @@ async function executeTask(task, curateExecutor, folderPackExecutor, queryExecut
     if (!transport || !agent)
         return;
     const freshProviderConfig = await transport.requestWithAck(TransportStateEventNames.GET_PROVIDER_CONFIG);
-    if (!freshProviderConfig.activeProvider) {
-        const error = serializeTaskError(new TaskError('No provider connected. Use /provider in the REPL to configure a provider.', TaskErrorCode.PROVIDER_NOT_CONFIGURED));
-        transport.request(TransportTaskEventNames.ERROR, { clientId, error, taskId });
-        return;
-    }
-    if (freshProviderConfig.providerKeyMissing) {
-        const modelInfo = freshProviderConfig.activeModel ? ` (model: ${freshProviderConfig.activeModel})` : '';
-        const credentialType = freshProviderConfig.authMethod === 'oauth' ? 'authentication has expired' : 'API key is missing';
-        const errorMessage = `${freshProviderConfig.activeProvider} ${credentialType}${modelInfo}. Use /provider in the REPL to reconnect.`;
-        const error = serializeTaskError(new TaskError(errorMessage, TaskErrorCode.PROVIDER_NOT_CONFIGURED));
-        transport.request(TransportTaskEventNames.ERROR, { clientId, error, taskId });
+    const validationError = validateProviderForTask(freshProviderConfig);
+    if (validationError) {
+        transport.request(TransportTaskEventNames.ERROR, { clientId, error: validationError, taskId });
         return;
     }
     activeTaskCount++;

package/dist/server/infra/daemon/brv-server.js

@@ -359,7 +359,7 @@ async function main() {
         // is returned to the onboarding flow rather than hitting a cryptic API key error mid-task.
         await clearStaleProviderConfig(providerConfigStore, providerKeychainStore, providerOAuthTokenStore);
         // State endpoint: provider config — agents request this on startup and after provider:updated
-        transportServer.onRequest(TransportStateEventNames.GET_PROVIDER_CONFIG, async () => resolveProviderConfig(providerConfigStore, providerKeychainStore, tokenRefreshManager));
+        transportServer.onRequest(TransportStateEventNames.GET_PROVIDER_CONFIG, async () => resolveProviderConfig({ authStateStore, providerConfigStore, providerKeychainStore, tokenRefreshManager }));
         // Feature handlers (auth, init, status, push, pull, etc.) require async OIDC discovery.
         // Placed after daemon:getState so the debug endpoint is available immediately,
         // without waiting for OIDC discovery (~400ms).

package/dist/server/infra/daemon/task-validation.d.ts

@@ -0,0 +1,18 @@
+/**
+ * Pre-task Provider Validation
+ *
+ * Pure validation logic extracted from agent-process.ts for testability.
+ * Checks that the provider config is ready for task execution.
+ */
+import type { TaskErrorData } from '../../core/domain/errors/task-error.js';
+import type { ProviderConfigResponse } from '../../core/domain/transport/schemas.js';
+/**
+ * Validate provider config before executing a task.
+ * Returns a TaskErrorData if validation fails, undefined if all checks pass.
+ *
+ * Check order matters — most fundamental issues first:
+ * 1. No provider connected
+ * 2. Provider credential missing (API key or expired OAuth token)
+ * 3. Provider requires authentication (ByteRover auth gate)
+ */
+export declare const validateProviderForTask: (config: ProviderConfigResponse) => TaskErrorData | undefined;

package/dist/server/infra/daemon/task-validation.js

@@ -0,0 +1,42 @@
+/**
+ * Pre-task Provider Validation
+ *
+ * Pure validation logic extracted from agent-process.ts for testability.
+ * Checks that the provider config is ready for task execution.
+ */
+import { TaskErrorCode } from '../../core/domain/errors/task-error.js';
+/**
+ * Validate provider config before executing a task.
+ * Returns a TaskErrorData if validation fails, undefined if all checks pass.
+ *
+ * Check order matters — most fundamental issues first:
+ * 1. No provider connected
+ * 2. Provider credential missing (API key or expired OAuth token)
+ * 3. Provider requires authentication (ByteRover auth gate)
+ */
+export const validateProviderForTask = (config) => {
+    if (!config.activeProvider) {
+        return {
+            code: TaskErrorCode.PROVIDER_NOT_CONFIGURED,
+            message: 'No provider connected. Use /provider in the REPL to configure a provider.',
+            name: 'TaskError',
+        };
+    }
+    if (config.providerKeyMissing) {
+        const modelInfo = config.activeModel ? ` (model: ${config.activeModel})` : '';
+        const credentialType = config.authMethod === 'oauth' ? 'authentication has expired' : 'API key is missing';
+        return {
+            code: TaskErrorCode.PROVIDER_NOT_CONFIGURED,
+            message: `${config.activeProvider} ${credentialType}${modelInfo}. Use /provider in the REPL to reconnect.`,
+            name: 'TaskError',
+        };
+    }
+    if (config.loginRequired) {
+        return {
+            code: TaskErrorCode.PROVIDER_NOT_CONFIGURED,
+            message: 'Provider requires authentication. Run /login or brv login to sign in.',
+            name: 'TaskError',
+        };
+    }
+    return undefined;
+};

package/dist/server/infra/http/authenticated-http-client.js

@@ -30,6 +30,7 @@ export class AuthenticatedHttpClient {
                 headers: this.buildHeaders(config?.headers),
                 httpAgent: ProxyConfig.getProxyAgent(),
                 httpsAgent: ProxyConfig.getProxyAgent(),
+                proxy: false,
                 timeout: config?.timeout,
             };
             const response = await axios.get(url, axiosConfig);
@@ -53,6 +54,7 @@ export class AuthenticatedHttpClient {
                 headers: this.buildHeaders(config?.headers),
                 httpAgent: ProxyConfig.getProxyAgent(),
                 httpsAgent: ProxyConfig.getProxyAgent(),
+                proxy: false,
                 timeout: config?.timeout,
             };
             const response = await axios.post(url, data, axiosConfig);
@@ -76,6 +78,7 @@ export class AuthenticatedHttpClient {
                 headers: this.buildHeaders(config?.headers),
                 httpAgent: ProxyConfig.getProxyAgent(),
                 httpsAgent: ProxyConfig.getProxyAgent(),
+                proxy: false,
                 timeout: config?.timeout,
             };
             const response = await axios.put(url, data, axiosConfig);

package/dist/server/infra/http/models-dev-client.js

@@ -60,6 +60,7 @@ export class ModelsDevClient {
         const response = await axios.get(MODELS_DEV_URL, {
             httpAgent: ProxyConfig.getProxyAgent(),
             httpsAgent: ProxyConfig.getProxyAgent(),
+            proxy: false,
             timeout: FETCH_TIMEOUT_MS,
         });
         const { data } = response;

package/dist/server/infra/http/openrouter-api-client.js

@@ -103,6 +103,7 @@ export class OpenRouterApiClient {
             },
             httpAgent: ProxyConfig.getProxyAgent(),
             httpsAgent: ProxyConfig.getProxyAgent(),
+            proxy: false,
             timeout: 30_000,
         });
         return response.data.data.map((model) => this.normalizeModel(model));

package/dist/server/infra/http/provider-model-fetchers.js

@@ -349,6 +349,7 @@ export class OpenAICompatibleModelFetcher {
             headers: { Authorization: `Bearer ${apiKey}` },
             httpAgent: ProxyConfig.getProxyAgent(),
             httpsAgent: ProxyConfig.getProxyAgent(),
+            proxy: false,
             timeout: 30_000,
         });
         // Handle different response formats:
@@ -381,6 +382,7 @@ export class OpenAICompatibleModelFetcher {
                 headers: { Authorization: `Bearer ${apiKey}` },
                 httpAgent: ProxyConfig.getProxyAgent(),
                 httpsAgent: ProxyConfig.getProxyAgent(),
+                proxy: false,
                 timeout: 15_000,
             });
             return { isValid: true };
@@ -438,6 +440,7 @@ export class ChatBasedModelFetcher {
                 },
                 httpAgent: ProxyConfig.getProxyAgent(),
                 httpsAgent: ProxyConfig.getProxyAgent(),
+                proxy: false,
                 timeout: 15_000,
             });
             return { isValid: true };

package/dist/server/infra/hub/hub-install-service.js

@@ -33,6 +33,7 @@ export class HubInstallService {
                 headers,
                 httpAgent: ProxyConfig.getProxyAgent(),
                 httpsAgent: ProxyConfig.getProxyAgent(),
+                proxy: false,
                 responseType: 'text',
                 timeout: 15_000,
             });

package/dist/server/infra/hub/hub-registry-service.js

@@ -72,6 +72,7 @@ export class HubRegistryService {
                 headers,
                 httpAgent: ProxyConfig.getProxyAgent(),
                 httpsAgent: ProxyConfig.getProxyAgent(),
+                proxy: false,
                 timeout: this.timeoutMs,
             });
             const validated = this.parseRegistryResponse(response.data);

package/dist/server/infra/memory/http-memory-storage-service.js

@@ -58,6 +58,7 @@ export class HttpMemoryStorageService {
                 },
                 httpAgent: ProxyConfig.getProxyAgent(),
                 httpsAgent: ProxyConfig.getProxyAgent(),
+                proxy: false,
                 timeout: this.config.timeout,
             });
         }

package/dist/server/infra/process/feature-handlers.js

@@ -59,6 +59,7 @@ export async function setupFeatureHandlers({ authStateStore, broadcastToProject,
         userService,
     }).setup();
     new ProviderHandler({
+        authStateStore,
         browserLauncher: new SystemBrowserLauncher(),
         providerConfigStore,
         providerKeychainStore,

package/dist/server/infra/provider/provider-config-resolver.d.ts

@@ -9,6 +9,7 @@ import type { IProviderConfigStore } from '../../core/interfaces/i-provider-conf
 import type { IProviderKeychainStore } from '../../core/interfaces/i-provider-keychain-store.js';
 import type { IProviderOAuthTokenStore } from '../../core/interfaces/i-provider-oauth-token-store.js';
 import type { ITokenRefreshManager } from '../../core/interfaces/i-token-refresh-manager.js';
+import type { IAuthStateStore } from '../../core/interfaces/state/i-auth-state-store.js';
 import { type ProviderConfigResponse } from '../../core/domain/transport/schemas.js';
 /**
  * Validate provider config integrity at startup.
@@ -29,4 +30,10 @@ export declare function clearStaleProviderConfig(providerConfigStore: IProviderC
  * the API key (keychain → env fallback), and maps provider-specific
  * fields (base URL, headers, location, etc.).
  */
-export declare function resolveProviderConfig(providerConfigStore: IProviderConfigStore, providerKeychainStore: IProviderKeychainStore, tokenRefreshManager?: ITokenRefreshManager): Promise<ProviderConfigResponse>;
+export type ResolveProviderConfigParams = {
+    authStateStore?: IAuthStateStore;
+    providerConfigStore: IProviderConfigStore;
+    providerKeychainStore: IProviderKeychainStore;
+    tokenRefreshManager?: ITokenRefreshManager;
+};
+export declare function resolveProviderConfig(params: ResolveProviderConfigParams): Promise<ProviderConfigResponse>;

package/dist/server/infra/provider/provider-config-resolver.js

@@ -49,9 +49,9 @@ export async function clearStaleProviderConfig(providerConfigStore, providerKeyc
         for (const providerId of staleProviderIds) {
             newConfig = newConfig.withProviderDisconnected(providerId);
         }
-        // withProviderDisconnected() falls back to 'byterover' when the active provider is
-        // removed, which causes the TUI to show 'ready' and skip provider setup. Explicitly
-        // set activeProvider to '' so the user is returned to the provider setup flow.
+        // withProviderDisconnected() already sets activeProvider to '' when the active
+        // provider is removed. This call is a no-op but kept for readability — it makes
+        // the "clear active provider" intent explicit at the call site.
         if (staleProviderIds.includes(config.activeProvider)) {
             newConfig = newConfig.withActiveProvider('');
         }
@@ -67,19 +67,18 @@ export async function clearStaleProviderConfig(providerConfigStore, providerKeyc
         // The user will encounter a provider error when submitting a task instead.
     }
 }
-/**
- * Resolve the active provider's full configuration.
- *
- * Reads the active provider/model from the config store, resolves
- * the API key (keychain → env fallback), and maps provider-specific
- * fields (base URL, headers, location, etc.).
- */
-export async function resolveProviderConfig(providerConfigStore, providerKeychainStore, tokenRefreshManager) {
+export async function resolveProviderConfig(params) {
+    const { authStateStore, providerConfigStore, providerKeychainStore, tokenRefreshManager } = params;
     const config = await providerConfigStore.read();
     const { activeProvider } = config;
     const activeModel = config.getActiveModel(activeProvider);
     const maxInputTokens = config.getActiveModelContextLength(activeProvider);
-    if (!activeProvider || activeProvider === 'byterover') {
+    if (activeProvider === 'byterover') {
+        const authToken = authStateStore?.getToken();
+        const loginRequired = authStateStore ? !authToken || !authToken.isValid() : undefined;
+        return { activeModel, activeProvider, loginRequired: loginRequired ? true : undefined, maxInputTokens };
+    }
+    if (!activeProvider) {
         return { activeModel, activeProvider, maxInputTokens };
     }
     // Resolve API key: keychain first, then environment variable

package/dist/server/infra/provider-oauth/refresh-token-exchange.js

@@ -23,6 +23,7 @@ export async function exchangeRefreshToken(params) {
             },
             httpAgent: ProxyConfig.getProxyAgent(),
             httpsAgent: ProxyConfig.getProxyAgent(),
+            proxy: false,
             timeout: 30_000,
         });
     }

package/dist/server/infra/provider-oauth/token-exchange.js

@@ -28,6 +28,7 @@ export async function exchangeCodeForTokens(params) {
             },
             httpAgent: ProxyConfig.getProxyAgent(),
             httpsAgent: ProxyConfig.getProxyAgent(),
+            proxy: false,
             timeout: 30_000,
         });
     }

package/dist/server/infra/transport/handlers/provider-handler.d.ts

@@ -2,10 +2,12 @@ import type { IProviderConfigStore } from '../../../core/interfaces/i-provider-c
 import type { IProviderKeychainStore } from '../../../core/interfaces/i-provider-keychain-store.js';
 import type { IProviderOAuthTokenStore } from '../../../core/interfaces/i-provider-oauth-token-store.js';
 import type { IBrowserLauncher } from '../../../core/interfaces/services/i-browser-launcher.js';
+import type { IAuthStateStore } from '../../../core/interfaces/state/i-auth-state-store.js';
 import type { ITransportServer } from '../../../core/interfaces/transport/i-transport-server.js';
 import type { PkceParameters, ProviderTokenResponse, TokenExchangeParams } from '../../provider-oauth/index.js';
 import { ProviderCallbackServer } from '../../provider-oauth/index.js';
 export interface ProviderHandlerDeps {
+    authStateStore: IAuthStateStore;
     browserLauncher: IBrowserLauncher;
     /** Factory for creating callback servers (injectable for testing) */
     createCallbackServer?: (options: {
@@ -26,6 +28,7 @@ export interface ProviderHandlerDeps {
  * Business logic for provider management — no terminal/UI calls.
  */
 export declare class ProviderHandler {
+    private readonly authStateStore;
     private readonly browserLauncher;
     private readonly createCallbackServer;
     private readonly exchangeCodeForTokens;
@@ -38,6 +41,7 @@ export declare class ProviderHandler {
     constructor(deps: ProviderHandlerDeps);
     setup(): void;
     private cleanupFlowsForClient;
+    private isByteRoverAuthSatisfied;
     private setupAwaitOAuthCallback;
     private setupCancelOAuth;
     private setupConnect;

package/dist/server/infra/transport/handlers/provider-handler.js

@@ -10,6 +10,7 @@ import { computeExpiresAt, exchangeCodeForTokens as defaultExchangeCodeForTokens
  * Business logic for provider management — no terminal/UI calls.
  */
 export class ProviderHandler {
+    authStateStore;
     browserLauncher;
     createCallbackServer;
     exchangeCodeForTokens;
@@ -20,6 +21,7 @@ export class ProviderHandler {
     providerOAuthTokenStore;
     transport;
     constructor(deps) {
+        this.authStateStore = deps.authStateStore;
         this.browserLauncher = deps.browserLauncher;
         this.createCallbackServer = deps.createCallbackServer ?? ((options) => new ProviderCallbackServer(options));
         this.exchangeCodeForTokens = deps.exchangeCodeForTokens ?? defaultExchangeCodeForTokens;
@@ -53,6 +55,10 @@ export class ProviderHandler {
             }
         }
     }
+    isByteRoverAuthSatisfied() {
+        const token = this.authStateStore.getToken();
+        return token !== undefined && token.isValid();
+    }
     setupAwaitOAuthCallback() {
         this.transport.onRequest(ProviderEvents.AWAIT_OAUTH_CALLBACK, async (data) => {
             const flow = this.oauthFlows.get(data.providerId);
@@ -133,6 +139,9 @@ export class ProviderHandler {
     setupConnect() {
         this.transport.onRequest(ProviderEvents.CONNECT, async (data) => {
             const { apiKey, baseUrl, providerId } = data;
+            if (providerId === 'byterover' && !this.isByteRoverAuthSatisfied()) {
+                return { error: 'ByteRover Provider requires authentication. Run /login or brv login to sign in', success: false };
+            }
             // Store API key if provided (supports optional keys for openai-compatible)
             if (apiKey) {
                 await this.providerKeychainStore.setApiKey(providerId, apiKey);
@@ -161,7 +170,8 @@ export class ProviderHandler {
         this.transport.onRequest(ProviderEvents.GET_ACTIVE, async () => {
             const activeProviderId = await this.providerConfigStore.getActiveProvider();
             const activeModel = await this.providerConfigStore.getActiveModel(activeProviderId);
-            return { activeModel, activeProviderId };
+            const loginRequired = activeProviderId === 'byterover' && !this.isByteRoverAuthSatisfied();
+            return { activeModel, activeProviderId, loginRequired: loginRequired ? true : undefined };
         });
     }
     setupList() {
@@ -198,6 +208,9 @@ export class ProviderHandler {
     }
     setupSetActive() {
         this.transport.onRequest(ProviderEvents.SET_ACTIVE, async (data) => {
+            if (data.providerId === 'byterover' && !this.isByteRoverAuthSatisfied()) {
+                return { error: 'ByteRover Provider requires authentication. Run /login or brv login to sign in', success: false };
+            }
             await this.providerConfigStore.setActiveProvider(data.providerId);
             this.transport.broadcast(TransportDaemonEventNames.PROVIDER_UPDATED, {});
             return { success: true };

package/dist/shared/transport/events/provider-events.d.ts

@@ -21,6 +21,7 @@ export interface ProviderConnectRequest {
     providerId: string;
 }
 export interface ProviderConnectResponse {
+    error?: string;
     success: boolean;
 }
 export interface ProviderDisconnectRequest {
@@ -40,11 +41,14 @@ export interface ProviderValidateApiKeyResponse {
 export interface ProviderGetActiveResponse {
     activeModel?: string;
     activeProviderId: string;
+    /** True when the active provider requires login but the user is not logged in. */
+    loginRequired?: boolean;
 }
 export interface ProviderSetActiveRequest {
     providerId: string;
 }
 export interface ProviderSetActiveResponse {
+    error?: string;
     success: boolean;
 }
 export interface ProviderCancelOAuthRequest {

package/dist/tui/features/onboarding/hooks/use-app-view-mode.d.ts

@@ -5,7 +5,7 @@
  * This is the single source of truth for determining what UI to show.
  */
 /**
- * The 5 valid application view modes as a discriminated union.
+ * The valid application view modes as a discriminated union.
  */
 export type AppViewMode = {
     type: 'config-provider';
@@ -15,13 +15,28 @@ export type AppViewMode = {
     type: 'ready';
 };
 /**
- * Selector that derives the current view mode from stored state.
- * This is the ONLY way to determine what UI to show.
+ * Parameters for the pure view mode derivation function.
+ */
+export type DeriveAppViewModeParams = {
+    activeModel?: string;
+    activeProviderId?: string;
+    isAuthorized: boolean;
+    isLoading: boolean;
+};
+/**
+ * Pure decision logic for determining the app view mode.
+ * Extracted from useAppViewMode for testability.
  *
- * View mode decision tree:
- * 1. Loading auth or onboarding check -> 'loading'
- * 2. New user (hasDismissed) -> 'onboarding'
- * 3. Existing user, no provider config -> provider flow
- * 4. Otherwise -> 'ready'
+ * Decision tree:
+ * 1. Loading → 'loading'
+ * 2. ByteRover + unauthenticated → 'config-provider'
+ * 3. ByteRover + authenticated → 'ready'
+ * 4. Non-byterover + no active model → 'config-provider'
+ * 5. Otherwise → 'ready'
+ */
+export declare function deriveAppViewMode(params: DeriveAppViewModeParams): AppViewMode;
+/**
+ * React hook that derives the current view mode from stored state.
+ * Thin wrapper around deriveAppViewMode — reads from stores, delegates logic.
  */
 export declare function useAppViewMode(): AppViewMode;

package/dist/tui/features/onboarding/hooks/use-app-view-mode.js

@@ -7,30 +7,42 @@
 import { useAuthStore } from '../../auth/stores/auth-store.js';
 import { useGetActiveProviderConfig } from '../../provider/api/get-active-provider-config.js';
 /**
- * Selector that derives the current view mode from stored state.
- * This is the ONLY way to determine what UI to show.
+ * Pure decision logic for determining the app view mode.
+ * Extracted from useAppViewMode for testability.
  *
- * View mode decision tree:
- * 1. Loading auth or onboarding check -> 'loading'
- * 2. New user (hasDismissed) -> 'onboarding'
- * 3. Existing user, no provider config -> provider flow
- * 4. Otherwise -> 'ready'
+ * Decision tree:
+ * 1. Loading → 'loading'
+ * 2. ByteRover + unauthenticated → 'config-provider'
+ * 3. ByteRover + authenticated → 'ready'
+ * 4. Non-byterover + no active model → 'config-provider'
+ * 5. Otherwise → 'ready'
  */
-export function useAppViewMode() {
-    const { isLoadingInitial: isLoadingAuth } = useAuthStore();
-    const { data: activeData, isLoading: isLoadingActive } = useGetActiveProviderConfig();
-    // Still loading auth or active provider check
-    if (isLoadingAuth || isLoadingActive) {
+export function deriveAppViewMode(params) {
+    if (params.isLoading) {
         return { type: 'loading' };
     }
-    // ByteRover is the default provider and doesn't require model config
-    if (activeData?.activeProviderId === 'byterover') {
+    if (params.activeProviderId === 'byterover' && !params.isAuthorized) {
+        return { type: 'config-provider' };
+    }
+    if (params.activeProviderId === 'byterover') {
         return { type: 'ready' };
     }
-    // No active model configured for non-byterover provider — need provider setup
-    if (!activeData?.activeModel) {
+    if (!params.activeModel) {
         return { type: 'config-provider' };
     }
-    // Normal app state
     return { type: 'ready' };
 }
+/**
+ * React hook that derives the current view mode from stored state.
+ * Thin wrapper around deriveAppViewMode — reads from stores, delegates logic.
+ */
+export function useAppViewMode() {
+    const { isAuthorized, isLoadingInitial: isLoadingAuth } = useAuthStore();
+    const { data: activeData, isLoading: isLoadingActive } = useGetActiveProviderConfig();
+    return deriveAppViewMode({
+        activeModel: activeData?.activeModel,
+        activeProviderId: activeData?.activeProviderId,
+        isAuthorized,
+        isLoading: isLoadingAuth || isLoadingActive,
+    });
+}