byterover-cli 1.1.0 → 1.2.0

package/dist/infra/connectors/rules/rules-connector.js

@@ -1,6 +1,6 @@
 import path from 'node:path';
 import { AGENT_CONNECTOR_CONFIG } from '../../../core/domain/entities/agent.js';
-import { BRV_RULE_MARKERS, BRV_RULE_TAG } from '../shared/constants.js';
+import { RuleFileManager } from '../shared/rule-file-manager.js';
 import { RULES_CONNECTOR_CONFIGS } from './rules-connector-config.js';
 /**
  * Connector that integrates BRV with coding agents via rule files.
@@ -10,12 +10,17 @@ export class RulesConnector {
     type = 'rules';
     fileService;
     projectRoot;
+    ruleFileManager;
     supportedAgents;
     templateService;
     constructor(options) {
         this.fileService = options.fileService;
         this.projectRoot = options.projectRoot;
         this.templateService = options.templateService;
+        this.ruleFileManager = new RuleFileManager({
+            fileService: options.fileService,
+            projectRoot: options.projectRoot,
+        });
         this.supportedAgents = Object.entries(AGENT_CONNECTOR_CONFIG)
             .filter(([_, config]) => config.supported.includes(this.type))
             .map(([agent]) => agent);
@@ -28,36 +33,10 @@ export class RulesConnector {
     }
     async install(agent) {
         const config = RULES_CONNECTOR_CONFIGS[agent];
-        const fullPath = path.join(this.projectRoot, config.filePath);
         try {
-            const exists = await this.fileService.exists(fullPath);
-            if (exists) {
-                const content = await this.fileService.read(fullPath);
-                const hasMarkers = content.includes(BRV_RULE_MARKERS.START) && content.includes(BRV_RULE_MARKERS.END);
-                // File exists but no BRV content or different agent - append or replace based on writeMode
-                const ruleContent = await this.templateService.generateRuleContent(agent);
-                if (config.writeMode === 'overwrite') {
-                    await this.fileService.write(ruleContent, fullPath, 'overwrite');
-                }
-                else if (hasMarkers) {
-                    // Replace existing markers section
-                    const newContent = this.replaceMarkerSection(content, ruleContent);
-                    await this.fileService.write(newContent, fullPath, 'overwrite');
-                }
-                else {
-                    // Append to file
-                    await this.fileService.write(ruleContent, fullPath, 'append');
-                }
-                return {
-                    alreadyInstalled: false,
-                    configPath: config.filePath,
-                    message: `Rules connector installed for ${agent}`,
-                    success: true,
-                };
-            }
-            // File doesn't exist - create it
-            const ruleContent = await this.templateService.generateRuleContent(agent);
-            await this.fileService.write(ruleContent, fullPath, 'overwrite');
+            const ruleContent = await this.templateService.generateRuleContent(agent, this.type);
+            // Write the rule content to the file
+            await this.ruleFileManager.install(config.filePath, config.writeMode, ruleContent);
             return {
                 alreadyInstalled: false,
                 configPath: config.filePath,
@@ -81,8 +60,8 @@ export class RulesConnector {
         const config = RULES_CONNECTOR_CONFIGS[agent];
         const fullPath = path.join(this.projectRoot, config.filePath);
         try {
-            const exists = await this.fileService.exists(fullPath);
-            if (!exists) {
+            const { fileExists, hasMarkers } = await this.ruleFileManager.status(config.filePath);
+            if (!fileExists) {
                 return {
                     configExists: false,
                     configPath: config.filePath,
@@ -90,12 +69,10 @@ export class RulesConnector {
                 };
             }
             const content = await this.fileService.read(fullPath);
-            // Check for boundary markers (new format)
-            const hasMarkers = content.includes(BRV_RULE_MARKERS.START) && content.includes(BRV_RULE_MARKERS.END);
-            const hasAgentTag = content.includes(`${BRV_RULE_TAG} ${agent}`);
+            const hasMcpTools = content.includes('brv-query') || content.includes('brv-curate');
             // For overwrite files, any BRV content means installed
             // For append files, need both markers and agent tag
-            const installed = config.writeMode === 'overwrite' ? hasMarkers || hasAgentTag : hasMarkers && hasAgentTag;
+            const installed = hasMarkers && !hasMcpTools;
             return {
                 configExists: true,
                 configPath: config.filePath,
@@ -113,10 +90,9 @@ export class RulesConnector {
     }
     async uninstall(agent) {
         const config = RULES_CONNECTOR_CONFIGS[agent];
-        const fullPath = path.join(this.projectRoot, config.filePath);
         try {
-            const exists = await this.fileService.exists(fullPath);
-            if (!exists) {
+            const { fileExists, hasLegacyTag, hasMarkers } = await this.ruleFileManager.status(config.filePath);
+            if (!fileExists) {
                 return {
                     configPath: config.filePath,
                     message: `Rule file does not exist: ${config.filePath}`,
@@ -124,11 +100,7 @@ export class RulesConnector {
                     wasInstalled: false,
                 };
             }
-            const content = await this.fileService.read(fullPath);
-            const hasMarkers = content.includes(BRV_RULE_MARKERS.START) && content.includes(BRV_RULE_MARKERS.END);
             if (!hasMarkers) {
-                // Check for legacy format (footer tag without markers)
-                const hasLegacyTag = content.includes(`${BRV_RULE_TAG} ${agent}`);
                 if (!hasLegacyTag) {
                     return {
                         configPath: config.filePath,
@@ -145,24 +117,14 @@ export class RulesConnector {
                     wasInstalled: true,
                 };
             }
-            // Remove the section between markers (inclusive)
-            if (config.writeMode === 'overwrite') {
-                // For dedicated files, delete the entire file
-                await this.fileService.delete(fullPath);
-            }
-            else {
-                // For shared files, remove only the BRV section
-                const newContent = this.removeMarkerSection(content);
-                // If file would be empty, delete it; otherwise write the new content
-                await (newContent.trim() === ''
-                    ? this.fileService.delete(fullPath)
-                    : this.fileService.write(newContent, fullPath, 'overwrite'));
-            }
+            const result = await this.ruleFileManager.uninstall(config.filePath, config.writeMode);
             return {
                 configPath: config.filePath,
-                message: `Rules connector uninstalled for ${agent}`,
+                message: result.wasInstalled
+                    ? `Rules connector uninstalled for ${agent}`
+                    : `Rules connector is not installed for ${agent}`,
                 success: true,
-                wasInstalled: true,
+                wasInstalled: result.wasInstalled,
             };
         }
         catch (error) {
@@ -174,31 +136,4 @@ export class RulesConnector {
             };
         }
     }
-    /**
-     * Removes the section between BRV markers (inclusive).
-     */
-    removeMarkerSection(content) {
-        const startIndex = content.indexOf(BRV_RULE_MARKERS.START);
-        const endIndex = content.indexOf(BRV_RULE_MARKERS.END);
-        if (startIndex === -1 || endIndex === -1) {
-            return content;
-        }
-        const before = content.slice(0, startIndex);
-        const after = content.slice(endIndex + BRV_RULE_MARKERS.END.length);
-        // Clean up extra newlines
-        return (before + after).replaceAll(/\n{3,}/g, '\n\n').trim();
-    }
-    /**
-     * Replaces the section between BRV markers with new content.
-     */
-    replaceMarkerSection(content, newRuleContent) {
-        const startIndex = content.indexOf(BRV_RULE_MARKERS.START);
-        const endIndex = content.indexOf(BRV_RULE_MARKERS.END);
-        if (startIndex === -1 || endIndex === -1) {
-            return content;
-        }
-        const before = content.slice(0, startIndex);
-        const after = content.slice(endIndex + BRV_RULE_MARKERS.END.length);
-        return before + newRuleContent + after;
-    }
 }

package/dist/infra/connectors/shared/rule-file-manager.d.ts

@@ -0,0 +1,72 @@
+import type { IFileService, WriteMode } from '../../../core/interfaces/i-file-service.js';
+/**
+ * Result of a rule file installation operation.
+ */
+export type RuleFileInstallResult = {
+    /** Whether the content was newly installed (false if replaced existing) */
+    isNew: boolean;
+    /** Whether the operation succeeded */
+    success: boolean;
+};
+/**
+ * Result of a rule file uninstallation operation.
+ */
+export type RuleFileUninstallResult = {
+    /** Whether the operation succeeded */
+    success: boolean;
+    /** Whether there was content to remove */
+    wasInstalled: boolean;
+};
+/**
+ * Result of a rule file status check.
+ */
+export type RuleFileStatusResult = {
+    /** Whether the file exists */
+    fileExists: boolean;
+    /** Whether the file contains legacy BRV tag (without markers) */
+    hasLegacyTag: boolean;
+    /** Whether the file contains BRV markers */
+    hasMarkers: boolean;
+};
+/**
+ * Manages rule file operations including installation, uninstallation,
+ * and marker section manipulation.
+ *
+ * This class centralizes the logic for working with rule files that use
+ * BRV markers to delimit managed content sections.
+ */
+export declare class RuleFileManager {
+    private readonly fileService;
+    private readonly projectRoot;
+    constructor(options: {
+        fileService: IFileService;
+        projectRoot: string;
+    });
+    /**
+     * Install rule content into a file.
+     *
+     * @param filePath - Relative path to the rule file
+     * @param writeMode - How to write the content ('overwrite' or 'append')
+     * @param ruleContent - The rule content to write (should include markers)
+     */
+    install(filePath: string, writeMode: WriteMode, ruleContent: string): Promise<RuleFileInstallResult>;
+    /**
+     * Removes the section between BRV markers (inclusive).
+     */
+    removeMarkerSection(content: string): string;
+    /**
+     * Replaces the section between BRV markers with new content.
+     */
+    replaceMarkerSection(content: string, newRuleContent: string): string;
+    /**
+     * Check the status of rule content in a file.
+     */
+    status(filePath: string): Promise<RuleFileStatusResult>;
+    /**
+     * Uninstall rule content from a file.
+     *
+     * @param filePath - Relative path to the rule file
+     * @param writeMode - How the content was written ('overwrite' or 'append')
+     */
+    uninstall(filePath: string, writeMode: WriteMode): Promise<RuleFileUninstallResult>;
+}

package/dist/infra/connectors/shared/rule-file-manager.js

@@ -0,0 +1,119 @@
+import path from 'node:path';
+import { BRV_RULE_MARKERS, BRV_RULE_TAG } from './constants.js';
+/**
+ * Manages rule file operations including installation, uninstallation,
+ * and marker section manipulation.
+ *
+ * This class centralizes the logic for working with rule files that use
+ * BRV markers to delimit managed content sections.
+ */
+export class RuleFileManager {
+    fileService;
+    projectRoot;
+    constructor(options) {
+        this.fileService = options.fileService;
+        this.projectRoot = options.projectRoot;
+    }
+    /**
+     * Install rule content into a file.
+     *
+     * @param filePath - Relative path to the rule file
+     * @param writeMode - How to write the content ('overwrite' or 'append')
+     * @param ruleContent - The rule content to write (should include markers)
+     */
+    async install(filePath, writeMode, ruleContent) {
+        const fullPath = path.join(this.projectRoot, filePath);
+        const exists = await this.fileService.exists(fullPath);
+        if (exists) {
+            const content = await this.fileService.read(fullPath);
+            const hasMarkers = content.includes(BRV_RULE_MARKERS.START) && content.includes(BRV_RULE_MARKERS.END);
+            if (writeMode === 'overwrite') {
+                await this.fileService.write(ruleContent, fullPath, 'overwrite');
+            }
+            else if (hasMarkers) {
+                // Replace existing markers section
+                const newContent = this.replaceMarkerSection(content, ruleContent);
+                await this.fileService.write(newContent, fullPath, 'overwrite');
+            }
+            else {
+                // Append to file
+                await this.fileService.write(ruleContent, fullPath, 'append');
+            }
+            return { isNew: !hasMarkers, success: true };
+        }
+        // File doesn't exist - create it
+        await this.fileService.write(ruleContent, fullPath, 'overwrite');
+        return { isNew: true, success: true };
+    }
+    /**
+     * Removes the section between BRV markers (inclusive).
+     */
+    removeMarkerSection(content) {
+        const startIndex = content.indexOf(BRV_RULE_MARKERS.START);
+        const endIndex = content.indexOf(BRV_RULE_MARKERS.END);
+        if (startIndex === -1 || endIndex === -1) {
+            return content;
+        }
+        const before = content.slice(0, startIndex);
+        const after = content.slice(endIndex + BRV_RULE_MARKERS.END.length);
+        // Clean up extra newlines
+        return (before + after).replaceAll(/\n{3,}/g, '\n\n').trim();
+    }
+    /**
+     * Replaces the section between BRV markers with new content.
+     */
+    replaceMarkerSection(content, newRuleContent) {
+        const startIndex = content.indexOf(BRV_RULE_MARKERS.START);
+        const endIndex = content.indexOf(BRV_RULE_MARKERS.END);
+        if (startIndex === -1 || endIndex === -1) {
+            return content;
+        }
+        const before = content.slice(0, startIndex);
+        const after = content.slice(endIndex + BRV_RULE_MARKERS.END.length);
+        return before + newRuleContent + after;
+    }
+    /**
+     * Check the status of rule content in a file.
+     */
+    async status(filePath) {
+        const fullPath = path.join(this.projectRoot, filePath);
+        const fileExists = await this.fileService.exists(fullPath);
+        if (!fileExists) {
+            return { fileExists: false, hasLegacyTag: false, hasMarkers: false };
+        }
+        const content = await this.fileService.read(fullPath);
+        const hasMarkers = content.includes(BRV_RULE_MARKERS.START) && content.includes(BRV_RULE_MARKERS.END);
+        const hasLegacyTag = content.includes(BRV_RULE_TAG);
+        return { fileExists: true, hasLegacyTag, hasMarkers };
+    }
+    /**
+     * Uninstall rule content from a file.
+     *
+     * @param filePath - Relative path to the rule file
+     * @param writeMode - How the content was written ('overwrite' or 'append')
+     */
+    async uninstall(filePath, writeMode) {
+        const fullPath = path.join(this.projectRoot, filePath);
+        const exists = await this.fileService.exists(fullPath);
+        if (!exists) {
+            return { success: true, wasInstalled: false };
+        }
+        const content = await this.fileService.read(fullPath);
+        const hasMarkers = content.includes(BRV_RULE_MARKERS.START) && content.includes(BRV_RULE_MARKERS.END);
+        if (!hasMarkers) {
+            return { success: true, wasInstalled: false };
+        }
+        if (writeMode === 'overwrite') {
+            // For dedicated files, delete the entire file
+            await this.fileService.delete(fullPath);
+        }
+        else {
+            // For shared files, remove only the BRV section
+            const newContent = this.removeMarkerSection(content);
+            await (newContent.trim() === ''
+                ? this.fileService.delete(fullPath)
+                : this.fileService.write(newContent, fullPath, 'overwrite'));
+        }
+        return { success: true, wasInstalled: true };
+    }
+}

package/dist/infra/connectors/shared/template-service.d.ts

@@ -1,4 +1,5 @@
 import type { Agent } from '../../../core/domain/entities/agent.js';
+import type { ConnectorType } from '../../../core/domain/entities/connector-type.js';
 import type { IRuleTemplateService } from '../../../core/interfaces/i-rule-template-service.js';
 import type { ITemplateLoader } from '../../../core/interfaces/i-template-loader.js';
 /**
@@ -14,5 +15,13 @@ export declare class RuleTemplateService implements IRuleTemplateService {
      * @returns Promise resolving to the rule content as a string.
      * @throws Error if templates cannot be loaded or assembled.
      */
-    generateRuleContent(agent: Agent): Promise<string>;
+    generateRuleContent(agent: Agent, type?: ConnectorType): Promise<string>;
+    /**
+     * Generates CLI mode content with full workflow and command reference.
+     */
+    private generateCliContent;
+    /**
+     * Generates MCP mode content with concise tool-focused instructions.
+     */
+    private generateMcpContent;
 }

package/dist/infra/connectors/shared/template-service.js

@@ -60,29 +60,66 @@ export class RuleTemplateService {
      * @returns Promise resolving to the rule content as a string.
      * @throws Error if templates cannot be loaded or assembled.
      */
-    async generateRuleContent(agent) {
+    async generateRuleContent(agent, type) {
         try {
             // Load section templates
-            const workflow = await this.templateLoader.loadSection('workflow');
-            const commandReference = await this.templateLoader.loadSection('command-reference');
-            // Load base template
-            const baseTemplate = await this.templateLoader.loadTemplate('base.md');
-            // Assemble context for variable substitution
-            const context = {
-                /* eslint-disable camelcase */
-                agent_name: agent,
-                command_reference: commandReference,
-                workflow,
-                /* eslint-enable camelcase */
-            };
-            // Substitute variables and get content
-            const content = this.templateLoader.substituteVariables(baseTemplate, context);
+            let content;
+            switch (type) {
+                case 'mcp': {
+                    content = await this.generateMcpContent();
+                    break;
+                }
+                case 'rules': {
+                    content = await this.generateCliContent(agent);
+                    break;
+                }
+                default: {
+                    throw new Error(`Unsupported connector type: ${type}`);
+                }
+            }
             // Add agent-specific header if available
             const header = guideHeaders.find((h) => h.agent === agent)?.value || '';
             return wrapContentWithBoundaryMarkers(content, agent, header);
         }
         catch (error) {
-            throw new Error(`Failed to generate rule content for agent '${agent}': ${error instanceof Error ? error.message : String(error)}`);
+            throw new Error(`Failed to generate rule content for agent '${agent}' - type '${type}': ${error instanceof Error ? error.message : String(error)}`);
         }
     }
+    /**
+     * Generates CLI mode content with full workflow and command reference.
+     */
+    async generateCliContent(agent) {
+        // Load section templates
+        const workflow = await this.templateLoader.loadSection('workflow');
+        const commandReference = await this.templateLoader.loadSection('command-reference');
+        // Load base template
+        const baseTemplate = await this.templateLoader.loadTemplate('base.md');
+        // Assemble context for variable substitution
+        const context = {
+            /* eslint-disable camelcase */
+            agent_name: agent,
+            command_reference: commandReference,
+            workflow,
+            /* eslint-enable camelcase */
+        };
+        // Substitute variables and get content
+        return this.templateLoader.substituteVariables(baseTemplate, context);
+    }
+    /**
+     * Generates MCP mode content with concise tool-focused instructions.
+     */
+    async generateMcpContent() {
+        // Load MCP-specific section
+        const mcpWorkflow = await this.templateLoader.loadSection('mcp-workflow');
+        // Load MCP base template
+        const mcpBaseTemplate = await this.templateLoader.loadTemplate('mcp-base.md');
+        // Assemble context for variable substitution
+        const context = {
+            /* eslint-disable camelcase */
+            mcp_workflow: mcpWorkflow,
+            /* eslint-enable camelcase */
+        };
+        // Substitute variables and get content
+        return this.templateLoader.substituteVariables(mcpBaseTemplate, context);
+    }
 }

package/dist/infra/mcp/index.d.ts

@@ -0,0 +1,2 @@
+export { ByteRoverMcpServer, type McpServerConfig } from './mcp-server.js';
+export { registerBrvCurateTool, registerBrvQueryTool, waitForTaskResult } from './tools/index.js';

package/dist/infra/mcp/index.js

@@ -0,0 +1,2 @@
+export { ByteRoverMcpServer } from './mcp-server.js';
+export { registerBrvCurateTool, registerBrvQueryTool, waitForTaskResult } from './tools/index.js';

package/dist/infra/mcp/mcp-server.d.ts

@@ -0,0 +1,58 @@
+export interface McpServerConfig {
+    /** CLI version for MCP server identification */
+    version: string;
+    /** Working directory for file operations */
+    workingDirectory: string;
+}
+/**
+ * ByteRover MCP Server.
+ *
+ * Exposes brv-query and brv-curate as MCP tools for coding agents.
+ * Connects to a running brv instance via Socket.IO transport.
+ *
+ * Architecture:
+ * - Coding agent spawns `brv mcp` process
+ * - MCP server connects to running brv instance via Socket.IO
+ * - MCP tools create tasks via transport
+ * - Tasks are executed by the existing agent process
+ */
+export declare class ByteRoverMcpServer {
+    private client;
+    private readonly config;
+    private currentReconnectDelay;
+    private isReconnecting;
+    private reconnectTimer;
+    private readonly server;
+    private transport;
+    constructor(config: McpServerConfig);
+    /**
+     * Starts the MCP server.
+     *
+     * 1. Connects to running brv instance via Socket.IO
+     * 2. Starts MCP server with stdio transport
+     *
+     * @throws NoInstanceRunningError - No brv instance is running
+     * @throws ConnectionFailedError - Failed to connect to brv instance
+     */
+    start(): Promise<void>;
+    /**
+     * Stops the MCP server.
+     *
+     * Disconnects from the brv instance.
+     */
+    stop(): Promise<void>;
+    /**
+     * Attempts to reconnect to the brv instance.
+     * Uses exponential backoff for retry delays.
+     */
+    private attemptReconnect;
+    /**
+     * Log to stderr (stdout is reserved for MCP protocol).
+     */
+    private log;
+    /**
+     * Sets up the state change handler for a client.
+     * Handles disconnection by triggering auto-reconnect.
+     */
+    private setupStateChangeHandler;
+}