bv-ui-core 2.9.2 → 2.9.4

package/lib/bvFetch/index.js

@@ -83,14 +83,15 @@ module.exports = function BvFetch ({ shouldCache, cacheName, cacheLimit }) {
       }
     }).then(() => {
       if (canBeCached) {
-        const clonedResponse = response.clone()
+        const clonedResponse = response.clone();
+        const sizeCheck = response.clone();
         const newHeaders = new Headers();
         clonedResponse.headers.forEach((value, key) => {
           newHeaders.append(key, value);
         });
         newHeaders.append('X-Bazaarvoice-Cached-Time', Date.now())
         // Get response text to calculate its size
-        clonedResponse.text().then(text => {
+        sizeCheck.text().then(text => {
         // Calculate size of response text in bytes
           const sizeInBytes = new Blob([text]).size;
 
@@ -166,6 +167,10 @@ module.exports = function BvFetch ({ shouldCache, cacheName, cacheLimit }) {
   // Check if response is available in cache
     const newPromise = this.fetchFromCache(cacheKey)
       .then((cachedResponse) => {
+        if (!cachedResponse) {
+          this.cachedUrls.delete(cacheKey)
+          return Promise.resolve(null);
+        }  
           // If response found in cache, return it
         if (cachedResponse) {
           return cachedResponse;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bv-ui-core",
-  "version": "2.9.2",
+  "version": "2.9.4",
   "license": "Apache 2.0",
   "description": "Bazaarvoice UI-related JavaScript",
   "repository": {

package/test/unit/bvFetch/index.spec.js

@@ -140,16 +140,17 @@ describe('BvFetch', function () {
     bvFetchInstance.bvFetchFunc(url, options)
     .then(response => {
       // Check if response is fetched from network
-      expect(response).to.not.be.null;
-      console.log(response.body)
+      setTimeout(() => { 
+        expect(response).to.not.be.null;
+        console.log(response.body)
 
       // Check if caches.match was called
-      expect(cacheStub.calledOnce).to.be.false;
+        expect(cacheStub.calledOnce).to.be.false;
 
       // Check if response is not cached
-      const cachedResponse = cacheStorage.get(url);
-      expect(cachedResponse).to.be.undefined;
-
+        const cachedResponse = cacheStorage.get(url);
+        expect(cachedResponse).to.be.undefined; 
+      }, 500)
       done();
     })
     .catch(done);