bv-ui-core 2.9.11 → 2.9.13

package/lib/bvFetch/index.js

@@ -168,6 +168,8 @@ module.exports = function BvFetch ({ shouldCache, cacheName, cacheLimit, exclude
       if (typeof this.shouldCache === 'function') {
         canBeCached = this.shouldCache(json);
       }
+    }).catch(() => {
+      canBeCached = false;  
     }).then(() => {
       if (canBeCached) {
         const clonedResponse = response.clone();
@@ -378,4 +380,4 @@ module.exports = function BvFetch ({ shouldCache, cacheName, cacheLimit, exclude
 
   this.debounceCleanupExpiredCache = debounce(this.manageCache, 8000);
   
-}
+}

package/lib/global/index.js

@@ -18,7 +18,7 @@ var getGlobal = function () {
     windows object during transpilation with __esModule being set. Below code would support
     global import in all bundle use cases
   */
-  if (globalObj && globalObj.__esModule) {
+  if (globalObj && globalObj.__esModule && typeof window !== 'undefined' && globalObj !== window) {
     const proxyGlobal = new Proxy(globalObj, {
       get: function (target, prop) {
         if (prop === 'default') {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bv-ui-core",
-  "version": "2.9.11",
+  "version": "2.9.13",
   "license": "Apache 2.0",
   "description": "Bazaarvoice UI-related JavaScript",
   "repository": {

package/test/unit/bvFetch/index.spec.js

@@ -168,6 +168,26 @@ describe('BvFetch', function () {
     .catch(done);
   });
 
+  it('should handle a 204 response without a JSON parse error', function (done) {
+    const cacheKey = bvFetchInstance.generateCacheKey('https://example.com/empty', {});
+    const shouldCache = sinon.spy();
+    const response = new Response(null, {
+      status: 204,
+      headers: {
+        'Cache-Control': 'max-age=3600'
+      }
+    });
+
+    bvFetchInstance.shouldCache = shouldCache;
+    expect(() => bvFetchInstance.cacheData(response, cacheKey)).to.not.throw();
+
+    setTimeout(() => {
+      expect(shouldCache.called).to.be.false;
+      expect(cacheStorage.get(cacheKey)).to.be.undefined;
+      done();
+    }, 0);
+  });
+
   it('should delete cache when size is greater than 10 MB', function (done) {
     // Mock cache entries exceeding 10 MB
     const mockCacheEntries = [

package/test/unit/global/index.spec.js

@@ -24,4 +24,23 @@ describe('lib/global', function () {
     }
   });
 
+  it('should not wrap window in a Proxy when globalObj is window even if __esModule is set', function () {
+    if (typeof window !== 'undefined') {
+      window.__esModule = true;
+      var result = require('../../../lib/global');
+      // When globalObj === window, the proxy branch should be skipped,
+      // so the result should be strictly equal to window.
+      expect(result).to.equal(window);
+      delete window.__esModule;
+    }
+  });
+
+  it('should return the global object directly when __esModule is not set', function () {
+    if (typeof window !== 'undefined') {
+      delete window.__esModule;
+      var result = require('../../../lib/global');
+      expect(result).to.equal(window);
+    }
+  });
+
 });