bunqueue 2.8.12 → 2.8.13

package/dist/client/worker/processor.js

@@ -6,7 +6,7 @@ import { createPublicJob } from '../types';
 import { getSharedManager } from '../manager';
 import { UnrecoverableError } from '../errors';
 import { DelayedError } from '../errors';
-import { createProgressHandler, createLogHandler, createGetStateHandler, createGetChildrenValuesHandler, createGetFailedChildrenValuesHandler, createGetIgnoredChildrenFailuresHandler, createRemoveChildDependencyHandler, createRemoveUnprocessedChildrenHandler, createMoveToFailedHandler, createMoveToCompletedHandler, createRemoveHandler, createRetryHandler, createUpdateDataHandler, createPromoteHandler, createChangeDelayHandler, createChangePriorityHandler, createExtendLockHandler, createClearLogsHandler, createMoveToWaitHandler, createMoveToDelayedHandler, createMoveToWaitingChildrenHandler, createWaitUntilFinishedHandler, createDiscardHandler, createGetDependenciesHandler, createGetDependenciesCountHandler, createRemoveDeduplicationKeyHandler, } from './processorHandlers';
+import { createProgressHandler, createLogHandler, createGetStateHandler, createGetChildrenValuesHandler, createGetFailedChildrenValuesHandler, createGetIgnoredChildrenFailuresHandler, createRemoveChildDependencyHandler, createRemoveUnprocessedChildrenHandler, createMoveToFailedHandler, createMoveToCompletedHandler, createRemoveHandler, createRetryHandler, createUpdateDataHandler, createPromoteHandler, createChangeDelayHandler, createChangePriorityHandler, createExtendLockHandler, createClearLogsHandler, createMoveToWaitHandler, createMoveToDelayedHandler, createMoveToWaitingChildrenHandler, createWaitUntilFinishedHandler, createDiscardHandler, createGetDependenciesHandler, createGetDependenciesCountHandler, createRemoveDeduplicationKeyHandler, computeStackLines, } from './processorHandlers';
 /**
  * Process a single job
  */
@@ -63,7 +63,7 @@ export async function processJob(internalJob, config) {
     try {
         const result = await processor(job);
         // Issue #82: If moveToFailed/moveToCompleted was called, skip auto-ACK
-        if (handleManualMove(manualMove, job, config))
+        if (handleManualMove(manualMove, job, config, internalJob))
             return;
         // Normal path: auto-ACK
         try {
@@ -94,16 +94,23 @@ export async function processJob(internalJob, config) {
     }
     catch (error) {
         // Issue #82: If moveToFailed was already called, skip normal failure handling
-        if (handleManualMove(manualMove, job, config))
+        if (handleManualMove(manualMove, job, config, internalJob))
             return;
         await handleJobFailure(internalJob, error, config, { job, jobIdStr, token });
     }
 }
 /** Issue #82: Handle explicit moveToFailed/moveToCompleted called inside processor */
-function handleManualMove(manualMove, job, config) {
+function handleManualMove(manualMove, job, config, internalJob) {
     if (manualMove.result?.type === 'failed') {
         const err = manualMove.result.error ?? new Error('Job manually moved to failed');
         job.failedReason = err.message;
+        // Bug #74 follow-up: populate stacktrace on the local `failed` event for the
+        // explicit moveToFailed() path too, mirroring handleJobFailure. The stack is
+        // persisted server-side by createMoveToFailedHandler's FAIL/manager.fail call.
+        if (err.stack) {
+            const { stackLines } = computeStackLines(err);
+            job.stacktrace = stackLines.slice(0, internalJob.stackTraceLimit);
+        }
         config.onOutcome?.(false);
         config.emitter.emit('failed', job, err);
         return true;
@@ -160,13 +167,7 @@ async function handleJobFailure(internalJob, error, config, context) {
     // Bug #74: stack lines computed BEFORE the send so the server can persist
     // them. The wire copy is capped at 50 lines as a bandwidth guard; the
     // authoritative cap (job.stackTraceLimit) is applied server-side in failJob.
-    const stackLines = err.stack
-        ? err.stack
-            .split('\n')
-            .map((l) => l.trim())
-            .filter(Boolean)
-        : [];
-    const wireStack = stackLines.length > 0 ? stackLines.slice(0, 50) : undefined;
+    const { stackLines, wireStack } = computeStackLines(err);
     try {
         if (embedded) {
             const manager = getSharedManager();

package/dist/client/worker/processorHandlers.d.ts

@@ -19,6 +19,17 @@ export declare function createGetFailedChildrenValuesHandler(embedded: boolean,
 export declare function createGetIgnoredChildrenFailuresHandler(embedded: boolean, tcp: TcpConnection | null): (id: string) => Promise<Record<string, string>>;
 export declare function createRemoveChildDependencyHandler(embedded: boolean, tcp: TcpConnection | null): (id: string) => Promise<boolean>;
 export declare function createRemoveUnprocessedChildrenHandler(embedded: boolean, tcp: TcpConnection | null): (id: string) => Promise<void>;
+/**
+ * Bug #74: split an Error's stack into trimmed, non-empty lines.
+ * `wireStack` is the bandwidth-capped copy sent to the server (50 lines); the
+ * authoritative cap (job.stackTraceLimit) is applied server-side in failJob.
+ * Shared by the natural-throw path (handleJobFailure) and the explicit
+ * moveToFailed() path so both persist the stack identically.
+ */
+export declare function computeStackLines(err: Error): {
+    stackLines: string[];
+    wireStack: string[] | undefined;
+};
 /** Issue #82: Create moveToFailed handler for use inside processor */
 export declare function createMoveToFailedHandler(embedded: boolean, tcp: TcpConnection | null, internalJob: InternalJob, token: string | null | undefined, onCalled: (error: Error) => void): (id: string, error: Error, _lockToken?: string) => Promise<void>;
 /** Issue #82: Create moveToCompleted handler for use inside processor */

package/dist/client/worker/processorHandlers.js

@@ -102,18 +102,40 @@ export function createRemoveUnprocessedChildrenHandler(embedded, tcp) {
         await tcp.send({ cmd: 'RemoveUnprocessedChildren', id });
     };
 }
+/**
+ * Bug #74: split an Error's stack into trimmed, non-empty lines.
+ * `wireStack` is the bandwidth-capped copy sent to the server (50 lines); the
+ * authoritative cap (job.stackTraceLimit) is applied server-side in failJob.
+ * Shared by the natural-throw path (handleJobFailure) and the explicit
+ * moveToFailed() path so both persist the stack identically.
+ */
+export function computeStackLines(err) {
+    const stackLines = err.stack
+        ? err.stack
+            .split('\n')
+            .map((l) => l.trim())
+            .filter(Boolean)
+        : [];
+    const wireStack = stackLines.length > 0 ? stackLines.slice(0, 50) : undefined;
+    return { stackLines, wireStack };
+}
 /** Issue #82: Create moveToFailed handler for use inside processor */
 export function createMoveToFailedHandler(embedded, tcp, internalJob, token, onCalled) {
     return async (_id, error, _lockToken) => {
+        // Bug #74 follow-up: carry the stack on explicit moveToFailed() too. The
+        // natural-throw path already does; @arthurvanl's repro showed the manual
+        // path lost it. Compute before the send so the server can persist it.
+        const { wireStack } = computeStackLines(error);
         if (embedded) {
             const manager = getSharedManager();
-            await manager.fail(internalJob.id, error.message, token ?? undefined);
+            await manager.fail(internalJob.id, error.message, token ?? undefined, undefined, wireStack);
         }
         else if (tcp) {
             await tcp.send({
                 cmd: 'FAIL',
                 id: internalJob.id,
                 error: error.message,
+                ...(wireStack ? { stack: wireStack } : {}),
                 ...(token ? { token } : {}),
             });
         }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bunqueue",
-  "version": "2.8.12",
+  "version": "2.8.13",
   "description": "High-performance job queue for Bun & AI agents. SQLite persistence, cron scheduling, priorities, retries, DLQ, webhooks, native MCP server. Zero external dependencies.",
   "type": "module",
   "main": "dist/main.js",