bunite-core 0.14.0 → 0.16.0

package/src/native/win/native_host_ffi.cpp

@@ -11,16 +11,20 @@
 //   (verified empirically on Win 11 / CEF 119+).
 // screenshot: PrintWindow PW_RENDERFULLCONTENT misses hardware-composited
 //   surfaces (returns all-black). Page.captureScreenshot is compositor-aware.
+#include <algorithm>
+#include <array>
 #include <atomic>
 #include <functional>
+#include <memory>
 #include <mutex>
 #include <unordered_map>
+#include <vector>
 
 
 using bunite_win::runOnUiThreadSync;
 using bunite_win::runOnCefUiThreadSync;
 
-static constexpr int32_t BUNITE_ABI_VERSION = 9;
+static constexpr int32_t BUNITE_ABI_VERSION = 11;
 
 namespace {
 
@@ -45,6 +49,48 @@ public:
     if (result && result_size) r.assign(static_cast<const char*>(result), result_size);
     cb(success, std::move(r));
   }
+  void OnDevToolsEvent(CefRefPtr<CefBrowser> browser,
+                       const CefString& method,
+                       const void* params,
+                       size_t params_size) override {
+    std::string m = method.ToString();
+    if (m != "Target.attachedToTarget" && m != "Target.detachedFromTarget") return;
+    std::string p;
+    if (params && params_size) p.assign(static_cast<const char*>(params), params_size);
+    CefRefPtr<CefValue> val = CefParseJSON(p, JSON_PARSER_RFC);
+    if (!val || val->GetType() != VTYPE_DICTIONARY) return;
+    auto d = val->GetDictionary();
+    uint32_t view_id = 0;
+    {
+      std::lock_guard<std::mutex> lk(g_runtime.object_mutex);
+      auto it = g_runtime.browser_to_view_id.find(browser->GetIdentifier());
+      if (it == g_runtime.browser_to_view_id.end()) return;
+      view_id = it->second;
+    }
+    auto* view = bunite_win::getViewHostById(view_id);
+    if (!view) return;
+    if (m == "Target.attachedToTarget") {
+      std::string session_id = d->HasKey("sessionId") ? d->GetString("sessionId").ToString() : "";
+      if (session_id.empty()) return;
+      auto info = d->HasKey("targetInfo") ? d->GetDictionary("targetInfo") : nullptr;
+      if (!info) return;
+      std::string type = info->HasKey("type") ? info->GetString("type").ToString() : "";
+      std::string target_id = info->HasKey("targetId") ? info->GetString("targetId").ToString() : "";
+      // For iframe targets in modern Chromium, targetId is the devtools frame
+      // token — identical to Page.FrameId. Spike-verified per OOPIF plan.
+      if (type != "iframe" || target_id.empty()) return;
+      std::lock_guard<std::mutex> lk(view->oopif_sessions_mutex);
+      view->oopif_sessions[target_id] = session_id;
+    } else {
+      std::string session_id = d->HasKey("sessionId") ? d->GetString("sessionId").ToString() : "";
+      if (session_id.empty()) return;
+      std::lock_guard<std::mutex> lk(view->oopif_sessions_mutex);
+      for (auto it = view->oopif_sessions.begin(); it != view->oopif_sessions.end(); ) {
+        if (it->second == session_id) it = view->oopif_sessions.erase(it);
+        else ++it;
+      }
+    }
+  }
   void OnDevToolsAgentDetached(CefRefPtr<CefBrowser>) override {
     // Pending method results are dropped by CEF on detach (browser crash,
     // process restart). Fire all callbacks with a failure result to prevent
@@ -64,6 +110,29 @@ CefRefPtr<CefDevToolsMessageObserver> getDevToolsObserver() {
   return obs;
 }
 
+// Raw-id space for SendDevToolsMessage (sessionId-routed calls). High range
+// avoids collision with CEF's internal counter used by ExecuteDevToolsMethod.
+std::atomic<int> g_raw_cdp_id_counter{0x40000000};
+int nextRawCdpId() { return ++g_raw_cdp_id_counter; }
+
+void cefSendRaw(ViewHost* v, const std::string& message, int id_for_cb,
+                std::function<void(bool, std::string)> cb) {
+  if (!v || !v->browser) { if (cb) cb(false, "{\"error\":\"view not ready\"}"); return; }
+  if (cb) {
+    std::lock_guard<std::mutex> lk(g_cdp_cb_mutex);
+    g_cdp_callbacks[id_for_cb] = std::move(cb);
+  }
+  if (!v->browser->GetHost()->SendDevToolsMessage(message.data(), message.size())) {
+    std::function<void(bool, std::string)> orphan;
+    {
+      std::lock_guard<std::mutex> lk(g_cdp_cb_mutex);
+      auto it = g_cdp_callbacks.find(id_for_cb);
+      if (it != g_cdp_callbacks.end()) { orphan = std::move(it->second); g_cdp_callbacks.erase(it); }
+    }
+    if (orphan) orphan(false, "{\"error\":\"SendDevToolsMessage failed\"}");
+  }
+}
+
 void cefCdpCall(ViewHost* v, const std::string& method, const std::string& params_json,
                 std::function<void(bool, std::string)> cb = nullptr) {
   if (!v || !v->browser) {
@@ -195,6 +264,7 @@ extern "C" BUNITE_EXPORT bool bunite_init(
   bool popup_blocking,
   const char* engine_config_json
 ) {
+  buniteApplyEnvLogLevel();
   reapChildrenOnExit();
   {
     std::lock_guard<std::mutex> lock(g_runtime.lifecycle_mutex);
@@ -1189,7 +1259,79 @@ extern "C" BUNITE_EXPORT uint32_t bunite_view_capabilities(uint32_t view_id) {
          BUNITE_CAP_NATIVE_INPUT_TRUSTED |
          BUNITE_CAP_CLICK | BUNITE_CAP_TYPE | BUNITE_CAP_PRESS | BUNITE_CAP_SCROLL |
          BUNITE_CAP_MOUSE | BUNITE_CAP_DIALOGS | BUNITE_CAP_CONSOLE |
-         BUNITE_CAP_SCREENSHOT | BUNITE_CAP_FORMAT_PNG | BUNITE_CAP_FORMAT_JPEG;
+         BUNITE_CAP_SCREENSHOT | BUNITE_CAP_FORMAT_PNG | BUNITE_CAP_FORMAT_JPEG |
+         BUNITE_CAP_AX | BUNITE_CAP_BOUNDING_RECT | BUNITE_CAP_FRAMES |
+         BUNITE_CAP_DOWNLOADS | BUNITE_CAP_POPUPS |
+         BUNITE_CAP_RESOLVE_AND_CLICK;
+}
+
+extern "C" BUNITE_EXPORT void bunite_view_set_download_policy(uint32_t view_id, int32_t policy, const char* download_dir) {
+  bunite_win::postCefUiTask([view_id, policy, dir = std::string(download_dir ? download_dir : "")]() {
+    auto* view = bunite_win::getViewHostById(view_id);
+    if (!view) return;
+    int32_t p = policy;
+    if (p < 0 || p > 2) p = 2;
+    view->download_policy.store(p);
+    view->download_dir = dir;
+  });
+}
+
+namespace bunite_win {
+
+void applyPopupAccept(ViewHost* view, uint32_t host_window_id, double x, double y, double w, double h) {
+  if (!view || !view->browser) return;
+  auto* host = getWindowHostById(host_window_id);
+  if (!host || !host->hwnd) return;
+  view->window = host;
+  view->is_popup_pending = false;
+  host->views.push_back(view);
+  HWND browser_hwnd = view->browser->GetHost()->GetWindowHandle();
+  if (browser_hwnd) {
+    SetParent(browser_hwnd, host->hwnd);
+    SetWindowPos(browser_hwnd, HWND_TOP,
+      static_cast<int>(x), static_cast<int>(y),
+      static_cast<int>(w), static_cast<int>(h),
+      SWP_SHOWWINDOW | SWP_NOACTIVATE);
+    view->bounds = RECT{
+      static_cast<LONG>(x), static_cast<LONG>(y),
+      static_cast<LONG>(x + w), static_cast<LONG>(y + h)
+    };
+  }
+  // Re-emit view-ready so the TS-side BrowserView.adopt resolves its
+  // `_readyPromise` (the original view-ready from OnAfterCreated fired before
+  // the TS resolver was registered).
+  emitWebviewEvent(view->id, "view-ready", "");
+}
+
+}  // namespace bunite_win
+
+extern "C" BUNITE_EXPORT void bunite_view_popup_accept(uint32_t new_view_id, uint32_t host_window_id,
+                                                       double x, double y, double w, double h) {
+  bunite_win::postCefUiTask([new_view_id, host_window_id, x, y, w, h]() {
+    auto* view = bunite_win::getViewHostById(new_view_id);
+    if (!view) return;
+    if (!view->browser) {
+      // OnAfterCreated hasn't fired yet; stash the accept and apply when it does.
+      view->pending_popup_accept = ViewHost::PendingPopupAccept{host_window_id, x, y, w, h};
+      return;
+    }
+    bunite_win::applyPopupAccept(view, host_window_id, x, y, w, h);
+  });
+}
+
+extern "C" BUNITE_EXPORT void bunite_view_popup_dismiss(uint32_t new_view_id) {
+  bunite_win::postCefUiTask([new_view_id]() {
+    auto* view = bunite_win::getViewHostById(new_view_id);
+    if (!view) return;
+    if (!view->is_popup_pending && view->window) return;  // already adopted — caller responsibility, ignore.
+    if (view->browser) {
+      view->closing.store(true);
+      view->browser->GetHost()->CloseBrowser(true);
+    } else {
+      // Browser not yet created — let OnAfterCreated handle dismissal.
+      view->popup_dismiss_requested = true;
+    }
+  });
 }
 
 extern "C" BUNITE_EXPORT void bunite_view_screenshot(uint32_t view_id, uint32_t request_id,
@@ -1234,6 +1376,680 @@ extern "C" BUNITE_EXPORT void bunite_view_screenshot(uint32_t view_id, uint32_t
   });
 }
 
+static void emitAxError(uint32_t view_id, uint32_t request_id, const char* code, const std::string& message) {
+  std::string esc; esc.reserve(message.size());
+  for (char c : message) {
+    if (c == '"' || c == '\\') { esc.push_back('\\'); esc.push_back(c); }
+    else if (c == '\n') esc += "\\n";
+    else if (c == '\r') esc += "\\r";
+    else if (c == '\t') esc += "\\t";
+    else esc.push_back(c);
+  }
+  std::string payload = "{\"requestId\":" + std::to_string(request_id) +
+                        ",\"ok\":false,\"code\":\"" + code +
+                        "\",\"message\":\"" + esc + "\"}";
+  bunite_win::emitWebviewEvent(view_id, "accessibility-result", payload);
+}
+
+extern "C" BUNITE_EXPORT void bunite_view_accessibility_snapshot(uint32_t view_id, uint32_t request_id,
+                                                                  int32_t /*interesting_only*/) {
+  // CDP `Accessibility.getFullAXTree` takes `depth`/`frameId` only; the
+  // interesting-only filter is applied TS-side on the flat node list.
+  bunite_win::postCefUiTask([view_id, request_id]() {
+    auto* view = bunite_win::getViewHostById(view_id);
+    if (!view) { emitAxError(view_id, request_id, "not_supported", "view not ready"); return; }
+    cefCdpCall(view, "Accessibility.getFullAXTree", "{}",
+        [view_id, request_id](bool ok, std::string result) {
+          if (!ok) { emitAxError(view_id, request_id, "runtime_error", "getFullAXTree failed: " + result); return; }
+          std::string payload = "{\"requestId\":" + std::to_string(request_id) +
+                                ",\"ok\":true,\"tree\":" + result + "}";
+          bunite_win::emitWebviewEvent(view_id, "accessibility-result", payload);
+        });
+  });
+}
+
+static void emitListFramesError(uint32_t view_id, uint32_t request_id, const char* code, const std::string& message) {
+  std::string esc; esc.reserve(message.size());
+  for (char c : message) {
+    if (c == '"' || c == '\\') { esc.push_back('\\'); esc.push_back(c); }
+    else esc.push_back(c);
+  }
+  std::string payload = "{\"requestId\":" + std::to_string(request_id) +
+                        ",\"ok\":false,\"code\":\"" + code +
+                        "\",\"message\":\"" + esc + "\"}";
+  bunite_win::emitWebviewEvent(view_id, "list-frames-result", payload);
+}
+
+extern "C" BUNITE_EXPORT void bunite_view_list_frames(uint32_t view_id, uint32_t request_id) {
+  bunite_win::postCefUiTask([view_id, request_id]() {
+    auto* view = bunite_win::getViewHostById(view_id);
+    if (!view) { emitListFramesError(view_id, request_id, "not_supported", "view not ready"); return; }
+    cefCdpCall(view, "Page.getFrameTree", "{}",
+        [view_id, request_id](bool ok, std::string result) {
+          if (!ok) { emitListFramesError(view_id, request_id, "runtime_error", "getFrameTree failed: " + result); return; }
+          // Raw CDP `{frameTree:{frame,childFrames}}` — TS flattens.
+          std::string payload = "{\"requestId\":" + std::to_string(request_id) +
+                                ",\"ok\":true,\"raw\":" + result + "}";
+          bunite_win::emitWebviewEvent(view_id, "list-frames-result", payload);
+        });
+  });
+}
+
+extern "C" BUNITE_EXPORT void bunite_view_evaluate_in_frame(uint32_t view_id, uint32_t request_id,
+                                                              const char* script_c, const char* frame_id_c) {
+  std::string script = script_c ? script_c : "";
+  std::string frameId = frame_id_c ? frame_id_c : "";
+  if (frameId.empty()) {
+    bunite_view_evaluate(view_id, request_id, script_c);
+    return;
+  }
+  bunite_win::postCefUiTask([view_id, request_id, script, frameId]() {
+    auto* view = bunite_win::getViewHostById(view_id);
+    if (!view) {
+      std::string payload = "{\"requestId\":" + std::to_string(request_id) +
+                            ",\"ok\":false,\"code\":\"not_supported\",\"message\":\"view not ready\"}";
+      bunite_win::emitWebviewEvent(view_id, "evaluate-result", payload);
+      return;
+    }
+    // Step 1: create an isolated world in the target frame.
+    std::string isoParams = "{\"frameId\":\"" + bunite_win::escapeJsonString(frameId) + "\",\"worldName\":\"bunite-eval\"}";
+    cefCdpCall(view, "Page.createIsolatedWorld", isoParams,
+        [view_id, request_id, script](bool ok, std::string isoResult) {
+          if (!ok) {
+            std::string payload = "{\"requestId\":" + std::to_string(request_id) +
+                                  ",\"ok\":false,\"code\":\"runtime_error\","
+                                  "\"message\":\"createIsolatedWorld failed\"}";
+            bunite_win::emitWebviewEvent(view_id, "evaluate-result", payload);
+            return;
+          }
+          CefRefPtr<CefValue> val = CefParseJSON(isoResult, JSON_PARSER_RFC);
+          if (!val || val->GetType() != VTYPE_DICTIONARY) {
+            std::string payload = "{\"requestId\":" + std::to_string(request_id) +
+                                  ",\"ok\":false,\"code\":\"runtime_error\","
+                                  "\"message\":\"createIsolatedWorld malformed\"}";
+            bunite_win::emitWebviewEvent(view_id, "evaluate-result", payload);
+            return;
+          }
+          int contextId = val->GetDictionary()->GetInt("executionContextId");
+          // Re-lookup view — async gap may have destroyed it.
+          auto* view2 = bunite_win::getViewHostById(view_id);
+          if (!view2) {
+            std::string payload = "{\"requestId\":" + std::to_string(request_id) +
+                                  ",\"ok\":false,\"code\":\"not_supported\","
+                                  "\"message\":\"view destroyed\"}";
+            bunite_win::emitWebviewEvent(view_id, "evaluate-result", payload);
+            return;
+          }
+          // Step 2: Runtime.evaluate in that context.
+          std::string escScript; escScript.reserve(script.size());
+          for (char c : script) {
+            if (c == '"' || c == '\\') { escScript.push_back('\\'); escScript.push_back(c); }
+            else if (c == '\n') escScript += "\\n";
+            else if (c == '\r') escScript += "\\r";
+            else if (c == '\t') escScript += "\\t";
+            else escScript.push_back(c);
+          }
+          std::string evalParams = "{\"expression\":\"" + escScript +
+                                   "\",\"contextId\":" + std::to_string(contextId) +
+                                   ",\"returnByValue\":true,\"awaitPromise\":true}";
+          cefCdpCall(view2, "Runtime.evaluate", evalParams,
+              [view_id, request_id](bool ok2, std::string evalResult) {
+                if (!ok2) {
+                  std::string payload = "{\"requestId\":" + std::to_string(request_id) +
+                                        ",\"ok\":false,\"code\":\"runtime_error\","
+                                        "\"message\":\"Runtime.evaluate failed\"}";
+                  bunite_win::emitWebviewEvent(view_id, "evaluate-result", payload);
+                  return;
+                }
+                CefRefPtr<CefValue> ev = CefParseJSON(evalResult, JSON_PARSER_RFC);
+                if (!ev || ev->GetType() != VTYPE_DICTIONARY) {
+                  std::string payload = "{\"requestId\":" + std::to_string(request_id) +
+                                        ",\"ok\":false,\"code\":\"runtime_error\","
+                                        "\"message\":\"Runtime.evaluate malformed\"}";
+                  bunite_win::emitWebviewEvent(view_id, "evaluate-result", payload);
+                  return;
+                }
+                CefRefPtr<CefDictionaryValue> d = ev->GetDictionary();
+                if (d->HasKey("exceptionDetails")) {
+                  CefRefPtr<CefDictionaryValue> ex = d->GetDictionary("exceptionDetails");
+                  std::string msg = ex && ex->HasKey("text") ? ex->GetString("text").ToString() : "runtime exception";
+                  std::string escMsg; escMsg.reserve(msg.size());
+                  for (char c : msg) {
+                    if (c == '"' || c == '\\') { escMsg.push_back('\\'); escMsg.push_back(c); }
+                    else escMsg.push_back(c);
+                  }
+                  std::string payload = "{\"requestId\":" + std::to_string(request_id) +
+                                        ",\"ok\":false,\"code\":\"runtime_error\","
+                                        "\"message\":\"" + escMsg + "\"}";
+                  bunite_win::emitWebviewEvent(view_id, "evaluate-result", payload);
+                  return;
+                }
+                // result.value (JSON-serialized into "value") -> stringify.
+                CefRefPtr<CefDictionaryValue> result = d->GetDictionary("result");
+                std::string valueJson = "null";
+                if (result && result->HasKey("value")) {
+                  CefRefPtr<CefValue> v = result->GetValue("value");
+                  if (v) valueJson = CefWriteJSON(v, JSON_WRITER_DEFAULT);
+                }
+                // The host expects "value" to be a JSON STRING (it re-parses).
+                std::string escVal; escVal.reserve(valueJson.size());
+                for (char c : valueJson) {
+                  if (c == '"' || c == '\\') { escVal.push_back('\\'); escVal.push_back(c); }
+                  else if (c == '\n') escVal += "\\n";
+                  else if (c == '\r') escVal += "\\r";
+                  else if (c == '\t') escVal += "\\t";
+                  else escVal.push_back(c);
+                }
+                std::string payload = "{\"requestId\":" + std::to_string(request_id) +
+                                      ",\"ok\":true,\"value\":\"" + escVal + "\"}";
+                bunite_win::emitWebviewEvent(view_id, "evaluate-result", payload);
+              });
+        });
+  });
+}
+
+namespace {
+
+void emitResolveAndClickError(uint32_t view_id, uint32_t request_id, const char* code, const std::string& msg) {
+  std::string payload = "{\"requestId\":" + std::to_string(request_id) +
+                        ",\"ok\":false,\"code\":\"" + code + "\","
+                        "\"message\":\"" + bunite_win::escapeJsonString(msg) + "\"}";
+  bunite_win::emitWebviewEvent(view_id, "resolve-and-click-result", payload);
+}
+
+const char* cdpButtonName(int32_t b) {
+  switch (b) { case 1: return "middle"; case 2: return "right"; default: return "left"; }
+}
+
+std::string escapeForJsString(const std::string& s) {
+  std::string out; out.reserve(s.size() + 2);
+  for (char c : s) {
+    if (c == '"' || c == '\\') { out.push_back('\\'); out.push_back(c); }
+    else if (c == '\n') out += "\\n";
+    else if (c == '\r') out += "\\r";
+    else if (c == '\t') out += "\\t";
+    else out.push_back(c);
+  }
+  return out;
+}
+
+std::string escapeForJsonString(const std::string& s) {
+  std::string out; out.reserve(s.size());
+  for (char c : s) {
+    if (c == '"' || c == '\\') { out.push_back('\\'); out.push_back(c); }
+    else if (c == '\n') out += "\\n";
+    else if (c == '\r') out += "\\r";
+    else if (c == '\t') out += "\\t";
+    else out.push_back(c);
+  }
+  return out;
+}
+
+std::string buildResolveScript(const std::string& selector) {
+  // Frame-local rect + innerWidth/innerHeight for bilinear mapping when the
+  // frame is transformed (rotate/scale). Main frame uses iw/ih harmlessly.
+  std::string sel_lit = "\"" + escapeForJsString(selector) + "\"";
+  return
+    "(function(){"
+      "var el=document.querySelector(" + sel_lit + ");"
+      "if(!el)return{ok:false,code:\"not_found\"};"
+      "el.scrollIntoView({block:\"nearest\",inline:\"nearest\",behavior:\"instant\"});"
+      "var r=el.getBoundingClientRect();"
+      "var vis=r.width>0&&r.height>0&&r.bottom>0&&r.right>0"
+      "&&r.top<innerHeight&&r.left<innerWidth;"
+      "if(!vis)return{ok:false,code:\"not_visible\"};"
+      "return{ok:true,x:r.x,y:r.y,w:r.width,h:r.height,"
+      "cx:r.x+r.width/2,cy:r.y+r.height/2,"
+      "iw:innerWidth,ih:innerHeight};"
+    "})()";
+}
+
+// Extract the user-returned value dict from a Runtime.evaluate response.
+// Complex (dict/list) CefValue handles reference parent storage — round-trip
+// through JSON so the returned dict has independent lifetime.
+CefRefPtr<CefDictionaryValue> parseEvaluateValue(
+    const std::string& evalResult,
+    std::function<void(const char*, const std::string&)> onErr) {
+  CefRefPtr<CefValue> ev = CefParseJSON(evalResult, JSON_PARSER_RFC);
+  if (!ev || ev->GetType() != VTYPE_DICTIONARY) { onErr("runtime_error", "Runtime.evaluate malformed"); return nullptr; }
+  CefRefPtr<CefDictionaryValue> d = ev->GetDictionary();
+  if (d->HasKey("exceptionDetails")) {
+    CefRefPtr<CefDictionaryValue> ex = d->GetDictionary("exceptionDetails");
+    std::string msg = ex && ex->HasKey("text") ? ex->GetString("text").ToString() : "runtime exception";
+    onErr("runtime_error", msg);
+    return nullptr;
+  }
+  CefRefPtr<CefDictionaryValue> result = d->GetDictionary("result");
+  if (!result || !result->HasKey("value")) { onErr("runtime_error", "evaluate returned no value"); return nullptr; }
+  CefRefPtr<CefValue> v = result->GetValue("value");
+  if (!v || v->GetType() != VTYPE_DICTIONARY) { onErr("runtime_error", "evaluate returned non-object"); return nullptr; }
+  std::string userJson = CefWriteJSON(v, JSON_WRITER_DEFAULT);
+  CefRefPtr<CefValue> independent = CefParseJSON(userJson, JSON_PARSER_RFC);
+  if (!independent || independent->GetType() != VTYPE_DICTIONARY) {
+    onErr("runtime_error", "evaluate value re-parse failed"); return nullptr;
+  }
+  return independent->GetDictionary();
+}
+
+void dispatchCdpClick(ViewHost* view, double cx, double cy,
+                       int32_t button, int32_t click_count, uint32_t modifiers) {
+  if (click_count < 1) click_count = 1;
+  const char* btn = cdpButtonName(button);
+  for (int i = 1; i <= click_count; ++i) {
+    std::string base = "\"x\":" + std::to_string(cx) + ",\"y\":" + std::to_string(cy) +
+                       ",\"button\":\"" + btn + "\",\"clickCount\":" + std::to_string(i) +
+                       ",\"modifiers\":" + std::to_string(modifiers);
+    cefCdpCall(view, "Input.dispatchMouseEvent", "{\"type\":\"mousePressed\"," + base + "}");
+    cefCdpCall(view, "Input.dispatchMouseEvent", "{\"type\":\"mouseReleased\"," + base + "}");
+  }
+}
+
+}  // namespace
+
+namespace {
+
+// Dispatch native click at page coords + emit success envelope.
+void finishResolveAndClick(uint32_t view_id, uint32_t request_id, double x, double y,
+                            double w, double h, double cx, double cy,
+                            int32_t button, int32_t click_count, uint32_t modifiers) {
+  auto* v = bunite_win::getViewHostById(view_id);
+  if (!v || !v->browser) { emitResolveAndClickError(view_id, request_id, "runtime_error", "view destroyed"); return; }
+  dispatchCdpClick(v, cx, cy, button, click_count, modifiers);
+  // CEF CDP `Input.dispatchMouseEvent` produces DOM events with isTrusted=true
+  // (empirical — `e.isTrusted` on page-side listener reports true).
+  std::string payload = "{\"requestId\":" + std::to_string(request_id) +
+                        ",\"ok\":true,\"rect\":{\"x\":" + std::to_string(x) +
+                        ",\"y\":" + std::to_string(y) +
+                        ",\"width\":" + std::to_string(w) +
+                        ",\"height\":" + std::to_string(h) + "},"
+                        "\"isTrustedEvent\":true}";
+  bunite_win::emitWebviewEvent(view_id, "resolve-and-click-result", payload);
+}
+
+struct FrameResolveOk { double x, y, w, h, cx, cy, iw, ih; };
+
+// CefDictionaryValue::GetDouble returns 0 for VTYPE_INT — JSON.stringify
+// serializes integer-valued numbers without `.0` so values like rect.height==35
+// re-parse as VTYPE_INT. Coerce here.
+double dictNumber(CefRefPtr<CefDictionaryValue> d, const char* key) {
+  if (!d || !d->HasKey(key)) return 0.0;
+  switch (d->GetType(key)) {
+    case VTYPE_INT:    return static_cast<double>(d->GetInt(key));
+    case VTYPE_DOUBLE: return d->GetDouble(key);
+    default: return 0.0;
+  }
+}
+
+// Parse a Runtime.evaluate response (either main-session or sessionId-routed)
+// and forward the script's frame-local fields to `onOk`. The script's failure
+// branch (`{ok:false,code:...}`) routes through `onErr`.
+void parseEvalAndContinue(uint32_t view_id, uint32_t request_id, bool ok, const std::string& evalResult,
+                           std::function<void(const FrameResolveOk&)> onOk) {
+  auto onErr = [view_id, request_id](const char* code, const std::string& msg) {
+    emitResolveAndClickError(view_id, request_id, code, msg);
+  };
+  if (!ok) {
+    BUNITE_INFO("cef/eval: Runtime.evaluate failed view=%u request=%u body=%.300s%s",
+                view_id, request_id, evalResult.c_str(),
+                evalResult.size() > 300 ? "..." : "");
+    onErr("runtime_error", "Runtime.evaluate failed"); return;
+  }
+  auto value = parseEvaluateValue(evalResult, onErr);
+  if (!value) return;
+  if (!value->HasKey("ok") || !value->GetBool("ok")) {
+    std::string code = value->HasKey("code") ? value->GetString("code").ToString() : "runtime_error";
+    onErr(code.c_str(), "");
+    return;
+  }
+  onOk(FrameResolveOk{
+      dictNumber(value, "x"),  dictNumber(value, "y"),
+      dictNumber(value, "w"),  dictNumber(value, "h"),
+      dictNumber(value, "cx"), dictNumber(value, "cy"),
+      dictNumber(value, "iw"), dictNumber(value, "ih"),
+  });
+}
+
+// Issue Runtime.evaluate inside the target frame — sessionId-routed (OOPIF) or
+// isolated-world via main session (same-renderer cross-origin or same-origin).
+void evalInFrame(uint32_t view_id, uint32_t request_id, const std::string& frameId,
+                  const std::string& escScript,
+                  std::function<void(const FrameResolveOk&)> onOk) {
+  auto* view = bunite_win::getViewHostById(view_id);
+  if (!view || !view->browser) { emitResolveAndClickError(view_id, request_id, "runtime_error", "view destroyed"); return; }
+  // Look up auto-attached OOPIF session.
+  std::string session_id;
+  {
+    std::lock_guard<std::mutex> lk(view->oopif_sessions_mutex);
+    auto it = view->oopif_sessions.find(frameId);
+    if (it != view->oopif_sessions.end()) session_id = it->second;
+  }
+  if (!session_id.empty()) {
+    int id = nextRawCdpId();
+    std::string msg = "{\"id\":" + std::to_string(id) +
+                      ",\"sessionId\":\"" + session_id +
+                      "\",\"method\":\"Runtime.evaluate\""
+                      ",\"params\":{\"expression\":\"" + escScript +
+                      "\",\"returnByValue\":true,\"awaitPromise\":true}}";
+    cefSendRaw(view, msg, id,
+        [view_id, request_id, onOk](bool ok, std::string r) {
+          parseEvalAndContinue(view_id, request_id, ok, r, onOk);
+        });
+    return;
+  }
+  // In-process: createIsolatedWorld + Runtime.evaluate via main session.
+  std::string isoParams = "{\"frameId\":\"" + bunite_win::escapeJsonString(frameId) + "\",\"worldName\":\"bunite-rac\"}";
+  cefCdpCall(view, "Page.createIsolatedWorld", isoParams,
+      [view_id, request_id, escScript, onOk](bool ok, std::string isoResult) {
+        if (!ok) { emitResolveAndClickError(view_id, request_id, "runtime_error", "createIsolatedWorld failed"); return; }
+        CefRefPtr<CefValue> val = CefParseJSON(isoResult, JSON_PARSER_RFC);
+        if (!val || val->GetType() != VTYPE_DICTIONARY) {
+          emitResolveAndClickError(view_id, request_id, "runtime_error", "createIsolatedWorld malformed"); return;
+        }
+        int contextId = val->GetDictionary()->GetInt("executionContextId");
+        auto* v2 = bunite_win::getViewHostById(view_id);
+        if (!v2) { emitResolveAndClickError(view_id, request_id, "runtime_error", "view destroyed"); return; }
+        std::string evalParams = "{\"expression\":\"" + escScript +
+                                 "\",\"contextId\":" + std::to_string(contextId) +
+                                 ",\"returnByValue\":true,\"awaitPromise\":true}";
+        cefCdpCall(v2, "Runtime.evaluate", evalParams,
+            [view_id, request_id, onOk](bool ok2, std::string r) {
+              parseEvalAndContinue(view_id, request_id, ok2, r, onOk);
+            });
+      });
+}
+
+// Bilinear: (fx, fy) ∈ [0, iw] × [0, ih] → page coord using clockwise quad
+// TL/TR/BR/BL. Handles axis-aligned, scaled, rotated, and skewed iframes.
+inline void bilinearMap(const std::array<double, 8>& q, double iw, double ih,
+                         double fx, double fy, double& px, double& py) {
+  const double u = (iw > 0) ? (fx / iw) : 0.0;
+  const double v = (ih > 0) ? (fy / ih) : 0.0;
+  px = (1-u)*(1-v)*q[0] + u*(1-v)*q[2] + u*v*q[4] + (1-u)*v*q[6];
+  py = (1-u)*(1-v)*q[1] + u*(1-v)*q[3] + u*v*q[5] + (1-u)*v*q[7];
+}
+
+// Recursive frame path lookup in Page.getFrameTree response.
+// Returns [outermost frame id, ..., target_frame_id] including main; empty if
+// target not in tree.
+std::vector<std::string> findFramePath(CefRefPtr<CefDictionaryValue> node, const std::string& target) {
+  if (!node) return {};
+  CefRefPtr<CefDictionaryValue> frame = node->HasKey("frame") ? node->GetDictionary("frame") : nullptr;
+  if (!frame) return {};
+  std::string this_id = frame->GetString("id").ToString();
+  if (this_id == target) return {this_id};
+  CefRefPtr<CefListValue> children = node->HasKey("childFrames") ? node->GetList("childFrames") : nullptr;
+  if (!children) return {};
+  for (size_t i = 0; i < children->GetSize(); ++i) {
+    auto v = children->GetValue(i);
+    if (!v || v->GetType() != VTYPE_DICTIONARY) continue;
+    auto sub = findFramePath(v->GetDictionary(), target);
+    if (!sub.empty()) { sub.insert(sub.begin(), this_id); return sub; }
+  }
+  return {};
+}
+
+bool parseQuadFromBoxModel(const std::string& result, std::array<double, 8>& out) {
+  CefRefPtr<CefValue> bv = CefParseJSON(result, JSON_PARSER_RFC);
+  if (!bv || bv->GetType() != VTYPE_DICTIONARY) return false;
+  auto model = bv->GetDictionary()->HasKey("model") ? bv->GetDictionary()->GetDictionary("model") : nullptr;
+  if (!model) return false;
+  auto content = model->HasKey("content") ? model->GetList("content") : nullptr;
+  if (!content || content->GetSize() < 8) return false;
+  for (int i = 0; i < 8; ++i) {
+    // CDP serializes integer pixel positions without `.0`; coerce from INT.
+    switch (content->GetType(i)) {
+      case VTYPE_INT:    out[i] = static_cast<double>(content->GetInt(i)); break;
+      case VTYPE_DOUBLE: out[i] = content->GetDouble(i); break;
+      default: out[i] = 0.0;
+    }
+  }
+  return true;
+}
+
+// Eval a script on a specific session (OOPIF) or main session (empty session_id).
+// Result delivered as raw JSON of `Runtime.evaluate` response.
+void evalRaw(ViewHost* view, const std::string& session_id, const std::string& escScript,
+              std::function<void(bool, std::string)> cb) {
+  if (session_id.empty()) {
+    std::string params = "{\"expression\":\"" + escScript + "\",\"returnByValue\":true,\"awaitPromise\":true}";
+    cefCdpCall(view, "Runtime.evaluate", params, std::move(cb));
+    return;
+  }
+  int id = nextRawCdpId();
+  std::string msg = "{\"id\":" + std::to_string(id) +
+                    ",\"sessionId\":\"" + session_id +
+                    "\",\"method\":\"Runtime.evaluate\",\"params\":{\"expression\":\"" +
+                    escScript + "\",\"returnByValue\":true,\"awaitPromise\":true}}";
+  cefSendRaw(view, msg, id, std::move(cb));
+}
+
+// State threaded through chain-walk continuations.
+struct ChainState {
+  uint32_t view_id;
+  uint32_t request_id;
+  std::string targetFrameId;
+  std::string escScript;
+  int32_t button, click_count;
+  uint32_t modifiers;
+  // chain[0] = main frameId, chain[1..N-1] = outermost..target. N >= 2.
+  std::vector<std::string> chain;
+  // For each link i (parent = chain[i], child = chain[i+1]): quad in parent's coord system.
+  std::vector<std::array<double, 8>> link_quads;
+  // For chain[i] (i in [1..N-2]): innerWidth/innerHeight of that ancestor frame.
+  // Used when mapping FROM chain[i+1]'s coords up to chain[i]'s coords.
+  // Indexed by ancestor's chain position; chain[N-1] (target) iw/ih comes from
+  // the target eval, not stored here.
+  std::vector<std::pair<double, double>> ancestor_inner;
+};
+
+void composeAndDispatch(std::shared_ptr<ChainState> s, const FrameResolveOk& fr);
+void fetchTargetEval(std::shared_ptr<ChainState> s);
+void fetchAncestorInner(std::shared_ptr<ChainState> s, size_t i);
+void fetchLink(std::shared_ptr<ChainState> s, size_t link_idx);
+
+// Look up the session for an ancestor frame (chain[idx]). idx == 0 → main (empty).
+std::string sessionForChainIdx(uint32_t view_id, const std::vector<std::string>& chain, size_t idx) {
+  if (idx == 0) return {};
+  auto* view = bunite_win::getViewHostById(view_id);
+  if (!view) return {};
+  std::lock_guard<std::mutex> lk(view->oopif_sessions_mutex);
+  auto it = view->oopif_sessions.find(chain[idx]);
+  return (it != view->oopif_sessions.end()) ? it->second : std::string{};
+}
+
+void fetchLink(std::shared_ptr<ChainState> s, size_t link_idx) {
+  if (link_idx + 1 >= s->chain.size()) {
+    // All links collected. Move to ancestor inner sizes.
+    fetchAncestorInner(s, 1);
+    return;
+  }
+  const std::string parent_session = sessionForChainIdx(s->view_id, s->chain, link_idx);
+  const std::string& child_frameId = s->chain[link_idx + 1];
+  auto* view = bunite_win::getViewHostById(s->view_id);
+  if (!view) { emitResolveAndClickError(s->view_id, s->request_id, "runtime_error", "view destroyed"); return; }
+  // DOM.getFrameOwner on parent's session.
+  std::string ownerParams = "{\"frameId\":\"" + bunite_win::escapeJsonString(child_frameId) + "\"}";
+  auto onOwner = [s, link_idx, parent_session](bool ok, std::string r) {
+    if (!ok) { emitResolveAndClickError(s->view_id, s->request_id, "not_found", "getFrameOwner failed"); return; }
+    CefRefPtr<CefValue> val = CefParseJSON(r, JSON_PARSER_RFC);
+    if (!val || val->GetType() != VTYPE_DICTIONARY) { emitResolveAndClickError(s->view_id, s->request_id, "runtime_error", "getFrameOwner malformed"); return; }
+    int backendNodeId = val->GetDictionary()->HasKey("backendNodeId") ? val->GetDictionary()->GetInt("backendNodeId") : 0;
+    if (!backendNodeId) { emitResolveAndClickError(s->view_id, s->request_id, "not_found", "no backendNodeId"); return; }
+    auto* v2 = bunite_win::getViewHostById(s->view_id);
+    if (!v2) { emitResolveAndClickError(s->view_id, s->request_id, "runtime_error", "view destroyed"); return; }
+    std::string boxParams = "{\"backendNodeId\":" + std::to_string(backendNodeId) + "}";
+    auto onBox = [s, link_idx](bool ok2, std::string rb) {
+      if (!ok2) { emitResolveAndClickError(s->view_id, s->request_id, "not_visible", "iframe has no box"); return; }
+      std::array<double, 8> quad{};
+      if (!parseQuadFromBoxModel(rb, quad)) { emitResolveAndClickError(s->view_id, s->request_id, "runtime_error", "bad quad"); return; }
+      s->link_quads.push_back(quad);
+      fetchLink(s, link_idx + 1);
+    };
+    if (parent_session.empty()) {
+      cefCdpCall(v2, "DOM.getBoxModel", boxParams, onBox);
+    } else {
+      int id = nextRawCdpId();
+      std::string msg = "{\"id\":" + std::to_string(id) +
+                        ",\"sessionId\":\"" + parent_session +
+                        "\",\"method\":\"DOM.getBoxModel\",\"params\":" + boxParams + "}";
+      cefSendRaw(v2, msg, id, onBox);
+    }
+  };
+  if (parent_session.empty()) {
+    cefCdpCall(view, "DOM.getFrameOwner", ownerParams, onOwner);
+  } else {
+    int id = nextRawCdpId();
+    std::string msg = "{\"id\":" + std::to_string(id) +
+                      ",\"sessionId\":\"" + parent_session +
+                      "\",\"method\":\"DOM.getFrameOwner\",\"params\":" + ownerParams + "}";
+    cefSendRaw(view, msg, id, onOwner);
+  }
+}
+
+void fetchAncestorInner(std::shared_ptr<ChainState> s, size_t i) {
+  // i ranges [1, N-2]. Skip N-1 (target — iw/ih from target eval).
+  if (i + 1 >= s->chain.size()) {
+    // Done with ancestors. Eval target script.
+    fetchTargetEval(s);
+    return;
+  }
+  const std::string sid = sessionForChainIdx(s->view_id, s->chain, i);
+  auto* view = bunite_win::getViewHostById(s->view_id);
+  if (!view) { emitResolveAndClickError(s->view_id, s->request_id, "runtime_error", "view destroyed"); return; }
+  const std::string& script = "JSON.stringify({iw:innerWidth,ih:innerHeight})";
+  std::string escScript = escapeForJsonString(script);
+  evalRaw(view, sid, escScript,
+      [s, i](bool ok, std::string r) {
+        if (!ok) { emitResolveAndClickError(s->view_id, s->request_id, "runtime_error", "ancestor eval failed"); return; }
+        // Result envelope: {"result":{"type":"string","value":"<json string>"}}
+        CefRefPtr<CefValue> v = CefParseJSON(r, JSON_PARSER_RFC);
+        if (!v || v->GetType() != VTYPE_DICTIONARY) { emitResolveAndClickError(s->view_id, s->request_id, "runtime_error", "ancestor eval malformed"); return; }
+        auto result = v->GetDictionary()->GetDictionary("result");
+        if (!result || !result->HasKey("value")) { emitResolveAndClickError(s->view_id, s->request_id, "runtime_error", "ancestor eval no value"); return; }
+        std::string vs = result->GetString("value").ToString();
+        CefRefPtr<CefValue> inner = CefParseJSON(vs, JSON_PARSER_RFC);
+        if (!inner || inner->GetType() != VTYPE_DICTIONARY) { emitResolveAndClickError(s->view_id, s->request_id, "runtime_error", "ancestor inner malformed"); return; }
+        s->ancestor_inner.push_back({dictNumber(inner->GetDictionary(), "iw"), dictNumber(inner->GetDictionary(), "ih")});
+        fetchAncestorInner(s, i + 1);
+      });
+}
+
+void fetchTargetEval(std::shared_ptr<ChainState> s) {
+  evalInFrame(s->view_id, s->request_id, s->targetFrameId, s->escScript,
+      [s](const FrameResolveOk& fr) { composeAndDispatch(s, fr); });
+}
+
+void composeAndDispatch(std::shared_ptr<ChainState> s, const FrameResolveOk& fr) {
+  // Stack iw/ih per chain level chain[1..N-1] for the bilinear walk.
+  // chain[N-1] = target → fr.iw, fr.ih.
+  // chain[i] (1 <= i < N-1) → s->ancestor_inner[i-1].
+  // link_quads[i] = quad of chain[i+1]'s iframe element, in chain[i]'s coords.
+  // Map order: from target up to main, applying bilinear at each link.
+  auto mapCorner = [&](double fx, double fy, double& px, double& py) {
+    double cur_x = fx, cur_y = fy;
+    double cur_iw = fr.iw, cur_ih = fr.ih;
+    // link i (chain[i+1] in chain[i]'s coords) for i = N-2 down to 0.
+    for (size_t i = s->link_quads.size(); i-- > 0; ) {
+      double mapped_x, mapped_y;
+      bilinearMap(s->link_quads[i], cur_iw, cur_ih, cur_x, cur_y, mapped_x, mapped_y);
+      cur_x = mapped_x; cur_y = mapped_y;
+      if (i == 0) break;  // chain[i] is main-direct child handled; next would be main itself
+      // Now in chain[i]'s coords; next iteration maps to chain[i-1]'s coords.
+      cur_iw = s->ancestor_inner[i - 1].first;
+      cur_ih = s->ancestor_inner[i - 1].second;
+    }
+    px = cur_x; py = cur_y;
+  };
+  double pcx, pcy; mapCorner(fr.cx, fr.cy, pcx, pcy);
+  double cx0, cy0, cx1, cy1, cx2, cy2, cx3, cy3;
+  mapCorner(fr.x,             fr.y,             cx0, cy0);
+  mapCorner(fr.x + fr.w,      fr.y,             cx1, cy1);
+  mapCorner(fr.x + fr.w,      fr.y + fr.h,      cx2, cy2);
+  mapCorner(fr.x,             fr.y + fr.h,      cx3, cy3);
+  const double min_x = std::min(std::min(cx0, cx1), std::min(cx2, cx3));
+  const double max_x = std::max(std::max(cx0, cx1), std::max(cx2, cx3));
+  const double min_y = std::min(std::min(cy0, cy1), std::min(cy2, cy3));
+  const double max_y = std::max(std::max(cy0, cy1), std::max(cy2, cy3));
+  finishResolveAndClick(s->view_id, s->request_id,
+      min_x, min_y, max_x - min_x, max_y - min_y, pcx, pcy,
+      s->button, s->click_count, s->modifiers);
+}
+
+// `frameId` non-empty: walk ancestor chain via Page.getFrameTree, compose
+// bilinear transforms across nested OOPIF/same-origin frames, dispatch click
+// in main-page coords.
+void runFrameTargeted(uint32_t view_id, uint32_t request_id, const std::string& frameId,
+                       const std::string& escScript,
+                       int32_t button, int32_t click_count, uint32_t modifiers) {
+  auto* view = bunite_win::getViewHostById(view_id);
+  if (!view || !view->browser) { emitResolveAndClickError(view_id, request_id, "runtime_error", "view destroyed"); return; }
+  cefCdpCall(view, "Page.getFrameTree", "{}",
+      [view_id, request_id, frameId, escScript, button, click_count, modifiers](bool ok, std::string r) {
+        if (!ok) { emitResolveAndClickError(view_id, request_id, "runtime_error", "getFrameTree failed"); return; }
+        CefRefPtr<CefValue> val = CefParseJSON(r, JSON_PARSER_RFC);
+        if (!val || val->GetType() != VTYPE_DICTIONARY) { emitResolveAndClickError(view_id, request_id, "runtime_error", "getFrameTree malformed"); return; }
+        auto root = val->GetDictionary()->GetDictionary("frameTree");
+        std::vector<std::string> chain = findFramePath(root, frameId);
+        if (chain.size() < 2) { emitResolveAndClickError(view_id, request_id, "not_found", "frame not in tree"); return; }
+        auto s = std::make_shared<ChainState>();
+        s->view_id = view_id;
+        s->request_id = request_id;
+        s->targetFrameId = frameId;
+        s->escScript = escScript;
+        s->button = button;
+        s->click_count = click_count;
+        s->modifiers = modifiers;
+        s->chain = std::move(chain);  // chain[0] = main, chain[N-1] = target
+        fetchLink(s, 0);
+      });
+}
+
+}  // namespace
+
+extern "C" BUNITE_EXPORT void bunite_view_resolve_and_click(
+    uint32_t view_id, uint32_t request_id,
+    const char* selector_c, const char* frame_id_c,
+    int32_t button, int32_t click_count, uint32_t modifiers) {
+  std::string selector = selector_c ? selector_c : "";
+  std::string frameId = frame_id_c ? frame_id_c : "";
+  bunite_win::postCefUiTask([view_id, request_id, selector, frameId, button, click_count, modifiers]() {
+    auto* view = bunite_win::getViewHostById(view_id);
+    if (!view || !view->browser) { emitResolveAndClickError(view_id, request_id, "runtime_error", "view not ready"); return; }
+
+    std::string script = buildResolveScript(selector);
+    std::string escScript = escapeForJsonString(script);
+
+    if (frameId.empty()) {
+      // Main frame — fr.x/y/w/h are already page-viewport coords (iw/ih unused).
+      std::string evalParams = "{\"expression\":\"" + escScript + "\",\"returnByValue\":true,\"awaitPromise\":true}";
+      cefCdpCall(view, "Runtime.evaluate", evalParams,
+          [view_id, request_id, button, click_count, modifiers](bool ok, std::string r) {
+            parseEvalAndContinue(view_id, request_id, ok, r,
+                [view_id, request_id, button, click_count, modifiers](const FrameResolveOk& fr) {
+                  finishResolveAndClick(view_id, request_id,
+                                         fr.x, fr.y, fr.w, fr.h, fr.cx, fr.cy,
+                                         button, click_count, modifiers);
+                });
+          });
+      return;
+    }
+
+    // Frame-targeted: lazy Target.setAutoAttach so OOPIF frames get sessionIds
+    // populated into view->oopif_sessions via OnDevToolsEvent. Wait for response
+    // so attachedToTarget events fire before we proceed.
+    if (!view->oopif_autoattach_armed.exchange(true)) {
+      cefCdpCall(view, "Target.setAutoAttach",
+          "{\"autoAttach\":true,\"flatten\":true,\"waitForDebuggerOnStart\":false}",
+          [view_id, request_id, frameId, escScript, button, click_count, modifiers](bool ok, std::string) {
+            if (!ok) { emitResolveAndClickError(view_id, request_id, "runtime_error", "setAutoAttach failed"); return; }
+            runFrameTargeted(view_id, request_id, frameId, escScript, button, click_count, modifiers);
+          });
+      return;
+    }
+    runFrameTargeted(view_id, request_id, frameId, escScript, button, click_count, modifiers);
+  });
+}
+
 extern "C" BUNITE_EXPORT void bunite_view_open_devtools(uint32_t view_id) {
   bunite_win::postCefUiTask([view_id]() { bunite_win::openDevToolsForView(bunite_win::getViewHostById(view_id)); });
 }