bun-workspaces 1.4.0 → 1.5.0

package/src/workspaces/dependencyGraph/validateDependencyRules.mjs

@@ -0,0 +1,66 @@
+import { WORKSPACE_ERRORS } from "../errors.mjs";
+import { matchWorkspacesByPatterns } from "../workspacePattern.mjs"; // CONCATENATED MODULE: external "../errors.mjs"
+// CONCATENATED MODULE: external "../workspacePattern.mjs"
+// CONCATENATED MODULE: ./src/workspaces/dependencyGraph/validateDependencyRules.ts
+
+const getTransitiveDeps = (workspaceName, workspaceMap, chain, visited) => {
+  const entry = workspaceMap[workspaceName];
+  if (!entry) return [];
+  const result = [];
+  for (const depName of entry.workspace.dependencies) {
+    if (visited.has(depName)) continue;
+    visited.add(depName);
+    const depChain = [...chain, depName];
+    result.push({
+      name: depName,
+      chain: depChain,
+    });
+    result.push(...getTransitiveDeps(depName, workspaceMap, depChain, visited));
+  }
+  return result;
+};
+const validateWorkspaceDependencyRules = ({ workspaceMap }) => {
+  const violations = [];
+  for (const [workspaceName, { config }] of Object.entries(workspaceMap)) {
+    const rule = config.rules?.workspaceDependencies;
+    if (!rule?.allowPatterns && !rule?.denyPatterns) continue;
+    const transitiveDeps = getTransitiveDeps(
+      workspaceName,
+      workspaceMap,
+      [workspaceName],
+      new Set([workspaceName]),
+    );
+    for (const { name: depName, chain } of transitiveDeps) {
+      const depWorkspace = workspaceMap[depName]?.workspace;
+      if (!depWorkspace) continue;
+      const chainStr = chain.join(" -> ");
+      if (rule.denyPatterns) {
+        const isDenied =
+          matchWorkspacesByPatterns(rule.denyPatterns, [depWorkspace]).length >
+          0;
+        if (isDenied) {
+          violations.push(
+            `"${workspaceName}" violates workspaceDependencies rule: workspace "${depName}" is denied by denyPatterns (dependency chain: ${chainStr})`,
+          );
+        }
+      }
+      if (rule.allowPatterns) {
+        const isAllowed =
+          matchWorkspacesByPatterns(rule.allowPatterns, [depWorkspace]).length >
+          0;
+        if (!isAllowed) {
+          violations.push(
+            `"${workspaceName}" violates workspaceDependencies rule: workspace "${depName}" is not permitted by allowPatterns (dependency chain: ${chainStr})`,
+          );
+        }
+      }
+    }
+  }
+  if (violations.length > 0) {
+    throw new WORKSPACE_ERRORS.DependencyRuleViolation(
+      `Workspace dependency rule violations:\n${violations.map((v) => `  - ${v}`).join("\n")}`,
+    );
+  }
+};
+
+export { validateWorkspaceDependencyRules };

package/src/workspaces/errors.d.ts

@@ -10,4 +10,5 @@ export declare const WORKSPACE_ERRORS: import("../internal/core").DefinedErrors<
   | "AliasConflict"
   | "AliasedWorkspaceNotFound"
   | "RootWorkspaceNotFound"
+  | "DependencyRuleViolation"
 >;

package/src/workspaces/errors.mjs

@@ -13,6 +13,7 @@ const WORKSPACE_ERRORS = defineErrors(
   "AliasConflict",
   "AliasedWorkspaceNotFound",
   "RootWorkspaceNotFound",
+  "DependencyRuleViolation",
 );
 
 export { WORKSPACE_ERRORS };

package/src/workspaces/findWorkspaces.d.ts

@@ -1,4 +1,4 @@
-import { type WorkspaceMap } from "./dependencyGraph/resolveDependencies";
+import { type WorkspaceMap } from "./dependencyGraph";
 import type { Workspace } from "./workspace";
 export interface FindWorkspacesOptions {
   rootDirectory: string;

package/src/workspaces/findWorkspaces.mjs

@@ -8,7 +8,10 @@ import {
 import { BUN_LOCK_ERRORS, readBunLockfile } from "../internal/bun/index.mjs";
 import { BunWorkspacesError } from "../internal/core/index.mjs";
 import { logger } from "../internal/logger/logger.mjs";
-import { resolveWorkspaceDependencies } from "./dependencyGraph/resolveDependencies.mjs";
+import {
+  resolveWorkspaceDependencies,
+  validateWorkspaceDependencyRules,
+} from "./dependencyGraph/index.mjs";
 import { WORKSPACE_ERRORS } from "./errors.mjs";
 import {
   resolvePackageJsonContent,
@@ -20,7 +23,7 @@ import {
 // CONCATENATED MODULE: external "../internal/bun/index.mjs"
 // CONCATENATED MODULE: external "../internal/core/index.mjs"
 // CONCATENATED MODULE: external "../internal/logger/logger.mjs"
-// CONCATENATED MODULE: external "./dependencyGraph/resolveDependencies.mjs"
+// CONCATENATED MODULE: external "./dependencyGraph/index.mjs"
 // CONCATENATED MODULE: external "./errors.mjs"
 // CONCATENATED MODULE: external "./packageJson.mjs"
 // CONCATENATED MODULE: ./src/workspaces/findWorkspaces.ts
@@ -176,6 +179,9 @@ const findWorkspaces = ({
       bunCatalogs,
     ),
   );
+  validateWorkspaceDependencyRules({
+    workspaceMap,
+  });
   validateWorkspaceAliases(workspaces, workspaceAliases, rootWorkspace.name);
   logger.debug(
     `Found ${workspaces.length} workspaces: ${workspaces.map((ws) => ws.name).join(", ")}`,

package/src/workspaces/workspacePattern.d.ts

@@ -7,6 +7,7 @@ export type WorkspacePattern = {
   value: string;
   isNegated: boolean;
 };
+export declare const WORKSPACE_PATTERN_NEGATION_PREFIX = "not:";
 export declare const WORKSPACE_PATTERN_SEPARATOR = ":";
 export declare const parseWorkspacePattern: (
   pattern: string,

package/src/workspaces/workspacePattern.mjs

@@ -5,10 +5,13 @@ import { createWildcardRegex, defineErrors } from "../internal/core/index.mjs";
 
 const TARGETS = ["path", "alias", "name", "tag"];
 const WORKSPACE_PATTERN_ERRORS = defineErrors("InvalidWorkspacePattern");
+const WORKSPACE_PATTERN_NEGATION_PREFIX = "not:";
 const WORKSPACE_PATTERN_SEPARATOR = ":";
 const parseWorkspacePattern = (pattern) => {
-  const isNegated = pattern.startsWith("!");
-  const patternValue = isNegated ? pattern.slice(1) : pattern;
+  const isNegated = pattern.startsWith(WORKSPACE_PATTERN_NEGATION_PREFIX);
+  const patternValue = isNegated
+    ? pattern.slice(WORKSPACE_PATTERN_NEGATION_PREFIX.length)
+    : pattern;
   const target = TARGETS.find((target) =>
     patternValue.startsWith(target + WORKSPACE_PATTERN_SEPARATOR),
   );
@@ -16,7 +19,7 @@ const parseWorkspacePattern = (pattern) => {
     return {
       target: "default",
       value: patternValue,
-      isNegated: pattern.startsWith("!"),
+      isNegated,
     };
   }
   const value = patternValue.slice(
@@ -62,7 +65,7 @@ const PATTERN_TARGET_HANDLERS = {
   },
   path: (pattern, workspaces) => {
     return workspaces.filter((workspace) =>
-      new bun.Glob(pattern.value).match(workspace.path),
+      new bun.Glob(pattern.value.replace(/\/+$/, "")).match(workspace.path),
     );
   },
   tag: (pattern, workspaces, wildcardRegex) => {
@@ -104,6 +107,7 @@ const matchWorkspacesByPatterns = (patterns, workspaces) => {
 
 export {
   WORKSPACE_PATTERN_ERRORS,
+  WORKSPACE_PATTERN_NEGATION_PREFIX,
   WORKSPACE_PATTERN_SEPARATOR,
   matchWorkspacesByPatterns,
   parseWorkspacePattern,