bulltrackers-module 1.0.800 → 1.0.802

package/functions/alert-system-v3/handlers/ingest.js

@@ -16,6 +16,8 @@ async function handleComputationResultWrite(change, context, config, dependencie
 
     if (!isAlertComputation(cachedAlertTypes, computationName)) return;
 
+    console.log("The computations assigned to on document write are," + computationName)
+
     const payload = {
       date,
       computationName,
@@ -32,4 +34,4 @@ async function handleComputationResultWrite(change, context, config, dependencie
   }
 }
 
-module.exports = { handleComputationResultWrite };
+module.exports = { handleComputationResultWrite };

package/functions/computation-system-v3/computations/GlobalAumPerAsset30D.js

@@ -4,7 +4,7 @@
  */
 
 const config = {
-    name: 'GlobalAumPerAsset30D', // Normalized name
+    name: 'GlobalAumPerAsset30D', 
     type: 'global',
     category: 'market_insights',
 
@@ -19,7 +19,7 @@ const config = {
         }
     },
 
-    dependencies: ['pidailyassetaum'], // Lowercase normalized
+    dependencies: ['pidailyassetaum'], 
 
     storage: {
         bigquery: true
@@ -32,11 +32,11 @@ async function process(context) {
     let rows = data['results'];
     if (!rows || (Array.isArray(rows) && rows.length === 0)) {
         if (log) log('[GlobalAumPerAsset] No input data found.');
-        return { result: null }; // V3 returns object with result
+        return { result: null }; 
     }
 
     if (!Array.isArray(rows) && typeof rows === 'object') {
-        rows = Object.values(rows); // Handle possible object map from BQ adapter
+        rows = Object.values(rows);
     }
 
     if (log) log(`[GlobalAumPerAsset] Aggregating ${rows.length} PI portfolios...`);
@@ -77,7 +77,6 @@ async function process(context) {
 
     if (log) log(`[GlobalAumPerAsset] Generated stats for ${materializedViewData.length} unique assets from ${piCount} PIs.`);
 
-    // V3 expects return value, not this.setResult
     return {
         status: 'completed',
         result: materializedViewData

package/functions/computation-system-v3/computations/PIDailyAssetAUM.js

@@ -24,7 +24,6 @@ const config = {
         'ticker_mappings': {
             mandatory: false,
             fields: ['instrument_id', 'ticker'],
-            // [CRITICAL] Disable batch filtering to get global map
             entityField: null 
         },
         'pi_master_list': {
@@ -53,7 +52,6 @@ async function process(context) {
     };
 
     // --- HELPER: V3 Data Normalizer ---
-    // Handles difference between Batch (keyed map) and Global (array) returns
     const getEntityRows = (dataset) => {
         if (!dataset) return [];
         if (dataset[entityId]) {
@@ -107,7 +105,6 @@ async function process(context) {
     }
 
     // 5. Calculation using V3 Libs
-    // Uses lib.portfolio.* and lib.rankings.* instead of V2 rules
     const pData = portfolio.extractPortfolioData(validPortfolio);
     const rData = rankings.extractRankingsData(validRanking);
 
@@ -123,7 +120,7 @@ async function process(context) {
     positions.forEach(pos => {
         const id = portfolio.getInstrumentId(pos);
         const ticker = resolveTicker(id);
-        const weight = portfolio.getInvested(pos); // V3 lib handles % normalization
+        const weight = portfolio.getInvested(pos); 
 
         if (weight > 0) {
             const dollarValue = (weight / 100) * totalAum;

package/functions/computation-system-v3/computations/PopularInvestorProfileMetrics.js

@@ -2,6 +2,7 @@
  * @fileoverview Popular Investor Profile Metrics
  * Migrated to V3 System.
  * FIXED: Corrected function call 'getTradesCount' and 'getTotalTrades' typo.
+ * OPTIMIZED: Uses 1-day lookback for trade history (rolling window) to prevent cost violations.
  */
 
 /** @typedef {import('../framework/core/ContextBuilder').ComputationContext} ComputationContext */
@@ -20,7 +21,7 @@ exports.config = {
             fields: ['user_id', 'portfolio_data', 'date']
         },
         'trade_history_snapshots': {
-            lookback: 30,
+            lookback: 1, // OPTIMIZED: Rolling history contained in single snapshot
             mandatory: false,
             fields: ['user_id', 'history_data', 'date']
         },
@@ -221,38 +222,38 @@ exports.process = (ctx) => {
                 gain: lib.rankings.getTotalGain(rData),
                 copiers: lib.rankings.getCopiers(rData),
                 winRatio: lib.rankings.getWinRatio(rData),
-                // [FIX] Changed from getTotalTrades to getTradesCount
                 trades: lib.rankings.getTradesCount(rData) 
             };
         }
     }
 
     // ==========================================================================================
-    // 4. TRADES
+    // 4. TRADES (OPTIMIZED)
     // ==========================================================================================
     const profitableMap = new Map();
     const allClosedTrades = [];
 
-    historyData.forEach(dayDoc => {
-        const trades = lib.trades.extractTrades(dayDoc);
-        trades.forEach(trade => {
-            const closeDate = lib.trades.getCloseDate(trade);
-            if (!closeDate) return;
-
-            const dKey = closeDate.toISOString().split('T')[0];
-            const profit = lib.trades.getNetProfit(trade);
-
-            const entry = profitableMap.get(dKey) || { date: dKey, profitableCount: 0, totalCount: 0 };
-            entry.totalCount++;
-            if (profit > 0) entry.profitableCount++;
-            profitableMap.set(dKey, entry);
-
-            allClosedTrades.push({
-                ticker: resolveTicker(lib.trades.getInstrumentId(trade)),
-                closeDate: closeDate,
-                netProfit: profit,
-                direction: lib.trades.isBuy(trade) ? 'Buy' : 'Sell'
-            });
+    // Only process the latest history snapshot as it contains the rolling history
+    const latestHistory = historyData.length > 0 ? historyData[historyData.length - 1] : null;
+    const trades = latestHistory ? lib.trades.extractTrades(latestHistory) : [];
+
+    trades.forEach(trade => {
+        const closeDate = lib.trades.getCloseDate(trade);
+        if (!closeDate) return;
+
+        const dKey = closeDate.toISOString().split('T')[0];
+        const profit = lib.trades.getNetProfit(trade);
+
+        const entry = profitableMap.get(dKey) || { date: dKey, profitableCount: 0, totalCount: 0 };
+        entry.totalCount++;
+        if (profit > 0) entry.profitableCount++;
+        profitableMap.set(dKey, entry);
+
+        allClosedTrades.push({
+            ticker: resolveTicker(lib.trades.getInstrumentId(trade)),
+            closeDate: closeDate,
+            netProfit: profit,
+            direction: lib.trades.isBuy(trade) ? 'Buy' : 'Sell'
         });
     });
 

package/functions/computation-system-v3/computations/SignedInUserProfileMetrics.js

@@ -2,6 +2,7 @@
  * @fileoverview Signed-In User Profile Metrics (V3 Recipe)
  * Migrated from V2 computation.
  * FIXED: Explicit fields, global lookups, and PI exclusion logic.
+ * OPTIMIZED: Uses 1-day lookback for trade history (rolling window) to prevent cost violations.
  */
 
 /** @typedef {import('../framework/core/ContextBuilder').ComputationContext} ComputationContext */
@@ -22,7 +23,7 @@ exports.config = {
             filter: { user_type: 'SIGNED_IN_USER' }
         },
         'trade_history_snapshots': {
-            lookback: 30,
+            lookback: 1, // OPTIMIZED: Rolling history contained in single snapshot
             fields: ['user_id', 'history_data', 'date'],
             filter: { user_type: 'SIGNED_IN_USER' }
         },
@@ -95,7 +96,6 @@ exports.process = (ctx) => {
     const piMasterList = toArray(data['pi_master_list']);
     
     // Check if the current entity is actually a PI (Source of Truth: Master List)
-    // This handles cases where user_type might be incorrect in snapshots
     const isPopularInvestor = piMasterList.some(pi => String(pi.cid) === String(entityId));
     
     if (isPopularInvestor) {
@@ -185,30 +185,31 @@ exports.process = (ctx) => {
     });
     result.myPosts.data = socialFeed.sort((a, b) => new Date(b.date) - new Date(a.date)).slice(0, 20);
 
-    // --- 7. Trades Processing ---
+    // --- 7. Trades Processing (OPTIMIZED) ---
     const dailyPnL = new Map();
     const winLoss = { wins: 0, losses: 0, profit: 0, loss: 0 };
     const tradeStats = new Map();
 
-    historyData.forEach(dayDoc => {
-        const trades = lib.trades.extractTrades(dayDoc);
-        trades.forEach(t => {
-            const closeDate = lib.trades.getCloseDate(t);
-            if (!closeDate) return;
+    // Only process the latest history snapshot as it contains the rolling history
+    const latestHistory = historyData.length > 0 ? historyData[historyData.length - 1] : null;
+    const trades = latestHistory ? lib.trades.extractTrades(latestHistory) : [];
 
-            const dKey = closeDate.toISOString().split('T')[0];
-            const profit = lib.trades.getNetProfit(t);
+    trades.forEach(t => {
+        const closeDate = lib.trades.getCloseDate(t);
+        if (!closeDate) return;
 
-            const entry = tradeStats.get(dKey) || { date: dKey, profitableCount: 0, totalCount: 0 };
-            entry.totalCount++;
-            if (profit > 0) entry.profitableCount++;
-            tradeStats.set(dKey, entry);
+        const dKey = closeDate.toISOString().split('T')[0];
+        const profit = lib.trades.getNetProfit(t);
 
-            if (profit > 0) { winLoss.wins++; winLoss.profit += profit; }
-            else if (profit < 0) { winLoss.losses++; winLoss.loss += profit; }
+        const entry = tradeStats.get(dKey) || { date: dKey, profitableCount: 0, totalCount: 0 };
+        entry.totalCount++;
+        if (profit > 0) entry.profitableCount++;
+        tradeStats.set(dKey, entry);
 
-            dailyPnL.set(dKey, (dailyPnL.get(dKey) || 0) + profit);
-        });
+        if (profit > 0) { winLoss.wins++; winLoss.profit += profit; }
+        else if (profit < 0) { winLoss.losses++; winLoss.loss += profit; }
+
+        dailyPnL.set(dKey, (dailyPnL.get(dKey) || 0) + profit);
     });
 
     result.profitablePositions.data = Array.from(tradeStats.values())

package/functions/computation-system-v3/framework/adapters/StateRepository.js

@@ -161,7 +161,9 @@ class StateRepository {
 
             return { completedBatches: snapshot.data().count };
         } catch (e) {
-            return { completedBatches: 0 };
+            // [FIX] Log the error!
+            this.logger.error(`[StateRepo] getCheckpointProgress failed for ${checkpointId}: ${e.message}`);
+            return { completedBatches: 0 }; 
         }
     }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bulltrackers-module",
-  "version": "1.0.800",
+  "version": "1.0.802",
   "description": "Helper Functions for Bulltrackers.",
   "main": "index.js",
   "files": [