bulltrackers-module 1.0.777 → 1.0.779

package/functions/alert-system/helpers/alert_manifest_loader.js

@@ -1,81 +1,63 @@
 /**
  * @fileoverview Dynamic Alert Manifest Loader
- * Loads alert types from computation classes instead of hardcoded registry
+ * Loads alert types from V2 computation config (getConfig()) instead of legacy package.
  */
 
+const path = require('path');
+
 /**
- * Flatten nested calculations object (same logic as index.js)
- * @param {Object} obj - Nested calculations object
- * @returns {Array<Function>} Flat array of computation classes
+ * Load V2 computation config (same source as scheduler).
+ * @returns {Object} Config with computations array
  */
-const flattenCalculations = (obj) => {
-  let result = [];
-  for (const key in obj) {
-    if (typeof obj[key] === 'function') {
-      result.push(obj[key]);
-    } else if (typeof obj[key] === 'object' && obj[key] !== null) {
-      result = result.concat(flattenCalculations(obj[key]));
-    }
-  }
-  return result;
-};
+function getV2Config() {
+  const configPath = path.join(__dirname, '../../computation-system-v2/config/bulltrackers.config.js');
+  return require(configPath);
+}
 
 /**
- * Load all alert computations from calculations package
+ * Load all alert computations from V2 config
  * @param {Object} logger - Logger instance
+ * @param {Object} [injectedConfig] - Optional config with computations array (for tests)
  * @returns {Promise<Array>} Array of alert type objects with metadata
  */
-async function loadAlertTypesFromManifest(logger) {
+async function loadAlertTypesFromManifest(logger, injectedConfig = null) {
   try {
-    // Import calculations the same way index.js does
-    const { calculations } = require('aiden-shared-calculations-unified');
-    const calculationsArray = flattenCalculations(calculations);
-    
+    const v2Config = injectedConfig || getV2Config();
+    const computations = v2Config.computations || [];
+
     const alertTypes = [];
-    
-    // Iterate through all computation classes (same logic as index.js alert trigger registration)
-    for (const CalcClass of calculationsArray) {
-      if (!CalcClass || typeof CalcClass.getMetadata !== 'function') {
-        continue;
-      }
-      
-      const metadata = CalcClass.getMetadata();
-      
-      // Check if this is an alert computation
-      if (metadata.isAlertComputation !== true) {
+
+    for (const ComputationClass of computations) {
+      if (!ComputationClass || typeof ComputationClass.getConfig !== 'function') {
         continue;
       }
-      
-      // Check if alert metadata exists
-      if (!metadata.alert) {
-        logger?.log('WARN', `[AlertManifestLoader] Computation ${metadata.name} has isAlertComputation=true but no alert metadata`);
+
+      const config = ComputationClass.getConfig();
+      if (!config || !config.alert) {
         continue;
       }
-      
-      // Build alert type object
+
+      const alert = config.alert;
       const alertType = {
-        id: metadata.alert.id,
-        name: metadata.alert.frontendName,
-        description: metadata.alert.description,
-        computationName: metadata.name,
-        category: metadata.category || 'alerts',
-        messageTemplate: metadata.alert.messageTemplate,
-        severity: metadata.alert.severity || 'medium',
-        configKey: metadata.alert.configKey,
-        isTest: metadata.isTest === true,
+        id: alert.id,
+        name: alert.frontendName,
+        description: alert.description || '',
+        computationName: config.name,
+        category: config.category || 'alerts',
+        messageTemplate: alert.messageTemplate || '',
+        severity: alert.severity || 'medium',
+        configKey: alert.configKey,
+        isTest: config.isTest === true,
         enabled: true,
-        // [FIX] Extract dynamic alert configuration from metadata
-        isDynamic: metadata.alert.isDynamic || false,
-        dynamicConfig: metadata.alert.dynamicConfig || null
+        isDynamic: alert.isDynamic || false,
+        dynamicConfig: alert.dynamicConfig || null
       };
-      
+
       alertTypes.push(alertType);
-      
-      logger?.log('DEBUG', `[AlertManifestLoader] Loaded alert type: ${alertType.id} from ${metadata.name} (isDynamic: ${alertType.isDynamic})`);
+      logger?.log('DEBUG', `[AlertManifestLoader] Loaded alert type: ${alertType.id} from ${config.name} (isDynamic: ${alertType.isDynamic})`);
     }
-    
-    logger?.log('INFO', `[AlertManifestLoader] Successfully loaded ${alertTypes.length} alert types from calculations`);
-    
+
+    logger?.log('INFO', `[AlertManifestLoader] Successfully loaded ${alertTypes.length} alert types from V2 config`);
     return alertTypes;
   } catch (error) {
     logger?.log('ERROR', `[AlertManifestLoader] Failed to load alert types: ${error.message}`);
@@ -104,59 +86,66 @@ function isAlertComputation(alertTypes, computationName) {
 }
 
 /**
- * Generate alert message from template and metadata
+ * Build resolved values for message placeholders from computation result using alert metadata.
+ * Uses alert.dynamicConfig.resultFields to map placeholder names to result keys (metadata-only; no hardcoded values).
+ * @param {Object} alertType - Alert type with messageTemplate and optional dynamicConfig.resultFields
+ * @param {Object} metadata - Computation result (e.g. per-PI result)
+ * @returns {Object} Resolved key-value map for placeholder substitution
+ */
+function resolvePlaceholdersFromMetadata(alertType, metadata = {}) {
+  const resolved = { ...metadata };
+  const resultFields = alertType.dynamicConfig?.resultFields;
+  if (resultFields && typeof resultFields === 'object') {
+    for (const [placeholderName, resultKey] of Object.entries(resultFields)) {
+      resolved[placeholderName] = metadata[resultKey];
+    }
+  }
+  return resolved;
+}
+
+/**
+ * Generate alert message from template and metadata only (no hardcoded message strings).
+ * Uses alertType.messageTemplate and injects values from computation result; resultFields maps placeholders to result keys.
  * @param {Object} alertType - Alert type object
  * @param {string} piUsername - PI username
  * @param {Object} metadata - Metadata from computation results
  * @returns {string} Generated alert message
  */
 function generateAlertMessage(alertType, piUsername, metadata = {}) {
-  let message = alertType.messageTemplate;
-  
-  // Replace placeholders
+  let message = alertType.messageTemplate || '';
+  const r = resolvePlaceholdersFromMetadata(alertType, metadata);
+
   message = message.replace(/{piUsername}/g, piUsername || 'Unknown');
-  message = message.replace(/{count}/g, metadata.count || metadata.positions?.length || metadata.moveCount || 0);
-  message = message.replace(/{change}/g, metadata.change || metadata.changePercent || metadata.diff || 'N/A');
-  message = message.replace(/{previous}/g, metadata.previous || metadata.previousValue || metadata.prev || metadata.previousRisk || 'N/A');
-  message = message.replace(/{current}/g, metadata.current || metadata.currentValue || metadata.curr || metadata.currentRisk || 'N/A');
-  message = message.replace(/{sectorName}/g, metadata.sectorName || (metadata.newExposures && metadata.newExposures.length > 0 ? metadata.newExposures.join(', ') : 'Unknown'));
-  message = message.replace(/{ticker}/g, metadata.ticker || metadata.symbol || 'Unknown');
-  
-  // Format numeric values
-  message = message.replace(/{volatility}/g, metadata.volatility ? `${(metadata.volatility * 100).toFixed(1)}` : 'N/A');
-  message = message.replace(/{threshold}/g, metadata.threshold ? `${(metadata.threshold * 100).toFixed(0)}` : 'N/A');
-  message = message.replace(/{diff}/g, metadata.diff ? `${metadata.diff.toFixed(1)}` : 'N/A');
-  message = message.replace(/{prev}/g, metadata.prev ? `${metadata.prev.toFixed(1)}` : 'N/A');
-  message = message.replace(/{curr}/g, metadata.curr ? `${metadata.curr.toFixed(1)}` : 'N/A');
-  message = message.replace(/{title}/g, metadata.title || 'New Update');
-  
-  // Probe placeholders
-  message = message.replace(/{status}/g, metadata.status || 'Unknown Status');
-  message = message.replace(/{timestamp}/g, metadata.timestamp || new Date().toISOString());
-
-  // Behavioral Anomaly placeholders
-  message = message.replace(/{primaryDriver}/g, metadata.primaryDriver || 'Unknown Factor');
-  message = message.replace(/{driverSignificance}/g, metadata.driverSignificance || 'N/A');
-  message = message.replace(/{anomalyScore}/g, metadata.anomalyScore || 'N/A');
-  
-  // Handle positions list if available
-  if (metadata.positions && Array.isArray(metadata.positions) && metadata.positions.length > 0) {
-    const positionsList = metadata.positions
-      .slice(0, 3)
-      .map(p => p.ticker || p.instrumentId)
-      .join(', ');
+  message = message.replace(/{count}/g, r.count ?? r.positions?.length ?? r.moveCount ?? 0);
+  message = message.replace(/{change}/g, r.change ?? r.changePercent ?? r.diff ?? 'N/A');
+  message = message.replace(/{previous}/g, r.previous ?? r.previousValue ?? r.prev ?? r.previousRisk ?? 'N/A');
+  message = message.replace(/{current}/g, r.current ?? r.currentValue ?? r.curr ?? r.currentRisk ?? 'N/A');
+  message = message.replace(/{sectorName}/g, r.sectorName ?? (r.newExposures?.length ? r.newExposures.join(', ') : 'Unknown'));
+  message = message.replace(/{ticker}/g, r.ticker ?? r.symbol ?? 'Unknown');
+  message = message.replace(/{volatility}/g, r.volatility != null ? `${(r.volatility * 100).toFixed(1)}` : 'N/A');
+  message = message.replace(/{threshold}/g, r.threshold != null ? `${(r.threshold * 100).toFixed(0)}` : 'N/A');
+  message = message.replace(/{diff}/g, r.diff != null ? `${Number(r.diff).toFixed(1)}` : 'N/A');
+  message = message.replace(/{prev}/g, r.prev != null ? `${Number(r.prev).toFixed(1)}` : 'N/A');
+  message = message.replace(/{curr}/g, r.curr != null ? `${Number(r.curr).toFixed(1)}` : 'N/A');
+  message = message.replace(/{title}/g, r.title ?? 'New Update');
+  message = message.replace(/{status}/g, r.status ?? 'Unknown Status');
+  message = message.replace(/{timestamp}/g, r.timestamp ?? new Date().toISOString());
+  message = message.replace(/{primaryDriver}/g, r.primaryDriver ?? r.driver ?? 'Unknown Factor');
+  message = message.replace(/{driverSignificance}/g, r.driverSignificance ?? r.driverValue ?? 'N/A');
+  message = message.replace(/{anomalyScore}/g, r.anomalyScore ?? r.score ?? 'N/A');
+
+  if (r.positions?.length) {
+    const positionsList = r.positions.slice(0, 3).map(p => p.ticker || p.instrumentId).join(', ');
     message = message.replace(/{positions}/g, positionsList);
   }
-  
-  // Handle moves array for PositionInvestedIncrease
-  if (metadata.moves && Array.isArray(metadata.moves) && metadata.moves.length > 0) {
-    const firstMove = metadata.moves[0];
-    message = message.replace(/{symbol}/g, firstMove.symbol || 'Unknown');
-    message = message.replace(/{diff}/g, firstMove.diff ? `${firstMove.diff.toFixed(1)}` : 'N/A');
-    message = message.replace(/{prev}/g, firstMove.prev ? `${firstMove.prev.toFixed(1)}` : 'N/A');
-    message = message.replace(/{curr}/g, firstMove.curr ? `${firstMove.curr.toFixed(1)}` : 'N/A');
+  if (r.moves?.length) {
+    const firstMove = r.moves[0];
+    message = message.replace(/{symbol}/g, firstMove.symbol ?? 'Unknown');
+    message = message.replace(/{diff}/g, firstMove.diff != null ? `${Number(firstMove.diff).toFixed(1)}` : 'N/A');
+    message = message.replace(/{prev}/g, firstMove.prev != null ? `${Number(firstMove.prev).toFixed(1)}` : 'N/A');
+    message = message.replace(/{curr}/g, firstMove.curr != null ? `${Number(firstMove.curr).toFixed(1)}` : 'N/A');
   }
-  
+
   return message;
 }