bulltrackers-module 1.0.706 → 1.0.709

package/functions/computation-system/executors/StandardExecutor.js

@@ -2,7 +2,7 @@
  * @fileoverview Executor for "Standard" (User-Level) calculations.
  * REFACTORED: Hoisted data loading, centralized Series/Root logic.
  * UPDATED: Calls getResult() on computations to trigger summary logging.
- * FIXED: Force-increments shard indexes after every flush to prevent batch overwrites.
+ * FIXED: Removed redundant shard index increment that caused shard gaps (0, 2, 4...).
  */
 const { normalizeName, getEarliestDataDates } = require('../utils/utils');
 const { streamPortfolioData, streamHistoryData, getPortfolioPartRefs, getHistoryPartRefs } = require('../utils/data_loader');
@@ -279,7 +279,7 @@ class StandardExecutor {
                 data = inst.results || {};
             }
 
-            // Track active calculations to increment their shards later
+            // Track active calculations (for debugging/logging only now)
             if (Object.keys(data).length > 0) {
                 activeCalcs.push(name);
             }
@@ -302,16 +302,10 @@ class StandardExecutor {
 
         const res = await commitResults(transformedState, dateStr, passName, config, deps, skipStatus, { flushMode: mode, shardIndexes: shardMap, isInitialWrite: isInitial });
         
-        // Update shardMap from result
+        // Update shardMap from result. 
+        // ResultCommitter now returns the CORRECT nextShardIndex (e.g. if it wrote shard_0, it returns 1).
         if (res.shardIndexes) Object.assign(shardMap, res.shardIndexes);
         
-        // [FIX 2] Force increment shard indexes for active calculations.
-        // This ensures the NEXT batch writes to a NEW shard (e.g. results_1) 
-        // instead of overwriting the current one (results_0).
-        activeCalcs.forEach(name => {
-            shardMap[name] = (shardMap[name] || 0) + 1;
-        });
-
         return res;
     }
 

package/functions/computation-system/persistence/ResultCommitter.js

@@ -3,6 +3,7 @@
  * UPDATED: Added GCS Offloading logic (Hybrid Pointer System).
  * UPDATED: Preserved Legacy Sharding/Compression for backward compatibility.
  * UPDATED: Auto-cleanup of old Firestore shards when migrating a doc to GCS.
+ * FIXED: Disabled "Single Doc Compression" strategy during intermediate flushes to ensure consistent sharding.
  */
 const { commitBatchInChunks, generateDataHash, FieldValue } = require('../utils/utils');
 const { updateComputationStatus }          = require('./StatusRepository');
@@ -366,7 +367,10 @@ async function writeSingleResult(result, docRef, name, dateContext, category, lo
     }
 
     // --- STRATEGY 2: FIRESTORE COMPRESSION ---
-    if (totalSize > 50 * 1024) { 
+    // FIX: Only compress if this is a single, atomic write (not part of a stream).
+    // Streaming relies on Strategy 3 (Sharding) to create distinct files (shard_0, shard_1...).
+    // If flushMode is INTERMEDIATE or we are already at a high shard index, we MUST fall through to sharding.
+    if (totalSize > 50 * 1024 && startShardIndex === 0 && flushMode !== 'INTERMEDIATE') { 
         try {
             const compressedBuffer = zlib.gzipSync(rawBuffer);
             if (compressedBuffer.length < 900 * 1024) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bulltrackers-module",
-  "version": "1.0.706",
+  "version": "1.0.709",
   "description": "Helper Functions for Bulltrackers.",
   "main": "index.js",
   "files": [