bulltrackers-module 1.0.686 → 1.0.688

package/functions/alert-system/helpers/alert_manifest_loader.js

@@ -63,12 +63,15 @@ async function loadAlertTypesFromManifest(logger) {
         severity: metadata.alert.severity || 'medium',
         configKey: metadata.alert.configKey,
         isTest: metadata.isTest === true,
-        enabled: true
+        enabled: true,
+        // [FIX] Extract dynamic alert configuration from metadata
+        isDynamic: metadata.alert.isDynamic || false,
+        dynamicConfig: metadata.alert.dynamicConfig || null
       };
       
       alertTypes.push(alertType);
       
-      logger?.log('DEBUG', `[AlertManifestLoader] Loaded alert type: ${alertType.id} from ${metadata.name}`);
+      logger?.log('DEBUG', `[AlertManifestLoader] Loaded alert type: ${alertType.id} from ${metadata.name} (isDynamic: ${alertType.isDynamic})`);
     }
     
     logger?.log('INFO', `[AlertManifestLoader] Successfully loaded ${alertTypes.length} alert types from calculations`);

package/functions/api-v2/helpers/data-fetchers/firestore.js

@@ -392,7 +392,10 @@ const manageUserWatchlist = async (db, userId, instruction, payload = {}) => {
     const sanitizedUserId = sanitizeCid(userId);
     
     // 1. Determine Watchlist ID and Reference
-    const watchlistId = payload.id ? sanitizeDocId(payload.id) : `watchlist_${Date.now()}_${Math.random().toString(16).substr(2, 8)}`;
+    // Handle both 'id' (from frontend) and 'watchlistId' (legacy)
+    const watchlistId = payload.id ? sanitizeDocId(payload.id) 
+                      : payload.watchlistId ? sanitizeDocId(payload.watchlistId)
+                      : `watchlist_${Date.now()}_${Math.random().toString(16).substr(2, 8)}`;
     const userDocRef = db.collection('SignedInUsers').doc(sanitizedUserId).collection('watchlists').doc(watchlistId);
 
     try {
@@ -414,11 +417,6 @@ const manageUserWatchlist = async (db, userId, instruction, payload = {}) => {
         // 3. Calculate Deltas based on Instruction
         if (instruction === 'create') {
             addedItems = payload.items || [];
-            
-            // DEBUG: Log what we're receiving
-            console.log('[manageUserWatchlist DEBUG] payload received:', JSON.stringify(payload));
-            console.log('[manageUserWatchlist DEBUG] payload.type:', payload.type);
-            
             // Create the User Document
             const newDocData = {
                 ...payload,
@@ -429,11 +427,6 @@ const manageUserWatchlist = async (db, userId, instruction, payload = {}) => {
                 copyCount: 0,
                 isAutoGenerated: false
             };
-            
-            // DEBUG: Log what we're about to save
-            console.log('[manageUserWatchlist DEBUG] newDocData to save:', JSON.stringify(newDocData));
-            console.log('[manageUserWatchlist DEBUG] newDocData.type:', newDocData.type);
-            
             batch.set(userDocRef, newDocData);
         } 
         

package/functions/api-v2/routes/watchlists.js

@@ -20,14 +20,15 @@ const router = express.Router();
 const watchlistManageSchema = z.object({
     instruction: z.enum(['create', 'update', 'delete', 'add_item', 'remove_item', 'update_item']),
     payload: z.object({
-        watchlistId: z.string().optional(),
+        id: z.string().optional(),  // Frontend sends "id"
+        watchlistId: z.string().optional(),  // Keep for backward compatibility
         name: z.string().max(200).optional(),
         description: z.string().max(1000).optional(),
-        type: z.enum(['static', 'dynamic']).optional(),  // FIX: Allow type field!
-        visibility: z.enum(['public', 'private']).optional(),  // FIX: Allow visibility field!
+        type: z.enum(['static', 'dynamic']).optional(),
+        visibility: z.enum(['public', 'private']).optional(),
         items: z.array(z.any()).optional(),
         item: z.any().optional(),
-        dynamicConfig: z.any().optional()  // FIX: Allow dynamicConfig for dynamic watchlists!
+        dynamicConfig: z.any().optional()
     })
 });
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bulltrackers-module",
-  "version": "1.0.686",
+  "version": "1.0.688",
   "description": "Helper Functions for Bulltrackers.",
   "main": "index.js",
   "files": [