bulltrackers-module 1.0.682 → 1.0.684

package/functions/api-v2/middleware/identity_middleware.js

@@ -34,7 +34,7 @@ const PUBLIC_ROUTES = [
     '/popular-investors/search',
     '/popular-investors/profile', // Public PI profiles - userCid optional for personalization
     '/verification/lookup', // Uses Firebase Auth token instead of userCid
-    '/alerts/types', // Static data - doesn't need userCid
+    // NOTE: /alerts/types REMOVED - now requires auth to check developer status for test alerts
     '/alerts/dynamic-watchlist-computations', // Static data - doesn't need userCid
     '/popular-investors/track-view', // Optional userCid - can track views anonymously
     '/reviews' // Public reviews - userCid optional (for showing current user's review)

package/functions/api-v2/routes/alerts.js

@@ -189,25 +189,31 @@ router.get('/types', async (req, res, next) => {
 // GET /alerts/dynamic-watchlist-computations - Get available computations for dynamic watchlists
 router.get('/dynamic-watchlist-computations', async (req, res, next) => {
     try {
-        // Import getAllAlertTypes from alert system
-        const { getAllAlertTypes } = require('../../alert-system/helpers/alert_type_registry.js');
-        const alertTypes = getAllAlertTypes();
+        const { logger } = req.dependencies;
         
-        // Extract unique computations from alert types
-        const computations = alertTypes.map(type => ({
-            computationName: type.computationName,
-            alertTypeName: type.name,
-            description: type.description,
-            severity: type.severity
-        }));
+        // [UPDATED] Load alert types from manifest instead of hardcoded registry
+        const alertTypes = await loadAlertTypesFromManifest(logger);
         
-        // Cache in browser/CDN for 1 hour (static data)
+        // Extract unique computations from alert types (exclude test alerts)
+        const computations = alertTypes
+            .filter(type => !type.isTest)
+            .map(type => ({
+                computationName: type.computationName,
+                alertTypeName: type.name,
+                description: type.description,
+                severity: type.severity,
+                configKey: type.configKey
+            }));
+        
+        // Cache in browser/CDN for 1 hour (data changes infrequently)
         res.set('Cache-Control', 'public, max-age=3600');
         res.json({
             success: true,
-            computations
+            computations,
+            count: computations.length
         });
     } catch (error) {
+        logger?.log('ERROR', `[GET /alerts/dynamic-watchlist-computations] Error: ${error.message}`);
         next(error);
     }
 });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bulltrackers-module",
-  "version": "1.0.682",
+  "version": "1.0.684",
   "description": "Helper Functions for Bulltrackers.",
   "main": "index.js",
   "files": [