bulltrackers-module 1.0.681 → 1.0.683

package/functions/api-v2/helpers/data-fetchers/firestore.js

@@ -184,18 +184,24 @@ const fetchPopularInvestorMasterList = async (firestore, userId = null) => {
 // 4. Fetch developer overrides data
 // GOAL : Used for allowing a given userID to have special abilities
 // Any userID document given in path /dev_overrides/ like /dev_overrides/29312236, is considered a developer, we want to return a true bool if a given ID is a developer, otherwise return false
+// [FIX] Must check that enabled === true, not just document existence
 
 const isDeveloper = async (firestore, userId) => {
     try {
         const docRef = firestore.collection('dev_overrides').doc(userId);
-
         const docSnapshot = await docRef.get();
-        return docSnapshot.exists;
+        
+        // Check both that document exists AND enabled === true
+        if (!docSnapshot.exists) {
+            return false;
+        }
+        
+        const data = docSnapshot.data();
+        return data?.enabled === true;
     }
     catch (error) {
         console.error(`Error checking developer status: ${error}`);
         throw error;
-
     }
 };
 

package/functions/api-v2/middleware/identity_middleware.js

@@ -34,7 +34,7 @@ const PUBLIC_ROUTES = [
     '/popular-investors/search',
     '/popular-investors/profile', // Public PI profiles - userCid optional for personalization
     '/verification/lookup', // Uses Firebase Auth token instead of userCid
-    '/alerts/types', // Static data - doesn't need userCid
+    // NOTE: /alerts/types REMOVED - now requires auth to check developer status for test alerts
     '/alerts/dynamic-watchlist-computations', // Static data - doesn't need userCid
     '/popular-investors/track-view', // Optional userCid - can track views anonymously
     '/reviews' // Public reviews - userCid optional (for showing current user's review)

package/functions/api-v2/routes/alerts.js

@@ -47,11 +47,15 @@ router.get('/types', async (req, res, next) => {
         // Check if user is a developer
         const isDev = await isDeveloper(db, String(req.targetUserId));
         
+        logger?.log('INFO', `[GET /alerts/types] User ${req.targetUserId} isDeveloper: ${isDev}, loaded ${alertTypes.length} total alert types`);
+        
         // Filter out test alerts for non-developers
         const filteredAlertTypes = isDev 
             ? alertTypes 
             : alertTypes.filter(type => !type.isTest);
         
+        logger?.log('INFO', `[GET /alerts/types] After filtering: ${filteredAlertTypes.length} alert types (removed ${alertTypes.length - filteredAlertTypes.length} test alerts)`);
+        
         // Format response for frontend
         const formattedTypes = filteredAlertTypes.map(type => ({
             id: type.id,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bulltrackers-module",
-  "version": "1.0.681",
+  "version": "1.0.683",
   "description": "Helper Functions for Bulltrackers.",
   "main": "index.js",
   "files": [