bulltrackers-module 1.0.680 → 1.0.682

package/functions/alert-system/helpers/alert_helpers.js

@@ -222,21 +222,13 @@ async function processAlertForPI(db, logger, piCid, alertType, computationMetada
 async function findSubscriptionsForPI(db, logger, piCid, alertTypeId, computationDate, dependencies = {}) {
   const subscriptions = [];
   
-  // Map computation names to watchlist alertConfig keys
-  const computationToConfigKey = {
-    'RiskScoreIncrease': 'increasedRisk',
-    'SignificantVolatility': 'volatilityChanges',
-    'NewSectorExposure': 'newSector',
-    'PositionInvestedIncrease': 'increasedPositionSize',
-    'NewSocialPost': 'newSocialPost',
-    // [NEW] Mapping for BehavioralAnomaly
-    'BehavioralAnomaly': 'behavioralAnomaly',
-    'TestSystemProbe': 'increasedRisk' // Hack: Map to 'increasedRisk' key
-  };
+  // [DYNAMIC] Get configKey from alertType metadata instead of hardcoded mapping
+  // The alertType is passed in dependencies and contains the configKey from computation metadata
+  const alertType = dependencies.alertType;
+  const configKey = alertType?.configKey;
   
-  const configKey = computationToConfigKey[alertTypeId];
   if (!configKey) {
-    logger.log('WARN', `[findSubscriptionsForPI] No mapping found for alert type: ${alertTypeId}`);
+    logger.log('WARN', `[findSubscriptionsForPI] No configKey found for alert type: ${alertTypeId}`);
     return subscriptions;
   }
   
@@ -264,8 +256,8 @@ async function findSubscriptionsForPI(db, logger, piCid, alertTypeId, computatio
       increasedPositionSize: true,
       newSocialPost: true,
       newPositions: true,
-      // [NEW] Enable for Dev Override
-      behavioralAnomaly: true
+      behavioralAnomaly: true,
+      testSystemProbe: true // Test alerts for developers
     };
     
     // Check all developer accounts

package/functions/api-v2/helpers/data-fetchers/firestore.js

@@ -184,18 +184,24 @@ const fetchPopularInvestorMasterList = async (firestore, userId = null) => {
 // 4. Fetch developer overrides data
 // GOAL : Used for allowing a given userID to have special abilities
 // Any userID document given in path /dev_overrides/ like /dev_overrides/29312236, is considered a developer, we want to return a true bool if a given ID is a developer, otherwise return false
+// [FIX] Must check that enabled === true, not just document existence
 
 const isDeveloper = async (firestore, userId) => {
     try {
         const docRef = firestore.collection('dev_overrides').doc(userId);
-
         const docSnapshot = await docRef.get();
-        return docSnapshot.exists;
+        
+        // Check both that document exists AND enabled === true
+        if (!docSnapshot.exists) {
+            return false;
+        }
+        
+        const data = docSnapshot.data();
+        return data?.enabled === true;
     }
     catch (error) {
         console.error(`Error checking developer status: ${error}`);
         throw error;
-
     }
 };
 

package/functions/api-v2/routes/alerts.js

@@ -47,11 +47,15 @@ router.get('/types', async (req, res, next) => {
         // Check if user is a developer
         const isDev = await isDeveloper(db, String(req.targetUserId));
         
+        logger?.log('INFO', `[GET /alerts/types] User ${req.targetUserId} isDeveloper: ${isDev}, loaded ${alertTypes.length} total alert types`);
+        
         // Filter out test alerts for non-developers
         const filteredAlertTypes = isDev 
             ? alertTypes 
             : alertTypes.filter(type => !type.isTest);
         
+        logger?.log('INFO', `[GET /alerts/types] After filtering: ${filteredAlertTypes.length} alert types (removed ${alertTypes.length - filteredAlertTypes.length} test alerts)`);
+        
         // Format response for frontend
         const formattedTypes = filteredAlertTypes.map(type => ({
             id: type.id,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bulltrackers-module",
-  "version": "1.0.680",
+  "version": "1.0.682",
   "description": "Helper Functions for Bulltrackers.",
   "main": "index.js",
   "files": [