bulltrackers-module 1.0.605 → 1.0.607

package/functions/api-v2/helpers/data-fetchers/firestore.js

@@ -1846,7 +1846,84 @@ const getSyncStatus = async (db, targetId) => {
     const isProcessingState = processingStates.includes(currentStatus);
     
     if (isProcessingState) {
-        // Check age of request
+        // First, check if computation results exist (computation may have completed but status wasn't updated)
+        // This is especially important for "computing" status
+        if (currentStatus === 'computing' || currentStatus === 'indexing') {
+            try {
+                const today = new Date().toISOString().split('T')[0];
+                const userType = data.userType || 'SIGNED_IN_USER';
+                
+                // Determine which computation to check based on user type
+                let computationNames = [];
+                if (userType === 'POPULAR_INVESTOR') {
+                    computationNames = ['PopularInvestorProfileMetrics'];
+                    // Check if also a signed-in user
+                    try {
+                        await isSignedInUser(db, targetId);
+                        computationNames.push('SignedInUserPIPersonalizedMetrics');
+                    } catch (e) {
+                        // Not a signed-in user
+                    }
+                } else {
+                    computationNames = ['SignedInUserProfileMetrics'];
+                    // Check if also a PI
+                    try {
+                        await fetchPopularInvestorMasterList(db, String(targetId));
+                        computationNames.push('SignedInUserPIPersonalizedMetrics', 'PopularInvestorProfileMetrics');
+                    } catch (e) {
+                        // Not a PI
+                    }
+                }
+                
+                // Check if any computation results exist for today
+                let computationFound = false;
+                for (const compName of computationNames) {
+                    try {
+                        const pageRef = db.collection('unified_insights')
+                            .doc(today)
+                            .collection('results')
+                            .doc('popular-investor')
+                            .collection('computations')
+                            .doc(compName)
+                            .collection('pages')
+                            .doc(String(targetId));
+                        
+                        const pageSnap = await pageRef.get();
+                        if (pageSnap.exists) {
+                            computationFound = true;
+                            break;
+                        }
+                    } catch (error) {
+                        // Continue checking other computations
+                        console.error(`Error checking computation ${compName} for ${today}:`, error);
+                    }
+                }
+                
+                // If computation results exist, mark as completed
+                if (computationFound) {
+                    await doc.ref.update({
+                        status: 'completed',
+                        completedAt: new Date(),
+                        updatedAt: new Date()
+                    });
+                    
+                    return {
+                        requestId: requestId,
+                        status: 'completed',
+                        type: data.userType,
+                        createdAt: data.createdAt ? (data.createdAt.toDate ? data.createdAt.toDate().toISOString() : (data.createdAt.toISOString ? data.createdAt.toISOString() : data.createdAt)) : null,
+                        updatedAt: new Date().toISOString(),
+                        completedAt: new Date().toISOString(),
+                        canRequest: true
+                    };
+                }
+            } catch (error) {
+                // If error checking computation results, continue with timeout check
+                console.error(`[getSyncStatus] Error checking computation results:`, error);
+            }
+        }
+        
+        // Check age of request for timeout
         const createdAt = data.createdAt;
         const updatedAt = data.updatedAt;
         

package/functions/api-v2/middleware/identity_middleware.js

@@ -20,10 +20,12 @@ const PUBLIC_ROUTES = [
     '/popular-investors/categories',
     '/popular-investors/master-list',
     '/popular-investors/search',
+    '/popular-investors/profile', // Public PI profiles - userCid optional for personalization
     '/verification/lookup', // Uses Firebase Auth token instead of userCid
     '/alerts/types', // Static data - doesn't need userCid
     '/alerts/dynamic-watchlist-computations', // Static data - doesn't need userCid
-    '/popular-investors/track-view' // Optional userCid - can track views anonymously
+    '/popular-investors/track-view', // Optional userCid - can track views anonymously
+    '/reviews' // Public reviews - userCid optional (for showing current user's review)
 ];
 
 const isPublicRoute = (path, originalUrl) => {
@@ -36,10 +38,21 @@ const isPublicRoute = (path, originalUrl) => {
         if (fullPath === route || fullPath.includes(route)) {
             return true;
         }
-        // Pattern match for routes with parameters (e.g., /popular-investors/:piId/track-view)
+        // Pattern match for routes with parameters
+        // /popular-investors/:piId/profile or /popular-investors/:piId/track-view
+        if (route.includes('/profile') && fullPath.includes('/profile')) {
+            return true;
+        }
         if (route.includes('/track-view') && fullPath.includes('/track-view')) {
             return true;
         }
+        // /reviews/:piId (but not /reviews/me or /reviews/:piId/eligibility)
+        if (route === '/reviews' && fullPath.startsWith('/reviews/')) {
+            // Exclude /reviews/me (requires auth) and /reviews/:piId/eligibility (requires auth)
+            if (!fullPath.startsWith('/reviews/me') && !fullPath.includes('/eligibility')) {
+                return true;
+            }
+        }
     }
     
     return false;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bulltrackers-module",
-  "version": "1.0.605",
+  "version": "1.0.607",
   "description": "Helper Functions for Bulltrackers.",
   "main": "index.js",
   "files": [