bulltrackers-module 1.0.602 → 1.0.604

package/functions/api-v2/helpers/data-fetchers/firestore.js

@@ -1935,39 +1935,51 @@ const checkDataStatus = async (db, userId) => {
     let computationDate = null;
     let fallbackWindowExhausted = false;
     
-    // Determine which computation to check based on user type
-    let computationName = 'SignedInUserProfileMetrics';
+    // Determine which computations to check based on user type
+    // Signed-in users always have SignedInUserProfileMetrics
+    // If they're also a PI, they may have SignedInUserPIPersonalizedMetrics
+    const computationNames = ['SignedInUserProfileMetrics'];
     try {
         await fetchPopularInvestorMasterList(db, userId);
-        computationName = 'SignedInUserPIPersonalizedMetrics';
+        // User is a PI, also check for PI-specific computation
+        computationNames.push('SignedInUserPIPersonalizedMetrics');
     } catch (e) {
-        // User is not a PI, use default
+        // User is not a PI, only check SignedInUserProfileMetrics
     }
     
     // Check for computation results in the last 7 days
+    // Check all relevant computation names for this user
     for (let i = 0; i < lookbackDays; i++) {
         const checkDate = new Date(today);
         checkDate.setDate(checkDate.getDate() - i);
         const dateStr = checkDate.toISOString().split('T')[0];
         
-        try {
-            const pageRef = db.collection('unified_insights')
-                .doc(dateStr)
-                .collection('results')
-                .doc('popular-investor')
-                .collection('computations')
-                .doc(computationName)
-                .collection('pages')
-                .doc(String(userId));
-            
-            const pageSnap = await pageRef.get();
-            if (pageSnap.exists) {
-                computationDate = dateStr;
-                break;
+        // Check each computation name
+        for (const compName of computationNames) {
+            try {
+                const pageRef = db.collection('unified_insights')
+                    .doc(dateStr)
+                    .collection('results')
+                    .doc('popular-investor')
+                    .collection('computations')
+                    .doc(compName)
+                    .collection('pages')
+                    .doc(String(userId));
+                
+                const pageSnap = await pageRef.get();
+                if (pageSnap.exists) {
+                    computationDate = dateStr;
+                    break;
+                }
+            } catch (error) {
+                // Continue checking other dates/computations
+                console.error(`Error checking computation ${compName} for ${dateStr}:`, error);
             }
-        } catch (error) {
-            // Continue checking other dates
-            console.error(`Error checking computation for ${dateStr}:`, error);
+        }
+        
+        // If we found a computation date, stop checking
+        if (computationDate) {
+            break;
         }
     }
     

package/functions/api-v2/routes/index.js

@@ -31,5 +31,17 @@ module.exports = (dependencies) => {
     router.use('/settings', settingsRoutes);
     router.use('/reviews', reviewsRoutes);
 
+    // Legacy route: /user/:userId/sync -> forwards to sync/request logic
+    // This maintains backward compatibility with frontend calls
+    router.post('/user/:userId/sync', async (req, res) => {
+        // Import sync handler (need to require it here to get the exported function)
+        const { handleSyncRequest } = require('./sync.js');
+        // Set targetId from URL param for the handler
+        req.body = req.body || {};
+        req.body.targetId = req.params.userId;
+        // Call the sync request handler
+        await handleSyncRequest(req, res);
+    });
+
     return router;
 };

package/functions/api-v2/routes/sync.js

@@ -11,12 +11,14 @@ const {
 
 const router = express.Router();
 
-// POST /sync/request (Unified - Auto-detects user type)
-router.post('/request', async (req, res) => {
+// Helper function for sync request logic (shared between /sync/request and /user/:userId/sync)
+const handleSyncRequest = async (req, res) => {
     try {
         const { pubsub, db } = req.dependencies;
         // targetId can be passed (for PIs) or default to self
-        const targetId = req.body.targetId || req.targetUserId;
+        // For /user/:userId/sync, targetId comes from URL param
+        // For /sync/request, targetId comes from body or req.targetUserId
+        const targetId = req.body.targetId || req.params.userId || req.targetUserId;
         
         // 1. Rate Limits
         const isDev = await isDeveloper(db, req.targetUserId);
@@ -107,6 +109,8 @@ router.post('/request', async (req, res) => {
         res.json({ 
             success: true, 
             requestIds,
+            requestId: requestIds[0], // Return first request ID for backward compatibility
+            status: 'queued',
             userTypes: {
                 isSignedInUser: isSignedIn,
                 isPopularInvestor: isPI
@@ -116,7 +120,10 @@ router.post('/request', async (req, res) => {
     } catch (error) {
         res.status(500).json({ error: error.message });
     }
-});
+};
+
+// POST /sync/request (Unified - Auto-detects user type)
+router.post('/request', handleSyncRequest);
 
 // GET /sync/status/:targetId
 router.get('/status/:targetId', async (req, res) => {
@@ -129,4 +136,6 @@ router.get('/status/:targetId', async (req, res) => {
     }
 });
 
-module.exports = router;
+// Export handler for use in main router
+module.exports = router;
+module.exports.handleSyncRequest = handleSyncRequest;

package/functions/computation-system/helpers/computation_worker.js

@@ -244,7 +244,12 @@ async function handleComputationTask(message, config, dependencies) {
                     computation,
                     getComputationDisplayName(computation),
                     true,
-                    null
+                    null,
+                    {
+                        collectionRegistry: dependencies.collectionRegistry,
+                        config: config,
+                        notificationType: 'userActionCompletions'
+                    }
                 );
             } catch (notifError) {
                 // Non-critical, log and continue
@@ -291,7 +296,12 @@ async function handleComputationTask(message, config, dependencies) {
                         computation,
                         getComputationDisplayName(computation),
                         false,
-                        err.message
+                        err.message,
+                        {
+                            collectionRegistry: dependencies.collectionRegistry,
+                            config: config,
+                            notificationType: 'userActionCompletions'
+                        }
                     );
                 } catch (notifError) {
                     // Non-critical, log and continue

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bulltrackers-module",
-  "version": "1.0.602",
+  "version": "1.0.604",
   "description": "Helper Functions for Bulltrackers.",
   "main": "index.js",
   "files": [