bulltrackers-module 1.0.568 → 1.0.569

package/functions/orchestrator/helpers/update_helpers.js

@@ -42,17 +42,47 @@ async function getUpdateTargets(userType, thresholds, config, dependencies) {
 
 /**
  * Sub-pipe: pipe.orchestrator.dispatchUpdates
+ * UPDATED: Added real-time validation to skip users already updated today.
  */
 async function dispatchUpdates(targets, userType, config, dependencies) {
-    const { logger, pubsubUtils } = dependencies;
+    const { logger, pubsubUtils, db } = dependencies;
     const { dispatcherTopicName, taskBatchSize, pubsubBatchSize } = config;
     
-    if (targets.length === 0) { 
-        logger.log('INFO', `[Orchestrator Helpers] No ${userType} update targets to dispatch.`); 
-        return; 
-    }
+    if (targets.length === 0) return;
+
+    // --- NEW VALIDATION BLOCK ---
+    const startOfToday = new Date();
+    startOfToday.setUTCHours(0, 0, 0, 0);
+    
+    logger.log('INFO', `[Orchestrator Validation] Verifying ${targets.length} targets for ${userType}...`);
     
-    logger.log('INFO', `[Orchestrator Helpers] Dispatching ${targets.length} update tasks for ${userType} to ${dispatcherTopicName}...`);
+    const validTargets = [];
+    for (const target of targets) {
+        const cid = target.userId || target.cid || (typeof target === 'string' ? target : null);
+        if (!cid) { validTargets.push(target); continue; }
+
+        // Check the actual Firestore record for today's completion
+        const collection = userType === 'popular_investor' ? 'PopularInvestors' : 
+                           userType === 'signed_in_user' ? 'SignedInUsers' : 'NormalUsers';
+        
+        const doc = await db.collection(collection).doc(String(cid)).get();
+        const lastUpdated = doc.data()?.lastUpdated?.updatedAt?.toDate?.() || 
+                           doc.data()?.lastUpdate?.toDate?.();
+
+        if (lastUpdated && lastUpdated >= startOfToday) {
+            logger.log('TRACE', `[Orchestrator Validation] Skipping ${cid} - Already updated today.`);
+            continue;
+        }
+        validTargets.push(target);
+    }
+
+    if (validTargets.length === 0) {
+        logger.log('INFO', `[Orchestrator Helpers] All ${targets.length} targets already updated. Skipping dispatch.`);
+        return;
+    }
+    // --- END VALIDATION BLOCK ---
+
+    logger.log('INFO', `[Orchestrator Helpers] Dispatching ${validTargets.length} validated update tasks for ${userType}...`);
     
     const individualTasks = targets.map(target => {
         let task = { userType };

package/functions/task-engine/handler_creator.js

@@ -133,7 +133,7 @@ async function handleRequest(message, context, configObj, dependencies) {
             if (updateTasksCount > 0) {
                 try {
                     // This batch counter is critical for triggering the Root Data Indexer
-                    batchCounterRef = db.collection('task_engine_batch_counters').doc(`${today}-${taskId}`);
+                    batchCounterRef = db.collection('system_task_counts').doc(`${today}-${taskId}`);
                     await batchCounterRef.set({
                         totalTasks: updateTasksCount,
                         remainingTasks: updateTasksCount,

package/functions/task-engine/helpers/popular_investor_helpers.js

@@ -308,7 +308,7 @@ async function handleGenericUserUpdate(taskData, config, dependencies, isPI) {
         
         // 5. Batch Counter Decrement (Critical for Scheduled Runs)
         if (batchCounterId) {
-             const counterRef = db.collection('task_engine_batch_counters').doc(batchCounterId);
+             const counterRef = db.collection('system_task_counts').doc(batchCounterId);
              await counterRef.update({ remainingTasks: FieldValue.increment(-1) });
              
              // Check if we need to trigger root indexer for the batch

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bulltrackers-module",
-  "version": "1.0.568",
+  "version": "1.0.569",
   "description": "Helper Functions for Bulltrackers.",
   "main": "index.js",
   "files": [