bulltrackers-module 1.0.558 → 1.0.559

package/functions/generic-api/user-api/helpers/dev/dev_helpers.js

@@ -290,6 +290,9 @@ async function getDevOverrideStatus(req, res, dependencies, config) {
  * Get the effective CID to use for a developer account
  * Returns impersonateCid if set, otherwise returns the actual userCid
  * Only works for developer accounts
+ * 
+ * Note: If pretendToBePI is false, impersonation will not be used for PI-related checks
+ * to prevent unintended impersonation when the user doesn't want to pretend to be a PI
  */
 async function getEffectiveCid(db, userCid, config, logger = null) {
     if (!isDeveloperAccount(userCid)) {
@@ -297,8 +300,20 @@ async function getEffectiveCid(db, userCid, config, logger = null) {
     }
     
     const devOverride = await getDevOverride(db, userCid, config, logger);
-    // Only use impersonation if dev override is enabled
+    // Only use impersonation if dev override is enabled AND impersonateCid is set
+    // BUT: If pretendToBePI is explicitly false, don't use impersonation (user doesn't want to be treated as PI)
     if (devOverride && devOverride.enabled && devOverride.impersonateCid) {
+        // Check if user explicitly doesn't want to pretend to be a PI
+        // If pretendToBePI is false, don't use impersonation (respects user intent)
+        if (devOverride.pretendToBePI === false) {
+            if (logger && logger.log) {
+                logger.log('INFO', `[getEffectiveCid] DEV OVERRIDE: User ${userCid} has impersonateCid set but pretendToBePI=false, using actual CID ${userCid} instead`);
+            } else {
+                console.log(`[getEffectiveCid] DEV OVERRIDE: User ${userCid} has impersonateCid set but pretendToBePI=false, using actual CID ${userCid} instead`);
+            }
+            return Number(userCid);
+        }
+        
         if (logger && logger.log) {
             logger.log('INFO', `[getEffectiveCid] DEV OVERRIDE: User ${userCid} impersonating CID ${devOverride.impersonateCid}`);
         } else {

package/functions/generic-api/user-api/helpers/metrics/personalized_metrics_helpers.js

@@ -96,8 +96,19 @@ async function getSignedInUserPIPersonalizedMetrics(req, res, dependencies, conf
     }
     
     try {
-        const effectiveCid = await getEffectiveCid(db, userCid, config, logger);
         const devOverride = await getDevOverride(db, userCid, config, logger);
+        
+        // For PI-related checks, respect pretendToBePI flag
+        // If pretendToBePI is false, use actual userCid even if impersonateCid is set
+        let effectiveCid;
+        if (devOverride && devOverride.enabled && devOverride.pretendToBePI === false) {
+            // User explicitly doesn't want to pretend to be a PI, use actual CID
+            effectiveCid = Number(userCid);
+        } else {
+            // Use normal effective CID logic (may use impersonateCid if set)
+            effectiveCid = await getEffectiveCid(db, userCid, config, logger);
+        }
+        
         const isImpersonating = devOverride && devOverride.enabled && devOverride.impersonateCid && effectiveCid !== Number(userCid);
         
         // Check if user is a PI

package/functions/generic-api/user-api/helpers/profile/user_profile_helpers.js

@@ -128,8 +128,19 @@ async function checkIfUserIsPopularInvestor(req, res, dependencies, config) {
     
     try {
         // Check for dev override impersonation
-        const effectiveCid = await getEffectiveCid(db, userCid, config, logger);
         const devOverride = await getDevOverride(db, userCid, config, logger);
+        
+        // For PI-related checks, respect pretendToBePI flag
+        // If pretendToBePI is false, use actual userCid even if impersonateCid is set
+        let effectiveCid;
+        if (devOverride && devOverride.enabled && devOverride.pretendToBePI === false) {
+            // User explicitly doesn't want to pretend to be a PI, use actual CID
+            effectiveCid = Number(userCid);
+        } else {
+            // Use normal effective CID logic (may use impersonateCid if set)
+            effectiveCid = await getEffectiveCid(db, userCid, config, logger);
+        }
+        
         const isImpersonating = devOverride && devOverride.enabled && devOverride.impersonateCid && effectiveCid !== Number(userCid);
         
         // Use effective CID (impersonated or actual) to check PI status

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bulltrackers-module",
-  "version": "1.0.558",
+  "version": "1.0.559",
   "description": "Helper Functions for Bulltrackers.",
   "main": "index.js",
   "files": [