bulltrackers-module 1.0.533 → 1.0.535

package/functions/task-engine/handler_creator.js

@@ -257,7 +257,13 @@ async function handleRequest(message, context, configObj, dependencies) {
         }
 
     } catch (err) {
-        logger.log('ERROR', `[TaskEngine] Error processing task ${type}.`, { error: err.message });
+        const errorMessage = err.message || String(err);
+        const errorStack = err.stack || '';
+        logger.log('ERROR', `[TaskEngine] Error processing task ${type}: ${errorMessage}`, { 
+            error: errorMessage,
+            stack: errorStack,
+            taskType: type
+        });
     }
 }
 

package/functions/task-engine/helpers/popular_investor_helpers.js

@@ -27,17 +27,26 @@ async function fetchWithRetry(url, options, proxyManager, logger, label) {
             if (res.ok) {
                 recordProxyOutcome(true);
                 return res;
+            } else {
+                // Log proxy failure with details
+                const errorText = await res.text().catch(() => 'Unable to read response');
+                logger.log('WARN', `[${label}] Proxy returned status ${res.status} for ${url}. Response: ${errorText.substring(0, 200)}`);
+                recordProxyOutcome(false);
             }
         } catch (e) {
             recordProxyOutcome(false);
-            logger.log('WARN', `[${label}] Proxy failed. Retrying direct.`);
+            logger.log('WARN', `[${label}] Proxy failed for ${url}: ${e.message}. Retrying direct.`);
         }
     }
     
     // Fallback
     const directFetch = typeof fetch !== 'undefined' ? fetch : require('node-fetch');
     const res = await directFetch(url, options);
-    if (!res.ok) throw new Error(`Fetch failed: ${res.status}`);
+    if (!res.ok) {
+        const errorText = await res.text().catch(() => 'Unable to read response');
+        logger.log('ERROR', `[${label}] Direct fetch failed for ${url}: Status ${res.status}. Response: ${errorText.substring(0, 200)}`);
+        throw new Error(`Fetch failed: ${res.status} ${res.statusText} - ${errorText.substring(0, 100)}`);
+    }
     return res;
 }
 
@@ -57,6 +66,8 @@ async function processPortfolio(context, config, taskData, isPI) {
     const { cid, username, uuid, today, requestOptions } = taskData;
     const url = `${config.ETORO_API_PORTFOLIO_URL}?cid=${cid}&client_request_id=${uuid}`;
     
+    logger.log('INFO', `[Portfolio] Fetching ${isPI ? 'PI' : 'Signed-In User'} portfolio from: ${url}`);
+    
     const res = await fetchWithRetry(url, requestOptions, proxyManager, logger, 'Portfolio');
     const data = await res.json();
     data.fetchedAt = new Date();
@@ -235,15 +246,26 @@ async function handleGenericUserUpdate(taskData, config, dependencies, isPI) {
         }
 
     } catch (err) {
-        logger.log('ERROR', `[Update] Failed for ${username}`, err);
+        // Log error with full details
+        const errorMessage = err.message || String(err);
+        const errorStack = err.stack || '';
+        logger.log('ERROR', `[Update] Failed for ${username}: ${errorMessage}`, {
+            error: errorMessage,
+            stack: errorStack,
+            cid,
+            username,
+            requestId,
+            isPI
+        });
+        
         // Mark Failed
         if (requestId && db) {
             const reqRef = db.collection(source === 'on_demand_sync' ? 'user_sync_requests' : 'pi_fetch_requests')
                            .doc(String(cid)).collection('requests').doc(requestId);
-            await reqRef.update({ status: 'failed', error: err.message, failedAt: FieldValue.serverTimestamp() });
+            await reqRef.update({ status: 'failed', error: errorMessage, failedAt: FieldValue.serverTimestamp() });
             
             if (metadata?.requestingUserCid) {
-                notifyTaskEngineComplete(db, logger, metadata.requestingUserCid, requestId, username, false, err.message).catch(()=>{});
+                notifyTaskEngineComplete(db, logger, metadata.requestingUserCid, requestId, username, false, errorMessage).catch(()=>{});
             }
         }
         throw err;
@@ -427,7 +449,9 @@ async function handlePopularInvestorUpdate(taskData, config, dependencies) {
 }
 
 async function handleOnDemandUserUpdate(taskData, config, dependencies) {
-    config.ETORO_API_PORTFOLIO_URL = config.ETORO_API_PORTFOLIO_URL || 'https://www.etoro.com/sapi/portfolios/portfolio';
+    // Use the same public portfolio endpoint as PIs - signed-in users can also use public endpoints
+    // The endpoint /sapi/portfolios/portfolio doesn't exist (404)
+    config.ETORO_API_PORTFOLIO_URL = config.ETORO_API_PORTFOLIO_URL || 'https://www.etoro.com/sapi/trade-data-real/live/public/portfolios';
     config.ETORO_API_HISTORY_URL = config.ETORO_API_HISTORY_URL || 'https://www.etoro.com/sapi/trade-data-real/history/public/credit/flat';
 
     return handleGenericUserUpdate(taskData, config, dependencies, false);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bulltrackers-module",
-  "version": "1.0.533",
+  "version": "1.0.535",
   "description": "Helper Functions for Bulltrackers.",
   "main": "index.js",
   "files": [