bulltrackers-module 1.0.524 → 1.0.525

package/functions/alert-system/helpers/alert_helpers.js

@@ -65,21 +65,25 @@ async function processAlertForPI(db, logger, piCid, alertType, computationMetada
       };
       
       // Use writeWithMigration to write to new path (with legacy fallback)
+      // notifications is a subcollection, so we need isCollection: true and documentId
       const writePromise = writeWithMigration(
         db,
         'signedInUsers',
         'notifications',
-        { cid: String(userCid), notificationId },
+        { cid: String(userCid) },
         notificationData,
         {
-          isCollection: false,
+          isCollection: true,
           merge: false,
           dataType: 'notifications',
+          documentId: notificationId,
+          dualWrite: false, // Disable dual write - we're fully migrated to new path
           config,
           collectionRegistry
         }
       ).catch(err => {
-        logger.log('WARN', `[processAlertForPI] Failed to write notification for CID ${userCid}: ${err.message}`);
+        logger.log('ERROR', `[processAlertForPI] Failed to write notification for CID ${userCid}: ${err.message}`, err);
+        throw err; // Re-throw so we know if writes are failing
       });
       
       notificationPromises.push(writePromise);

package/functions/alert-system/index.js

@@ -406,17 +406,20 @@ async function sendAllClearNotification(db, logger, userCid, piCid, piUsername,
     };
     
     // Use writeWithMigration to write to new path (with legacy fallback)
+    // notifications is a subcollection, so we need isCollection: true and documentId
     const { writeWithMigration } = require('../generic-api/user-api/helpers/core/path_resolution_helpers');
     await writeWithMigration(
       db,
       'signedInUsers',
       'notifications',
-      { cid: String(userCid), notificationId },
+      { cid: String(userCid) },
       notificationData,
       {
-        isCollection: false,
+        isCollection: true,
         merge: false,
         dataType: 'notifications',
+        documentId: notificationId,
+        dualWrite: false, // Disable dual write - we're fully migrated to new path
         config,
         collectionRegistry
       }

package/functions/generic-api/user-api/helpers/alerts/test_alert_helpers.js

@@ -155,21 +155,25 @@ async function sendTestAlert(req, res, dependencies, config) {
             };
             
             // Use writeWithMigration to write to new path (with legacy fallback)
+            // notifications is a subcollection, so we need isCollection: true and documentId
             const writePromise = writeWithMigration(
                 db,
                 'signedInUsers',
                 'notifications',
-                { cid: String(targetCid), notificationId },
+                { cid: String(targetCid) },
                 notificationData,
                 {
-                    isCollection: false,
+                    isCollection: true,
                     merge: false,
                     dataType: 'notifications',
+                    documentId: notificationId,
+                    dualWrite: false, // Disable dual write - we're fully migrated to new path
                     config,
                     collectionRegistry
                 }
             ).catch(err => {
-                logger.log('WARN', `[sendTestAlert] Failed to write notification for CID ${targetCid}: ${err.message}`);
+                logger.log('ERROR', `[sendTestAlert] Failed to write notification for CID ${targetCid}: ${err.message}`, err);
+                throw err; // Re-throw so we know if writes are failing
             });
             
             notificationPromises.push(writePromise);

package/functions/generic-api/user-api/helpers/core/path_resolution_helpers.js

@@ -469,10 +469,21 @@ async function writeWithMigration(db, category, subcategory, params, data, optio
     // Get legacy path if dual write is enabled
     let legacyPath = null;
     if (dualWrite && dataType && userCid) {
-        const { resolvePath: resolve } = getRegistryFunctions(registryOptions);
-        legacyPath = getLegacyPath(dataType, userCid, config, params, null, null, registryOptions);
-        if (legacyPath) {
-            legacyPath = resolve(legacyPath, params);
+        try {
+            const registryFuncs = getRegistryFunctions(registryOptions);
+            const resolve = registryFuncs?.resolvePath;
+            legacyPath = getLegacyPath(dataType, userCid, config, params, null, null, registryOptions);
+            if (legacyPath && resolve && typeof resolve === 'function') {
+                legacyPath = resolve(legacyPath, params);
+            } else if (legacyPath) {
+                // If resolve is not available, manually replace placeholders
+                for (const [key, value] of Object.entries(params)) {
+                    legacyPath = legacyPath.replace(`{${key}}`, String(value));
+                }
+            }
+        } catch (error) {
+            console.warn('[writeWithMigration] Could not resolve legacy path, skipping dual write:', error.message);
+            legacyPath = null; // Skip dual write if we can't resolve legacy path
         }
     }
     

package/functions/generic-api/user-api/helpers/notifications/notification_helpers.js

@@ -127,17 +127,20 @@ async function sendOnDemandNotification(db, logger, userCid, type, title, messag
         };
         
         // Write using collection registry
+        // notifications is a subcollection, so we need isCollection: true and documentId
         if (collectionRegistry) {
             await writeWithMigration(
                 db,
                 'signedInUsers',
                 'notifications',
-                { cid: String(userCid), notificationId },
+                { cid: String(userCid) },
                 notificationData,
                 {
-                    isCollection: false,
+                    isCollection: true,
                     merge: false,
                     dataType: 'notifications',
+                    documentId: notificationId,
+                    dualWrite: false, // Disable dual write - we're fully migrated to new path
                     config,
                     collectionRegistry
                 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bulltrackers-module",
-  "version": "1.0.524",
+  "version": "1.0.525",
   "description": "Helper Functions for Bulltrackers.",
   "main": "index.js",
   "files": [