bulltrackers-module 1.0.447 → 1.0.448

package/functions/computation-system/workflows/datafeederpipelineinstructions.md

@@ -0,0 +1,32 @@
+Below is a quick-reference guide for testing the **Data Feeder Pipeline** using the Google Cloud Console UI.
+
+---
+
+# 🧪 Workflow Testing Guide
+
+When triggering a manual execution in the **GCP Workflows Console**, use the following JSON objects in the **Input** field to bypass the schedule and test specific components.
+
+### How to Run a Test
+
+1. Go to the **Workflows** page in your GCP Console.
+2. Click on `data-feeder-pipeline`.
+3. Click the **Execute** button at the top.
+4. Paste the relevant **JSON Input** from the table below into the input box.
+
+### Test Commands
+
+| Component to Test | JSON Input | Description |
+| --- | --- | --- |
+| **Market Data** | `{"target_step": "market"}` | Runs `price-fetcher`, `insights-fetcher`, and `market-data-indexer`. |
+| **Rankings** | `{"target_step": "rankings"}` | Runs the `fetch-popular-investors` function specifically. |
+| **Social Orchestrator** | `{"target_step": "social"}` | Runs the midnight social task and the midnight data indexer. |
+| **Global Sync** | `{"target_step": "global"}` | Triggers the `root-data-indexer` with no target date (Full Scan). |
+| **Full Pipeline** | `{}` | Runs the entire 24-hour cycle from the beginning (Standard Run). |
+
+---
+
+### 💡 Pro-Tips for Testing
+
+* **Variable Checking:** After an execution finishes, click the **Details** tab in the execution logs to see the final values of variables like `sleep_midnight` or `sleep_loop` to verify the UTC alignment math worked correctly.
+* **Permissions:** Ensure your user account or the service account running the workflow has the `roles/workflows.invoker` role to trigger these tests.
+* **Timeouts:** If testing the full loop, remember that the workflow will "pause" at the `sys.sleep` steps. You can see the status as **Active** while it waits for the next 3-hour window.

package/functions/generic-api/user-api/helpers/data_helpers.js

@@ -165,7 +165,7 @@ async function checkIfUserIsPI(db, userCid, config, logger = null) {
         const { getDevOverride } = require('./dev_helpers');
         const devOverride = await getDevOverride(db, userCid, config, logger);
         
-        if (devOverride && devOverride.pretendToBePI) {
+        if (devOverride && devOverride.enabled && devOverride.pretendToBePI) {
             // Generate fake ranking entry for dev testing
             const fakeRankEntry = {
                 CustomerId: Number(userCid),
@@ -588,7 +588,7 @@ async function getUserPortfolio(req, res, dependencies, config) {
         const { getEffectiveCid, getDevOverride } = require('./dev_helpers');
         const effectiveCid = await getEffectiveCid(db, userCid, config, logger);
         const devOverride = await getDevOverride(db, userCid, config, logger);
-        const isImpersonating = devOverride && devOverride.impersonateCid && effectiveCid !== Number(userCid);
+        const isImpersonating = devOverride && devOverride.enabled && devOverride.impersonateCid && effectiveCid !== Number(userCid);
         
         // If impersonating, check if the effective CID is a Popular Investor
         // PIs store data in pi_portfolios_overall, not signed_in_users
@@ -784,7 +784,7 @@ async function getUserVerification(req, res, dependencies, config) {
         const { getEffectiveCid, getDevOverride } = require('./dev_helpers');
         const effectiveCid = await getEffectiveCid(db, userCid, config, logger);
         const devOverride = await getDevOverride(db, userCid, config, logger);
-        const isImpersonating = devOverride && devOverride.impersonateCid && effectiveCid !== Number(userCid);
+        const isImpersonating = devOverride && devOverride.enabled && devOverride.impersonateCid && effectiveCid !== Number(userCid);
         
         const { signedInUsersCollection } = config;
         
@@ -852,7 +852,7 @@ async function getUserComputations(req, res, dependencies, config) {
         const { getEffectiveCid, getDevOverride } = require('./dev_helpers');
         const effectiveCid = await getEffectiveCid(db, userCid, config, logger);
         const devOverride = await getDevOverride(db, userCid, config, logger);
-        const isImpersonating = devOverride && devOverride.impersonateCid && effectiveCid !== Number(userCid);
+        const isImpersonating = devOverride && devOverride.enabled && devOverride.impersonateCid && effectiveCid !== Number(userCid);
         
         const insightsCollection = config.unifiedInsightsCollection || 'unified_insights';
         const resultsSub = config.resultsSubcollection || 'results';
@@ -1884,7 +1884,7 @@ async function checkIfUserIsPopularInvestor(req, res, dependencies, config) {
         const { getEffectiveCid, getDevOverride } = require('./dev_helpers');
         const effectiveCid = await getEffectiveCid(db, userCid, config, logger);
         const devOverride = await getDevOverride(db, userCid, config, logger);
-        const isImpersonating = devOverride && devOverride.impersonateCid && effectiveCid !== Number(userCid);
+        const isImpersonating = devOverride && devOverride.enabled && devOverride.impersonateCid && effectiveCid !== Number(userCid);
         
         // Use effective CID (impersonated or actual) to check PI status
         const rankEntry = await checkIfUserIsPI(db, effectiveCid, config, logger);
@@ -1899,7 +1899,7 @@ async function checkIfUserIsPopularInvestor(req, res, dependencies, config) {
         }
         
         // Check if this is a dev override (pretendToBePI)
-        const isDevOverride = devOverride && devOverride.pretendToBePI;
+        const isDevOverride = devOverride && devOverride.enabled && devOverride.pretendToBePI;
         
         // Return ranking data
         return res.status(200).json({
@@ -2226,7 +2226,7 @@ async function getSignedInUserPIPersonalizedMetrics(req, res, dependencies, conf
         const { getEffectiveCid, getDevOverride } = require('./dev_helpers');
         const effectiveCid = await getEffectiveCid(db, userCid, config, logger);
         const devOverride = await getDevOverride(db, userCid, config, logger);
-        const isImpersonating = devOverride && devOverride.impersonateCid && effectiveCid !== Number(userCid);
+        const isImpersonating = devOverride && devOverride.enabled && devOverride.impersonateCid && effectiveCid !== Number(userCid);
         
         // Use effective CID (impersonated or actual) to check PI status
         const rankEntry = await checkIfUserIsPI(db, effectiveCid, config, logger);
@@ -2240,7 +2240,7 @@ async function getSignedInUserPIPersonalizedMetrics(req, res, dependencies, conf
         }
         
         // Check if this is a dev override (pretendToBePI)
-        const isDevOverride = devOverride && devOverride.pretendToBePI;
+        const isDevOverride = devOverride && devOverride.enabled && devOverride.pretendToBePI;
         
         // If dev override (pretendToBePI), generate sample data
         if (isDevOverride) {

package/functions/generic-api/user-api/helpers/dev_helpers.js

@@ -291,7 +291,8 @@ async function getEffectiveCid(db, userCid, config, logger = null) {
     }
     
     const devOverride = await getDevOverride(db, userCid, config, logger);
-    if (devOverride && devOverride.impersonateCid) {
+    // Only use impersonation if dev override is enabled
+    if (devOverride && devOverride.enabled && devOverride.impersonateCid) {
         if (logger && logger.log) {
             logger.log('INFO', `[getEffectiveCid] DEV OVERRIDE: User ${userCid} impersonating CID ${devOverride.impersonateCid}`);
         } else {

package/functions/generic-api/user-api/helpers/on_demand_fetch_helpers.js

@@ -32,7 +32,7 @@ async function requestPiFetch(req, res, dependencies, config) {
     const { getEffectiveCid, getDevOverride } = require('./dev_helpers');
     const effectiveCid = await getEffectiveCid(db, userCid, config, logger);
     const devOverride = await getDevOverride(db, userCid, config, logger);
-    const isImpersonating = devOverride && devOverride.impersonateCid && effectiveCid !== Number(userCid);
+    const isImpersonating = devOverride && devOverride.enabled && devOverride.impersonateCid && effectiveCid !== Number(userCid);
     
     // Use effective CID for the request (impersonated or actual)
     const requestUserCid = Number(effectiveCid);

package/functions/generic-api/user-api/helpers/review_helpers.js

@@ -189,7 +189,7 @@ async function submitReview(req, res, dependencies, config) {
         const { getEffectiveCid, getDevOverride } = require('./dev_helpers');
         const effectiveCid = await getEffectiveCid(db, userCid, config, logger);
         const devOverride = await getDevOverride(db, userCid, config, logger);
-        const isImpersonating = devOverride && devOverride.impersonateCid && effectiveCid !== Number(userCid);
+        const isImpersonating = devOverride && devOverride.enabled && devOverride.impersonateCid && effectiveCid !== Number(userCid);
         
         // Block self-reviews
         if (Number(effectiveCid) === Number(piCid)) {
@@ -403,7 +403,7 @@ async function checkReviewEligibility(req, res, dependencies, config) {
         const { getEffectiveCid, getDevOverride } = require('./dev_helpers');
         const effectiveCid = await getEffectiveCid(db, userCid, config, logger);
         const devOverride = await getDevOverride(db, userCid, config, logger);
-        const isImpersonating = devOverride && devOverride.impersonateCid && effectiveCid !== Number(userCid);
+        const isImpersonating = devOverride && devOverride.enabled && devOverride.impersonateCid && effectiveCid !== Number(userCid);
         
         // Block self-reviews (user cannot review themselves)
         if (Number(effectiveCid) === Number(piCid)) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bulltrackers-module",
-  "version": "1.0.447",
+  "version": "1.0.448",
   "description": "Helper Functions for Bulltrackers.",
   "main": "index.js",
   "files": [