bulltrackers-module 1.0.424 → 1.0.426

package/functions/generic-api/user-api/helpers/data_helpers.js

@@ -573,6 +573,24 @@ async function getUserPortfolio(req, res, dependencies, config) {
         const devOverride = await getDevOverride(db, userCid, config, logger);
         const isImpersonating = devOverride && devOverride.impersonateCid && effectiveCid !== Number(userCid);
         
+        // If impersonating, check if the effective CID is a Popular Investor
+        // PIs store data in pi_portfolios_overall, not signed_in_users
+        if (isImpersonating) {
+            const rankEntry = await checkIfUserIsPI(db, effectiveCid, config, logger);
+            if (rankEntry) {
+                // This is a PI being impersonated - they don't have signed_in_users portfolio data
+                // Return a helpful error indicating they should use the PI profile endpoint instead
+                return res.status(404).json({ 
+                    error: "Popular Investor account",
+                    message: `CID ${effectiveCid} is a Popular Investor. Use /user/me/pi-personalized-metrics or /user/pi/${effectiveCid}/profile instead.`,
+                    effectiveCid: effectiveCid,
+                    isImpersonating: true,
+                    isPopularInvestor: true,
+                    suggestedEndpoint: `/user/me/pi-personalized-metrics?userCid=${userCid}`
+                });
+            }
+        }
+        
         const { signedInUsersCollection } = config;
         const CANARY_BLOCK_ID = '19M';
         const today = new Date().toISOString().split('T')[0];
@@ -614,12 +632,15 @@ async function getUserPortfolio(req, res, dependencies, config) {
         }
         
         if (!portfolioData) {
-            return res.status(404).json({ error: "Portfolio data not found for this user" });
+            return res.status(404).json({ 
+                error: "Portfolio data not found in any part document",
+                effectiveCid: effectiveCid,
+                isImpersonating: isImpersonating || false
+            });
         }
         
         // Apply dev override to AggregatedMirrors if dev override is active
-        const { getDevOverride } = require('./dev_helpers');
-        const devOverride = await getDevOverride(db, userCid, config, logger);
+        // Note: devOverride is already available from earlier in the function (line 573)
         if (devOverride && devOverride.enabled && devOverride.fakeCopiedPIs.length > 0 && portfolioData.AggregatedMirrors) {
             logger.log('INFO', `[getUserPortfolio] Applying DEV OVERRIDE to AggregatedMirrors for user ${userCid}`);
             
@@ -973,13 +994,17 @@ async function autoGenerateWatchlist(req, res, dependencies, config) {
     }
     
     try {
+        // Check for dev override impersonation (for computation lookup)
+        const { getEffectiveCid, getCopiedPIsWithDevOverride } = require('./dev_helpers');
+        const effectiveCid = await getEffectiveCid(db, userCid, config, logger);
+        
         let copiedPIs = [];
         let dataSource = 'unknown';
         let isDevOverride = false;
         const today = new Date().toISOString().split('T')[0];
         
         // === DEV OVERRIDE CHECK (for developer accounts) ===
-        const { getCopiedPIsWithDevOverride } = require('./dev_helpers');
+        // Note: Use actual userCid for dev override check (dev override is about what PIs the developer "copies")
         const devResult = await getCopiedPIsWithDevOverride(db, userCid, config, logger);
         if (devResult.isDevOverride) {
             copiedPIs = devResult.copiedPIs;
@@ -990,12 +1015,14 @@ async function autoGenerateWatchlist(req, res, dependencies, config) {
         
         // === PRIMARY: Try to fetch from computation (cheaper/faster) ===
         // Only if dev override is not active
+        // Use effectiveCid for computation lookup (to support impersonation)
         if (!isDevOverride) {
             const insightsCollection = config.unifiedInsightsCollection || 'unified_insights';
             const category = 'signed_in_user';
             const computationName = 'SignedInUserCopiedPIs';
             
             // Try to find latest computation date (with fallback)
+            // Use effectiveCid for lookup (supports impersonation)
             const resultsSub = config.resultsSubcollection || 'results';
             const compsSub = config.computationsSubcollection || 'computations';
             const computationDate = await findLatestComputationDate(
@@ -1005,7 +1032,7 @@ async function autoGenerateWatchlist(req, res, dependencies, config) {
                 compsSub,
                 category, 
                 computationName, 
-                userCid, 
+                effectiveCid, 
                 30
             );
             

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bulltrackers-module",
-  "version": "1.0.424",
+  "version": "1.0.426",
   "description": "Helper Functions for Bulltrackers.",
   "main": "index.js",
   "files": [