bulltrackers-module 1.0.365 → 1.0.367

package/functions/computation-system/helpers/computation_dispatcher.js

@@ -35,34 +35,22 @@ async function filterActiveTasks(db, date, pass, tasks, logger, forceRun = false
             const data = snap.data();
             const isActive = ['PENDING', 'IN_PROGRESS'].includes(data.status);
 
-            // 1. ZOMBIE CHECK (Recover Stale Locks)
             if (isActive) {
                 const lastActivityTime = data.telemetry?.lastHeartbeat 
                     ? new Date(data.telemetry.lastHeartbeat).getTime() 
                     : (data.startedAt ? new Date(data.startedAt).getTime() : 0);
                 
-                const timeSinceActive = Date.now() - lastActivityTime;
-
-                if (timeSinceActive > STALE_LOCK_THRESHOLD_MS) {
+                if ((Date.now() - lastActivityTime) > STALE_LOCK_THRESHOLD_MS) {
                     if (logger) logger.log('WARN', `[Dispatcher] 🧟 Breaking stale lock for ${taskName}.`);
                     return t; 
                 }
                 return null; 
             }
-
-            // 2. COMPLETED CHECK (Ignore)
-            if (data.status === 'COMPLETED') return null; 
-
-            // 3. FAILED CHECK (Pass through to Route Splitter)
-            // We do NOT filter FAILED tasks here. We pass them to splitRoutes() 
-            // which decides if they get promoted to High-Mem or dropped forever.
-            if (data.status === 'FAILED') {
-                 return t; 
-            }
+            // Note: We do NOT filter COMPLETED here anymore for Sweep. 
+            // If the Orchestrator says it needs to run, we run it.
         }
         return t;
     });
-    
     const results = await Promise.all(checkPromises);
     return results.filter(t => t !== null);
 }
@@ -276,7 +264,6 @@ async function handleSweepDispatch(config, dependencies, computationManifest, re
         return { dispatched: 0 };
     }
 
-    // [CRITICAL UPDATE] FILTER FOR SWEEP:
     const validTasks = [];
     for (const task of pending) {
         const name = normalizeName(task.name);
@@ -286,28 +273,34 @@ async function handleSweepDispatch(config, dependencies, computationManifest, re
         if (doc.exists) {
             const data = doc.data();
             
-            // 1. ACTIVE CHECK: Don't double-dispatch if already running
+           // 1. ACTIVE CHECK: Don't double-dispatch if already running... UNLESS IT'S A ZOMBIE
             if (['PENDING', 'IN_PROGRESS'].includes(data.status)) {
-                 // Optional: Check for zombies here if needed, but usually Standard Dispatch handles that.
-                 logger.log('INFO', `[Sweep] ⏳ Skipping ${name} - Already IN_PROGRESS.`);
-                 continue;
-            }
+                const lastActivity = data.telemetry?.lastHeartbeat 
+                    ? new Date(data.telemetry.lastHeartbeat).getTime() 
+                    : (data.startedAt ? new Date(data.startedAt).getTime() : 0);
 
-            // 2. COMPLETION CHECK: Don't re-dispatch if already done (Ghost State protection)
-            if (data.status === 'COMPLETED') {
-                 // Only skip if the code hash matches (True Duplicate)
-                 // If hashes differ, it's a legitimate Re-Run that needs to happen.
-                 if (data.hash === task.hash) {
-                      logger.log('WARN', `[Sweep] 🛑 Skipping ${name} - Ledger says COMPLETED (Ghost State).`);
-                      continue;
-                 }
+                // If it's been silent for > 15 mins, it's a Zombie. Kill it and Re-run.
+                if ((Date.now() - lastActivity) > STALE_LOCK_THRESHOLD_MS) {
+                    logger.log('WARN', `[Sweep] 🧟 Found ZOMBIE lock for ${name}. Breaking lock and re-running.`);
+                    // Don't continue; let it fall through to dispatch
+                } else {
+                    logger.log('INFO', `[Sweep] ⏳ Skipping ${name} - Valid IN_PROGRESS.`);
+                    continue;
+                }
             }
+
+            // 2. COMPLETION CHECK (GHOST STATE FIX)
+            // We REMOVED the check that skips if (status === 'COMPLETED' && hash === task.hash).
+            // If we are here, 'analyzeDateExecution' (The Brain) decided this task is NOT done
+            // (likely due to a missing or outdated entry in computation_status).
+            // Even if the Ledger (The Log) says it finished, the system state is inconsistent.
+            // We MUST re-run to repair the Status Index.
             
             const stage = data.error?.stage;
             
             // 3. DETERMINISTIC FAILURE CHECK
             if (['QUALITY_CIRCUIT_BREAKER', 'SEMANTIC_GATE', 'SHARDING_LIMIT_EXCEEDED'].includes(stage)) {
-                 // [FIX] If the code hash has changed, ignore the previous failure and allow retry
+                 // If hash matches, it's the exact same code that failed before. Don't retry in loop.
                  if (data.hash === task.hash) {
                      logger.log('WARN', `[Sweep] 🛑 Skipping deterministic failure for ${name} (${stage}).`);
                      continue;
@@ -315,10 +308,13 @@ async function handleSweepDispatch(config, dependencies, computationManifest, re
                  logger.log('INFO', `[Sweep] 🔄 Code Updated for ${name}. Retrying sweep despite previous ${stage}.`);
              }
              
-             // 4. DEAD END CHECK
+             // 4. DEAD END CHECK (High Mem)
              if (data.resourceTier === 'high-mem' && data.status === 'FAILED') {
-                 logger.log('WARN', `[Sweep] 🛑 Skipping ${name} - Already failed on High-Mem.`);
-                 continue;
+                 // If code hasn't changed, don't hammer it.
+                 if (data.hash === task.hash) {
+                     logger.log('WARN', `[Sweep] 🛑 Skipping ${name} - Already failed on High-Mem.`);
+                     continue;
+                 }
              }
         }
         validTasks.push(task);
@@ -345,11 +341,7 @@ async function handleSweepDispatch(config, dependencies, computationManifest, re
             dispatchId: currentDispatchId,
             triggerReason: 'SWEEP_RECOVERY',
             resources: 'high-mem', // FORCE
-            traceContext: {
-                traceId: traceId,
-                spanId: spanId,
-                sampled: true
-            }
+            traceContext: { traceId, spanId, sampled: true }
         };
     });
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bulltrackers-module",
-  "version": "1.0.365",
+  "version": "1.0.367",
   "description": "Helper Functions for Bulltrackers.",
   "main": "index.js",
   "files": [