bulltrackers-module 1.0.325 → 1.0.326

package/functions/computation-system/helpers/computation_dispatcher.js

@@ -2,6 +2,7 @@
  * FILENAME: computation-system/helpers/computation_dispatcher.js
  * PURPOSE: Sequential Cursor-Based Dispatcher.
  * BEHAVIOR: Dispatch -> Wait ETA -> Next Date.
+ * UPDATED: Added "Zombie Protocol" to auto-recover stale locks.
  */
 
 const { getExpectedDateStrings, getEarliestDataDates, normalizeName, DEFINITIVE_EARLIEST_DATES } = require('../utils/utils.js');
@@ -15,10 +16,14 @@ const OOM_THRESHOLD_MB = 1500;
 const BASE_SECONDS_PER_WEIGHT_UNIT = 3;
 const SESSION_CACHE_DURATION_MS = 1000 * 60 * 30; // 30 Minutes
 
+// [NEW] Zombie Timeout: Max Cloud Function run is 9m (540s). 
+// If no heartbeat/start within 15m, it's definitely dead.
+const STALE_LOCK_THRESHOLD_MS = 1000 * 60 * 15; 
+
 // =============================================================================
-// HELPER: Ledger Awareness (Prevents Race Conditions)
+// HELPER: Ledger Awareness (Prevents Race Conditions & Clears Zombies)
 // =============================================================================
-async function filterActiveTasks(db, date, pass, tasks) {
+async function filterActiveTasks(db, date, pass, tasks, logger) {
     if (!tasks || tasks.length === 0) return [];
     
     const checkPromises = tasks.map(async (t) => {
@@ -28,13 +33,37 @@ async function filterActiveTasks(db, date, pass, tasks) {
         
         if (snap.exists) {
             const data = snap.data();
-            // Check PENDING, IN_PROGRESS, or "Ghost" (Completed < 1 min ago)
             const isActive = ['PENDING', 'IN_PROGRESS'].includes(data.status);
+
+            // 1. ZOMBIE CHECK (Recover Stale Locks)
+            if (isActive) {
+                // Prefer heartbeat, fall back to start time
+                const lastActivityTime = data.telemetry?.lastHeartbeat 
+                    ? new Date(data.telemetry.lastHeartbeat).getTime() 
+                    : (data.startedAt ? new Date(data.startedAt).getTime() : 0);
+                
+                const timeSinceActive = Date.now() - lastActivityTime;
+
+                if (timeSinceActive > STALE_LOCK_THRESHOLD_MS) {
+                    if (logger) {
+                        logger.log('WARN', `[Dispatcher] 🧟 Breaking stale lock for ${taskName}. Inactive for ${(timeSinceActive/60000).toFixed(1)} mins.`);
+                    }
+                    // Return task (Re-dispatching it will overwrite the old lock in Firestore)
+                    return t; 
+                }
+                
+                // If distinct and recent, filter it out (let it run)
+                return null; 
+            }
+
+            // 2. GHOST CHECK (Debounce immediate re-runs)
+            // If it finished less than 1 minute ago, don't re-dispatch immediately 
+            // (prevents double-tap if latency is high)
             const isJustFinished = data.status === 'COMPLETED' && 
                                    data.completedAt && 
                                    (Date.now() - new Date(data.completedAt).getTime() < 60 * 1000);
             
-            if (isActive || isJustFinished) return null; // Filter out
+            if (isJustFinished) return null; // Filter out
         }
         return t;
     });
@@ -110,7 +139,6 @@ async function getStableDateSession(config, dependencies, passToRun, dateLimitSt
         if (sessionSnap.exists) {
             const data = sessionSnap.data();
             if ((Date.now() - new Date(data.createdAt).getTime()) < SESSION_CACHE_DURATION_MS) {
-                // logger.log('INFO', `[Session] 📂 Loaded stable session for Pass ${passToRun}.`);
                 return data.dates;
             }
         }
@@ -184,8 +212,8 @@ async function dispatchComputationPass(config, dependencies, computationManifest
             if (rawTasks.length > 0) {
                 rawTasks = await attemptSimHashResolution(dependencies, selectedDate, rawTasks, dailyStatus, manifestMap);
                 
-                // Ledger Filter: Removes tasks that are already running
-                selectedTasks = await filterActiveTasks(db, selectedDate, passToRun, rawTasks);
+                // [UPDATED] Pass logger to filterActiveTasks for zombie warnings
+                selectedTasks = await filterActiveTasks(db, selectedDate, passToRun, rawTasks, logger);
             }
             
             // OOM / High-Mem Reroute Check
@@ -200,7 +228,6 @@ async function dispatchComputationPass(config, dependencies, computationManifest
 
     // 4. Dispatch Logic
     if (selectedTasks.length === 0) {
-        // Return 0 dispatched, FALSE cursor ignored -> Move to NEXT date immediately.
         return {
             status: 'CONTINUE_PASS',
             dateProcessed: selectedDate,
@@ -258,14 +285,11 @@ async function dispatchComputationPass(config, dependencies, computationManifest
     }
     await Promise.all(pubPromises);
 
-    // CRITICAL: We dispatched work. 
-    // We return n_cursor_ignored: FALSE.
-    // This tells the workflow to Wait ETA -> Increment Cursor -> Move to Next Date.
     return {
         status: 'CONTINUE_PASS',
         dateProcessed: selectedDate,
         dispatched: selectedTasks.length,
-        n_cursor_ignored: false, // FORCE NEXT DATE
+        n_cursor_ignored: false,
         etaSeconds: etaSeconds,
         remainingDates: sessionDates.length - targetCursorN
     };

package/functions/computation-system/tools/BuildReporter.js

@@ -2,6 +2,7 @@
  * FILENAME: bulltrackers-module/functions/computation-system/tools/BuildReporter.js
  * UPGRADED: Offloads heavy logic to a dedicated Cloud Function via Pub/Sub.
  * FEATURES: Patch versioning, data-drift detection (window changes), and checkpointed writes.
+ * FIX: Ensures ALL dates in the window are reported, even if analysis fails.
  */
 
 const { analyzeDateExecution } = require('../WorkflowOrchestrator');
@@ -62,7 +63,7 @@ async function handleBuildReportTrigger(message, context, config, dependencies,
 function getSystemFingerprint(manifest) {
     const sortedManifestHashes = manifest.map(c => c.hash).sort().join('|');
     return crypto.createHash('sha256')
-        .update(sortedManifestHashes + SYSTEM_EPOCH + REPORTER_EPOCH) // [UPDATED]
+        .update(sortedManifestHashes + SYSTEM_EPOCH + REPORTER_EPOCH) 
         .digest('hex');
 }
 
@@ -187,20 +188,20 @@ async function generateBuildReport(config, dependencies, manifest) {
     const lastEarliestStr = latest?.windowEarliest || 'NONE';
     const windowChanged = currentEarliestStr !== lastEarliestStr;
 
-    const epochChanged = latest?.reporterEpoch !== REPORTER_EPOCH; // [NEW]
+    const epochChanged = latest?.reporterEpoch !== REPORTER_EPOCH; 
 
     // If fingerprints match AND the window is the same, we can truly skip.
     if (latest && 
         latest.systemFingerprint === currentFingerprint && 
         !windowChanged && 
-        !epochChanged) { // [NEW]
+        !epochChanged) { 
         logger.log('INFO', `[BuildReporter] ⚡ System fingerprint, window, and reporter epoch stable. Skipping report.`);
         return { success: true, status: 'SKIPPED_IDENTICAL' };
     }
 
     // Determine primary reason for logging
     let reason = 'Code Change';
-    if (epochChanged) reason = 'Master Epoch Override'; // [NEW]
+    if (epochChanged) reason = 'Master Epoch Override'; 
     else if (windowChanged) reason = 'Data Window Drift';
 
     // Increment patch version
@@ -251,7 +252,7 @@ async function generateBuildReport(config, dependencies, manifest) {
     // Initialize the build record
     await db.collection(BUILD_RECORDS_COLLECTION).doc(buildId).set(reportHeader);
 
-    let totalRun = 0, totalReRun = 0, totalStable = 0;
+    let totalRun = 0, totalReRun = 0, totalStable = 0, totalErrors = 0;
     const limit = pLimit(10); // Concurrency for fetching statuses
 
     // Process dates in chunks of 5 for checkpointed writing
@@ -336,17 +337,33 @@ async function generateBuildReport(config, dependencies, manifest) {
                 // Write detailed date record
                 await db.collection(BUILD_RECORDS_COLLECTION).doc(buildId).collection('details').doc(dateStr).set(dateSummary);
 
-                return { run: dateSummary.run.length, rerun: dateSummary.rerun.length, stable: dateSummary.stable.length };
+                return { run: dateSummary.run.length, rerun: dateSummary.rerun.length, stable: dateSummary.stable.length, error: false };
             } catch (err) {
                 logger.log('ERROR', `[BuildReporter] Analysis failed for ${dateStr}: ${err.message}`);
-                return { run: 0, rerun: 0, stable: 0 };
+                
+                // [FIX] Write error record so the date appears in the report
+                await db.collection(BUILD_RECORDS_COLLECTION).doc(buildId).collection('details').doc(dateStr).set({
+                    error: err.message,
+                    status: 'ANALYSIS_FAILED',
+                    meta: { totalIncluded: 0, totalExpected: 0, match: false }
+                }).catch(e => logger.log('ERROR', `Failed to write error record for ${dateStr}: ${e.message}`));
+                
+                return { run: 0, rerun: 0, stable: 0, error: true };
             }
         })));
 
         // Accumulate stats and write a progress checkpoint
-        results.forEach(res => { totalRun += res.run; totalReRun += res.rerun; totalStable += res.stable; });
+        results.forEach(res => { 
+            if (res.error) totalErrors++;
+            else {
+                totalRun += res.run; 
+                totalReRun += res.rerun; 
+                totalStable += res.stable; 
+            }
+        });
+        
         await db.collection(BUILD_RECORDS_COLLECTION).doc(buildId).update({ 
-            checkpoint: `Processed ${i + dateBatch.length}/${datesToCheck.length} dates` 
+            checkpoint: `Processed ${Math.min(i + dateBatch.length, datesToCheck.length)}/${datesToCheck.length} dates` 
         });
     }
 
@@ -355,6 +372,7 @@ async function generateBuildReport(config, dependencies, manifest) {
         totalReRuns: totalReRun, 
         totalNew: totalRun, 
         totalStable: totalStable, 
+        totalErrors: totalErrors,
         scanRange: `${datesToCheck[0]} to ${datesToCheck[datesToCheck.length-1]}` 
     };
 
@@ -362,7 +380,7 @@ async function generateBuildReport(config, dependencies, manifest) {
     await db.collection(BUILD_RECORDS_COLLECTION).doc(buildId).set(reportHeader);
     await db.collection(BUILD_RECORDS_COLLECTION).doc('latest').set({ ...reportHeader, note: "Latest completed build report." });
     
-    logger.log('SUCCESS', `[BuildReporter] Build ${buildId} completed. Re-runs: ${totalReRun}, Stable: ${totalStable}, New: ${totalRun}.`);
+    logger.log('SUCCESS', `[BuildReporter] Build ${buildId} completed. Re-runs: ${totalReRun}, Stable: ${totalStable}, New: ${totalRun}, Errors: ${totalErrors}.`);
     
     return { success: true, buildId, summary: reportHeader.summary };
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bulltrackers-module",
-  "version": "1.0.325",
+  "version": "1.0.326",
   "description": "Helper Functions for Bulltrackers.",
   "main": "index.js",
   "files": [