bulltrackers-module 1.0.32 → 1.0.33

package/functions/generic-api/index.js

@@ -5,7 +5,7 @@
 
 const express = require('express');
 const cors = require('cors');
-// FieldPath is needed to query by document ID
+// FieldPath is needed to query by document ID and dynamic paths
 const { FieldPath } = require('@google-cloud/firestore'); 
 const { buildCalculationMap, createApiHandler } = require('./helpers/api_helpers.js');
 
@@ -36,7 +36,7 @@ function createStructureSnippet(data, maxKeys = 20) {
 
     // If it's a large map (e.g., user IDs), just show one example
     if (keys.length > maxKeys) {
-        const firstKey = keys[0];
+        const firstKey = keys[0] || "example_key";
         newObj[firstKey] = createStructureSnippet(data[firstKey], maxKeys);
         newObj[`... (${keys.length - 1} more keys)`] = "<object>";
     } else {
@@ -90,7 +90,7 @@ function createApiApp(config, dependencies, unifiedCalculations) {
         }
     });
 
-    // --- REVISED: Debug Endpoint to get the structure from Firestore ---
+    // --- REVISED V3: Debug Endpoint to get the structure from Firestore ---
     app.get('/structure/:computationName', async (req, res) => {
         const { computationName } = req.params;
         try {
@@ -106,30 +106,37 @@ function createApiApp(config, dependencies, unifiedCalculations) {
             const resultsSub = config.resultsSubcollection || 'results';
             const compsSub = config.computationsSubcollection || 'computations';
 
-            // 3. Find the most recent date document in Firestore
+            // 3. Find the most recent date *that contains this computation*
+            // This relies on the summary flags set by orchestration_helpers.js
+            const computationQueryPath = `${category}.${computationName}`;
             const dateQuery = firestore.collection(insightsCollection)
-                .orderBy(FieldPath.documentId(), 'desc')
+                .where(computationQueryPath, '==', true) // Find docs with the summary flag
+                .orderBy(FieldPath.documentId(), 'desc') // Get the latest date
                 .limit(1);
                 
             const dateSnapshot = await dateQuery.get();
 
             if (dateSnapshot.empty) {
-                return res.status(404).send({ status: 'error', message: `No data found in insights collection '${insightsCollection}'.` });
+                return res.status(404).send({ 
+                    status: 'error', 
+                    message: `No computed data found for '${computationName}'. (Query path: ${computationQueryPath})`
+                });
             }
             
-            const recentDate = dateSnapshot.docs[0].id;
+            const latestDateForThisComp = dateSnapshot.docs[0].id;
 
             // 4. Construct the path to the actual computation document
-            const docRef = firestore.collection(insightsCollection).doc(recentDate)
+            const docRef = firestore.collection(insightsCollection).doc(latestDateForThisComp)
                 .collection(resultsSub).doc(category)
                 .collection(compsSub).doc(computationName);
 
             const doc = await docRef.get();
 
             if (!doc.exists) {
+                // This is unlikely if the summary flag is true, but good to check
                 return res.status(404).send({ 
                     status: 'error', 
-                    message: `Data for '${computationName}' not found for the most recent date (${recentDate}).`,
+                    message: `Data for '${computationName}' not found for its latest date (${latestDateForThisComp}). Summary flag was present but doc is missing.`,
                     checkedPath: docRef.path
                 });
             }
@@ -142,11 +149,16 @@ function createApiApp(config, dependencies, unifiedCalculations) {
                 status: 'success',
                 computation: computationName,
                 category: category,
-                exampleDate: recentDate,
+                latestStoredDate: latestDateForThisComp,
                 structureSnippet: snippet,
             });
 
         } catch (error) {
+            // Handle errors, including bad query paths
+            if (error.message && error.message.includes('Invalid argument')) {
+                 logger.log('ERROR', `API /structure/${computationName} failed, likely due to invalid query path.`, { queryPath: `${category}.${computationName}`, stack: error.stack });
+                 return res.status(500).send({ status: 'error', message: `Internal query error. The path '${category}.${computationName}' might be invalid.` });
+            }
             logger.log('ERROR', `API /structure/${computationName} failed.`, { errorMessage: error.message, stack: error.stack });
             res.status(500).send({ status: 'error', message: `An internal error occurred while processing '${computationName}'.` });
         }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bulltrackers-module",
-  "version": "1.0.32",
+  "version": "1.0.33",
   "description": "Helper Functions for Bulltrackers.",
   "main": "index.js",
   "files": [